[clangd] Fix data type of WorkDoneProgressReport::percentage

[ckandeler]

Summary

According to the specification, this should be an unsigned integer.

[ckandeler]

Would you mind pushing this?

[ckandeler]

ping. Any chance of getting this pushed?

[kadircet]

done, sorry for the delay!

[ckandeler]

No problem, thanks!

clang-tools-extra/clangd/ClangdLSPServer.cpp

if (BackgroundIndexProgressState != BackgroundIndexProgress::Live) {
       Begin.title = "indexing";
       BeginWorkDoneProgress({ProgressToken, std::move(Begin)});
       BackgroundIndexProgressState = BackgroundIndexProgress::Live;
     }
 
     if (Stats.Completed < Stats.Enqueued) {
       assert(Stats.Enqueued > Stats.LastIdle);
       WorkDoneProgressReport Report;
-      Report.percentage = 100.0 * (Stats.Completed - Stats.LastIdle) /
+      Report.percentage = 100 * (Stats.Completed - Stats.LastIdle) /
                           (Stats.Enqueued - Stats.LastIdle);
       Report.message =
           llvm::formatv("{0}/{1}", Stats.Completed - Stats.LastIdle,
                         Stats.Enqueued - Stats.LastIdle);
       ReportWorkDoneProgress({ProgressToken, std::move(Report)});
     } else {
       assert(Stats.Completed == Stats.Enqueued);
       EndWorkDoneProgress({ProgressToken, WorkDoneProgressEnd()});

clang-tools-extra/clangd/Protocol.h

struct WorkDoneProgressReport {
   llvm::Optional<std::string> message;
 
   /// Optional progress percentage to display (value 100 is considered 100%).
   /// If not provided infinite progress is assumed and clients are allowed
   /// to ignore the `percentage` value in subsequent in report notifications.
   ///
   /// The value should be steadily rising. Clients are free to ignore values
   /// that are not following this rule.
-  llvm::Optional<double> percentage;
+  llvm::Optional<unsigned> percentage;
 };
 llvm::json::Value toJSON(const WorkDoneProgressReport &);
 //
 /// Signals the end of progress reporting.
 struct WorkDoneProgressEnd {
   /// Optional, a final message indicating to for example indicate the outcome
   /// of the operation.
   llvm::Optional<std::string> message;