Page MenuHomePhabricator

[AMDGPU] Remove dead early-out in GCNHazardRecognizer
ClosedPublic

Authored by critson on Apr 29 2021, 4:54 AM.

Details

Summary

Remove an early-out in wait state counting which can never be
taken.

Diff Detail

Event Timeline

critson created this revision.Apr 29 2021, 4:54 AM
critson requested review of this revision.Apr 29 2021, 4:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 29 2021, 4:54 AM
critson updated this revision to Diff 341475.Apr 29 2021, 4:57 AM

Remove extra line.

foad accepted this revision.Apr 29 2021, 6:21 AM

LGTM.

Just to explain a bit more, I think that once we get to this check, one of the recursive calls on getWaitStatesSince must already have called IsExpired with the same WaitStates value, and that call can't have returned true otherwise getWaitStatesSince would have returned INTMAX and we'd have taken the continue on line 428. (This is assuming that the various IsExpiredFns are fairly sane in that they don't interpret their WaitStates argument differently depending on whether their MI argument is null or not.)

This revision is now accepted and ready to land.Apr 29 2021, 6:21 AM
rampitec accepted this revision.Apr 29 2021, 9:46 AM
This revision was landed with ongoing or failed builds.Apr 29 2021, 4:57 PM
This revision was automatically updated to reflect the committed changes.