thanks for doing this! can we also have a lit test? we already have some tests spinning up an index-server, i suppose we can make an extra rpc to those and ensure we get a success response?
being more specific would be nice, just in case we have more servers (i.e. review) in the future.
rather than dumping protobuf, can we dump in json ? see https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.util.json_util
logs for index-server and monitor gets intertwined (as we put logs from index-server until initialization above). so can we output monitoring logs after we've dumped all the logs from index-server?
can we just dump the stdout to main process (as we do with other subprocesses) and check for the output in the lit tests instead? that way we can check for particular values without complicating the helper instead
thanks, let's ship it!
nit: this is probably not needed now as we dropped formatv
nit: i am not sure if this really compiles (was testing it for status-updater patch on gcp). as this is a stringpiece, so you might wanna call ToString/as_string on it.
nit: as discussed offline this is only to save some runtime on tests that don't care about it. I'd probably drop this and add later if we feel the need, but up to you.