Page MenuHomePhabricator
Differential D101376

[MLIR][Shape] Canonicalize casted extent tensor operands
ClosedPublic
Actions

Authored by frgossen on Apr 27 2021, 9:17 AM.

Details

Reviewers
silvas
pifon2a
Commits
rGcb393f4c99c1: [MLIR][Shape] Canonicalize casted extent tensor operands
Summary

Both, shape.broadcast and shape.cstr_broadcastable accept dynamic and static
extent tensors. If their operands are casted, we can use the original value
instead.

Diff Detail

Event Timeline

frgossen created this revision.Apr 27 2021, 9:17 AM
Herald added a reviewer: silvas. · View Herald TranscriptApr 27 2021, 9:17 AM
Herald added subscribers: dcaballe, cota, teijeong and 16 others. · View Herald Transcript
frgossen requested review of this revision.Apr 27 2021, 9:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2021, 9:17 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
frgossen added a reviewer: pifon2a.Apr 27 2021, 9:18 AM
frgossen added a child revision: D101377: [MLIR][Shape] Concretize broadcast result type if possible.Apr 27 2021, 9:19 AM
pifon2a accepted this revision.Apr 27 2021, 9:24 AM
pifon2a added inline comments.
mlir/lib/Dialect/Shape/IR/Shape.cpp
731

Casted?

mlir/test/Dialect/Shape/canonicalize.mlir
1336

nit: i think "casted" is an incorrect form. Shouldn't it be just "cast"?

This revision is now accepted and ready to land.Apr 27 2021, 9:24 AM
Harbormaster completed remote builds in B101189: Diff 340873.Apr 27 2021, 10:11 AM
frgossen updated this revision to Diff 341108.Apr 28 2021, 2:37 AM

Rebase

frgossen updated this revision to Diff 341114.Apr 28 2021, 2:50 AM
frgossen marked 2 inline comments as done.

Address comments

frgossen added a comment.Apr 28 2021, 2:51 AM

Thanks!

This revision was landed with ongoing or failed builds.Apr 28 2021, 2:52 AM
Closed by commit rGcb393f4c99c1: [MLIR][Shape] Canonicalize casted extent tensor operands (authored by frgossen). · Explain Why
This revision was automatically updated to reflect the committed changes.
frgossen added a commit: rGcb393f4c99c1: [MLIR][Shape] Canonicalize casted extent tensor operands.
Harbormaster completed remote builds in B101356: Diff 341108.Apr 28 2021, 3:07 AM
Harbormaster completed remote builds in B101361: Diff 341114.Apr 28 2021, 3:27 AM

Revision Contents
Changeset List

PathSize
mlir/
lib/
Dialect/
Shape/
IR/
41 lines
test/
Dialect/
Shape/
18 lines

Diff 340873

View Options

mlir/lib/Dialect/Shape/IR/Shape.cpp

Loading...
View Options

mlir/test/Dialect/Shape/canonicalize.mlir

Loading...