This is an archive of the discontinued LLVM Phabricator instance.

[DOCS] Removed inconsistency in clang vs Clang usage in docs (c vs C)
ClosedPublic

Authored by sushmaunnibhavi on Apr 27 2021, 4:01 AM.

Diff Detail

Event Timeline

sushmaunnibhavi requested review of this revision.Apr 27 2021, 4:01 AM
sushmaunnibhavi created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 27 2021, 4:01 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
xgupta accepted this revision.Apr 27 2021, 4:26 AM

LGTM, Thanks for the patch!

This revision is now accepted and ready to land.Apr 27 2021, 4:26 AM
xgupta edited reviewers, added: jrtc27; removed: tmfink.Apr 29 2021, 11:35 AM

I'm not convinced by these changes?

xgupta added a subscriber: rnk.Apr 29 2021, 2:20 PM

I'm not convinced by these changes?

Yes, I also thought first, clang man page can't be incorrect/inconsistent.
I think @rnk can suggest the changes as he has also commented on the Bugzilla issue.
(I also got confused in Clang vs clang naming, sorry if I accepted revision with not much thought)

rnk added a comment.Apr 29 2021, 3:04 PM

This is what I said back in 2018 on the bug:

I think you're right, we generally try to capitalize "Clang" when referring to the project and use lower case when talking about the command name. People do the same thing with "GCC" and "gcc". We're not always consistent though. Patches welcome I guess.

I think most of the instances in this patch should stay capitalized. Some of them are ambiguous, they could be referring to Clang the product, or clang the command. In the face of ambiguity, I think more capitalization is better.

rnk added a subscriber: chandlerc.Apr 29 2021, 3:07 PM

I should add that I started to think this way after @chandlerc asked me to capitalize "Clang" in some slides for a presentation I was giving years ago. I didn't invent this convention, other people already follow it.

xgupta added a comment.May 5 2021, 8:08 AM

@sushmaunnibhavi Please close this revision, I got some misunderstading. Changes are not expected here.

@sushmaunnibhavi Please close this revision, I got some misunderstading. Changes are not expected here.

Yes, will do it.