This is an archive of the discontinued LLVM Phabricator instance.

[DebugInfo] Add tests that we emit .eh_frame instead of .debug_frame
ClosedPublic

Authored by MaskRay on Apr 26 2021, 7:54 PM.

Details

Summary

Add tests which can catch the issue in 0ce723cb228bc1d1a0f5718f3862fb836145a333
(If any function needs CFISection::EH, the module should use CFISection::EH).

Diff Detail

Event Timeline

MaskRay requested review of this revision.Apr 26 2021, 7:54 PM
MaskRay created this revision.
Herald added a project: Restricted Project. Β· View Herald TranscriptApr 26 2021, 7:54 PM
Herald added a subscriber: llvm-commits. Β· View Herald Transcript
RamNalamothu added inline comments.
llvm/test/DebugInfo/X86/cfi_sections.ll
3

May be add --force-dwarf-frame-section scenario as well, to make sure we get .debug_frame along with .eh_frame when asked for?

While the rest looks good to me, from logical point of view, I can't read LLVM IR well. So, not able to comment on that.

MaskRay updated this revision to Diff 340732.Apr 26 2021, 11:21 PM

Test -force-dwarf-frame-section

MaskRay marked an inline comment as done.Apr 27 2021, 11:38 AM
echristo accepted this revision.Apr 28 2021, 1:09 PM
echristo added a subscriber: echristo.

Looks like they said with that change it was good for them and from my reading the IR is pretty good for a test. :)

This revision is now accepted and ready to land.Apr 28 2021, 1:09 PM
This revision was landed with ongoing or failed builds.Apr 29 2021, 9:35 AM
This revision was automatically updated to reflect the committed changes.
llvm/test/DebugInfo/X86/cfi_sections.ll