[clang-tidy] Enable the use of IgnoreArray flag in pro-type-member-init rule

[h-joo]

Summary

The IgnoreArray flag was not used before while running the rule. Fixes b/47288

[njames93]

clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-member-init.ignorearrays.cpp

5

Small nit.

[h-joo]

Change 1 to true in the test flag as requested by the reviewer.

[njames93]

Whats the expected behaviour of sugar types. Can tests be added that demonstrate the behaviour.
I'd argue these cases shouldn't be warned on if IgnoreArrays is enabled and If that behaviour isn't observed currently it should be addressed.

typedef int TypedefArray[4];
using UsingArray = int[4];

struct HasArrayMember {
  HasArrayMember() {}
  UsingArray U; // Don't warn on this?
  TypedefArray T; // Or this?
  int Number; // Do warn this.
};

[h-joo]

Extended the test case to confirm the fix also works for alias types(typedef, using).

[h-joo]

In D101239#2746147, @njames93 wrote:

Whats the expected behaviour of sugar types. Can tests be added that demonstrate the behaviour.
I'd argue these cases shouldn't be warned on if IgnoreArrays is enabled and If that behaviour isn't observed currently it should be addressed.

typedef int TypedefArray[4];
using UsingArray = int[4];

struct HasArrayMember {
  HasArrayMember() {}
  UsingArray U; // Don't warn on this?
  TypedefArray T; // Or this?
  int Number; // Do warn this.
};

Extended the existing test case to confirm that it works fine :)

[njames93]

LGTM, thanks.

[h-joo]

In D101239#2746644, @njames93 wrote:

LGTM, thanks.

@njames93, I appreciate your time for the review. May I ask one more thing? I do not have commit rights. Would it be possible for you to make the commit? Thank you!!

[njames93]

In D101239#2746675, @h-joo wrote:

In D101239#2746644, @njames93 wrote:

LGTM, thanks.

@njames93, I appreciate your time for the review. May I ask one more thing? I do not have commit rights. Would it be possible for you to make the commit? Thank you!!

No problem, Can you please provide your GitHub username and email so I can mark you as the author of the patch.

[h-joo]

In D101239#2747370, @njames93 wrote:

In D101239#2746675, @h-joo wrote:

In D101239#2746644, @njames93 wrote:

LGTM, thanks.

@njames93, I appreciate your time for the review. May I ask one more thing? I do not have commit rights. Would it be possible for you to make the commit? Thank you!!

No problem, Can you please provide your GitHub username and email so I can mark you as the author of the patch.

I don't know which one you're asking for but if it's for the commit message git user.name Hana Joo and git user.email is [e-mail] and my github username is h-joo same as the phabricator account. Thank you for your help!

clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp

void ProTypeMemberInitCheck::checkMissingMemberInitializer(
   bool IsUnion = ClassDecl.isUnion();
 
   if (IsUnion && ClassDecl.hasInClassInitializer())
     return;
 
   // Gather all fields (direct and indirect) that need to be initialized.
   SmallPtrSet<const FieldDecl *, 16> FieldsToInit;
   forEachField(ClassDecl, ClassDecl.fields(), [&](const FieldDecl *F) {
+    if (IgnoreArrays && F->getType()->isArrayType())
+      return;
     if (!F->hasInClassInitializer() &&
         utils::type_traits::isTriviallyDefaultConstructible(F->getType(),
                                                             Context) &&
         !isEmpty(Context, F->getType()) && !F->isUnnamedBitfield())
       FieldsToInit.insert(F);
   });
   if (FieldsToInit.empty())
     return;

clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-member-init.ignorearrays.cpp

+// RUN: %check_clang_tidy %s \
+// RUN: cppcoreguidelines-pro-type-member-init %t \
+// RUN: -config="{CheckOptions: \
+// RUN: [{key: cppcoreguidelines-pro-type-member-init.IgnoreArrays, value: true} ]}"
+
+typedef int TypedefArray[4];
+using UsingArray = int[4];
+
+struct HasArrayMember {
+  HasArrayMember() {}
+  // CHECK-MESSAGES: warning: constructor does not initialize these fields: Number
+  UsingArray U;
+  TypedefArray T;
+  int RawArray[4];
+  int Number;
+};