Page MenuHomePhabricator

[X86][AMX][NFC] Remove assert for comparison between different BBs.
ClosedPublic

Authored by pengfei on Apr 22 2021, 2:37 AM.

Details

Summary

SmallSet may use operator < when we insert MIRef elements, so we
cannot limit the comparison between different BBs.

We alow MIRef() to be less that any initialized MIRef object, otherwise,
we always reture false when compare between different BBs.

Diff Detail

Event Timeline

pengfei created this revision.Apr 22 2021, 2:37 AM
pengfei requested review of this revision.Apr 22 2021, 2:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 22 2021, 2:37 AM

Is there any test case for it?

Is there any test case for it?

I don't have a small case. On another hand, removing assert supposes to be NFC. The previous functionality still be checked by existing tests.

This revision is now accepted and ready to land.Apr 22 2021, 4:53 AM
This revision was landed with ongoing or failed builds.Apr 22 2021, 5:42 AM
This revision was automatically updated to reflect the committed changes.