This is an archive of the discontinued LLVM Phabricator instance.

[OpenCL] Remove pragma requirement for functions from Arm dot extension

Authored by Anastasia on Apr 21 2021, 11:52 AM.



This removed the pointless need for extension pragma since it doesn't disable anything properly and it doesn't need to enable anything that is not possible to disable.

The change doesn't break existing kernels since it allows to compile more cases i.e. without pragma statements but the pragma continues to be accepted.

Diff Detail

Event Timeline

Anastasia created this revision.Apr 21 2021, 11:52 AM
Anastasia requested review of this revision.Apr 21 2021, 11:52 AM
svenvh accepted this revision.Apr 22 2021, 9:35 AM

LGTM, thanks!

This revision is now accepted and ready to land.Apr 22 2021, 9:35 AM
mantognini accepted this revision.Apr 23 2021, 2:10 AM

Feels appropriate to remove this indeed.

This revision was landed with ongoing or failed builds.May 12 2021, 8:25 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 12 2021, 8:26 AM
Herald added a subscriber: ldrumm. · View Herald Transcript