Page MenuHomePhabricator

[AMDGPU] SIWholeQuadMode: don't add duplicate implicit $exec operands
ClosedPublic

Authored by foad on Apr 21 2021, 9:41 AM.

Details

Summary

STRICT_WWM and STRICT_WQM are already defined with Uses = [EXEC], so
there is no need to add another implicit use of $exec when lowering them
to V_MOV_B32 instructions.

Diff Detail

Event Timeline

foad created this revision.Apr 21 2021, 9:41 AM
foad requested review of this revision.Apr 21 2021, 9:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2021, 9:41 AM
critson accepted this revision.Apr 21 2021, 4:59 PM

LGTM

I think this particular line of code is pretty old.
I take it this is largely NFC on compiler output (i.e. no test difference)?

This revision is now accepted and ready to land.Apr 21 2021, 4:59 PM
foad added a comment.Apr 22 2021, 1:00 AM

I take it this is largely NFC on compiler output (i.e. no test difference)?

Yes it just affects the MIR, but there are no explicit tests for that.

This revision was landed with ongoing or failed builds.Apr 22 2021, 1:20 AM
This revision was automatically updated to reflect the committed changes.