[mlir][StandardToSPIRV] Add support for lowering std.xor on bool to SPIR-V
ClosedPublic
Actions

Authored by hanchung on Apr 19 2021, 11:10 PM.

Details

Reviewers

ThomasRaoux
antiagainst
mravishankar

Commits

rG7b7df8e85eec: [mlir][StandardToSPIRV] Add support for lowering std.xor on bool to SPIR-V

Summary

std.xor ops on bool are lowered to spv.LogicalNotEqual. For Boolean values, xor
and not-equal are the same thing.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

hanchung created this revision.Apr 19 2021, 11:10 PM

Herald added subscribers: dcaballe, cota, teijeong and 16 others. · View Herald TranscriptApr 19 2021, 11:10 PM

hanchung requested review of this revision.Apr 19 2021, 11:10 PM

Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2021, 11:10 PM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

Harbormaster completed remote builds in B99621: Diff 338720.Apr 20 2021, 12:37 AM

antiagainst accepted this revision.Apr 20 2021, 5:27 AM

This revision is now accepted and ready to land.Apr 20 2021, 5:27 AM

Closed by commit rG7b7df8e85eec: [mlir][StandardToSPIRV] Add support for lowering std.xor on bool to SPIR-V (authored by hanchung). · Explain WhyApr 20 2021, 7:35 AM

This revision was automatically updated to reflect the committed changes.

hanchung added a commit: rG7b7df8e85eec: [mlir][StandardToSPIRV] Add support for lowering std.xor on bool to SPIR-V.

Revision Contents
Changeset List

Path

Size

mlir/

lib/

Conversion/

StandardToSPIRV/

StandardToSPIRV.cpp

29 lines

test/

Conversion/

StandardToSPIRV/

std-ops-to-spirv.mlir

4 lines

Diff 338866

View Options

mlir/lib/Conversion/StandardToSPIRV/StandardToSPIRV.cpp