Page MenuHomePhabricator

[OpenMP] Ensure the DefaultMapperId has a location
ClosedPublic

Authored by jdoerfert on Thu, Apr 15, 11:12 PM.

Details

Summary

A user reported an assertion (below) but without a reproducer. I failed to
create a test myself but from the assertion one can derive the problem.
I set the DefaultMapperId location now to make sure this doesn't cause
trouble.

clang-13: .../DeclTemplate.h:1940:
void clang::ClassTemplateSpecializationDecl::setPointOfInstantiation(clang::SourceLocation):
Assertion `Loc.isValid() && "point of instantiation must be valid!"' failed.

Diff Detail

Event Timeline

jdoerfert created this revision.Thu, Apr 15, 11:12 PM
jdoerfert requested review of this revision.Thu, Apr 15, 11:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Apr 15, 11:12 PM
JonChesterfield accepted this revision.Mon, May 3, 8:20 AM

Not ideal to have unreproducible failures but the fix looks safe regardless

This revision is now accepted and ready to land.Mon, May 3, 8:20 AM
This revision was landed with ongoing or failed builds.Thu, May 6, 12:10 AM
This revision was automatically updated to reflect the committed changes.