This is an archive of the discontinued LLVM Phabricator instance.

Differential D100409

[AMDGPU] Factor out predicate FmaakFmamkF32Insts
ClosedPublic

Authored by rampitec on Apr 13 2021, 12:57 PM.

Details

Reviewers
foad
kzhuravl
arsenm
Commits
rG13015ebd6f56: [AMDGPU] Factor out predicate FmaakFmamkF32Insts

Diff Detail

Event Timeline

rampitec created this revision.Apr 13 2021, 12:57 PM
Herald added subscribers: kerbowa, hiraditya, t-tye and 6 others. · View Herald TranscriptApr 13 2021, 12:57 PM
rampitec requested review of this revision.Apr 13 2021, 12:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2021, 12:57 PM
Herald added a subscriber: wdng. · View Herald Transcript
rampitec added a reviewer: arsenm.Apr 13 2021, 1:00 PM
Harbormaster completed remote builds in B98545: Diff 337242.Apr 13 2021, 6:59 PM
kzhuravl accepted this revision.Apr 15 2021, 11:52 AM

LGTM

This revision is now accepted and ready to land.Apr 15 2021, 11:52 AM
This revision was landed with ongoing or failed builds.Apr 15 2021, 12:29 PM
Closed by commit rG13015ebd6f56: [AMDGPU] Factor out predicate FmaakFmamkF32Insts (authored by rampitec). · Explain Why
This revision was automatically updated to reflect the committed changes.
rampitec added a commit: rG13015ebd6f56: [AMDGPU] Factor out predicate FmaakFmamkF32Insts.

Revision Contents

PathSize
llvm/
lib/
Target/
AMDGPU/
4 lines
4 lines
16 lines

Diff 337242

llvm/lib/Target/AMDGPU/AMDGPU.td

Show First 20 Lines • Show All 1,315 Lines • ▼ Show 20 Linesdef HasDPP8 : Predicate<"Subtarget->hasDPP8()">,
AssemblerPredicate<(all_of (not FeatureGCN3Encoding), FeatureGFX10Insts, FeatureDPP8)>; AssemblerPredicate<(all_of (not FeatureGCN3Encoding), FeatureGFX10Insts, FeatureDPP8)>;
def Has64BitDPP : Predicate<"Subtarget->has64BitDPP()">, def Has64BitDPP : Predicate<"Subtarget->has64BitDPP()">,
AssemblerPredicate<(all_of Feature64BitDPP)>; AssemblerPredicate<(all_of Feature64BitDPP)>;
def HasPackedFP32Ops : Predicate<"Subtarget->hasPackedFP32Ops()">, def HasPackedFP32Ops : Predicate<"Subtarget->hasPackedFP32Ops()">,
AssemblerPredicate<(all_of FeaturePackedFP32Ops)>; AssemblerPredicate<(all_of FeaturePackedFP32Ops)>;
def HasFmaakFmamkF32Insts :
Predicate<"Subtarget->hasFmaakFmamkF32Insts()">,
AssemblerPredicate<(any_of FeatureGFX10Insts)>;
def HasExtendedImageInsts : Predicate<"Subtarget->hasExtendedImageInsts()">, def HasExtendedImageInsts : Predicate<"Subtarget->hasExtendedImageInsts()">,
AssemblerPredicate<(all_of FeatureExtendedImageInsts)>; AssemblerPredicate<(all_of FeatureExtendedImageInsts)>;
def HasR128A16 : Predicate<"Subtarget->hasR128A16()">, def HasR128A16 : Predicate<"Subtarget->hasR128A16()">,
AssemblerPredicate<(all_of FeatureR128A16)>; AssemblerPredicate<(all_of FeatureR128A16)>;
def HasGFX10A16 : Predicate<"Subtarget->hasGFX10A16()">, def HasGFX10A16 : Predicate<"Subtarget->hasGFX10A16()">,
AssemblerPredicate<(all_of FeatureGFX10A16)>; AssemblerPredicate<(all_of FeatureGFX10A16)>;
▲ Show 20 Lines • Show All 112 Lines • Show Last 20 Lines

llvm/lib/Target/AMDGPU/GCNSubtarget.h

Show First 20 Lines • Show All 832 Lines • ▼ Show 20 Linespublic:
bool has64BitDPP() const { bool has64BitDPP() const {
return Has64BitDPP; return Has64BitDPP;
} }
bool hasPackedFP32Ops() const { bool hasPackedFP32Ops() const {
return HasPackedFP32Ops; return HasPackedFP32Ops;
} }
bool hasFmaakFmamkF32Insts() const {
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  bool hasFmaakFmamkF32Insts() const {
-    return getGeneration() >= GFX10;
-  }
+  bool hasFmaakFmamkF32Insts() const { return getGeneration() >= GFX10; }
Lint: Pre-merge checks: clang-format: please reformat the code ``` - bool hasFmaakFmamkF32Insts() const { - return…
return getGeneration() >= GFX10;
}
bool hasExtendedImageInsts() const { bool hasExtendedImageInsts() const {
return HasExtendedImageInsts; return HasExtendedImageInsts;
} }
bool hasR128A16() const { bool hasR128A16() const {
return HasR128A16; return HasR128A16;
} }
▲ Show 20 Lines • Show All 269 Lines • Show Last 20 Lines

llvm/lib/Target/AMDGPU/VOP2Instructions.td

Show First 20 Lines • Show All 743 Lines • ▼ Show 20 Lineslet AddedComplexity = 30 in {
def : GCNPat< def : GCNPat<
(i32 (int_amdgcn_sdot8 i32:$src0, i32:$src1, i32:$src2, (i1 DSTCLAMP.NONE))), (i32 (int_amdgcn_sdot8 i32:$src0, i32:$src1, i32:$src2, (i1 DSTCLAMP.NONE))),
(i32 (V_DOT8C_I32_I4_e32 $src0, $src1, $src2)) (i32 (V_DOT8C_I32_I4_e32 $src0, $src1, $src2))
> { > {
let SubtargetPredicate = HasDot3Insts; let SubtargetPredicate = HasDot3Insts;
} }
} // End AddedComplexity = 30 } // End AddedComplexity = 30
let SubtargetPredicate = HasFmaakFmamkF32Insts in {
def V_FMAMK_F32 : VOP2_Pseudo<"v_fmamk_f32", VOP_MADMK_F32, [], "">;
let isCommutable = 1 in
def V_FMAAK_F32 : VOP2_Pseudo<"v_fmaak_f32", VOP_MADAK_F32, [], "">;
}
let SubtargetPredicate = isGFX10Plus in { let SubtargetPredicate = isGFX10Plus in {
def V_FMAMK_F32 : VOP2_Pseudo<"v_fmamk_f32", VOP_MADMK_F32, [], "">; let FPDPRounding = 1 in {
let FPDPRounding = 1 in
def V_FMAMK_F16 : VOP2_Pseudo <"v_fmamk_f16", VOP_MADMK_F16, [], "">; def V_FMAMK_F16 : VOP2_Pseudo <"v_fmamk_f16", VOP_MADMK_F16, [], "">;
let isCommutable = 1 in { let isCommutable = 1 in
def V_FMAAK_F32 : VOP2_Pseudo<"v_fmaak_f32", VOP_MADAK_F32, [], "">;
let FPDPRounding = 1 in
def V_FMAAK_F16 : VOP2_Pseudo <"v_fmaak_f16", VOP_MADAK_F16, [], "">; def V_FMAAK_F16 : VOP2_Pseudo <"v_fmaak_f16", VOP_MADAK_F16, [], "">;
} // End isCommutable = 1 } // End FPDPRounding = 1
let Constraints = "$vdst = $src2", let Constraints = "$vdst = $src2",
DisableEncoding="$src2", DisableEncoding="$src2",
isConvertibleToThreeAddress = 1, isConvertibleToThreeAddress = 1,
isCommutable = 1 in { isCommutable = 1 in {
defm V_FMAC_F16 : VOP2Inst <"v_fmac_f16", VOP_MAC_F16>; defm V_FMAC_F16 : VOP2Inst <"v_fmac_f16", VOP_MAC_F16>;
} }
▲ Show 20 Lines • Show All 965 Lines • Show Last 20 Lines