Page MenuHomePhabricator

[mlir] Use MCJIT to fix integration tests
ClosedPublic

Authored by cota on Apr 12 2021, 2:24 PM.

Details

Summary

Since c42c67ad ('Re-apply "[lli] Make -jit-kind=orc the default JIT
engine"'), ORC is the default JIT. Unfortunately, ORC seems to
ignore the --entry-function flag, which breaks all tests that
use the flag, namely the AMX and X86Vector integration tests.
This has been reported in PR#49906
(https://bugs.llvm.org/show_bug.cgi?id=49906).

Work around this by explicitly selecting MCJIT.

Diff Detail

Event Timeline

cota created this revision.Apr 12 2021, 2:24 PM
cota requested review of this revision.Apr 12 2021, 2:24 PM
aartbik accepted this revision.Apr 12 2021, 2:53 PM

aren't the AMX test affected by this as well then?

This revision is now accepted and ready to land.Apr 12 2021, 2:53 PM
cota updated this revision to Diff 336974.Apr 12 2021, 3:09 PM

Fix AMX tests as well

cota added a comment.Apr 12 2021, 3:09 PM

aren't the AMX test affected by this as well then?

They are indeed!
Fixed.

cota retitled this revision from [mlir] X86Vector: use MCJIT to fix integration tests to [mlir] Use MCJIT to fix integration tests.Apr 12 2021, 3:11 PM
cota edited the summary of this revision. (Show Details)
aartbik accepted this revision.Apr 12 2021, 3:26 PM

ship it!

Ideally the bug should be referred as TODO in all these tests, and also these tests should be mentioned in the bug so that when closing the bug we update the tests back.

cota updated this revision to Diff 337004.Apr 12 2021, 5:56 PM
cota edited the summary of this revision. (Show Details)

Add TODO comments that refer to the reported bug.

cota added a comment.Apr 12 2021, 6:01 PM

Ideally the bug should be referred as TODO in all these tests, and also these tests should be mentioned in the bug so that when closing the bug we update the tests back.

Done, thanks.

This revision was automatically updated to reflect the committed changes.

The ORC bug is closed, can you update all these tests back to use ORC?

cota added a comment.Apr 13 2021, 1:15 PM

The ORC bug is closed, can you update all these tests back to use ORC?

Please see https://reviews.llvm.org/D100407.