- operator!= isn't in the spec
- <compare> is designed to work with operator<=> so it doesn't really make sense to have operator<=>-less friendly sections.
Depends on D100283.
Paths
| Differential D100342
[libcxx] removes operator!= and globally guards against no spaceship operator ClosedPublic Authored by cjdb on Apr 12 2021, 2:05 PM.
Details
Summary
Depends on D100283.
Diff Detail
Event TimelineThis revision is now accepted and ready to land.Apr 12 2021, 2:16 PM Comment Actions This seems like a step in the right direction. Would you be interested in jumping all the way to the full C++20-mandated hidden-friend implementation in one fell swoop? Or is that already on your roadmap? cppreference says:
In other words, they should be defined inline, as hidden friends. Comment Actions adds // UNSUPPORTED: apple-clang-9, apple-clang-10, apple-clang-11, apple-clang-12.0.0 to the files failing CI (AppleClang <12.0.1 seems to not work) Closed by commit rG20506fb1f361: [libcxx] removes operator!= and globally guards against no spaceship operator (authored by cjdb). · Explain WhyMay 10 2021, 11:41 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 344293 libcxx/include/compare
libcxx/test/std/language.support/cmp/cmp.categories.pre/zero_type.verify.cpp
libcxx/test/std/language.support/cmp/cmp.partialord/partialord.pass.cpp
libcxx/test/std/language.support/cmp/cmp.strongord/strongord.pass.cpp
libcxx/test/std/language.support/cmp/cmp.weakord/weakord.pass.cpp
|