Page MenuHomePhabricator

[mlir][spirv] Allow bitwidth emulation on runtime arrays
ClosedPublic

Authored by antiagainst on Apr 12 2021, 12:09 PM.

Details

Summary

Runtime arrays are converted from memrefs with unknown
dimensions.

Diff Detail

Event Timeline

antiagainst created this revision.Apr 12 2021, 12:09 PM
antiagainst requested review of this revision.Apr 12 2021, 12:09 PM
mravishankar accepted this revision.Apr 12 2021, 1:40 PM
mravishankar added inline comments.
mlir/lib/Conversion/StandardToSPIRV/StandardToSPIRV.cpp
998

Nit: Having dstType initially being the StructType and overwriting it with element type adds cognitive overhead to me while reading. Can we just use elementType for the actual element type.

This revision is now accepted and ready to land.Apr 12 2021, 1:40 PM
This revision was automatically updated to reflect the committed changes.
antiagainst marked an inline comment as done.