This is an archive of the discontinued LLVM Phabricator instance.

[mlir][ArmSVE] Cleanup dialect registration
ClosedPublic

Authored by jsetoain on Apr 9 2021, 3:43 AM.

Details

Summary

ArmSVE dialect is behind the recent changes in how the Vector dialect
interacts with backend vector dialects and the MLIR -> LLVM IR
translation module. This patch cleans up ArmSVE initialization within
Vector and removes the need for an LLVMArmSVE dialect.

Diff Detail

Event Timeline

jsetoain created this revision.Apr 9 2021, 3:43 AM
jsetoain requested review of this revision.Apr 9 2021, 3:43 AM
jsetoain updated this revision to Diff 336404.Apr 9 2021, 5:09 AM

Fixed command line test.

ftynse accepted this revision.Apr 13 2021, 9:48 AM

Nice cleanup!

mlir/include/mlir/Dialect/ArmSVE/ArmSVEOpBase.td
39

Please document that this is intended to accept the cross product of allowed lengths and types rather than co-indexed list entries.

46

Please add a newline.

mlir/include/mlir/Dialect/LLVMIR/CMakeLists.txt
37

Also add a new line.

mlir/lib/Dialect/ArmSVE/CMakeLists.txt
3

Ditto.

This revision is now accepted and ready to land.Apr 13 2021, 9:48 AM
jsetoain updated this revision to Diff 337348.Apr 13 2021, 11:47 PM

Rebasing on main and addressing comments

jsetoain marked 4 inline comments as done.Apr 13 2021, 11:48 PM

I can't land revisions myself, can somebody do that for me, please? Thanks!

jsetoain updated this revision to Diff 337672.Apr 15 2021, 2:14 AM

Rebase on latest main

jsetoain retitled this revision from [mlir][ArmSVE] Cleanup dialect registration and initialization to [mlir][ArmSVE] Cleanup dialect registration.Apr 15 2021, 2:17 AM
jsetoain edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.
mlir/lib/Target/LLVMIR/Dialect/ArmSVE/CMakeLists.txt