Page MenuHomePhabricator

[mlir][ODS] Fix `VariadicRegion` code generation for `NoTerminator` Ops
ClosedPublic

Authored by vinograd47 on Thu, Mar 25, 5:10 AM.

Details

Summary

The issue was introduced in D98468.

The {0}Regions is an array of std::unique_ptr<Region> objects,
so it should be processed accordingly.

Diff Detail

Event Timeline

vinograd47 created this revision.Thu, Mar 25, 5:10 AM
vinograd47 requested review of this revision.Thu, Mar 25, 5:10 AM

Is it possible to make it exercised in tree? Maybe in the TestDialect?

mehdi_amini accepted this revision.Thu, Mar 25, 1:22 PM

(if this unblocks you, feel free to land it and send me a test afterward)

This revision is now accepted and ready to land.Thu, Mar 25, 1:22 PM

Added a test for the issue