- User Since
- Jun 18 2016, 2:24 PM (215 w, 5 d)
Can you also change the Dialect classof implementation to use getTypeID instead? That would remove the string comparison, and make casting to a dialect O(1) now.
Wed, Aug 5
Switch to a combo of weak_ptr/shared_ptr.
Tue, Aug 4
I tried to touch on most of the important aspects, but let me know if I missed something. Thanks.
Resolve comments and a section on debugging
Thanks for the cleanup!
Mon, Aug 3
A lot of your patterns (all of them?) are breaking the contract with the pattern rewriter right now.
Please also run clang-format.
Sat, Aug 1
Fri, Jul 31
Thanks. LGTM after resolving the last few comments.
Thu, Jul 30
Wed, Jul 29
Thanks Mahesh!! Looks good, just had some comments on the encoding.
Tue, Jul 28
Mon, Jul 27
Looks really great Alex! Made a first pass through, nothing really big mostly nits.
Add another test
Remove unnecessary interfaces
(Leaving approval to Lei or Stephan)