Page MenuHomePhabricator

rriddle (River Riddle)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 18 2016, 2:24 PM (260 w, 1 d)

Recent Activity

Yesterday

rriddle accepted D104189: Simplify getArgAttrDict/getResultAttrDict by removing unnecessary checks.
Sat, Jun 12, 3:21 PM · Restricted Project

Fri, Jun 11

rriddle requested review of D104173: [mlir] Add value_begin/value_end methods to DenseElementsAttr.
Fri, Jun 11, 9:05 PM · Restricted Project
rriddle added a comment to D104167: [mlir][OpGen] Cache Identifiers for known attribute names in AbstractOperation..

OOC what is the memory usage impact?

Fri, Jun 11, 9:03 PM · Restricted Project
rriddle requested review of D104167: [mlir][OpGen] Cache Identifiers for known attribute names in AbstractOperation..
Fri, Jun 11, 6:10 PM · Restricted Project
rriddle requested review of D104160: [mlir:Linalg] Populate LinalgOp patterns on LinalgDialect as opposed to each op.
Fri, Jun 11, 4:55 PM · Restricted Project

Thu, Jun 10

rriddle requested changes to D103969: [mlir] Add EmitC dialect.

Thanks, starting to work through it.

Thu, Jun 10, 6:24 PM · Restricted Project
rriddle committed rG8800047707a9: [mlir-ir-printing] Prefix the dump message with the split marker(// -----) (authored by rriddle).
[mlir-ir-printing] Prefix the dump message with the split marker(// -----)
Thu, Jun 10, 5:43 PM
rriddle closed D104073: [mlir-ir-printing] Prefix the dump message with the split marker(// -----).
Thu, Jun 10, 5:43 PM · Restricted Project
rriddle committed rGc42dd5dbb015: [mlir] Add new SubElementAttr/SubElementType Interfaces (authored by rriddle).
[mlir] Add new SubElementAttr/SubElementType Interfaces
Thu, Jun 10, 5:29 PM
rriddle committed rGf8a1d652da00: [mlir][IR] Move MemRefElementTypeInterface to a new BuiltinTypeInterfaces file (authored by rriddle).
[mlir][IR] Move MemRefElementTypeInterface to a new BuiltinTypeInterfaces file
Thu, Jun 10, 5:29 PM
rriddle closed D102945: [mlir] Add new SubElementAttr/SubElementType Interfaces.
Thu, Jun 10, 5:28 PM · Restricted Project
rriddle requested review of D104073: [mlir-ir-printing] Prefix the dump message with the split marker(// -----).
Thu, Jun 10, 4:28 PM · Restricted Project
rriddle committed rGc0e6f2f43a4c: [mlir-vscode] Fix dependencies to enable packaging the extension properly. (authored by rriddle).
[mlir-vscode] Fix dependencies to enable packaging the extension properly.
Thu, Jun 10, 11:34 AM
rriddle committed rGbb97959949ff: [mlir-lsp-server] Document the features provided by the language server (authored by rriddle).
[mlir-lsp-server] Document the features provided by the language server
Thu, Jun 10, 11:04 AM
rriddle committed rGff81a2c95ddb: [mlir-lsp-server] Add support for textDocument/documentSymbols (authored by rriddle).
[mlir-lsp-server] Add support for textDocument/documentSymbols
Thu, Jun 10, 11:04 AM
rriddle closed D103942: [mlir-lsp-server] Document the features provided by the language server.
Thu, Jun 10, 11:04 AM · Restricted Project
rriddle closed D103729: [mlir-lsp-server] Add support for textDocument/documentSymbols.
Thu, Jun 10, 11:04 AM · Restricted Project
rriddle accepted D102525: [MLIR] Document that Dialect Conversion traverses in preorder.

Thanks. (Sorry, missed this somehow)

Thu, Jun 10, 10:24 AM · Restricted Project
rriddle added inline comments to D103729: [mlir-lsp-server] Add support for textDocument/documentSymbols.
Thu, Jun 10, 10:22 AM · Restricted Project

Wed, Jun 9

rriddle added a comment to D103591: [mlir] Allow move-only RewritePattern arguments.

Are the test failures related? They look like they might be.

Yes, they are real. The arguments here are rvalues, so after the first pattern they are use-after-move.

I'm not sure if I want to proceed with this change. It might be safer to require using the add() overload on line 960 if pattern arguments are move-only. WDYT?

Wed, Jun 9, 12:05 AM · Restricted Project

Tue, Jun 8

rriddle accepted D103356: Reset all options in cl::ResetCommandLineParser().

This looks right to me, but might be good to get another LGTM.

Tue, Jun 8, 11:29 PM · Restricted Project
rriddle updated the diff for D103942: [mlir-lsp-server] Document the features provided by the language server.

update

Tue, Jun 8, 11:12 PM · Restricted Project
rriddle requested review of D103942: [mlir-lsp-server] Document the features provided by the language server.
Tue, Jun 8, 11:08 PM · Restricted Project
rriddle added a comment to D103373: [Verifier] Speed up and parallelize dominance checking. NFC.

I thought you abandoned this change? Looks like you landed it.

Tue, Jun 8, 2:12 PM · Restricted Project
rriddle added inline comments to D103822: [MLIR] Mark additional builtin attr methods const.
Tue, Jun 8, 12:38 PM · Restricted Project
rriddle added inline comments to D103827: [mlir] Make MemRef element type extensible.
Tue, Jun 8, 1:26 AM · Restricted Project
rriddle accepted D103827: [mlir] Make MemRef element type extensible.

Can you add a link to the discussion for this?

https://llvm.discourse.group/t/rfc-memref-of-custom-types/3558

Tue, Jun 8, 1:24 AM · Restricted Project
rriddle accepted D103828: [mlir] support memref of memref in standard-to-llvm conversion.
Tue, Jun 8, 1:20 AM · Restricted Project
rriddle accepted D103754: [Core] Add Twine support for StringAttr and Identifier. NFC..
Tue, Jun 8, 1:16 AM · Restricted Project

Mon, Jun 7

rriddle added a comment to D103649: [mlir] Add support to SourceMgrDiagnosticHandler for filtering FileLineColLocs.

Thanks for the review, PTAL.

Mon, Jun 7, 5:35 PM · Restricted Project
rriddle updated the diff for D103649: [mlir] Add support to SourceMgrDiagnosticHandler for filtering FileLineColLocs.

update

Mon, Jun 7, 5:34 PM · Restricted Project
rriddle added inline comments to D103649: [mlir] Add support to SourceMgrDiagnosticHandler for filtering FileLineColLocs.
Mon, Jun 7, 5:34 PM · Restricted Project
rriddle updated the diff for D103729: [mlir-lsp-server] Add support for textDocument/documentSymbols.

update

Mon, Jun 7, 4:00 PM · Restricted Project
rriddle committed rG2db4701cafd4: [mlir-lsp-server] Fix bug in symbol use/def tracking (authored by rriddle).
[mlir-lsp-server] Fix bug in symbol use/def tracking
Mon, Jun 7, 2:11 PM
rriddle committed rG4c3adea7a4ab: [mlir-lsp-server] Add support for hover on symbol references (authored by rriddle).
[mlir-lsp-server] Add support for hover on symbol references
Mon, Jun 7, 2:11 PM
rriddle committed rGf492c3596503: [mlir-lsp-server] Add support for hover on region operations (authored by rriddle).
[mlir-lsp-server] Add support for hover on region operations
Mon, Jun 7, 2:11 PM
rriddle closed D103730: [mlir-lsp-server] Fix bug in symbol use/def tracking.
Mon, Jun 7, 2:11 PM · Restricted Project
rriddle closed D103728: [mlir-lsp-server] Add support for hover on symbol references.
Mon, Jun 7, 2:10 PM · Restricted Project
rriddle closed D103727: [mlir-lsp-server] Add support for hover on region operations.
Mon, Jun 7, 2:10 PM · Restricted Project
rriddle added inline comments to D103728: [mlir-lsp-server] Add support for hover on symbol references.
Mon, Jun 7, 1:51 PM · Restricted Project
rriddle added inline comments to D103727: [mlir-lsp-server] Add support for hover on region operations.
Mon, Jun 7, 1:35 PM · Restricted Project
rriddle added inline comments to D103830: [MLIR][GPU] Simplify memcpy of cast.
Mon, Jun 7, 11:25 AM · Restricted Project
rriddle added a comment to D103591: [mlir] Allow move-only RewritePattern arguments.

Are the test failures related? They look like they might be.

Mon, Jun 7, 10:52 AM · Restricted Project
rriddle added a comment to D103754: [Core] Add Twine support for StringAttr and Identifier. NFC..

I'm open to that, only two downsides I can think of:

  1. absolutely tiny additional runtime overhead, slight codebloat for making the temporary twine. I'm not concerned about this.
  1. additional header depedency for everything that uses these methods, they'd have to include twine.h. This may already be happening implicitly though.
Mon, Jun 7, 10:48 AM · Restricted Project
rriddle accepted D103822: [MLIR] Mark additional builtin attr methods const.
Mon, Jun 7, 10:45 AM · Restricted Project
rriddle added inline comments to D103828: [mlir] support memref of memref in standard-to-llvm conversion.
Mon, Jun 7, 10:41 AM · Restricted Project
rriddle added a comment to D103827: [mlir] Make MemRef element type extensible.

Can you add a link to the discussion for this?

Mon, Jun 7, 10:33 AM · Restricted Project

Fri, Jun 4

rriddle requested review of D103730: [mlir-lsp-server] Fix bug in symbol use/def tracking.
Fri, Jun 4, 5:08 PM · Restricted Project
rriddle requested review of D103729: [mlir-lsp-server] Add support for textDocument/documentSymbols.
Fri, Jun 4, 5:07 PM · Restricted Project
rriddle requested review of D103728: [mlir-lsp-server] Add support for hover on symbol references.
Fri, Jun 4, 5:06 PM · Restricted Project
rriddle requested review of D103727: [mlir-lsp-server] Add support for hover on region operations.
Fri, Jun 4, 5:06 PM · Restricted Project
rriddle added inline comments to D103669: Avoid assertion failure on printing scf.for in debug dump..
Fri, Jun 4, 4:45 PM · Restricted Project
rriddle added inline comments to D103632: [mlir][sparse] add option for 32-bit indices in scatter/gather.
Fri, Jun 4, 1:56 PM · Restricted Project

Thu, Jun 3

rriddle requested changes to D103669: Avoid assertion failure on printing scf.for in debug dump..
Thu, Jun 3, 11:57 PM · Restricted Project
rriddle added inline comments to D103669: Avoid assertion failure on printing scf.for in debug dump..
Thu, Jun 3, 11:57 PM · Restricted Project
rriddle added inline comments to D103669: Avoid assertion failure on printing scf.for in debug dump..
Thu, Jun 3, 11:36 PM · Restricted Project
rriddle accepted D103657: [NFC] Add ArrayRef includes to two files..
Thu, Jun 3, 4:22 PM · Restricted Project
rriddle committed rGd6af89beb26d: [mlir-lsp-server] Add support for tracking the use/def chains of symbols (authored by rriddle).
[mlir-lsp-server] Add support for tracking the use/def chains of symbols
Thu, Jun 3, 4:12 PM
rriddle closed D103585: [mlir-lsp-server] Add support for tracking the use/def chains of symbols.
Thu, Jun 3, 4:12 PM · Restricted Project
rriddle added inline comments to D103585: [mlir-lsp-server] Add support for tracking the use/def chains of symbols.
Thu, Jun 3, 4:08 PM · Restricted Project
rriddle updated the diff for D103585: [mlir-lsp-server] Add support for tracking the use/def chains of symbols.

Update

Thu, Jun 3, 4:04 PM · Restricted Project
rriddle added a comment to D102945: [mlir] Add new SubElementAttr/SubElementType Interfaces.

Could you add a C++ unit test for this?

Thu, Jun 3, 3:22 PM · Restricted Project
rriddle updated the diff for D102945: [mlir] Add new SubElementAttr/SubElementType Interfaces.

update

Thu, Jun 3, 3:21 PM · Restricted Project
rriddle added inline comments to D103591: [mlir] Allow move-only RewritePattern arguments.
Thu, Jun 3, 3:17 PM · Restricted Project
rriddle requested review of D103649: [mlir] Add support to SourceMgrDiagnosticHandler for filtering FileLineColLocs.
Thu, Jun 3, 2:47 PM · Restricted Project

Wed, Jun 2

rriddle requested review of D103585: [mlir-lsp-server] Add support for tracking the use/def chains of symbols.
Wed, Jun 2, 6:56 PM · Restricted Project
rriddle committed rGc89dff5855bb: [mlir][NFC] Split the non-templated bits out of IROperand into a base class (authored by rriddle).
[mlir][NFC] Split the non-templated bits out of IROperand into a base class
Wed, Jun 2, 12:55 PM
rriddle closed D103353: [mlir][NFC] Split the non-templated bits out of IROperand into a base class.
Wed, Jun 2, 12:55 PM · Restricted Project
rriddle added a comment to D103353: [mlir][NFC] Split the non-templated bits out of IROperand into a base class.

Thanks for the review!

Wed, Jun 2, 12:48 PM · Restricted Project
rriddle committed rGfa51c5af5d5d: [mlir] Resolve TODO and use the pass argument instead of the TypeID for… (authored by rriddle).
[mlir] Resolve TODO and use the pass argument instead of the TypeID for…
Wed, Jun 2, 12:18 PM
rriddle closed D101880: [mlir] Resolve TODO and use the pass argument instead of the TypeID for registration.
Wed, Jun 2, 12:17 PM · Restricted Project
rriddle committed rG0289a2692e0e: [mlir] Add support for filtering patterns based on debug names and labels (authored by rriddle).
[mlir] Add support for filtering patterns based on debug names and labels
Wed, Jun 2, 12:06 PM
rriddle closed D102441: [mlir] Add support for filtering patterns based on debug names and labels.
Wed, Jun 2, 12:05 PM · Restricted Project
rriddle accepted D103482: [mlir-lsp] Report range of potential identifier starting at location of diagnostic.
Wed, Jun 2, 10:08 AM · Restricted Project

Tue, Jun 1

rriddle accepted D103494: [CSE] Ask DominanceInfo about "hasSSADominance" instead of reconstructing it..
Tue, Jun 1, 3:16 PM · Restricted Project
rriddle added inline comments to D103373: [Verifier] Speed up and parallelize dominance checking. NFC.
Tue, Jun 1, 12:46 PM · Restricted Project
rriddle added a comment to D103482: [mlir-lsp] Report range of potential identifier starting at location of diagnostic.

It would be nice of we could reuse some of the tokenizing logic from the parser to recover the full range. Maybe we could use the ParserAsmState for this injection, and add a method to transform positions into ranges.

Tue, Jun 1, 12:25 PM · Restricted Project
rriddle requested changes to D103482: [mlir-lsp] Report range of potential identifier starting at location of diagnostic.
Tue, Jun 1, 12:20 PM · Restricted Project

Mon, May 31

rriddle accepted D103373: [Verifier] Speed up and parallelize dominance checking. NFC.

LGTM, especially if the DominanceInfo stuff is going to be cleaned up in a followup. Thanks for cleaning this up!

Mon, May 31, 10:29 PM · Restricted Project
rriddle added a comment to D103384: [Dominators] Rewrite the dominator implementation for efficiency. NFC..

Thanks! This is another thing that's been lingering for a while to be cleaned up. Took a cursory glance and generally seems alright, most comments are stylistic. Will look again when I get back to the office if some else hasn't approved by then.

Mon, May 31, 10:20 PM · Restricted Project

Sat, May 29

rriddle added inline comments to D103373: [Verifier] Speed up and parallelize dominance checking. NFC.
Sat, May 29, 5:35 PM · Restricted Project

Fri, May 28

rriddle requested review of D103353: [mlir][NFC] Split the non-templated bits out of IROperand into a base class.
Fri, May 28, 10:18 PM · Restricted Project
rriddle accepted D103345: [Verifier] Significantly speed up IsolatedFromAbove checking. NFC..
Fri, May 28, 3:24 PM · Restricted Project

Thu, May 27

rriddle added a reviewer for D102945: [mlir] Add new SubElementAttr/SubElementType Interfaces: jpienaar.
Thu, May 27, 2:48 PM · Restricted Project
rriddle committed rG8cbbc5d00b6a: [mlir-lsp-server] Add support for processing split files (authored by rriddle).
[mlir-lsp-server] Add support for processing split files
Thu, May 27, 2:47 PM
rriddle closed D102660: [mlir-lsp-server] Add support for processing split files.
Thu, May 27, 2:47 PM · Restricted Project
rriddle added inline comments to D102660: [mlir-lsp-server] Add support for processing split files.
Thu, May 27, 2:37 PM · Restricted Project
rriddle updated the diff for D102660: [mlir-lsp-server] Add support for processing split files.

update

Thu, May 27, 2:37 PM · Restricted Project
rriddle edited reviewers for D103276: [MLIR] Fix Standalone dialect test to work in out-of-tree builds, added: stephenneuendorffer, mehdi_amini; removed: Restricted Project.
Thu, May 27, 1:59 PM · Restricted Project
rriddle committed rGd47dd1107132: [mlir] Add support for querying the ModRef behavior from the AliasAnalysis class (authored by rriddle).
[mlir] Add support for querying the ModRef behavior from the AliasAnalysis class
Thu, May 27, 1:58 PM
rriddle closed D101673: [mlir] Add support for querying the ModRef behavior from the AliasAnalysis class.
Thu, May 27, 1:58 PM · Restricted Project
rriddle accepted D101046: [mlir-reduce] Reducer refactor..

Looks good, thanks!

Thu, May 27, 1:34 PM · Restricted Project

Wed, May 26

rriddle accepted D103226: [mlir] Support dialect-wide canonicalization pattern registration.

LGTM

Wed, May 26, 10:35 PM · Restricted Project
rriddle requested changes to D103216: [mlir][Standard] Add unsigned integers to UIToFPOp and FPToUIOp cast-compatibility checks.

Standard operations are explicitly signless by design, i.e. they purposefully don't support signed/unsigned integers.

Wed, May 26, 5:22 PM · Restricted Project
rriddle added inline comments to D103141: [mlir] Fold complex.re(complex.create) and complex.im(complex.create).
Wed, May 26, 1:52 AM · Restricted Project

Tue, May 25

rriddle accepted D103117: [MLIR Core] Cache the empty StringAttr like we do for empty dictionaries. NFC..
Tue, May 25, 2:42 PM · Restricted Project
rriddle added a comment to D103053: [Canonicalize] Switch the default setting to "top down"..

It looks like there may be a few failures in toy, can you take a look?

Tue, May 25, 2:13 PM · Restricted Project
rriddle committed rGdc2aa4767601: [mlir] Add a copy constructor to FailureOr (authored by math-fehr).
[mlir] Add a copy constructor to FailureOr
Tue, May 25, 12:16 PM
rriddle closed D98955: [mlir] Add a copy constructor to FailureOr.
Tue, May 25, 12:16 PM · Restricted Project
rriddle committed rG1bf3fd9bb55a: [mlir] Use unique_function in AbstractOperation fields (authored by math-fehr).
[mlir] Use unique_function in AbstractOperation fields
Tue, May 25, 11:41 AM