- User Since
- Jun 18 2016, 2:24 PM (260 w, 1 d)
Fri, Jun 11
Thu, Jun 10
Thanks, starting to work through it.
Thanks. (Sorry, missed this somehow)
Wed, Jun 9
Tue, Jun 8
This looks right to me, but might be good to get another LGTM.
I thought you abandoned this change? Looks like you landed it.
Mon, Jun 7
Thanks for the review, PTAL.
Are the test failures related? They look like they might be.
Can you add a link to the discussion for this?
Fri, Jun 4
Thu, Jun 3
Wed, Jun 2
Thanks for the review!
Tue, Jun 1
It would be nice of we could reuse some of the tokenizing logic from the parser to recover the full range. Maybe we could use the ParserAsmState for this injection, and add a method to transform positions into ranges.
Mon, May 31
LGTM, especially if the DominanceInfo stuff is going to be cleaned up in a followup. Thanks for cleaning this up!
Thanks! This is another thing that's been lingering for a while to be cleaned up. Took a cursory glance and generally seems alright, most comments are stylistic. Will look again when I get back to the office if some else hasn't approved by then.
Sat, May 29
Fri, May 28
Thu, May 27
Looks good, thanks!
Wed, May 26
Standard operations are explicitly signless by design, i.e. they purposefully don't support signed/unsigned integers.
Tue, May 25
It looks like there may be a few failures in toy, can you take a look?