Page MenuHomePhabricator

rriddle (River Riddle)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 18 2016, 2:24 PM (215 w, 5 d)

Recent Activity

Today

rriddle accepted D85541: [mlir] Centralize handling of memref element types..
Fri, Aug 7, 11:50 AM · Restricted Project
rriddle accepted D85495: Revisit Dialect registration: require and store a TypeID on dialects.
Fri, Aug 7, 12:28 AM · Restricted Project

Yesterday

rriddle added inline comments to D85495: Revisit Dialect registration: require and store a TypeID on dialects.
Thu, Aug 6, 9:56 PM · Restricted Project
rriddle added inline comments to D85167: [mlir][DialectConversion] Update the documentation for dialect conversion.
Thu, Aug 6, 9:37 PM · Restricted Project
rriddle updated the diff for D85260: [mlir][docs] Update/Add documentation for MLIRs Pattern Rewrite infrastructure.

Address comments

Thu, Aug 6, 3:57 PM · Restricted Project
rriddle updated the diff for D85167: [mlir][DialectConversion] Update the documentation for dialect conversion.

Address comments

Thu, Aug 6, 3:57 PM · Restricted Project
rriddle requested review of D85475: [mlir][Type] Remove usages of Type::getKind.
Thu, Aug 6, 2:45 PM · Restricted Project
rriddle updated the diff for D85370: [mlir][Attribute] Remove usages of Attribute::getKind.

Resolve comments

Thu, Aug 6, 2:45 PM · Restricted Project
rriddle updated the diff for D82597: [mlir] Add a utility class, ThreadLocalCache, for storing non static thread local objects..

Resolve comments

Thu, Aug 6, 2:44 PM · Restricted Project
rriddle added a comment to D85348: [mlir][Types] Remove the subclass data from Type.

Wow that was pretty bad actually, do I miss something or there was zero upside to the subclass data before?

Thu, Aug 6, 2:37 PM · Restricted Project
rriddle added inline comments to D85382: [MLIR] Add getSizeInBits() for tensor of complex.
Thu, Aug 6, 2:32 PM · Restricted Project
rriddle accepted D85382: [MLIR] Add getSizeInBits() for tensor of complex.
Thu, Aug 6, 1:43 PM · Restricted Project
rriddle accepted D85445: [mlir] Remove llvm::LLVMContext and llvm::Module from mlir::LLVMDialectImpl.
Thu, Aug 6, 11:38 AM · Restricted Project
rriddle added inline comments to D85196: [mlir][spirv] Add correct handling of Kernel and Addresses capabilities.
Thu, Aug 6, 11:35 AM · Restricted Project
rriddle added inline comments to D85449: [mlir][SCF] Add utility to outline the then and else branches of an scf.IfOp.
Thu, Aug 6, 11:33 AM · Restricted Project
rriddle accepted D85444: [mlir] do not require LLVMDialect in conversion from LLVM IR.
Thu, Aug 6, 11:28 AM · Restricted Project
rriddle accepted D85443: [mlir] take LLVMContext in MLIR-to-LLVM-IR translation.
Thu, Aug 6, 11:24 AM · Restricted Project
rriddle added inline comments to D85413: [mlir][Linalg] Introduce canonicalization to remove dead LinalgOps.
Thu, Aug 6, 2:27 AM · Restricted Project
rriddle accepted D85411: Migrate Dialect registration to a method on the Context: getOrCreateDialect<ConcreteDialect>().

Can you also change the Dialect classof implementation to use getTypeID instead? That would remove the string comparison, and make casting to a dialect O(1) now.

Thu, Aug 6, 2:00 AM · Restricted Project

Wed, Aug 5

rriddle updated the diff for D82597: [mlir] Add a utility class, ThreadLocalCache, for storing non static thread local objects..

Switch to a combo of weak_ptr/shared_ptr.

Wed, Aug 5, 5:18 PM · Restricted Project
rriddle accepted D85372: [mlir] take MLIRContext instead of LLVMDialect in getters of LLVMType's.
Wed, Aug 5, 4:05 PM · Restricted Project
rriddle accepted D85371: [mlir] Remove most uses of LLVMDialect::getModule.
Wed, Aug 5, 3:55 PM · Restricted Project
rriddle requested review of D85370: [mlir][Attribute] Remove usages of Attribute::getKind.
Wed, Aug 5, 3:50 PM · Restricted Project
rriddle updated the diff for D85356: [mlir] Remove the need to define `kindof` on attribute and type classes..

Rebase

Wed, Aug 5, 3:49 PM · Restricted Project
rriddle updated the diff for D85356: [mlir] Remove the need to define `kindof` on attribute and type classes..

Rebase

Wed, Aug 5, 3:47 PM · Restricted Project
rriddle updated the diff for D85348: [mlir][Types] Remove the subclass data from Type.

Rebase

Wed, Aug 5, 3:46 PM · Restricted Project
rriddle updated the diff for D82597: [mlir] Add a utility class, ThreadLocalCache, for storing non static thread local objects..

Rebase

Wed, Aug 5, 3:46 PM · Restricted Project
rriddle updated the diff for D82596: [mlir] Refactor StorageUniquer to require registration of possible storage types.

Rebase

Wed, Aug 5, 3:44 PM · Restricted Project
rriddle added inline comments to D82596: [mlir] Refactor StorageUniquer to require registration of possible storage types.
Wed, Aug 5, 3:31 PM · Restricted Project
rriddle requested review of D85356: [mlir] Remove the need to define `kindof` on attribute and type classes..
Wed, Aug 5, 1:28 PM · Restricted Project
rriddle updated the diff for D85348: [mlir][Types] Remove the subclass data from Type.

Rebase

Wed, Aug 5, 1:28 PM · Restricted Project
rriddle updated the diff for D82597: [mlir] Add a utility class, ThreadLocalCache, for storing non static thread local objects..

Rebase

Wed, Aug 5, 1:27 PM · Restricted Project
rriddle updated the diff for D82596: [mlir] Refactor StorageUniquer to require registration of possible storage types.

Rebase

Wed, Aug 5, 1:27 PM · Restricted Project
rriddle requested review of D85348: [mlir][Types] Remove the subclass data from Type.
Wed, Aug 5, 12:41 PM · Restricted Project
rriddle updated the diff for D82597: [mlir] Add a utility class, ThreadLocalCache, for storing non static thread local objects..

Rebase

Wed, Aug 5, 12:41 PM · Restricted Project
rriddle updated the diff for D82596: [mlir] Refactor StorageUniquer to require registration of possible storage types.

Rebase

Wed, Aug 5, 12:40 PM · Restricted Project
rriddle accepted D85297: [mlir] use the new stateful LLVM type translator by default.
Wed, Aug 5, 11:30 AM · Restricted Project
rriddle added inline comments to D83969: Create the Reduction Tree Pass.
Wed, Aug 5, 2:46 AM · Restricted Project

Tue, Aug 4

rriddle added inline comments to D84268: [mlir][openacc] Introduce OpenACC dialect with parallel, data, loop operations.
Tue, Aug 4, 7:06 PM · Restricted Project
rriddle added inline comments to D84268: [mlir][openacc] Introduce OpenACC dialect with parallel, data, loop operations.
Tue, Aug 4, 6:51 PM · Restricted Project
rriddle added a comment to D85260: [mlir][docs] Update/Add documentation for MLIRs Pattern Rewrite infrastructure.

I tried to touch on most of the important aspects, but let me know if I missed something. Thanks.

Tue, Aug 4, 4:51 PM · Restricted Project
rriddle requested review of D85260: [mlir][docs] Update/Add documentation for MLIRs Pattern Rewrite infrastructure.
Tue, Aug 4, 4:50 PM · Restricted Project
rriddle added inline comments to D85167: [mlir][DialectConversion] Update the documentation for dialect conversion.
Tue, Aug 4, 12:16 PM · Restricted Project
rriddle added a comment to D85167: [mlir][DialectConversion] Update the documentation for dialect conversion.

One thing I think is missing from this when and if failed type conversions result in failed patterns. I was debugging a case recently where a type conversion failed, but it wasn't obvious why this happened, and it was not reported separately, only as part of a failing pattern.

Tue, Aug 4, 11:45 AM · Restricted Project
rriddle updated the diff for D85167: [mlir][DialectConversion] Update the documentation for dialect conversion.

Resolve comments and a section on debugging

Tue, Aug 4, 11:45 AM · Restricted Project
rriddle accepted D85075: [MLIR] Change FunctionType::get() and TupleType::get() to use TypeRange.

Thanks for the cleanup!

Tue, Aug 4, 10:42 AM · Restricted Project
rriddle added inline comments to D84268: [mlir][openacc] Introduce OpenACC dialect with parallel, data, loop operations.
Tue, Aug 4, 10:35 AM · Restricted Project
rriddle accepted D85206: [MLIR][SPIRVToLLVM] Indentation and style fix in tests.

Thanks!

Tue, Aug 4, 10:26 AM · Restricted Project
rriddle accepted D85224: [mlir] Remove LLVMTypeTestDialect.
Tue, Aug 4, 10:24 AM · Restricted Project

Mon, Aug 3

rriddle added inline comments to D85075: [MLIR] Change FunctionType::get() and TupleType::get() to use TypeRange.
Mon, Aug 3, 6:05 PM · Restricted Project
rriddle added inline comments to D84998: [MLIR] Add affine.parallel canonicalizations and folding.
Mon, Aug 3, 4:31 PM · Restricted Project
rriddle updated the diff for D82597: [mlir] Add a utility class, ThreadLocalCache, for storing non static thread local objects..

Rebase

Mon, Aug 3, 4:21 PM · Restricted Project
rriddle updated the diff for D82596: [mlir] Refactor StorageUniquer to require registration of possible storage types.

Run clang-format

Mon, Aug 3, 4:20 PM · Restricted Project
rriddle updated the diff for D82596: [mlir] Refactor StorageUniquer to require registration of possible storage types.

Resolve comments

Mon, Aug 3, 4:17 PM · Restricted Project
rriddle requested review of D85167: [mlir][DialectConversion] Update the documentation for dialect conversion.
Mon, Aug 3, 3:24 PM · Restricted Project
rriddle committed rG8c39e70679e9: [mlir][OpFormatGen] Add support for eliding UnitAttr when used to anchor an… (authored by rriddle).
[mlir][OpFormatGen] Add support for eliding UnitAttr when used to anchor an…
Mon, Aug 3, 2:32 PM
rriddle closed D84577: [mlir][OpFormatGen] Add support for eliding UnitAttr when used to anchor an optional group.
Mon, Aug 3, 2:32 PM · Restricted Project
rriddle added a comment to D84998: [MLIR] Add affine.parallel canonicalizations and folding.

A lot of your patterns (all of them?) are breaking the contract with the pattern rewriter right now.

Mon, Aug 3, 2:06 PM · Restricted Project
rriddle added inline comments to D84998: [MLIR] Add affine.parallel canonicalizations and folding.
Mon, Aug 3, 2:04 PM · Restricted Project
rriddle requested changes to D85075: [MLIR] Change FunctionType::get() and TupleType::get() to use TypeRange.

Please also run clang-format.

Mon, Aug 3, 1:47 PM · Restricted Project

Sat, Aug 1

rriddle added inline comments to D84245: [MLIR][SPIRVToLLVM] Conversion pattern for loop op.
Sat, Aug 1, 12:37 AM · Restricted Project

Fri, Jul 31

rriddle added inline comments to D84795: [mlir][DialectConversion] Add support for mergeBlocks in ConversionPatternRewriter..
Fri, Jul 31, 10:39 PM · Restricted Project
rriddle accepted D85066: [mlir][DialectConversion] Remove usage of std::distance to track position..
Fri, Jul 31, 10:37 PM · Restricted Project
rriddle accepted D84990: [MLIR] Simplify CmpIOp when operands are identical.

Thanks. LGTM after resolving the last few comments.

Fri, Jul 31, 4:08 PM · Restricted Project
rriddle added inline comments to D84990: [MLIR] Simplify CmpIOp when operands are identical.
Fri, Jul 31, 3:24 PM · Restricted Project
rriddle added inline comments to D84990: [MLIR] Simplify CmpIOp when operands are identical.
Fri, Jul 31, 2:37 PM · Restricted Project
rriddle committed rG2a6c8b2e9581: [mlir][PassIncGen] Refactor how pass registration is generated (authored by rriddle).
[mlir][PassIncGen] Refactor how pass registration is generated
Fri, Jul 31, 1:26 PM
rriddle closed D84983: [mlir][PassIncGen] Refactor how pass registration is generated.
Fri, Jul 31, 1:26 PM · Restricted Project
rriddle updated the diff for D84983: [mlir][PassIncGen] Refactor how pass registration is generated.

Fixup flang

Fri, Jul 31, 1:18 PM · Restricted Project
rriddle added inline comments to D84983: [mlir][PassIncGen] Refactor how pass registration is generated.
Fri, Jul 31, 12:28 PM · Restricted Project
rriddle added a comment to D84983: [mlir][PassIncGen] Refactor how pass registration is generated.

Thanks River!

So I just want to confirm that as a user if I call, say registerGpuKernelOutliningPass() I just include GPU/Passes.h and depend on MLIRGPU and don't end up bringing, say cuda, into my build. Right?

Fri, Jul 31, 12:23 PM · Restricted Project
rriddle accepted D84795: [mlir][DialectConversion] Add support for mergeBlocks in ConversionPatternRewriter..
Fri, Jul 31, 12:12 PM · Restricted Project
rriddle accepted D85021: [mlir] switch the modeling of LLVM types to use the new mechanism.
Fri, Jul 31, 11:57 AM · Restricted Project
rriddle added inline comments to D85020: [mlir] provide same APIs as existing LLVMType in the new LLVM type modeling.
Fri, Jul 31, 11:52 AM · Restricted Project
rriddle added a comment to D82704: [WIP] [MLIR] [RFC] Async dialect targeting LLVM coroutines.

What's the status here?

POC that will never be submitted as is (can't find a button to revert this PR).

Fri, Jul 31, 11:49 AM · Restricted Project
rriddle requested changes to D84990: [MLIR] Simplify CmpIOp when operands are identical.
Fri, Jul 31, 11:47 AM · Restricted Project
rriddle added inline comments to D85019: [mlir] translate types between MLIR LLVM dialect and LLVM IR.
Fri, Jul 31, 11:43 AM · Restricted Project
rriddle accepted D85038: [MLIR][NFC] Add FuncOp::addArgument() and FuncOp::getArgumentTypes().
Fri, Jul 31, 11:04 AM · Restricted Project

Thu, Jul 30

rriddle added inline comments to D84990: [MLIR] Simplify CmpIOp when operands are identical.
Thu, Jul 30, 4:36 PM · Restricted Project
rriddle requested review of D84986: [mlir] Add a new debug action framework..
Thu, Jul 30, 2:50 PM · Restricted Project
rriddle accepted D84984: [MLIR][NFC] Add SymbolUse::UseRange::empty().
Thu, Jul 30, 2:22 PM · Restricted Project
rriddle requested review of D84983: [mlir][PassIncGen] Refactor how pass registration is generated.
Thu, Jul 30, 1:56 PM · Restricted Project

Wed, Jul 29

rriddle accepted D84339: [mlir] First-party modeling of LLVM types.
Wed, Jul 29, 3:38 PM · Restricted Project
rriddle added a comment to D84795: [mlir][DialectConversion] Add support for mergeBlocks in ConversionPatternRewriter..

Thanks Mahesh!! Looks good, just had some comments on the encoding.

Wed, Jul 29, 3:25 PM · Restricted Project

Tue, Jul 28

rriddle accepted D84807: [NFC] Add getArgumentTypes() to Region.
Tue, Jul 28, 3:42 PM · Restricted Project

Mon, Jul 27

rriddle added a comment to D84339: [mlir] First-party modeling of LLVM types.

Looks really great Alex! Made a first pass through, nothing really big mostly nits.

Mon, Jul 27, 7:42 PM · Restricted Project
rriddle updated the summary of D84719: [mlir][OpFormatGen] Add support for specifiy "custom" directives..
Mon, Jul 27, 7:06 PM · Restricted Project
Herald added a project to D84719: [mlir][OpFormatGen] Add support for specifiy "custom" directives.: Restricted Project.
Mon, Jul 27, 6:57 PM · Restricted Project
rriddle added inline comments to D84577: [mlir][OpFormatGen] Add support for eliding UnitAttr when used to anchor an optional group.
Mon, Jul 27, 1:31 PM · Restricted Project
rriddle updated the diff for D84577: [mlir][OpFormatGen] Add support for eliding UnitAttr when used to anchor an optional group.

Add another test

Mon, Jul 27, 1:30 PM · Restricted Project
rriddle added inline comments to D84657: [MLIR][SPIRVToLLVM] Branch weights support for BranchConditional conversion.
Mon, Jul 27, 1:18 PM · Restricted Project
rriddle added inline comments to D84698: [MLIR] Consider AffineIfOp when getting the index set of an Op wrapped in nested loops.
Mon, Jul 27, 1:06 PM · Restricted Project
rriddle added inline comments to D84635: [MLIR] Add lowering for shape.extend..
Mon, Jul 27, 1:01 PM · Restricted Project
rriddle updated the diff for D84580: [mlir] Add a conversion pass between PDL and the PDL Interpreter Dialect.

Rebase

Mon, Jul 27, 12:57 PM · Restricted Project
rriddle updated the diff for D84579: [mlir][PDL] Add a PDL Interpreter Dialect.

Remove unnecessary interfaces

Mon, Jul 27, 12:56 PM · Restricted Project
rriddle added inline comments to D84619: [mlir][GPUToSPIRV] Add a test pass to set workgroup size for kernel functions..
Mon, Jul 27, 12:40 PM · Restricted Project
rriddle added a comment to D84619: [mlir][GPUToSPIRV] Add a test pass to set workgroup size for kernel functions..

(Leaving approval to Lei or Stephan)

Mon, Jul 27, 12:39 PM · Restricted Project

Sun, Jul 26

rriddle requested changes to D84619: [mlir][GPUToSPIRV] Add a test pass to set workgroup size for kernel functions..
Sun, Jul 26, 11:29 PM · Restricted Project
rriddle added inline comments to D84490: [MLIR] Introduce inter-procedural memref layout normalization.
Sun, Jul 26, 9:18 PM · Restricted Project
rriddle added inline comments to D84566: [mlir][Linalg] Enable fusion of std.constant (producer) with linalg.indexed_generic (consumer) with tensor arguments..
Sun, Jul 26, 3:00 PM · Restricted Project