Page MenuHomePhabricator

mehdi_amini (Mehdi AMINI)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Apr 30 2013, 5:34 PM (415 w, 4 d)
Roles
Administrator

Recent Activity

Yesterday

mehdi_amini accepted D100690: [mlir][mlir-lsp-server] Add some initial documentation on the MLIR LSP server.

Thanks for the high-level doc!

Fri, Apr 16, 4:44 PM · Restricted Project
mehdi_amini added a comment to D100677: [mlir][llvm] Add UnnamedAddr attribute to GlobalOp.

Can you add a test for the conversion back and forth with LLVM IR?

Fri, Apr 16, 1:48 PM · Restricted Project
mehdi_amini added a comment to D100647: [MLIR] Add API for external timers to pass manager.

I support making the timing infrastructure usable and pluggable outside of the pass manager! Thanks for working on this, I looked into it at some point but didn't need it badly enough to finish it.

Fri, Apr 16, 11:39 AM · Restricted Project

Thu, Apr 15

mehdi_amini accepted D100607: [mlir] Add a vscode language extension for MLIR.
Thu, Apr 15, 4:52 PM · Restricted Project
mehdi_amini added a comment to D100607: [mlir] Add a vscode language extension for MLIR.

If it works, that'll be good enough for me :)

Thu, Apr 15, 4:52 PM · Restricted Project
mehdi_amini committed rG102fd1cb8b40: Add support for numpy arrays to memref conversions. (authored by pashu123).
Add support for numpy arrays to memref conversions.
Thu, Apr 15, 4:41 PM
mehdi_amini closed D100077: Add support for numpy arrays to memref conversions..
Thu, Apr 15, 4:41 PM · Restricted Project
mehdi_amini accepted D100578: [mlir][AsmPrinter] Fix multi-threaded segfault by using explicit null stream per thread.
Thu, Apr 15, 11:09 AM · Restricted Project

Wed, Apr 14

mehdi_amini committed rGf78dcb81af7d: Fix the build of `mlir-doc` (again) (authored by mehdi_amini).
Fix the build of `mlir-doc` (again)
Wed, Apr 14, 10:18 PM
mehdi_amini committed rG037bae8928f2: Fix Interface doc generation after recent change to add_mlir_doc() API (authored by mehdi_amini).
Fix Interface doc generation after recent change to add_mlir_doc() API
Wed, Apr 14, 9:34 PM
mehdi_amini committed rG90ae4d9030b0: Change add_mlir_doc CMake macro to take the tablegen command as last argument… (authored by mehdi_amini).
Change add_mlir_doc CMake macro to take the tablegen command as last argument…
Wed, Apr 14, 8:00 PM
mehdi_amini closed D100517: Change add_mlir_doc CMake macro to take the tablegen command as last argument to allow extra flags.
Wed, Apr 14, 7:59 PM · Restricted Project
mehdi_amini requested review of D100517: Change add_mlir_doc CMake macro to take the tablegen command as last argument to allow extra flags.
Wed, Apr 14, 6:12 PM · Restricted Project
mehdi_amini added a comment to D99967: [Flang] Changes to mangling code.
Wed, Apr 14, 1:16 PM · Restricted Project
mehdi_amini added a reverting change for D99713: Refactor the architecture of mlir-reduce: rGa33b6471001a: Revert "Refactor the architecture of mlir-reduce".
Wed, Apr 14, 12:26 PM · Restricted Project
mehdi_amini added a reverting change for rGa32846b1d014: Refactor the architecture of mlir-reduce: rGa33b6471001a: Revert "Refactor the architecture of mlir-reduce".
Wed, Apr 14, 12:26 PM
mehdi_amini committed rGa33b6471001a: Revert "Refactor the architecture of mlir-reduce" (authored by mehdi_amini).
Revert "Refactor the architecture of mlir-reduce"
Wed, Apr 14, 12:26 PM
mehdi_amini committed rG543cd763a488: Update OpBase.td AttrDef class to define default value for returnType and… (authored by mehdi_amini).
Update OpBase.td AttrDef class to define default value for returnType and…
Wed, Apr 14, 12:25 PM
mehdi_amini closed D100356: Update OpBase.td AttrDef class to define default value for returnType and convertFromStorage (NFC).
Wed, Apr 14, 12:25 PM · Restricted Project
mehdi_amini added inline comments to D100356: Update OpBase.td AttrDef class to define default value for returnType and convertFromStorage (NFC).
Wed, Apr 14, 12:25 PM · Restricted Project

Tue, Apr 13

mehdi_amini added a comment to D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529).

On the other hand, all three leak checkers that we have tried don't cope with the transformation well at all

Tue, Apr 13, 10:32 PM · Restricted Project
mehdi_amini added a comment to D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529).

clang++ -O1 a.cc b.cc -fsanitize=leak had no leak before and reported a leak with this patch. You can also change -O1 to -O2 or -O3. -fsanitize=leak can be changed to -fsanitize=address. You may remove -fsanitize= and use valgrind.

I'd question whether this is a feature or a bug though: if a user really want to intentionally "leak" this way, they could mark the static void *g; with __attribute__((__used__)) to prevent the optimization, or make the store volatile.

The loads can be optimized out, so I don't think the user needs annotation.

Tue, Apr 13, 9:12 PM · Restricted Project
mehdi_amini accepted D100439: [mlir][mlir-lsp] Add a new C++ LSP server for MLIR named mlir-lsp-server.

This whole design with MessageHandler, LSPServer, JSONTransport and how these are all intertwined isn't clear to me.
The individual class doc is not helping here, and I don't think improving these individual class is actually gonna solve it for me: I suspect I'd like to have some high-level description of how this fits. Maybe if expanding the classes themselves, the description could position them in the global scheme, and describe their role with respect to the others.

Tue, Apr 13, 9:09 PM · Restricted Project
mehdi_amini accepted D100438: [mlir] Add a new AsmParserState class to capture detailed source information for .mlir files.
Tue, Apr 13, 8:44 PM · Restricted Project
mehdi_amini updated the summary of D100439: [mlir][mlir-lsp] Add a new C++ LSP server for MLIR named mlir-lsp-server.
Tue, Apr 13, 8:34 PM · Restricted Project
mehdi_amini added a comment to D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529).

clang++ -O1 a.cc b.cc -fsanitize=leak had no leak before and reported a leak with this patch. You can also change -O1 to -O2 or -O3. -fsanitize=leak can be changed to -fsanitize=address. You may remove -fsanitize= and use valgrind.

Tue, Apr 13, 8:33 PM · Restricted Project
mehdi_amini accepted D100437: [mlir] Add support for walking locations similarly to Operations.
Tue, Apr 13, 8:28 PM · Restricted Project, Restricted Project
mehdi_amini retitled D100436: [mlir][NFC] Add a using directive for llvm::SetVector in mlir/Support/LLVM.h from [mlir][NFC] Add a using directive for llvm::SetVector to [mlir][NFC] Add a using directive for llvm::SetVector in mlir/Support/LLVM.h.
Tue, Apr 13, 8:27 PM · Restricted Project
mehdi_amini accepted D100436: [mlir][NFC] Add a using directive for llvm::SetVector in mlir/Support/LLVM.h.
Tue, Apr 13, 8:27 PM · Restricted Project
mehdi_amini committed rG597207a3c3d7: Expose parseXInDimensionList() to the `DialectAsmParser` (authored by mehdi_amini).
Expose parseXInDimensionList() to the `DialectAsmParser`
Tue, Apr 13, 7:08 PM
mehdi_amini closed D100432: Expose parseXInDimensionList() to the `DialectAsmParser`.
Tue, Apr 13, 7:07 PM · Restricted Project
mehdi_amini requested review of D100432: Expose parseXInDimensionList() to the `DialectAsmParser`.
Tue, Apr 13, 6:25 PM · Restricted Project
mehdi_amini added a comment to D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529).

In the meantime, we should revert: if this is making clang entirely incompatible with Valgrind it'd be nice to have a plan. Can we bring this up on llvm-dev@ maybe?

Tue, Apr 13, 5:02 PM · Restricted Project
mehdi_amini added a comment to D69428: [GlobalOpt] Remove valgrind specific hacks (revert r160529).

To me that looks like a problem of "as-if" and definition of what a "leak" is: do we have a reference to a standard (or better LangRef) that would guide this here?
(to me it always looked like these were leaks in the first place, even if the leak checker was happy about them because technically "reachable")

Tue, Apr 13, 4:56 PM · Restricted Project
mehdi_amini added a comment to D100077: Add support for numpy arrays to memref conversions..

@mehdi_amini indeed, in https://numpy.org/doc/stable/reference/generated/numpy.ndarray.html we can see:

>>> np.ndarray((2,), buffer=np.array([1,2,3]),
...            offset=np.int_().itemsize,
...            dtype=int) # offset = 1*itemsize, i.e. skip first element
array([2, 3])
Tue, Apr 13, 4:14 PM · Restricted Project
mehdi_amini added inline comments to D100077: Add support for numpy arrays to memref conversions..
Tue, Apr 13, 4:04 PM · Restricted Project
mehdi_amini added a comment to D100077: Add support for numpy arrays to memref conversions..

@bondhugula @nicolasvasilache : can you confirm the recent changes address your previous comments?

Tue, Apr 13, 3:50 PM · Restricted Project
mehdi_amini accepted D100077: Add support for numpy arrays to memref conversions..

LGTM, seems like a good basis to iterate on!

Tue, Apr 13, 3:50 PM · Restricted Project
mehdi_amini accepted D100407: [mlir] Use default lli JIT in Integration tests.

Thanks for the quick fix!

Tue, Apr 13, 3:45 PM · Restricted Project
mehdi_amini added a comment to D100344: [mlir] Use MCJIT to fix integration tests.

The ORC bug is closed, can you update all these tests back to use ORC?

Tue, Apr 13, 1:00 PM · Restricted Project

Mon, Apr 12

mehdi_amini requested review of D100356: Update OpBase.td AttrDef class to define default value for returnType and convertFromStorage (NFC).
Mon, Apr 12, 6:13 PM · Restricted Project
mehdi_amini added a comment to D100344: [mlir] Use MCJIT to fix integration tests.

Ideally the bug should be referred as TODO in all these tests, and also these tests should be mentioned in the bug so that when closing the bug we update the tests back.

Mon, Apr 12, 3:48 PM · Restricted Project
mehdi_amini accepted D95390: [mlir] Async: add automatic reference counting at async.runtime operations level.

LG

Mon, Apr 12, 10:29 AM · Restricted Project

Sun, Apr 11

mehdi_amini accepted D100268: [mlir] Canonicalize AllocOp's with only store and dealloc uses.
Sun, Apr 11, 10:21 AM · Restricted Project

Sat, Apr 10

mehdi_amini accepted D100248: [mlir] Canonicalize single-iteration ParallelOp.
Sat, Apr 10, 10:28 AM · Restricted Project
mehdi_amini added a comment to D99548: [mlir] introduce "encoding" attribute to tensor type.

properties LGTM as well.

The reason I (very mildly -- just trying to stimulate discussion here) don't like properties is that it sounds like something that can be ignored if I don't know about it. (at least attr sounds like an opaque thing I have to be conservative around).

Sat, Apr 10, 9:16 AM · Restricted Project

Fri, Apr 9

mehdi_amini added a comment to D99548: [mlir] introduce "encoding" attribute to tensor type.

properties LGTM as well.

Fri, Apr 9, 11:37 AM · Restricted Project
mehdi_amini added a comment to D96397: Add C++ helpers to manage Unranked Memref in native code.

I haven't worked around the specific requirement in the CRunnerUtils file and I suspect it requires some refactoring. But I don't know also the exact use-case and how to test it in order to be able to propose a path forward here, @nicolasvasilache can you help figure out who's using this and how?

I don't either which is why the best proxy I found is mlir/lib/ExecutionEngine/CMakeLists.txt:set_property(TARGET mlir_c_runner_utils PROPERTY CXX_STANDARD 11).
I don't think there are active users though so this could be your window of opportunity to move everything into RunnerUtils as I suggested above.

Fri, Apr 9, 9:54 AM · Restricted Project

Thu, Apr 8

mehdi_amini added a comment to D96397: Add C++ helpers to manage Unranked Memref in native code.

I haven't worked around the specific requirement in the CRunnerUtils file and I suspect it requires some refactoring. But I don't know also the exact use-case and how to test it in order to be able to propose a path forward here, @nicolasvasilache can you help figure out who's using this and how?

Thu, Apr 8, 10:19 PM · Restricted Project
mehdi_amini added a comment to D95390: [mlir] Async: add automatic reference counting at async.runtime operations level.

Excellent documentation in the code!!

Thu, Apr 8, 10:16 PM · Restricted Project
mehdi_amini committed rG38b106f68157: Improve error message when tring to export to LLVM IR with a dialect missing… (authored by mehdi_amini).
Improve error message when tring to export to LLVM IR with a dialect missing…
Thu, Apr 8, 4:22 PM
mehdi_amini closed D96729: Improve error message when tring to export to LLVM IR with a dialect missing the interface.
Thu, Apr 8, 4:21 PM · Restricted Project
mehdi_amini added a comment to D96729: Improve error message when tring to export to LLVM IR with a dialect missing the interface.

Actually we can't do that in mlir-translate.cpp like we did in mlir-opt.cpp because there is no dialect registry passed through this interface. We'd have to do it in ConvertToLLVMIR.cpp but I'm not sure it is desirable there, let me know if you have another idea I'll address this post-commit.

Thu, Apr 8, 3:22 PM · Restricted Project
mehdi_amini added inline comments to D99548: [mlir] introduce "encoding" attribute to tensor type.
Thu, Apr 8, 2:02 PM · Restricted Project

Wed, Apr 7

mehdi_amini committed rGeb7f5eaf3500: Change the default value for `preloadDialectsInContext` for MlirOptMain (authored by mehdi_amini).
Change the default value for `preloadDialectsInContext` for MlirOptMain
Wed, Apr 7, 10:05 PM
mehdi_amini closed D99025: Change the default value for `preloadDialectsInContext` for MlirOptMain.
Wed, Apr 7, 10:05 PM · Restricted Project
mehdi_amini added inline comments to D100077: Add support for numpy arrays to memref conversions..
Wed, Apr 7, 8:50 PM · Restricted Project
mehdi_amini added inline comments to D99548: [mlir] introduce "encoding" attribute to tensor type.
Wed, Apr 7, 7:35 PM · Restricted Project
mehdi_amini added inline comments to D100077: Add support for numpy arrays to memref conversions..
Wed, Apr 7, 4:42 PM · Restricted Project
mehdi_amini added inline comments to D99548: [mlir] introduce "encoding" attribute to tensor type.
Wed, Apr 7, 4:16 PM · Restricted Project
mehdi_amini committed rG39ee9fd8c1c2: [mlir] Fixed alignment attribute of alloc constant folding. (authored by imaihal).
[mlir] Fixed alignment attribute of alloc constant folding.
Wed, Apr 7, 12:29 PM
mehdi_amini closed D99882: [mlir] Fixed alighnment attribute of alloc constant folding..
Wed, Apr 7, 12:29 PM · Restricted Project
mehdi_amini accepted D100049: Remove .gitignore entries not relevant in the monorepo..
Wed, Apr 7, 12:00 PM · Restricted Project, Restricted Project

Tue, Apr 6

mehdi_amini added a comment to D99561: Support visitor pattern by PointerUnion..

Right, if we look at our containers, we also find APIs that don't match exactly the standard (DenseMap::find_as or insert_as for example, or SmallVector::pop_back_val), so yes someone swapping std::vector for SmallVector may be surprised.

Tue, Apr 6, 5:47 PM · Restricted Project
mehdi_amini added a comment to D99561: Support visitor pattern by PointerUnion..

also the issue of "Oh, I'm used to using x.match(a, b) - ah, bother, this is the standard thing that doesn't support x.match, I have to use visit(a, b, x) instead".

Tue, Apr 6, 5:37 PM · Restricted Project
mehdi_amini added inline comments to D99925: [MLIR] Add a switch operation to the standard dialect.
Tue, Apr 6, 12:26 PM · Restricted Project

Mon, Apr 5

mehdi_amini accepted D99882: [mlir] Fixed alighnment attribute of alloc constant folding..
Mon, Apr 5, 10:11 AM · Restricted Project

Sat, Apr 3

mehdi_amini accepted D99844: [mlir][NFC] Fully spell mlir types names in LoopLikeOpInterface, so it can be used in ops defined outside mlir namespace.
Sat, Apr 3, 12:43 PM · Restricted Project

Fri, Apr 2

mehdi_amini added a comment to D99560: Utility to construct visitors from lambdas..

Regarding deriving from using other kinds of functors: I have not yet seen a need for this. My preference is to cross that bridge when we reach it. :)

Regarding taking references to the functors: I played around but on my first attempts the assembly seemed to have become scarier than without the references, so I decided not to push it further. Here's the evidence: https://godbolt.org/z/eoGKMW3jx

Fri, Apr 2, 1:29 PM · Restricted Project

Thu, Apr 1

mehdi_amini committed rG51a07182b3ea: Setup OpBuilder to support detached block in loopUnrollByFactor (NFC) (authored by mehdi_amini).
Setup OpBuilder to support detached block in loopUnrollByFactor (NFC)
Thu, Apr 1, 4:36 PM
mehdi_amini accepted D99720: [mlir] add memref dialect as dependent of lower-affine pass.
Thu, Apr 1, 12:51 PM · Restricted Project
mehdi_amini accepted D99721: Silence `-Wunused-private-field` warning on isIsolatedFromAbove..
Thu, Apr 1, 11:12 AM · Restricted Project

Wed, Mar 31

mehdi_amini accepted D99684: [mlir] Emit errors when creating unregistered attributes/types when not allowed.
Wed, Mar 31, 1:58 PM · Restricted Project
mehdi_amini added inline comments to D99430: [mlir][Python][Linalg] Add missing attributes to linalg ops.
Wed, Mar 31, 9:54 AM · Restricted Project
mehdi_amini added a comment to rG465b9a4a3303: Revert "Revert "[mlir] Introduce CloneOp and adapt test cases in….

Can you please include detailed reasons in the description with revert commits in the future?

Wed, Mar 31, 3:20 AM

Tue, Mar 30

mehdi_amini accepted D99638: [mlir] Add C and python API for is_registered_operation..
Tue, Mar 30, 10:42 PM · Restricted Project
mehdi_amini added inline comments to D99560: Utility to construct visitors from lambdas..
Tue, Mar 30, 4:54 PM · Restricted Project
mehdi_amini added a comment to D99501: ignore -flto= options recognized by GCC.

I don't know what's the best practice for gcc compatibility with respect to clang command line flags, adding Teresa and Richard here.

Tue, Mar 30, 3:23 PM · Restricted Project
mehdi_amini added reviewers for D99501: ignore -flto= options recognized by GCC: tejohnson, rsmith.
Tue, Mar 30, 3:23 PM · Restricted Project
mehdi_amini added inline comments to D99578: [mlir][Linalg][Python] Create the body of builtin named Linalg ops.
Tue, Mar 30, 3:17 PM · Restricted Project
mehdi_amini added inline comments to D99578: [mlir][Linalg][Python] Create the body of builtin named Linalg ops.
Tue, Mar 30, 3:14 PM · Restricted Project
mehdi_amini accepted D99608: [StructLayout] Use TrailingObjects to allocate space for MemberOffsets..
Tue, Mar 30, 3:05 PM · Restricted Project
mehdi_amini committed rGa360a9786f5f: Fix deletion of operations through the rewriter in a pattern matching a… (authored by mehdi_amini).
Fix deletion of operations through the rewriter in a pattern matching a…
Tue, Mar 30, 3:03 PM
mehdi_amini closed D99442: Fix deletion of operations through the rewriter in a pattern matching a consumer operation.
Tue, Mar 30, 3:03 PM · Restricted Project
mehdi_amini updated the diff for D99442: Fix deletion of operations through the rewriter in a pattern matching a consumer operation.

Address river's comment

Tue, Mar 30, 2:11 PM · Restricted Project
mehdi_amini added inline comments to D99442: Fix deletion of operations through the rewriter in a pattern matching a consumer operation.
Tue, Mar 30, 2:10 PM · Restricted Project
mehdi_amini committed rG7a4d63076482: Add a "register_runtime" method to the mlir.execution_engine and show calling… (authored by mehdi_amini).
Add a "register_runtime" method to the mlir.execution_engine and show calling…
Tue, Mar 30, 10:08 AM
mehdi_amini closed D99562: Add a "register_runtime" method to the mlir.execution_engine and show calling back from MLIR into Python.
Tue, Mar 30, 10:07 AM · Restricted Project
mehdi_amini updated the diff for D99562: Add a "register_runtime" method to the mlir.execution_engine and show calling back from MLIR into Python.

Address Stella's comments

Tue, Mar 30, 9:40 AM · Restricted Project
mehdi_amini added inline comments to D99562: Add a "register_runtime" method to the mlir.execution_engine and show calling back from MLIR into Python.
Tue, Mar 30, 9:33 AM · Restricted Project

Mon, Mar 29

mehdi_amini requested review of D99563: Add a test for the MLIR JIT showing the numpy array to memref conversion.
Mon, Mar 29, 10:58 PM · Restricted Project
mehdi_amini added a comment to D99561: Support visitor pattern by PointerUnion..

Also, thanks for sending the patch!
Is it possible to write a unit-test for it?

Mon, Mar 29, 9:52 PM · Restricted Project
mehdi_amini added inline comments to D99561: Support visitor pattern by PointerUnion..
Mon, Mar 29, 9:51 PM · Restricted Project
mehdi_amini added a reviewer for D99561: Support visitor pattern by PointerUnion.: dblaikie.
Mon, Mar 29, 9:51 PM · Restricted Project
mehdi_amini added a reviewer for D99560: Utility to construct visitors from lambdas.: dblaikie.
Mon, Mar 29, 9:46 PM · Restricted Project
mehdi_amini requested review of D99562: Add a "register_runtime" method to the mlir.execution_engine and show calling back from MLIR into Python.
Mon, Mar 29, 9:37 PM · Restricted Project
mehdi_amini accepted D99529: Update python deps for buildbot-mlir-nvidia..

I think Christian will need to redeploy the image, I don't think it is automatic.

Mon, Mar 29, 11:55 AM

Sun, Mar 28

mehdi_amini accepted D99464: MLIR][STD] Fold trunci (sexti)..
Sun, Mar 28, 9:55 AM · Restricted Project

Sat, Mar 27

mehdi_amini accepted D97513: [CMake] Add <Project>ConfigVersion.cmake files.
Sat, Mar 27, 7:40 PM · Restricted Project, Restricted Project, Restricted Project
mehdi_amini added inline comments to D99453: [MLIR][STD] Fold trunci (zexti)..
Sat, Mar 27, 9:43 AM · Restricted Project