Page MenuHomePhabricator

vinograd47 (Vladislav Vinogradov)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 26 2020, 10:38 PM (52 w, 4 d)

Recent Activity

Today

vinograd47 added a comment to D97612: [mlir][NFC] Use `BaseMemRefType::isValidElementType` in Parser.

@ftynse I saw the proposal about data layout and custom elements. How it assume to perform the validity check? I thought it will extend the existing isValidElementType method with more advanced checks. IMHO, in that case it will be simpler to do this in CPP file, otherwise it might bring extra dependencies to header file or make the method to complex to be inline. That's why I've moved its implementation to CPP.

Mon, Mar 1, 9:33 AM · Restricted Project

Sat, Feb 27

vinograd47 requested review of D97613: [mlir][CMAKE] Detect and enable python binding automatically.
Sat, Feb 27, 3:29 AM · Restricted Project
vinograd47 requested review of D97612: [mlir][NFC] Use `BaseMemRefType::isValidElementType` in Parser.
Sat, Feb 27, 3:20 AM · Restricted Project
vinograd47 added a comment to D94769: [Support] Format provider improvements.

@sammccall @zturner ping

Sat, Feb 27, 2:58 AM · Restricted Project

Fri, Feb 26

vinograd47 updated the diff for D97390: [mlir][ODS] Use StringLiteral instead of StringRef when applicable.

Update TypeDef - getMnemonic method.

Fri, Feb 26, 8:54 AM · Restricted Project
vinograd47 updated the diff for D96145: [mlir] Model MemRef memory space as Attribute.

Update related section in LangRef documentation.

Fri, Feb 26, 8:33 AM · Restricted Project
vinograd47 added inline comments to D97476: [mlir][NFC] Rename `MemRefType::getMemorySpace` to `getMemorySpaceAsInt`.
Fri, Feb 26, 8:18 AM · Restricted Project
vinograd47 updated the diff for D97476: [mlir][NFC] Rename `MemRefType::getMemorySpace` to `getMemorySpaceAsInt`.

Use getMemorySpaceAsInt instead of getMemorySpaceInteger.

Fri, Feb 26, 8:17 AM · Restricted Project
vinograd47 updated the diff for D94769: [Support] Format provider improvements.

Fixed clang-tidy issues in new tests.

Fri, Feb 26, 8:04 AM · Restricted Project
vinograd47 committed rG9909237d9920: [ADT][NFC] Add extra typedefs to `ArrayRef` and `MutableArrayRef` (authored by vinograd47).
[ADT][NFC] Add extra typedefs to `ArrayRef` and `MutableArrayRef`
Fri, Feb 26, 7:37 AM
vinograd47 closed D95611: [ADT][NFC] Add extra typedefs to `ArrayRef` and `MutableArrayRef`.
Fri, Feb 26, 7:37 AM · Restricted Project
vinograd47 added a comment to D95611: [ADT][NFC] Add extra typedefs to `ArrayRef` and `MutableArrayRef`.

@courbet I saw in git history that you have had similar commit, which was reverted. Could you please take a look at this change?

Fri, Feb 26, 5:25 AM · Restricted Project
vinograd47 added a reviewer for D95611: [ADT][NFC] Add extra typedefs to `ArrayRef` and `MutableArrayRef`: courbet.
Fri, Feb 26, 5:23 AM · Restricted Project

Thu, Feb 25

vinograd47 updated the diff for D96145: [mlir] Model MemRef memory space as Attribute.

Re-implemented the feature on top of separate "renaming" change.

Thu, Feb 25, 9:16 AM · Restricted Project
vinograd47 added a comment to D96145: [mlir] Model MemRef memory space as Attribute.

@mehdi_amini Submitted separate change for the first part (method renaming) : https://reviews.llvm.org/D97476

Thu, Feb 25, 8:08 AM · Restricted Project
vinograd47 requested review of D97476: [mlir][NFC] Rename `MemRefType::getMemorySpace` to `getMemorySpaceAsInt`.
Thu, Feb 25, 8:07 AM · Restricted Project
vinograd47 updated the diff for D94769: [Support] Format provider improvements.

Rebased to restart CI.

Thu, Feb 25, 7:16 AM · Restricted Project
vinograd47 committed rGf4d78a5e3aee: [mlir][NFC] Add missing namespace qualifier to ODS generated code (authored by vinograd47).
[mlir][NFC] Add missing namespace qualifier to ODS generated code
Thu, Feb 25, 7:14 AM
vinograd47 closed D97376: [mlir][NFC] Add missing namespace qualifier to ODS generated code.
Thu, Feb 25, 7:14 AM · Restricted Project

Wed, Feb 24

vinograd47 added a comment to D97390: [mlir][ODS] Use StringLiteral instead of StringRef when applicable.

This is an updated version of https://reviews.llvm.org/D95945 with attempt to fix build issues caused StringLiteral class usage. @mehdi_amini @antiagainst @bkramer Could you please take a look one more time?

Wed, Feb 24, 7:55 AM · Restricted Project
vinograd47 requested review of D97390: [mlir][ODS] Use StringLiteral instead of StringRef when applicable.
Wed, Feb 24, 7:53 AM · Restricted Project
vinograd47 updated the diff for D94769: [Support] Format provider improvements.

Rebased and added a test for range with non-reference return value.

Wed, Feb 24, 6:18 AM · Restricted Project
vinograd47 requested review of D97376: [mlir][NFC] Add missing namespace qualifier to ODS generated code.
Wed, Feb 24, 4:02 AM · Restricted Project

Sun, Feb 21

vinograd47 added a comment to D95611: [ADT][NFC] Add extra typedefs to `ArrayRef` and `MutableArrayRef`.

@lattner I've finalized the change and fixed CI failures. Please take a look one more time.

Sun, Feb 21, 2:31 AM · Restricted Project

Sat, Feb 20

vinograd47 updated the diff for D95611: [ADT][NFC] Add extra typedefs to `ArrayRef` and `MutableArrayRef`.

Rebased and fixed ArrayRef typedefs

Sat, Feb 20, 5:58 AM · Restricted Project

Wed, Feb 17

vinograd47 added a comment to D96145: [mlir] Model MemRef memory space as Attribute.

BTW, as I can see the CI failed with the following error:

Wed, Feb 17, 6:00 AM · Restricted Project
vinograd47 added a comment to D96145: [mlir] Model MemRef memory space as Attribute.

@mehdi_amini Actually, while I've seen positive feedback from the forum discussion (integer memory space leads to non-informative IRs, GPU dialect is good example for this), doing such change in atomic commit by one developer is quite hard task. It is breaking change, which affects various dialects, I believe, not only inside MLIR source tree. That's why I've submitted 2 variants of this change:

Wed, Feb 17, 5:57 AM · Restricted Project
vinograd47 added inline comments to D96145: [mlir] Model MemRef memory space as Attribute.
Wed, Feb 17, 5:48 AM · Restricted Project

Tue, Feb 16

vinograd47 added a comment to D96145: [mlir] Model MemRef memory space as Attribute.

@mehdi_amini I've updated the change and removed old integer-based API from the MemRefType. I've fixed internal dialects by switching to the new API. I still used IntegerAttr for them, because switch to another representation (like StringAttr) will require more deep modification of the dialects and lowering passes.

Tue, Feb 16, 3:17 AM · Restricted Project
vinograd47 updated the diff for D96145: [mlir] Model MemRef memory space as Attribute.

Rebased and fixed conflicts with new code.

Tue, Feb 16, 3:15 AM · Restricted Project
vinograd47 updated the diff for D96145: [mlir] Model MemRef memory space as Attribute.

Removed old integer-based API from MemRefType. Updated internal dialects to use new API.

Tue, Feb 16, 12:59 AM · Restricted Project

Sat, Feb 13

vinograd47 accepted D96645: fix linalg ods gen cross compiling like other gen executables.

Looks OK to me.

Sat, Feb 13, 4:03 AM · Restricted Project

Tue, Feb 9

vinograd47 updated the diff for D95611: [ADT][NFC] Add extra typedefs to `ArrayRef` and `MutableArrayRef`.

Removed const qualifier from ArrayRef::value_type.

Tue, Feb 9, 4:38 AM · Restricted Project

Mon, Feb 8

vinograd47 updated the diff for D95611: [ADT][NFC] Add extra typedefs to `ArrayRef` and `MutableArrayRef`.

Removed std:: namespace from size_t and ptrdiff_t.

Mon, Feb 8, 9:14 AM · Restricted Project
vinograd47 added a comment to D96145: [mlir] Model MemRef memory space as Attribute.

@rriddle @mehdi_amini @bondhugula I've updated the change according to your comments.

Mon, Feb 8, 3:32 AM · Restricted Project
vinograd47 updated the diff for D96145: [mlir] Model MemRef memory space as Attribute.

Rebased and fix review remarks

Mon, Feb 8, 3:19 AM · Restricted Project
vinograd47 committed rG035abe30c9a5: [mlir][ODS] Allow to specify custom namespace for `NativeOpTrait` (authored by vinograd47).
[mlir][ODS] Allow to specify custom namespace for `NativeOpTrait`
Mon, Feb 8, 12:08 AM
vinograd47 closed D96128: [mlir][ODS] Allow to specify custom namespace for `NativeOpTrait`.
Mon, Feb 8, 12:08 AM · Restricted Project

Fri, Feb 5

vinograd47 requested review of D96145: [mlir] Model MemRef memory space as Attribute.
Fri, Feb 5, 8:08 AM · Restricted Project
vinograd47 requested review of D96128: [mlir][ODS] Allow to specify custom namespace for `NativeOpTrait`.
Fri, Feb 5, 5:45 AM · Restricted Project
vinograd47 committed rGf349abc265eb: [mlir] Add `const` qualifiers to `AffineMap` methods (authored by vinograd47).
[mlir] Add `const` qualifiers to `AffineMap` methods
Fri, Feb 5, 4:22 AM
vinograd47 closed D96026: [mlir] Add `const` qualifiers to `AffineMap` methods.
Fri, Feb 5, 4:22 AM · Restricted Project

Thu, Feb 4

vinograd47 updated the diff for D96026: [mlir] Add `const` qualifiers to `AffineMap` methods.

@ftynse Done

Thu, Feb 4, 11:48 PM · Restricted Project
vinograd47 added a comment to D96026: [mlir] Add `const` qualifiers to `AffineMap` methods.

@ftynse Here is the code snippet, which doesn't work for me:

Thu, Feb 4, 6:28 AM · Restricted Project
vinograd47 requested review of D96026: [mlir] Add `const` qualifiers to `AffineMap` methods.
Thu, Feb 4, 6:08 AM · Restricted Project
vinograd47 added a comment to D94769: [Support] Format provider improvements.

@sammccall Could we have some agreement? As I mentioned in the last comment, even while has_StreamOperator checks for const correct version of operator << with streams, formatv implementation can call non-const version if it is available due to perfect forwarding.

Thu, Feb 4, 12:48 AM · Restricted Project
vinograd47 added a comment to D95936: [mlir][ODS] Small fixes for ODS classes.

@mehdi_amini I don't have commit access. Could you please land this change?

Thu, Feb 4, 12:38 AM · Restricted Project
vinograd47 added a comment to D95945: [mlir][ODS] Use StringLiteral instead of StringRef when applicable.

@mehdi_amini I don't have commit access. Could you please land this change?

Thu, Feb 4, 12:38 AM · Restricted Project
vinograd47 added a comment to D95952: [mlir][ODS] Add explicit namespace to `ViewLikeInterface` definition.

@mehdi_amini I don't have commit access. Could you please land this change?

Thu, Feb 4, 12:38 AM · Restricted Project

Wed, Feb 3

vinograd47 requested review of D95952: [mlir][ODS] Add explicit namespace to `ViewLikeInterface` definition.
Wed, Feb 3, 6:49 AM · Restricted Project
vinograd47 requested review of D95945: [mlir][ODS] Use StringLiteral instead of StringRef when applicable.
Wed, Feb 3, 5:24 AM · Restricted Project
vinograd47 requested review of D95936: [mlir][ODS] Small fixes for ODS classes.
Wed, Feb 3, 4:01 AM · Restricted Project

Tue, Feb 2

vinograd47 requested review of D95854: [mlir] Print more verbose message in case of type inference error.
Tue, Feb 2, 12:21 AM · Restricted Project
vinograd47 added a comment to D95787: [mlir] Allow to use constant lambda as callbacks for `TypeConverter`.

@rriddle I don't have commit access to the repo. Could you please land the change by yourself?

Tue, Feb 2, 12:12 AM · Restricted Project
vinograd47 added a comment to D95533: [mlir][NFC] Add missing include guards to MlirOptMain.h.

@mehdi_amini I don't have commit access to the repo. Could you please land the change by yourself?

Tue, Feb 2, 12:12 AM · Restricted Project
vinograd47 added a comment to D95525: [mlir] Return new Operation from `Rewriter::replaceOpWithNewOp`.

@ftynse I don't have commit access to the repo. Could you please land the change by yourself?

Tue, Feb 2, 12:12 AM · Restricted Project
vinograd47 added a comment to D95520: [mlir][NFC] Use explicit `mlir` namespace in generated code.

@rriddle I don't have commit access to the repo. Could you please land the change by yourself?

Tue, Feb 2, 12:11 AM · Restricted Project

Mon, Feb 1

vinograd47 requested review of D95787: [mlir] Allow to use constant lambda as callbacks for `TypeConverter`.
Mon, Feb 1, 7:42 AM · Restricted Project
vinograd47 updated the diff for D95611: [ADT][NFC] Add extra typedefs to `ArrayRef` and `MutableArrayRef`.

Rebased to latest main branch.

Mon, Feb 1, 12:30 AM · Restricted Project

Jan 28 2021

vinograd47 requested review of D95611: [ADT][NFC] Add extra typedefs to `ArrayRef` and `MutableArrayRef`.
Jan 28 2021, 6:05 AM · Restricted Project
vinograd47 updated the diff for D95533: [mlir][NFC] Add missing include guards to MlirOptMain.h.

Fixed include guard macro name to match preferred style.
Rebased on latest main branch.

Jan 28 2021, 4:44 AM · Restricted Project
vinograd47 updated the diff for D95525: [mlir] Return new Operation from `Rewriter::replaceOpWithNewOp`.

Rebased to latest main branch.

Jan 28 2021, 4:41 AM · Restricted Project
vinograd47 added a comment to D95520: [mlir][NFC] Use explicit `mlir` namespace in generated code.

@rriddle I've fixed your remark.

Jan 28 2021, 4:39 AM · Restricted Project
vinograd47 updated the diff for D95520: [mlir][NFC] Use explicit `mlir` namespace in generated code.

Used full namespaces name (::mlir) and rebased to latest main branch.

Jan 28 2021, 4:38 AM · Restricted Project

Jan 27 2021

vinograd47 added reviewers for D95533: [mlir][NFC] Add missing include guards to MlirOptMain.h: rriddle, ftynse, mehdi_amini.
Jan 27 2021, 7:58 AM · Restricted Project
vinograd47 requested review of D95533: [mlir][NFC] Add missing include guards to MlirOptMain.h.
Jan 27 2021, 7:57 AM · Restricted Project
vinograd47 added reviewers for D95525: [mlir] Return new Operation from `Rewriter::replaceOpWithNewOp`: ftynse, mehdi_amini.
Jan 27 2021, 7:03 AM · Restricted Project
vinograd47 requested review of D95525: [mlir] Return new Operation from `Rewriter::replaceOpWithNewOp`.
Jan 27 2021, 7:02 AM · Restricted Project
vinograd47 added reviewers for D95520: [mlir][NFC] Use explicit `mlir` namespace in generated code: ftynse, mehdi_amini.
Jan 27 2021, 5:54 AM · Restricted Project
vinograd47 requested review of D95520: [mlir][NFC] Use explicit `mlir` namespace in generated code.
Jan 27 2021, 5:47 AM · Restricted Project

Jan 22 2021

vinograd47 updated the diff for D94769: [Support] Format provider improvements.

One more comment.

Jan 22 2021, 2:10 AM · Restricted Project

Jan 20 2021

vinograd47 added inline comments to D94769: [Support] Format provider improvements.
Jan 20 2021, 2:51 AM · Restricted Project
vinograd47 updated the diff for D94769: [Support] Format provider improvements.

Rebased and fixes clang-tidy warnings in the new test.

Jan 20 2021, 1:44 AM · Restricted Project

Jan 19 2021

vinograd47 added inline comments to D94769: [Support] Format provider improvements.
Jan 19 2021, 5:49 AM · Restricted Project
vinograd47 updated the diff for D94769: [Support] Format provider improvements.

Added a test for the case, which this change fixes.

Jan 19 2021, 5:44 AM · Restricted Project

Jan 17 2021

vinograd47 added a reviewer for D94769: [Support] Format provider improvements: zturner.
Jan 17 2021, 5:15 AM · Restricted Project
vinograd47 updated the diff for D94769: [Support] Format provider improvements.

Suppress clang-tidy diagnostic about class member name.

Jan 17 2021, 5:13 AM · Restricted Project
vinograd47 removed a reviewer for D94769: [Support] Format provider improvements: Hardcode84.

@Hardcode84 Sorry for confusion, added you by mistake.

Jan 17 2021, 3:10 AM · Restricted Project
vinograd47 added a comment to D94598: [mlir] Fix cross-compilation (Linalg ODS gen).

@nicolasvasilache I'm afraid I don't have commit access. Could you please land this change to the main repository?

Jan 17 2021, 3:09 AM · Restricted Project

Jan 15 2021

vinograd47 added a reviewer for D94769: [Support] Format provider improvements: Hardcode84.
Jan 15 2021, 5:37 AM · Restricted Project
vinograd47 added a reviewer for D94769: [Support] Format provider improvements: sammccall.
Jan 15 2021, 5:36 AM · Restricted Project
vinograd47 requested review of D94769: [Support] Format provider improvements.
Jan 15 2021, 5:28 AM · Restricted Project
vinograd47 added a comment to D94417: [ADT][Support] Fix C4146 error from MSVC.

@dblaikie CI now passed. Could you please commit this change to main repo?

Jan 15 2021, 4:08 AM · Restricted Project
vinograd47 added a comment to D94417: [ADT][Support] Fix C4146 error from MSVC.

@dblaikie I see similar failures locally even on clean main branch without this changes. Is it some known issue?

Jan 15 2021, 2:37 AM · Restricted Project
vinograd47 updated the diff for D94417: [ADT][Support] Fix C4146 error from MSVC.

Rebased to the latest main state.

Jan 15 2021, 2:33 AM · Restricted Project
vinograd47 added a reviewer for D94598: [mlir] Fix cross-compilation (Linalg ODS gen): rriddle.
Jan 15 2021, 2:30 AM · Restricted Project

Jan 14 2021

vinograd47 abandoned D94658: Remove redundant move call in return statements.
Jan 14 2021, 5:49 AM · Restricted Project
vinograd47 added reviewers for D94658: Remove redundant move call in return statements: dblaikie, RKSimon, csigg.
Jan 14 2021, 1:00 AM · Restricted Project
vinograd47 requested review of D94658: Remove redundant move call in return statements.
Jan 14 2021, 12:56 AM · Restricted Project

Jan 13 2021

vinograd47 added a comment to D94417: [ADT][Support] Fix C4146 error from MSVC.

@dblaikie I'm not sure if I have commit access. But after rebase CI shows unit tests failures, I need to investigate them prior to merging.

Jan 13 2021, 11:48 PM · Restricted Project
vinograd47 added reviewers for D94598: [mlir] Fix cross-compilation (Linalg ODS gen): mehdi_amini, ftynse.
Jan 13 2021, 7:00 AM · Restricted Project
vinograd47 requested review of D94598: [mlir] Fix cross-compilation (Linalg ODS gen).
Jan 13 2021, 6:59 AM · Restricted Project
vinograd47 updated the diff for D94417: [ADT][Support] Fix C4146 error from MSVC.

Rebased

Jan 13 2021, 5:52 AM · Restricted Project
vinograd47 updated the diff for D94417: [ADT][Support] Fix C4146 error from MSVC.

Update the revision using Arcanist tool

Jan 13 2021, 1:10 AM · Restricted Project

Jan 12 2021

vinograd47 requested review of D94496: [mlir][CAPI] Fix inline function declaration.
Jan 12 2021, 7:38 AM · Restricted Project
vinograd47 updated the diff for D94417: [ADT][Support] Fix C4146 error from MSVC.

Reworked the patch. Fixed the warning instead of disabling it.

Jan 12 2021, 7:32 AM · Restricted Project
vinograd47 added a comment to D94407: [mlir] Fix for LIT tests.

I believe I don't have commit rights to LLVM repository. Could someone commit this change to main repository?

Jan 12 2021, 5:41 AM · Restricted Project

Jan 11 2021

vinograd47 requested review of D94417: [ADT][Support] Fix C4146 error from MSVC.
Jan 11 2021, 7:24 AM · Restricted Project
vinograd47 requested review of D94407: [mlir] Fix for LIT tests.
Jan 11 2021, 5:31 AM · Restricted Project

Nov 13 2020

vinograd47 added a comment to D90675: [MLIR] Added documentation and manual to use bufferization features..

Hello! It looks like this documentation is a bit outdated. For example, setResultConversionKind method was removed and replaced with separate pass (see https://github.com/llvm/llvm-project/commit/f7bc56826616814a656866fd50e90a35a8e461eb). Is there any plans to update this documentation?

Nov 13 2020, 12:23 AM · Restricted Project