Page MenuHomePhabricator

stephenneuendorffer (Stephen Neuendorffer)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 25 2019, 11:07 AM (56 w, 3 d)

Recent Activity

Mon, Nov 9

stephenneuendorffer added a comment to D90988: [MLIR] Flag no-terminator error on the last operation of non-empty blocks.

This still seems confusing, since the operation itself may have a region with only one block. Maybe we could show a range of line numbers from the first and last instructions in the block?

Mon, Nov 9, 9:48 AM · Restricted Project

Mon, Oct 26

stephenneuendorffer committed rG745c1671b16a: [mlir] Document 'ParentOneOf' with the HasParent trait (authored by stephenneuendorffer).
[mlir] Document 'ParentOneOf' with the HasParent trait
Mon, Oct 26, 3:56 PM
stephenneuendorffer closed D90197: [mlir] Document 'ParentOneOf' with the HasParent trait.
Mon, Oct 26, 3:56 PM · Restricted Project
stephenneuendorffer requested review of D90197: [mlir] Document 'ParentOneOf' with the HasParent trait.
Mon, Oct 26, 3:53 PM · Restricted Project

Oct 12 2020

stephenneuendorffer added inline comments to D89167: [mlir] Make Python bindings installable..
Oct 12 2020, 11:03 AM · Restricted Project

Oct 9 2020

stephenneuendorffer added inline comments to D89060: [mlir] Add missing dependencies.
Oct 9 2020, 9:11 PM · Restricted Project

Oct 8 2020

stephenneuendorffer updated the diff for D89060: [mlir] Add missing dependencies.
Oct 8 2020, 2:01 PM · Restricted Project
stephenneuendorffer added inline comments to D89060: [mlir] Add missing dependencies.
Oct 8 2020, 1:54 PM · Restricted Project
stephenneuendorffer added a reviewer for D89060: [mlir] Add missing dependencies: pawelo12345678.
Oct 8 2020, 11:58 AM · Restricted Project
stephenneuendorffer requested review of D89060: [mlir] Add missing dependencies.
Oct 8 2020, 11:55 AM · Restricted Project
stephenneuendorffer accepted D88846: [mlir] Improve LLVM shlib support.

Thanks for this!

Oct 8 2020, 10:54 AM · Restricted Project
stephenneuendorffer added a comment to D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects.

Does further work on this one have a potential to fix following issues while building MLIR?:
It occurs on every build since June/July. I guess it's because I'm using plain cmake, not ninja.

Oct 8 2020, 7:52 AM · Restricted Project, Restricted Project

Oct 5 2020

stephenneuendorffer accepted D88809: [MLIR] Add a foldTrait() mechanism to allow traits to define folding and test it with an Involution trait.
Oct 5 2020, 10:22 AM · Restricted Project

Oct 4 2020

stephenneuendorffer added a reverting change for rGe9b87f43bde8: [RFC] Factor out repetitive cmake patterns for llvm-style projects: rGb0dce6b37f15: Revert "[RFC] Factor out repetitive cmake patterns for llvm-style projects".
Oct 4 2020, 3:25 PM
stephenneuendorffer committed rGb0dce6b37f15: Revert "[RFC] Factor out repetitive cmake patterns for llvm-style projects" (authored by stephenneuendorffer).
Revert "[RFC] Factor out repetitive cmake patterns for llvm-style projects"
Oct 4 2020, 3:25 PM
stephenneuendorffer added a reverting change for D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects: rGb0dce6b37f15: Revert "[RFC] Factor out repetitive cmake patterns for llvm-style projects".
Oct 4 2020, 3:25 PM · Restricted Project, Restricted Project
stephenneuendorffer added a comment to D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects.

Thanks Petr. Can you point to some example projects where some of these
targets are harmful? Personally I'm willing to accept that some of the
mechanisms here might not be used by all projects in exchange for
simplification and ease of use.

Oct 4 2020, 2:56 PM · Restricted Project, Restricted Project

Oct 3 2020

stephenneuendorffer committed rGe9b87f43bde8: [RFC] Factor out repetitive cmake patterns for llvm-style projects (authored by stephenneuendorffer).
[RFC] Factor out repetitive cmake patterns for llvm-style projects
Oct 3 2020, 5:51 PM
stephenneuendorffer closed D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects.
Oct 3 2020, 5:51 PM · Restricted Project, Restricted Project
stephenneuendorffer updated the diff for D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects.
Oct 3 2020, 5:41 PM · Restricted Project, Restricted Project

Oct 2 2020

stephenneuendorffer added a comment to D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects.

Anyone have any concerns with this patch landing? I'd be particularly interested if there are opinions about better ways to structure llvm/cmake/modules/LLVMProjectOptions.cmake or llvm/cmake/modules/LLVMProjectTargets.cmake

Oct 2 2020, 11:27 AM · Restricted Project, Restricted Project
stephenneuendorffer committed rG34d12c15f7d8: [MLIR] Better message for FuncOp type mismatch (authored by stephenneuendorffer).
[MLIR] Better message for FuncOp type mismatch
Oct 2 2020, 9:32 AM
stephenneuendorffer closed D88318: [MLIR] Better message for FuncOp type mismatch.
Oct 2 2020, 9:32 AM · Restricted Project

Oct 1 2020

stephenneuendorffer committed rG47df8c57e4ed: [MLIR] Updates around MemRef Normalization (authored by stephenneuendorffer).
[MLIR] Updates around MemRef Normalization
Oct 1 2020, 9:24 PM
stephenneuendorffer closed D88532: [MLIR] Updates around MemRef Normalization.
Oct 1 2020, 9:24 PM · Restricted Project
stephenneuendorffer updated the diff for D88532: [MLIR] Updates around MemRef Normalization.
Oct 1 2020, 8:42 PM · Restricted Project
stephenneuendorffer updated the diff for D88532: [MLIR] Updates around MemRef Normalization.
Oct 1 2020, 11:16 AM · Restricted Project
stephenneuendorffer added a comment to D88532: [MLIR] Updates around MemRef Normalization.

Thanks for the feedback.

Oct 1 2020, 11:14 AM · Restricted Project

Sep 29 2020

stephenneuendorffer requested review of D88532: [MLIR] Updates around MemRef Normalization.
Sep 29 2020, 11:51 PM · Restricted Project

Sep 28 2020

stephenneuendorffer added a comment to D88343: Add a safeguard when creating a MLIR operation with a null/invalid Type.

I dig it. Definitely not a case where the runtime overhead would be
desirable in a release build, and a something that should be easily caught
by development testing.

Sep 28 2020, 9:17 PM · Restricted Project
stephenneuendorffer added a comment to D88343: Add a safeguard when creating a MLIR operation with a null/invalid Type.

The difference I see is that assets rarely have a useful message, because
they can't refer to the specific values they are comparing. The other
error reporting mechanisms make this possible. Or maybe it's the other way
around: people who think about nice error messages rarely use assert
because you can't create one and so use report fatal error instead. :)

Sep 28 2020, 8:46 PM · Restricted Project
stephenneuendorffer added a comment to D88343: Add a safeguard when creating a MLIR operation with a null/invalid Type.

I think there's a little bit of grey area here. What is 'my code' for
instance? In the case of IR invariants, I think there are two questions:

  1. should there be a check? and 2) if there is a check, what form should it

take? In this case, I think that it makes sense for this kind of
verification to be essentially delegated and centralized in the verifier:
Although one *could* pass invalid IR to the verifier, in most usage, the
verifier is usually coupled together with the execution of passes.
However, verifier checks are not asserts, since they are not checking a
local invariant property of the code, but are checking a property which
should be guaraunteed by some other piece of code.

Sep 28 2020, 6:14 PM · Restricted Project
stephenneuendorffer updated subscribers of D88343: Add a safeguard when creating a MLIR operation with a null/invalid Type.

My rule of thumb is to use assert to check properties that should hold
based on local code postconditions (i.e. 'my' code),
and to use report_fatal_error to report failures in assumptions about what
other components produce (i.e. 'someone else's code').

Sep 28 2020, 4:17 PM · Restricted Project
stephenneuendorffer added a comment to D88343: Add a safeguard when creating a MLIR operation with a null/invalid Type.

My rule of thumb is to use assert to check properties that should hold
based on local code postconditions (i.e. 'my' code),
and to use report_fatal_error to report failures in assumptions about what
other components produce (i.e. 'someone else's code').

Sep 28 2020, 4:17 PM · Restricted Project

Sep 25 2020

stephenneuendorffer closed D85987: [examples][cmake] build fix for examples with BUILD_SHARED_LIBS=on.
Sep 25 2020, 4:31 PM · Restricted Project
stephenneuendorffer added a comment to D88318: [MLIR] Better message for FuncOp type mismatch.

I'll land this. @jurahul are you able to look at the refactoring part?

Sep 25 2020, 2:47 PM · Restricted Project
stephenneuendorffer updated the diff for D88318: [MLIR] Better message for FuncOp type mismatch.
Sep 25 2020, 2:46 PM · Restricted Project
stephenneuendorffer added a comment to D88318: [MLIR] Better message for FuncOp type mismatch.

Should we do the same for result types as well?

Sep 25 2020, 2:15 PM · Restricted Project
stephenneuendorffer updated the diff for D88318: [MLIR] Better message for FuncOp type mismatch.
Sep 25 2020, 1:58 PM · Restricted Project
stephenneuendorffer requested review of D88318: [MLIR] Better message for FuncOp type mismatch.
Sep 25 2020, 9:29 AM · Restricted Project

Sep 24 2020

stephenneuendorffer added inline comments to D88251: [MLIR] Move TestDialect to ::test namespace.
Sep 24 2020, 9:24 PM · Restricted Project
stephenneuendorffer published D88267: Common code preparation for tblgen-types patch for review.

Seems generally reasonable to me.

Sep 24 2020, 3:50 PM · Restricted Project, Restricted Project
stephenneuendorffer requested review of D88251: [MLIR] Move TestDialect to ::test namespace.
Sep 24 2020, 11:54 AM · Restricted Project

Sep 22 2020

stephenneuendorffer added inline comments to D85464: [MLIR] [CMake] Support building MLIR standalone.
Sep 22 2020, 3:06 PM · Restricted Project

Sep 21 2020

stephenneuendorffer abandoned D88053: [MLIR] add support for dialect loading in mlir-translate.
Sep 21 2020, 5:08 PM · Restricted Project
stephenneuendorffer added a comment to D88053: [MLIR] add support for dialect loading in mlir-translate.

Hmm.. I see.. That didn't work though.

Sep 21 2020, 4:48 PM · Restricted Project
stephenneuendorffer added a comment to D88053: [MLIR] add support for dialect loading in mlir-translate.
Sep 21 2020, 4:47 PM · Restricted Project
stephenneuendorffer requested review of D88053: [MLIR] add support for dialect loading in mlir-translate.
Sep 21 2020, 3:50 PM · Restricted Project
stephenneuendorffer committed rG3f5031f143b6: [mlir] Add missing space in debug message (authored by stephenneuendorffer).
[mlir] Add missing space in debug message
Sep 21 2020, 1:02 PM

Sep 6 2020

stephenneuendorffer accepted D87221: Add a doc/tutorial on traversing the IR.

Love it. Thanks for adding this!

Sep 6 2020, 11:22 PM · Restricted Project

Aug 19 2020

stephenneuendorffer accepted D86219: [llvm-zorg] Flang and MLIR PowerPC buildbot; removed double quoting.
Aug 19 2020, 9:56 AM

Aug 14 2020

stephenneuendorffer committed rG65049f9b7934: [examples][cmake] build fix for examples with BUILD_SHARED_LIBS=on (authored by stephenneuendorffer).
[examples][cmake] build fix for examples with BUILD_SHARED_LIBS=on
Aug 14 2020, 11:40 AM
stephenneuendorffer closed D85987: [examples][cmake] build fix for examples with BUILD_SHARED_LIBS=on.
Aug 14 2020, 11:40 AM · Restricted Project
stephenneuendorffer committed rG6ce8e4f46b7a: [mlir] build fix for gcc-5 (authored by stephenneuendorffer).
[mlir] build fix for gcc-5
Aug 14 2020, 11:40 AM
stephenneuendorffer closed D85986: [mlir] build fix for gcc-5.
Aug 14 2020, 11:40 AM · Restricted Project
stephenneuendorffer committed rG324ae458df7e: [mlir] Make mlir_check_link_libraries() work with interface libraries (authored by marbre).
[mlir] Make mlir_check_link_libraries() work with interface libraries
Aug 14 2020, 11:39 AM
stephenneuendorffer closed D85957: [mlir] Make mlir_check_link_libraries() work with interface libraries.
Aug 14 2020, 11:39 AM · Restricted Project
stephenneuendorffer requested review of D85987: [examples][cmake] build fix for examples with BUILD_SHARED_LIBS=on.
Aug 14 2020, 11:38 AM · Restricted Project
stephenneuendorffer requested review of D85986: [mlir] build fix for gcc-5.
Aug 14 2020, 11:27 AM · Restricted Project
stephenneuendorffer accepted D85957: [mlir] Make mlir_check_link_libraries() work with interface libraries.
Aug 14 2020, 10:51 AM · Restricted Project

Aug 7 2020

stephenneuendorffer accepted D84579: [mlir][PDL] Add a PDL Interpreter Dialect.
Aug 7 2020, 10:48 PM · Restricted Project
stephenneuendorffer accepted D84578: [mlir] Add a new "Pattern Descriptor Language" (PDL) dialect..
Aug 7 2020, 10:40 PM · Restricted Project

Aug 6 2020

stephenneuendorffer added a reviewer for D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects: mgorny.
Aug 6 2020, 12:56 PM · Restricted Project, Restricted Project
stephenneuendorffer added inline comments to D85464: [MLIR] [CMake] Support building MLIR standalone.
Aug 6 2020, 12:55 PM · Restricted Project

Aug 4 2020

stephenneuendorffer added inline comments to D85167: [mlir][DialectConversion] Update the documentation for dialect conversion.
Aug 4 2020, 11:57 AM · Restricted Project

Aug 3 2020

stephenneuendorffer added a comment to D85167: [mlir][DialectConversion] Update the documentation for dialect conversion.

One thing I think is missing from this when and if failed type conversions result in failed patterns. I was debugging a case recently where a type conversion failed, but it wasn't obvious why this happened, and it was not reported separately, only as part of a failing pattern.

Aug 3 2020, 10:25 PM · Restricted Project
stephenneuendorffer accepted D85060: [MLIR][TableGen] Fix ambiguous build methods when inferring result types..

I'm happy with filing an issue about it.

Aug 3 2020, 11:40 AM · Restricted Project
stephenneuendorffer updated the diff for D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects.
Aug 3 2020, 11:24 AM · Restricted Project, Restricted Project
stephenneuendorffer added inline comments to D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects.
Aug 3 2020, 11:17 AM · Restricted Project, Restricted Project
stephenneuendorffer added inline comments to D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects.
Aug 3 2020, 10:57 AM · Restricted Project, Restricted Project
stephenneuendorffer added a comment to D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects.

Something you don't make very explicit in the description of this patch is that beyond a "refactoring" this is also changing the behavior by *duplicating* the options for each subproject.
For example building with -DLLVM_INCLUDE_EXAMPLES won't be enough to include the examples in MLIR, the user must also provide -DMLIR_INCLUDE_EXAMPLES. Same for every other options.

I can see how this provide more flexibility to the user configuring the build, but this flexibility comes also with a more complex surface. For example when building LLVM+MLIR, passing -DLLVM_INSTALL_TOOLCHAIN_ONLY=ON isn't enough and you need also -DMLIR_INSTALL_TOOLCHAIN_ONLY=ON.

Aug 3 2020, 10:55 AM · Restricted Project, Restricted Project
stephenneuendorffer added a comment to D85060: [MLIR][TableGen] Fix ambiguous build methods when inferring result types..

Seems like this will prevent the collision in the short term, but this solution doesn't seem like it will scale as builders get more complex. I'm not opposed to a special case here, but I'd feel more comfortable if there was a more general structure in place to prevent this from scaling to lots of special cases.

Aug 3 2020, 10:40 AM · Restricted Project
stephenneuendorffer added reviewers for D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects: silvas, stellaraccident, mehdi_amini.
Aug 3 2020, 9:59 AM · Restricted Project, Restricted Project
stephenneuendorffer requested review of D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects.
Aug 3 2020, 9:46 AM · Restricted Project, Restricted Project

Jul 27 2020

stephenneuendorffer added a comment to D84691: [CMake] Move find_package(ZLIB) to LLVMConfig.

Perfect! Thanks!

Jul 27 2020, 5:17 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 25 2020

stephenneuendorffer added inline comments to D79219: [CMake] Simplify CMake handling for zlib.
Jul 25 2020, 9:22 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 17 2020

stephenneuendorffer added inline comments to D83924: [mlir] Add update_mlir_test_checks.py.
Jul 17 2020, 12:05 AM · Restricted Project

Jul 16 2020

stephenneuendorffer added a comment to D83924: [mlir] Add update_mlir_test_checks.py.

[Drive by] tests?

Jul 16 2020, 6:06 PM · Restricted Project
stephenneuendorffer added a comment to D83924: [mlir] Add update_mlir_test_checks.py.

There seems to be a lot of hardcoding in here related to func. Given that func is not even the only function in upstream MLIR, and that for several dialects(existing and upcoming) func isn't even used at all, what is the story for those users?

Jul 16 2020, 12:48 PM · Restricted Project
stephenneuendorffer added inline comments to D83924: [mlir] Add update_mlir_test_checks.py.
Jul 16 2020, 12:31 PM · Restricted Project
stephenneuendorffer added a comment to D83924: [mlir] Add update_mlir_test_checks.py.

It's kind of confusing that this is in llvm/utils while generate-test-checks.py is in mlir/utils. Is there a plan to reconcile this difference?

Jul 16 2020, 12:28 PM · Restricted Project
stephenneuendorffer added inline comments to D83924: [mlir] Add update_mlir_test_checks.py.
Jul 16 2020, 9:35 AM · Restricted Project

Jul 15 2020

stephenneuendorffer added reviewers for D83924: [mlir] Add update_mlir_test_checks.py: timshen, silvas, jdoerfert.
Jul 15 2020, 6:54 PM · Restricted Project
Herald added a project to D83924: [mlir] Add update_mlir_test_checks.py: Restricted Project.
Jul 15 2020, 6:50 PM · Restricted Project
stephenneuendorffer committed rG628288658c5b: [MLIR] Add RegionKindInterface (authored by stephenneuendorffer).
[MLIR] Add RegionKindInterface
Jul 15 2020, 2:32 PM
stephenneuendorffer closed D80358: [MLIR] Add RegionKindInterface.
Jul 15 2020, 2:32 PM · Restricted Project, Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Jul 15 2020, 12:40 PM · Restricted Project, Restricted Project
stephenneuendorffer added a comment to D80358: [MLIR] Add RegionKindInterface.

Quick question: how do we know in printed IR if something is a graph region or an SSA one?

Jul 15 2020, 12:40 PM · Restricted Project, Restricted Project

Jul 14 2020

stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Jul 14 2020, 3:20 PM · Restricted Project, Restricted Project
stephenneuendorffer added a comment to D80358: [MLIR] Add RegionKindInterface.

If there are no further comments, I'd like to commit this. @bondhugula @mehdi_amini Do you want to accept?

Jul 14 2020, 3:10 PM · Restricted Project, Restricted Project
stephenneuendorffer added a comment to D83599: [MLIR] Add argument related API to Region.

Looking at https://reviews.llvm.org/D80358, I don't see the definition of region arguments being entry block arguments changing.

Yeah I sync'd with Stephen today and there is no concern.

Jul 14 2020, 10:11 AM · Restricted Project

Jul 13 2020

stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Jul 13 2020, 6:30 PM · Restricted Project, Restricted Project
stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Jul 13 2020, 6:13 PM · Restricted Project, Restricted Project

Jul 11 2020

stephenneuendorffer committed rGd8c35031a39e: [examples] fix ExceptionDemo (authored by stephenneuendorffer).
[examples] fix ExceptionDemo
Jul 11 2020, 12:40 PM
stephenneuendorffer closed D83628: [examples] fix ExceptionDemo.
Jul 11 2020, 12:39 PM · Restricted Project
Herald added a project to D83628: [examples] fix ExceptionDemo: Restricted Project.
Jul 11 2020, 12:38 PM · Restricted Project

Jul 10 2020

stephenneuendorffer accepted D83604: [mlir][ODS] Add support for specifying the namespace of an interface..
Jul 10 2020, 9:30 PM · Restricted Project

Jul 8 2020

stephenneuendorffer accepted D83279: Initial boiler-plate for python bindings..
Jul 8 2020, 5:30 PM · Restricted Project
stephenneuendorffer accepted D83422: Create TestReducer pass.
Jul 8 2020, 2:32 PM · Restricted Project

Jul 6 2020

stephenneuendorffer updated the diff for D80358: [MLIR] Add RegionKindInterface.
Jul 6 2020, 11:27 PM · Restricted Project, Restricted Project