Page MenuHomePhabricator

dcaballe (Diego Caballero)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 16 2016, 11:47 AM (203 w, 4 d)

Recent Activity

Yesterday

dcaballe added inline comments to D84998: [MLIR] Add affine.parallel canonicalizations and folding.
Mon, Aug 10, 2:07 PM · Restricted Project

Thu, Aug 6

dcaballe updated subscribers of D84998: [MLIR] Add affine.parallel canonicalizations and folding.
Thu, Aug 6, 11:56 AM · Restricted Project

Wed, Aug 5

dcaballe requested changes to D84998: [MLIR] Add affine.parallel canonicalizations and folding.

Thanks Frank! It looks good to me. Just a few minor comments

Wed, Aug 5, 4:12 PM · Restricted Project

Tue, Aug 4

dcaballe committed rG3bfbc5df87cb: [MLIR][Affine] Fix createPrivateMemRef in affine fusion (authored by dcaballe).
[MLIR][Affine] Fix createPrivateMemRef in affine fusion
Tue, Aug 4, 12:34 PM
dcaballe closed D85177: [MLIR][Affine] Fix createPrivateMemRef in affine fusion.
Tue, Aug 4, 12:34 PM · Restricted Project
dcaballe added inline comments to D85177: [MLIR][Affine] Fix createPrivateMemRef in affine fusion.
Tue, Aug 4, 11:39 AM · Restricted Project
dcaballe added inline comments to D85177: [MLIR][Affine] Fix createPrivateMemRef in affine fusion.
Tue, Aug 4, 7:50 AM · Restricted Project

Mon, Aug 3

dcaballe requested review of D85177: [MLIR][Affine] Fix createPrivateMemRef in affine fusion.
Mon, Aug 3, 7:27 PM · Restricted Project
dcaballe added a comment to D84998: [MLIR] Add affine.parallel canonicalizations and folding.

Thanks for the patch! Just a high-level comment for now. It looks good overall.

Mon, Aug 3, 11:11 AM · Restricted Project

Tue, Jul 28

dcaballe committed rG834133c950fc: [MLIR] Vector store to load forwarding (authored by anandkodnani).
[MLIR] Vector store to load forwarding
Tue, Jul 28, 11:41 AM
dcaballe closed D84302: [MLIR] Vector store to load forwarding.
Tue, Jul 28, 11:41 AM · Restricted Project

Mon, Jul 27

dcaballe accepted D84302: [MLIR] Vector store to load forwarding.
Mon, Jul 27, 10:32 PM · Restricted Project

Thu, Jul 23

dcaballe added inline comments to D84302: [MLIR] Vector store to load forwarding.
Thu, Jul 23, 11:08 AM · Restricted Project

Wed, Jul 22

dcaballe committed rG3fff5acd8f5f: [mlir][VectorOps] Expose SuperVectorizer as a utility (authored by dcaballe).
[mlir][VectorOps] Expose SuperVectorizer as a utility
Wed, Jul 22, 2:36 PM
dcaballe closed D84289: [mlir][VectorOps] Expose SuperVectorizer as a utility.
Wed, Jul 22, 2:36 PM · Restricted Project
dcaballe added reviewers for D84302: [MLIR] Vector store to load forwarding: bondhugula, ftynse.
Wed, Jul 22, 9:24 AM · Restricted Project

Tue, Jul 21

Herald added a project to D84289: [mlir][VectorOps] Expose SuperVectorizer as a utility: Restricted Project.
Tue, Jul 21, 6:46 PM · Restricted Project
dcaballe committed rGf8b72fba868b: [MLIR][EDSC] Add fptrunc and fpext to EDSC (authored by dcaballe).
[MLIR][EDSC] Add fptrunc and fpext to EDSC
Tue, Jul 21, 9:06 AM
dcaballe closed D84216: [MLIR][EDSC] Add fptrunc and fpext to EDSC.
Tue, Jul 21, 9:05 AM · Restricted Project

Mon, Jul 20

Herald added a project to D84216: [MLIR][EDSC] Add fptrunc and fpext to EDSC: Restricted Project.
Mon, Jul 20, 9:16 PM · Restricted Project

Jun 26 2020

dcaballe added a comment to D82600: IR changes to add yield semantics for affine.if and affine.parallel, additional affine.parallel canonicalization.

Thanks Jeremy! Some minor comments.

Jun 26 2020, 3:39 PM · Restricted Project
dcaballe added a reviewer for D82600: IR changes to add yield semantics for affine.if and affine.parallel, additional affine.parallel canonicalization: ftynse.
Jun 26 2020, 2:41 PM · Restricted Project

Jun 25 2020

dcaballe committed rGa72887831a22: [mlir][EDSC] Add divis and diviu and vector.extractelement (authored by dcaballe).
[mlir][EDSC] Add divis and diviu and vector.extractelement
Jun 25 2020, 8:35 AM
dcaballe closed D82515: [mlir][EDSL] Add divis and diviu and vector.extractelement.
Jun 25 2020, 8:35 AM · Restricted Project

Jun 24 2020

dcaballe created D82515: [mlir][EDSL] Add divis and diviu and vector.extractelement.
Jun 24 2020, 5:56 PM · Restricted Project

Jun 23 2020

dcaballe accepted D82409: [MLIR] Fix affine loop fusion private memref alloc.

Thanks for fixing this! LGTM

Jun 23 2020, 4:11 PM · Restricted Project

Jun 15 2020

dcaballe accepted D81792: [MLIR] Fix memref region compute for 0-d memref accesses.
Jun 15 2020, 9:13 AM · Restricted Project

Jun 11 2020

dcaballe committed rG2e7a0845913e: [mlir][Affine] Revisit fusion candidates after successful fusion (authored by dcaballe).
[mlir][Affine] Revisit fusion candidates after successful fusion
Jun 11 2020, 3:28 PM
dcaballe closed D81609: [mlir][Affine] Revisit fusion candidates after successful fusion.
Jun 11 2020, 3:27 PM · Restricted Project

Jun 10 2020

dcaballe created D81609: [mlir][Affine] Revisit fusion candidates after successful fusion.
Jun 10 2020, 12:47 PM · Restricted Project

Jun 8 2020

dcaballe added a comment to D80971: [mlir][Affine] Enable fusion of loops with vector loads/stores.

Thanks Uday! Good point. I haven't looked too much into the slice computation but if you can send me some pointers and some examples on how the regions should be computed I could have a look. Thanks!

Jun 8 2020, 11:36 AM · Restricted Project

Jun 5 2020

dcaballe committed rG7d59f49bdadd: [mlir] Fix representation of BF16 constants (authored by dcaballe).
[mlir] Fix representation of BF16 constants
Jun 5 2020, 5:55 PM
dcaballe committed rGa2588948febc: Fix convertBFloatAPFloatToAPInt for NaN/Inf values (authored by dcaballe).
Fix convertBFloatAPFloatToAPInt for NaN/Inf values
Jun 5 2020, 5:55 PM
dcaballe closed D81218: [mlir] Fix representation of BF16 constants.
Jun 5 2020, 5:55 PM · Restricted Project
dcaballe closed D81302: Fix convertBFloatAPFloatToAPInt for NaN/Inf values.
Jun 5 2020, 5:54 PM · Restricted Project
dcaballe added a comment to D81218: [mlir] Fix representation of BF16 constants.

If no more comments, I'll land this after https://reviews.llvm.org/D81302

Jun 5 2020, 2:02 PM · Restricted Project
dcaballe created D81302: Fix convertBFloatAPFloatToAPInt for NaN/Inf values.
Jun 5 2020, 1:30 PM · Restricted Project

Jun 4 2020

dcaballe added inline comments to D81218: [mlir] Fix representation of BF16 constants.
Jun 4 2020, 8:56 PM · Restricted Project
dcaballe created D81218: [mlir] Fix representation of BF16 constants.
Jun 4 2020, 8:23 PM · Restricted Project
dcaballe committed rG5c990d699455: [mlir] Add support for bf16 to StandardToLLVM conversion (authored by dcaballe).
[mlir] Add support for bf16 to StandardToLLVM conversion
Jun 4 2020, 2:58 PM
dcaballe closed D81127: [mlir] Add support for bf16 to StandardToLLVM conversion.
Jun 4 2020, 2:57 PM · Restricted Project

Jun 3 2020

dcaballe created D81127: [mlir] Add support for bf16 to StandardToLLVM conversion.
Jun 3 2020, 6:12 PM · Restricted Project

Jun 2 2020

dcaballe committed rG8a418e5f8e89: [mlir][Affine] Enable fusion of loops with vector loads/stores (authored by dcaballe).
[mlir][Affine] Enable fusion of loops with vector loads/stores
Jun 2 2020, 3:56 PM
dcaballe closed D80971: [mlir][Affine] Enable fusion of loops with vector loads/stores.
Jun 2 2020, 3:56 PM · Restricted Project
dcaballe committed rGb78b98491ada: Update 'git push' command in GettingStarted guide (authored by dcaballe).
Update 'git push' command in GettingStarted guide
Jun 2 2020, 11:32 AM
dcaballe closed D79964: Update 'git push' command in GettingStarted guide.
Jun 2 2020, 11:32 AM · Restricted Project

Jun 1 2020

dcaballe created D80971: [mlir][Affine] Enable fusion of loops with vector loads/stores.
Jun 1 2020, 6:58 PM · Restricted Project

May 29 2020

dcaballe committed rGe75325cfc397: [mlir][Affine] Minor clean-up of D79829 (authored by dcaballe).
[mlir][Affine] Minor clean-up of D79829
May 29 2020, 2:49 PM
dcaballe closed D80814: [mlir][Affine] Minor clean-up of D79829.
May 29 2020, 2:49 PM · Restricted Project
dcaballe added a comment to D79964: Update 'git push' command in GettingStarted guide.

Ping :)

May 29 2020, 2:49 PM · Restricted Project
dcaballe created D80814: [mlir][Affine] Minor clean-up of D79829.
May 29 2020, 9:45 AM · Restricted Project

May 27 2020

dcaballe added a comment to D79829: [mlir][Affine] Introduce affine memory interfaces.

Thanks @rriddle. I'll take care of this.

May 27 2020, 2:09 PM · Restricted Project
dcaballe accepted D80419: [mlir] [VectorOps] Add 'vector.flat_transpose' operation.

Thanks, LGTM. You can rename both intrinsics in a separate commit.

May 27 2020, 9:11 AM · Restricted Project

May 22 2020

dcaballe requested changes to D80419: [mlir] [VectorOps] Add 'vector.flat_transpose' operation.

Thanks! It looks good to me in general. I just added some comments about making it a bit more generic.
For my understanding, how do we plan to lower to these vector matrix multiply and transpose? From a vector contraction?

May 22 2020, 9:38 AM · Restricted Project

May 20 2020

dcaballe updated the diff for D79964: Update 'git push' command in GettingStarted guide.

It sounds good, thanks.
Replacing 'origin' with 'https://github.com/llvm/llvm-project.git' in git pull and push commands.

May 20 2020, 10:22 AM · Restricted Project

May 19 2020

dcaballe committed rGa45fb1942fc5: [mlir][Affine] Introduce affine memory interfaces (authored by dcaballe).
[mlir][Affine] Introduce affine memory interfaces
May 19 2020, 6:11 PM
dcaballe closed D79829: [mlir][Affine] Introduce affine memory interfaces.
May 19 2020, 6:11 PM · Restricted Project
dcaballe updated the diff for D79964: Update 'git push' command in GettingStarted guide.

Changing to git push origin HEAD:master

May 19 2020, 6:11 PM · Restricted Project
dcaballe updated the diff for D79829: [mlir][Affine] Introduce affine memory interfaces.

Adding Alex's changes. Thanks for the patch!
I'll proceed with the commit if no more comments.

May 19 2020, 10:55 AM · Restricted Project
dcaballe added a comment to D79829: [mlir][Affine] Introduce affine memory interfaces.

Thank you so much for such a detailed explanation! It's really good! I think we should move this to somewhere in the documentation because it's really elucidating!

May 19 2020, 10:55 AM · Restricted Project

May 18 2020

dcaballe added a comment to D80092: [mlir][Vector] Make minor identity permutation map optional in transfer op printing and parsing.

I was thinking about doing the same! Thanks for doing this, Nicolas!

May 18 2020, 3:12 PM · Restricted Project
dcaballe added a comment to D80098: [mlir][Vector] Add an optional "masked" boolean array attribute to vector transfer operations.

Thanks, Nicolas! It looks good! Just a minor comment below.
This patch introduces an attribute to set if a vector load/store is masked but how is that mask being computed/passed to the vector load/store?
IIUC, the current implementation assumes that there is no divergent control flow and therefore the loop exit condition can be used as mask for all the vector loads/stores, is that correct?

May 18 2020, 2:05 PM · Restricted Project

May 14 2020

dcaballe added inline comments to D79964: Update 'git push' command in GettingStarted guide.
May 14 2020, 11:22 PM · Restricted Project
dcaballe added a comment to D79829: [mlir][Affine] Introduce affine memory interfaces.

I tried to change all the interface methods to have a default implementation but I'm hitting some problems. After reading again the documentation about interfaces, it's not clear to me what is the difference between providing a methodBody or a defaultImplementation. I had to dig into the generated code to have a bit better understanding but still, I couldn't make it work. I uploaded the patch with both approaches: methods in AffineWriteOpInterface has a methodBody, methods in AffineReadOpInterface has a defaultImplementation.

May 14 2020, 6:31 PM · Restricted Project
dcaballe updated the diff for D79829: [mlir][Affine] Introduce affine memory interfaces.

Provide a default implementation for interface methods (not working, see next message)

May 14 2020, 6:31 PM · Restricted Project
dcaballe created D79964: Update 'git push' command in GettingStarted guide.
May 14 2020, 2:08 PM · Restricted Project
dcaballe committed rGbc5565f9ea7a: [mlir][Affine] Introduce affine.vector_load and affine.vector_store (authored by dcaballe).
[mlir][Affine] Introduce affine.vector_load and affine.vector_store
May 14 2020, 1:37 PM
dcaballe closed D79658: [mlir][Affine] Introduce affine.vector_load and affine.vector_store.
May 14 2020, 1:37 PM · Restricted Project

May 13 2020

dcaballe updated the diff for D79658: [mlir][Affine] Introduce affine.vector_load and affine.vector_store.

Enabled multi-dim vector loads/stores (minor fixes)
Added tests and doc examples.

May 13 2020, 11:23 PM · Restricted Project
dcaballe updated the diff for D79829: [mlir][Affine] Introduce affine memory interfaces.

Addressing feedback.

May 13 2020, 7:07 PM · Restricted Project
dcaballe added a comment to D79829: [mlir][Affine] Introduce affine memory interfaces.

Thanks for the feedback!

May 13 2020, 7:07 PM · Restricted Project
dcaballe retitled D79829: [mlir][Affine] Introduce affine memory interfaces from [mlir][Affine][NFCI]: Introduce affine memory interfaces to [mlir][Affine]: Introduce affine memory interfaces.
May 13 2020, 6:34 PM · Restricted Project
dcaballe retitled D79829: [mlir][Affine] Introduce affine memory interfaces from [mlir][Affine]: Introduce affine memory interfaces to [mlir][Affine] Introduce affine memory interfaces.
May 13 2020, 6:34 PM · Restricted Project
dcaballe added a comment to D79658: [mlir][Affine] Introduce affine.vector_load and affine.vector_store.

This overall looks great. Please also update the commit title for vload/vstore -> vector_load/store. (since arc won't do it by itself as you know.)

May 13 2020, 4:57 PM · Restricted Project
dcaballe updated the diff for D79658: [mlir][Affine] Introduce affine.vector_load and affine.vector_store.

Addressing feedback.

  • Added specific verifiers for affine.vector_load and affine.vector_store.
  • Refactored affine.load and affine.store verifiers to avoid code duplication.
  • Added invalid tests.
May 13 2020, 4:57 PM · Restricted Project
dcaballe retitled D79658: [mlir][Affine] Introduce affine.vector_load and affine.vector_store from [mlir][Affine] Introduce affine.vload and affine.vstore to [mlir][Affine] Introduce affine.vector_load and affine.vector_store.
May 13 2020, 9:44 AM · Restricted Project

May 12 2020

dcaballe added a comment to D79658: [mlir][Affine] Introduce affine.vector_load and affine.vector_store.

Also: you did mention in the past that you were interested to look into gather/scatter load/store with some 2D native memory unit in mind, do you still plan to look into this later?

May 12 2020, 5:48 PM · Restricted Project
dcaballe created D79829: [mlir][Affine] Introduce affine memory interfaces.
May 12 2020, 5:15 PM · Restricted Project
dcaballe added inline comments to D79658: [mlir][Affine] Introduce affine.vector_load and affine.vector_store.
May 12 2020, 3:04 PM · Restricted Project
dcaballe added inline comments to D79658: [mlir][Affine] Introduce affine.vector_load and affine.vector_store.
May 12 2020, 1:59 PM · Restricted Project
dcaballe updated the diff for D79658: [mlir][Affine] Introduce affine.vector_load and affine.vector_store.

Addressing all the feedback. Thanks!

May 12 2020, 1:59 PM · Restricted Project
dcaballe updated the summary of D79658: [mlir][Affine] Introduce affine.vector_load and affine.vector_store.
May 12 2020, 11:48 AM · Restricted Project
dcaballe added a comment to D79658: [mlir][Affine] Introduce affine.vector_load and affine.vector_store.

What about affine.vector_store (or affine.vec_store)?

May 12 2020, 9:07 AM · Restricted Project

May 11 2020

dcaballe updated the diff for D79658: [mlir][Affine] Introduce affine.vector_load and affine.vector_store.

Addressing feedback. Thanks!

May 11 2020, 4:44 PM · Restricted Project
dcaballe added inline comments to D79658: [mlir][Affine] Introduce affine.vector_load and affine.vector_store.
May 11 2020, 4:44 PM · Restricted Project
dcaballe added inline comments to D79658: [mlir][Affine] Introduce affine.vector_load and affine.vector_store.
May 11 2020, 2:01 PM · Restricted Project
dcaballe added inline comments to D79658: [mlir][Affine] Introduce affine.vector_load and affine.vector_store.
May 11 2020, 11:18 AM · Restricted Project

May 8 2020

dcaballe added a comment to D79658: [mlir][Affine] Introduce affine.vector_load and affine.vector_store.

A few things I found along the road...

May 8 2020, 6:49 PM · Restricted Project
dcaballe created D79658: [mlir][Affine] Introduce affine.vector_load and affine.vector_store.
May 8 2020, 6:49 PM · Restricted Project

May 7 2020

dcaballe committed rGf5224d437eac: [LoopFusion] Remove unreachable blocks from DT and LI after fusion (authored by dcaballe).
[LoopFusion] Remove unreachable blocks from DT and LI after fusion
May 7 2020, 5:24 PM
dcaballe closed D78679: [LoopFusion] Fix LI after fusion of guarded loops.
May 7 2020, 5:24 PM · Restricted Project
dcaballe added a comment to D79547: [MLIR] Fix affine fusion bug/efficiency issue / enable more fusion.

LGTM, Thanks!

May 7 2020, 5:23 PM · Restricted Project
dcaballe added a comment to D78679: [LoopFusion] Fix LI after fusion of guarded loops.

One minor comment that I just noticed - can you please change the names of the test cases to use _ instead of - (to be consistent with the other tests in the directory)?
Aside from that, LGTM.

May 7 2020, 9:40 AM · Restricted Project

May 4 2020

dcaballe updated the diff for D78679: [LoopFusion] Fix LI after fusion of guarded loops.

Hi Kit. This should be it. Thanks for taking a look!

May 4 2020, 8:27 PM · Restricted Project

Apr 30 2020

dcaballe added a comment to D78679: [LoopFusion] Fix LI after fusion of guarded loops.

Ping :)

Apr 30 2020, 4:39 PM · Restricted Project

Apr 27 2020

dcaballe added reviewers for D78679: [LoopFusion] Fix LI after fusion of guarded loops: Meinersbur, Whitney.
Apr 27 2020, 2:34 PM · Restricted Project

Apr 22 2020

dcaballe created D78679: [LoopFusion] Fix LI after fusion of guarded loops.
Apr 22 2020, 3:48 PM · Restricted Project

Apr 14 2020

dcaballe committed rG2f8b4545f496: [mlir] Fix assert on signed integer type in EDSC (authored by adstraw).
[mlir] Fix assert on signed integer type in EDSC
Apr 14 2020, 4:21 PM
dcaballe closed D78144: [mlir] Fix assert on signed integer type in EDSC.
Apr 14 2020, 4:21 PM · Restricted Project
dcaballe updated subscribers of D78144: [mlir] Fix assert on signed integer type in EDSC.
Apr 14 2020, 1:30 PM · Restricted Project