# User Details

User Details

- User Since
- Aug 18 2017, 8:12 AM (191 w, 2 d)

# Tue, Apr 13

Tue, Apr 13

cota added a comment to D100344: [mlir] Use MCJIT to fix integration tests.

Tue, Apr 13, 1:15 PM · Restricted Project

cota requested review of D100407: [mlir] Use default lli JIT in Integration tests.

Tue, Apr 13, 12:43 PM · Restricted Project

# Mon, Apr 12

Mon, Apr 12

cota added inline comments to D99818: [mlir] X86Vector: Add AVX Rsqrt.

Mon, Apr 12, 6:51 PM · Restricted Project

cota updated the diff for D99818: [mlir] X86Vector: Add AVX Rsqrt.

- Use std.constant dense
- Mention https://bugs.llvm.org/show_bug.cgi?id=49906 in test-rsqrt.mlir

Mon, Apr 12, 6:51 PM · Restricted Project

cota added a comment to D100344: [mlir] Use MCJIT to fix integration tests.

Mon, Apr 12, 6:01 PM · Restricted Project

cota updated the diff for D100344: [mlir] Use MCJIT to fix integration tests.

Add TODO comments that refer to the reported bug.

Mon, Apr 12, 5:56 PM · Restricted Project

cota retitled D100344: [mlir] Use MCJIT to fix integration tests from [mlir] X86Vector: use MCJIT to fix integration tests to [mlir] Use MCJIT to fix integration tests.

Mon, Apr 12, 3:11 PM · Restricted Project

cota added a comment to D100344: [mlir] Use MCJIT to fix integration tests.

Mon, Apr 12, 3:09 PM · Restricted Project

cota updated the diff for D100344: [mlir] Use MCJIT to fix integration tests.

Fix AMX tests as well

Mon, Apr 12, 3:09 PM · Restricted Project

cota updated the diff for D99818: [mlir] X86Vector: Add AVX Rsqrt.

fix newline

Mon, Apr 12, 2:39 PM · Restricted Project

cota retitled D99818: [mlir] X86Vector: Add AVX Rsqrt from [mlir] Add rsqrt to AVX512 dialect to [mlir] X86Vector: Add AVX Rsqrt .

Mon, Apr 12, 2:33 PM · Restricted Project

cota updated the diff for D99818: [mlir] X86Vector: Add AVX Rsqrt.

Rebase on X86Vector

Mon, Apr 12, 2:32 PM · Restricted Project

cota requested review of D100344: [mlir] Use MCJIT to fix integration tests.

Mon, Apr 12, 2:24 PM · Restricted Project

cota added a comment to D100119: [mlir] Rename AVX512 dialect to X86Vector.

So far I only have immediate plans of adding avx.rsqrt to the dialect. I'd expect AVX, AVX512 and SSE ops to be added to this dialect in the future.

# Fri, Apr 9

Fri, Apr 9

cota added inline comments to D100119: [mlir] Rename AVX512 dialect to X86Vector.

cota updated the diff for D100119: [mlir] Rename AVX512 dialect to X86Vector.

Fix overly long comments

cota added a comment to D100119: [mlir] Rename AVX512 dialect to X86Vector.

cota updated the summary of D100119: [mlir] Rename AVX512 dialect to X86Vector.

# Thu, Apr 8

Thu, Apr 8

cota updated the diff for D100119: [mlir] Rename AVX512 dialect to X86Vector.

The previous push used a different diffbase than the original push,

which messed up the diff. Push a diff with the original diffbase now.

cota retitled D100119: [mlir] Rename AVX512 dialect to X86Vector from [mlir] Add X86Vector dialect to supersede the AVX512 dialect to [mlir] Rename AVX512 dialect to X86Vector.

cota updated the diff for D100119: [mlir] Rename AVX512 dialect to X86Vector.

- [mlir] Rename AVX512 dialect to X86Vector

cota added inline comments to D99818: [mlir] X86Vector: Add AVX Rsqrt.

Thu, Apr 8, 8:55 AM · Restricted Project

cota added a comment to D100119: [mlir] Rename AVX512 dialect to X86Vector.

Context: https://reviews.llvm.org/D99818

cota requested review of D100119: [mlir] Rename AVX512 dialect to X86Vector.

# Tue, Apr 6

Tue, Apr 6

cota added inline comments to D99818: [mlir] X86Vector: Add AVX Rsqrt.

Tue, Apr 6, 2:11 PM · Restricted Project

cota added inline comments to D99818: [mlir] X86Vector: Add AVX Rsqrt.

Tue, Apr 6, 12:10 PM · Restricted Project

cota updated the diff for D99818: [mlir] X86Vector: Add AVX Rsqrt.

Address some reviewer comments

Tue, Apr 6, 12:10 PM · Restricted Project

# Fri, Apr 2

Fri, Apr 2

cota updated subscribers of D99818: [mlir] X86Vector: Add AVX Rsqrt.

Fri, Apr 2, 2:55 PM · Restricted Project

cota requested review of D99818: [mlir] X86Vector: Add AVX Rsqrt.

Fri, Apr 2, 2:54 PM · Restricted Project

# Mar 16 2021

Mar 16 2021

Mar 16 2021, 7:17 AM · Restricted Project

# Mar 10 2021

Mar 10 2021

cota updated the diff for D98282: [mlir] Add polynomial approximation for math::Log2.

- Fix typo in comment.

Mar 10 2021, 10:11 AM · Restricted Project

cota added inline comments to D98282: [mlir] Add polynomial approximation for math::Log2.

Mar 10 2021, 10:09 AM · Restricted Project

cota updated the diff for D98282: [mlir] Add polynomial approximation for math::Log2.

- Test fixes as suggested by mehdi_amini.
- Log base class as suggested by ezhulenev.

Mar 10 2021, 10:09 AM · Restricted Project

# Mar 9 2021

Mar 9 2021

cota added inline comments to D98282: [mlir] Add polynomial approximation for math::Log2.

Mar 9 2021, 2:08 PM · Restricted Project

cota updated the diff for D98282: [mlir] Add polynomial approximation for math::Log2.

s/LOG_OP/Op/

Mar 9 2021, 2:06 PM · Restricted Project

cota updated the summary of D98282: [mlir] Add polynomial approximation for math::Log2.

Mar 9 2021, 12:25 PM · Restricted Project

cota updated the diff for D98282: [mlir] Add polynomial approximation for math::Log2.

Update D98282: [mlir] Add polynomial approximation for math::Log2

Mar 9 2021, 12:24 PM · Restricted Project

cota requested review of D98282: [mlir] Add polynomial approximation for math::Log2.

Mar 9 2021, 12:18 PM · Restricted Project

# Mar 9 2020

Mar 9 2020

cota added a comment to D75820: tsan_interface.h: make constants static.

I have no commit access -- please merge it, thanks!

# Mar 7 2020

Mar 7 2020