Page MenuHomePhabricator

nicolasvasilache (Nicolas Vasilache)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 2 2017, 2:24 AM (259 w, 13 h)

Recent Activity

Today

nicolasvasilache added inline comments to D117772: [mlir][memref] Add better support for identity layouts in memref.collapse_shape canonicalizer.
Thu, Jan 20, 4:35 AM · Restricted Project
nicolasvasilache accepted D117602: [mlir][Linalg] Avoid generating illegal operations during elementwise fusion..
Thu, Jan 20, 12:49 AM · Restricted Project

Yesterday

nicolasvasilache committed rGd492a7b2cac3: [mlir][Linalg] Add a useLinalgCopy option to Linalg bufferization. (authored by nicolasvasilache).
[mlir][Linalg] Add a useLinalgCopy option to Linalg bufferization.
Wed, Jan 19, 10:00 AM
nicolasvasilache closed D117696: [mlir][Linalg] Add a useLinalgCopy option to Linalg bufferization..
Wed, Jan 19, 10:00 AM · Restricted Project
nicolasvasilache accepted D117695: Bump pybind11 version for mlir-nvidia.
Wed, Jan 19, 9:54 AM
nicolasvasilache requested review of D117696: [mlir][Linalg] Add a useLinalgCopy option to Linalg bufferization..
Wed, Jan 19, 9:51 AM · Restricted Project
nicolasvasilache accepted D117641: [mlir][bufferization] Move one-shot bufferization to Bufferization dialect.
Wed, Jan 19, 12:22 AM · Restricted Project
nicolasvasilache accepted D117478: [mlir][linalg][bufferize][NFC] Move analysis-related code to Comprehensive Bufferize.
Wed, Jan 19, 12:21 AM · Restricted Project
nicolasvasilache accepted D117477: [mlir][linalg][bufferize] Split analysis-related code from BufferizationState/Options.

Please mark as NFC in the commit message.

Wed, Jan 19, 12:20 AM · Restricted Project
nicolasvasilache accepted D117476: [mlir][linalg][bufferize][NFC] Merge AllocationCallbacks into BufferizationOptions.
Wed, Jan 19, 12:18 AM · Restricted Project
nicolasvasilache accepted D116687: [mlir][linalg][bufferize] Generalize destination-passing style detection.
Wed, Jan 19, 12:16 AM · Restricted Project
nicolasvasilache accepted D117424: [mlir][linalg][bufferize] Support scf.execute_region bufferization.
Wed, Jan 19, 12:07 AM · Restricted Project

Tue, Jan 18

nicolasvasilache committed rGefdd4c169d30: [mlir][Linalg] NFC - Drop vectorization reliance on ConvolutionOpInterface (authored by nicolasvasilache).
[mlir][Linalg] NFC - Drop vectorization reliance on ConvolutionOpInterface
Tue, Jan 18, 1:31 AM
nicolasvasilache closed D117323: [mlir][Linalg] NFC - Drop vectorization reliance on ConvolutionOpInterface.
Tue, Jan 18, 1:31 AM · Restricted Project
nicolasvasilache committed rGcc0d208805c3: [mlir][Linalg] Drop deprecated convolution vectorization patterns (authored by nicolasvasilache).
[mlir][Linalg] Drop deprecated convolution vectorization patterns
Tue, Jan 18, 1:28 AM
nicolasvasilache closed D117326: [mlir][Linalg] Drop deprecated convolution vectorization patterns.
Tue, Jan 18, 1:27 AM · Restricted Project
nicolasvasilache added a comment to D117326: [mlir][Linalg] Drop deprecated convolution vectorization patterns.

https://buildkite.com/llvm-project/premerge-checks/builds/74313#bc3eefd3-52f4-4d4b-beed-0c2a170d22f5 now shows 1 unrelated failure:

Tue, Jan 18, 1:26 AM · Restricted Project
nicolasvasilache added a comment to D117323: [mlir][Linalg] NFC - Drop vectorization reliance on ConvolutionOpInterface.

https://buildkite.com/llvm-project/premerge-checks/builds/74313#bc3eefd3-52f4-4d4b-beed-0c2a170d22f5 now shows 1 unrelated failure:

Tue, Jan 18, 1:25 AM · Restricted Project
nicolasvasilache updated the diff for D117323: [mlir][Linalg] NFC - Drop vectorization reliance on ConvolutionOpInterface.

Rebase.

Tue, Jan 18, 12:56 AM · Restricted Project
nicolasvasilache updated the diff for D117326: [mlir][Linalg] Drop deprecated convolution vectorization patterns.

Drop old tests.

Tue, Jan 18, 12:49 AM · Restricted Project
nicolasvasilache updated the diff for D117326: [mlir][Linalg] Drop deprecated convolution vectorization patterns.

Rebase post revert.

Tue, Jan 18, 12:23 AM · Restricted Project
nicolasvasilache reopened D117326: [mlir][Linalg] Drop deprecated convolution vectorization patterns.
Tue, Jan 18, 12:23 AM · Restricted Project

Mon, Jan 17

nicolasvasilache reopened D117323: [mlir][Linalg] NFC - Drop vectorization reliance on ConvolutionOpInterface.
Mon, Jan 17, 11:59 PM · Restricted Project
nicolasvasilache added a comment to D117323: [mlir][Linalg] NFC - Drop vectorization reliance on ConvolutionOpInterface.

hmm sorry .. the build was green but it seems I made a mistake landing and ended up squashing 2 things that turned into a breakage.
Thanks @mehdi_amini

Mon, Jan 17, 11:57 AM · Restricted Project
nicolasvasilache committed rG392e16c27ffc: [mlir][Linalg] NFC - Cleanup conv1d generators (authored by nicolasvasilache).
[mlir][Linalg] NFC - Cleanup conv1d generators
Mon, Jan 17, 9:39 AM
nicolasvasilache closed D117330: [mlir][Linalg] NFC - Cleanup conv1d generators.
Mon, Jan 17, 9:39 AM · Restricted Project
nicolasvasilache added inline comments to D117330: [mlir][Linalg] NFC - Cleanup conv1d generators.
Mon, Jan 17, 9:38 AM · Restricted Project
nicolasvasilache updated the diff for D117330: [mlir][Linalg] NFC - Cleanup conv1d generators.

Address and rebase.

Mon, Jan 17, 9:37 AM · Restricted Project
nicolasvasilache updated the diff for D117330: [mlir][Linalg] NFC - Cleanup conv1d generators.

Rebase.

Mon, Jan 17, 9:15 AM · Restricted Project
nicolasvasilache committed rG8a8f0a00b245: [mlir][Linalg] Relax PadTensor tiling constraints and expose it to strategies. (authored by nicolasvasilache).
[mlir][Linalg] Relax PadTensor tiling constraints and expose it to strategies.
Mon, Jan 17, 9:14 AM
nicolasvasilache closed D117334: [mlir][Linalg] Relax PadTensor tiling constraints and expose it to strategies..
Mon, Jan 17, 9:14 AM · Restricted Project
nicolasvasilache updated the diff for D117334: [mlir][Linalg] Relax PadTensor tiling constraints and expose it to strategies..

Rebase.

Mon, Jan 17, 9:09 AM · Restricted Project
nicolasvasilache closed D117326: [mlir][Linalg] Drop deprecated convolution vectorization patterns.

This was folded and merged into c8f5735301993c363c16ce5ddda6f1f6cb968090 during a rebase.

Mon, Jan 17, 9:06 AM · Restricted Project
nicolasvasilache committed rGc8f573530199: [mlir][Linalg] NFC - Drop vectorization reliance on ConvolutionOpInterface (authored by nicolasvasilache).
[mlir][Linalg] NFC - Drop vectorization reliance on ConvolutionOpInterface
Mon, Jan 17, 9:02 AM
nicolasvasilache closed D117323: [mlir][Linalg] NFC - Drop vectorization reliance on ConvolutionOpInterface.
Mon, Jan 17, 9:01 AM · Restricted Project
nicolasvasilache updated the diff for D117323: [mlir][Linalg] NFC - Drop vectorization reliance on ConvolutionOpInterface.

Rebase

Mon, Jan 17, 9:01 AM · Restricted Project
nicolasvasilache added a comment to D116600: [linalg][fusion] Disallow fusion when it would create an invalid expand_shape.

Please update the commit message to reflect your latest changes, thanks!

Mon, Jan 17, 8:38 AM · Restricted Project
nicolasvasilache accepted D116600: [linalg][fusion] Disallow fusion when it would create an invalid expand_shape.

Ah this already happens transitively, LGTM, thanks @bkramer !

Mon, Jan 17, 8:37 AM · Restricted Project
nicolasvasilache added a comment to D116600: [linalg][fusion] Disallow fusion when it would create an invalid expand_shape.

Can we make proper use of this new function also in the reshape op verifiers?
We should have only one logic used everywhere.
Thanks for pushing on this cleanup!

Mon, Jan 17, 8:36 AM · Restricted Project
nicolasvasilache committed rGf98025d867e3: [mlir][Vector] Generalize and improve folding of ExtractOp from… (authored by nicolasvasilache).
[mlir][Vector] Generalize and improve folding of ExtractOp from…
Mon, Jan 17, 8:05 AM
nicolasvasilache closed D117322: [mlir][Vector] Generalize and improve folding of ExtractOp from Insert/Transpose chain..
Mon, Jan 17, 8:05 AM · Restricted Project
nicolasvasilache updated the diff for D117322: [mlir][Vector] Generalize and improve folding of ExtractOp from Insert/Transpose chain..

Rebase and address

Mon, Jan 17, 7:31 AM · Restricted Project

Fri, Jan 14

nicolasvasilache requested review of D117334: [mlir][Linalg] Relax PadTensor tiling constraints and expose it to strategies..
Fri, Jan 14, 10:01 AM · Restricted Project
nicolasvasilache requested review of D117330: [mlir][Linalg] NFC - Cleanup conv1d generators.
Fri, Jan 14, 9:19 AM · Restricted Project
nicolasvasilache requested review of D117326: [mlir][Linalg] Drop deprecated convolution vectorization patterns.
Fri, Jan 14, 8:28 AM · Restricted Project
nicolasvasilache requested review of D117323: [mlir][Linalg] NFC - Drop vectorization reliance on ConvolutionOpInterface.
Fri, Jan 14, 8:18 AM · Restricted Project
nicolasvasilache requested review of D117322: [mlir][Vector] Generalize and improve folding of ExtractOp from Insert/Transpose chain..
Fri, Jan 14, 8:09 AM · Restricted Project
nicolasvasilache added a comment to rGb0a309dd7a59: [mlir][vector] Add folding for extract + extract/insert_strided.

Note: I am sending a rewrite of the extract from insert+transpose chain that needs more cases than we currently have.
Would be good to also have the same extensions for this revision.

Fri, Jan 14, 6:32 AM
nicolasvasilache accepted D117224: [mlir][memref] Fold self copies.
Fri, Jan 14, 2:14 AM · Restricted Project
nicolasvasilache accepted D117220: [mlir][linalg][bufferize] Use memref.copy instead of linalg.copy.
Fri, Jan 14, 2:05 AM · Restricted Project
nicolasvasilache accepted D117291: [mlir][linalg][bufferize] Support custom insertion point for buffer copies.
Fri, Jan 14, 2:04 AM · Restricted Project

Thu, Jan 13

nicolasvasilache added a comment to D116069: [mlir][vector] Allow values outside of [0; dim-size] in create_mask.

@aartbik is actually the original contributor of this abstraction and the main user at this time.
Offhand it would seem to me that we wouldn't want negative values here?
I would personally rather go for an explicit truncation, but @aartbik will know better.

Thu, Jan 13, 7:19 AM · Restricted Project
nicolasvasilache accepted D117215: [mlir][memref] Fold copy of cast.

thanks, you may want to look at other linalg.copy canonicalizations and foldings that may have been missed when memref.copy was introduced.

Thu, Jan 13, 5:53 AM · Restricted Project

Wed, Jan 12

nicolasvasilache accepted D117106: [mlir] Provide getMixedOffsets/sizes/strides as free functions.
Wed, Jan 12, 6:02 AM · Restricted Project
nicolasvasilache added a comment to D116600: [linalg][fusion] Disallow fusion when it would create an invalid expand_shape.

We had a deeper offline discussion with @bkramer
There is a bug that needs to be fixed.
In the same way that we have a "isCastCompatible", we should have a "isShapeCollapse/Expand" compatible.
In this form, the result of that "isShapeCollapse/Expand" is false and the pattern/transformation should fail to apply.

Wed, Jan 12, 3:04 AM · Restricted Project
nicolasvasilache accepted D117096: [mlir][linalg][bufferize] Add pass options for `createDeallocs`.
Wed, Jan 12, 1:42 AM · Restricted Project
nicolasvasilache accepted D117072: Add an example of integration test invoking MLIR source with Memref from C.
Wed, Jan 12, 12:36 AM · Restricted Project
nicolasvasilache accepted D116868: [mlir][linalg][bufferize] Support std.select bufferization.

Please leave a TODO somewhere that you can improve this to making 0 or 1 copies (e.g. dynamically if you put your copy operations under the same conditional as the switch; or something else as we discussed offline).
Atm you make 0, 1 or 2 copies quite greedily.

Wed, Jan 12, 12:09 AM · Restricted Project

Tue, Jan 11

nicolasvasilache accepted D115520: [mlir][linalg] Improve pooling op iterator order consistency.
Tue, Jan 11, 8:06 AM · Restricted Project
nicolasvasilache added a comment to D116600: [linalg][fusion] Disallow fusion when it would create an invalid expand_shape.

I don't see a particular semantic problem with either cases (fully static, partially static, fully dynamic): all are valid and are subject to the same UB as a wrong cast would be.
I think Mahesh's suggestion is better because there is no guarantee in shape reification that you'd return 1 and you may well end up with propagating dynamic information further down.
I wouldn't change the verifier behavior here as it could limit the ability to have partial foldings that I think are valid.

Tue, Jan 11, 5:03 AM · Restricted Project
nicolasvasilache accepted D116418: [mlir][Linalg] Pattern to fuse pad operation with elementwise operations..
Tue, Jan 11, 4:32 AM · Restricted Project
nicolasvasilache added inline comments to D116418: [mlir][Linalg] Pattern to fuse pad operation with elementwise operations..
Tue, Jan 11, 4:32 AM · Restricted Project
nicolasvasilache accepted D116962: [mlir] Refactor ShapedType into an interface.

Nice, thanks much!

Tue, Jan 11, 3:52 AM · Restricted Project
nicolasvasilache accepted D116457: [mlir][linalg][bufferize] Fix CallOp bufferization.
Tue, Jan 11, 1:52 AM · Restricted Project
nicolasvasilache accepted D116860: [mlir][bufferize][linalg] Fix aliasing reads detection in analysis.
Tue, Jan 11, 1:28 AM · Restricted Project
nicolasvasilache added inline comments to D116868: [mlir][linalg][bufferize] Support std.select bufferization.
Tue, Jan 11, 1:25 AM · Restricted Project

Mon, Jan 10

nicolasvasilache committed rGd0ee094d6acf: [mlir][Bufferize] Fix incorrect bufferization of rank-reducing tensor ops. (authored by nicolasvasilache).
[mlir][Bufferize] Fix incorrect bufferization of rank-reducing tensor ops.
Mon, Jan 10, 7:15 AM
nicolasvasilache closed D116899: [mlir][Bufferize] Fix incorrect bufferization of rank-reducing tensor ops..
Mon, Jan 10, 7:15 AM · Restricted Project
nicolasvasilache updated the diff for D116899: [mlir][Bufferize] Fix incorrect bufferization of rank-reducing tensor ops..

Reasbe , clean

Mon, Jan 10, 7:14 AM · Restricted Project
nicolasvasilache retitled D116899: [mlir][Bufferize] Fix incorrect bufferization of rank-reducing tensor ops. from [mlir][Bufferize][WIP] Fix incorrect bufferization of rank-reducing tensor ops. to [mlir][Bufferize] Fix incorrect bufferization of rank-reducing tensor ops..
Mon, Jan 10, 7:06 AM · Restricted Project
nicolasvasilache added inline comments to D116899: [mlir][Bufferize] Fix incorrect bufferization of rank-reducing tensor ops..
Mon, Jan 10, 7:06 AM · Restricted Project
nicolasvasilache updated the diff for D116899: [mlir][Bufferize] Fix incorrect bufferization of rank-reducing tensor ops..

Rebase address and cleanup

Mon, Jan 10, 7:04 AM · Restricted Project
nicolasvasilache accepted D116937: [mlir][linalg][bufferize][NFC] Pass missing BufferizationState objs as const ref.
Mon, Jan 10, 6:39 AM · Restricted Project
nicolasvasilache committed rG1a2474b78631: [mlir][Linalg] Disable init_tensor elimination by default (authored by nicolasvasilache).
[mlir][Linalg] Disable init_tensor elimination by default
Mon, Jan 10, 6:24 AM
nicolasvasilache closed D116936: [mlir][Linalg] Disable init_tensor elimination by default.
Mon, Jan 10, 6:24 AM · Restricted Project
nicolasvasilache requested review of D116936: [mlir][Linalg] Disable init_tensor elimination by default.
Mon, Jan 10, 6:12 AM · Restricted Project
nicolasvasilache accepted D116892: [mlir][linalg][bufferize][NFC] Clean up bufferization entry point.
Mon, Jan 10, 4:37 AM · Restricted Project

Sun, Jan 9

nicolasvasilache requested review of D116899: [mlir][Bufferize] Fix incorrect bufferization of rank-reducing tensor ops..
Sun, Jan 9, 1:18 PM · Restricted Project
nicolasvasilache committed rG8871d8236a9f: [mlir][MemRef] NFC - Improve assertion error message (authored by nicolasvasilache).
[mlir][MemRef] NFC - Improve assertion error message
Sun, Jan 9, 11:18 AM
nicolasvasilache committed rG9ba25ec92d88: [mlir][Bufferize] NFC - Introduce areCastCompatible assertions to catch… (authored by nicolasvasilache).
[mlir][Bufferize] NFC - Introduce areCastCompatible assertions to catch…
Sun, Jan 9, 11:13 AM
nicolasvasilache closed D116893: [mlir][Bufferize] NFC - Introduce areCastCompatible assertions to catch misformed CastOp early.
Sun, Jan 9, 11:13 AM · Restricted Project
nicolasvasilache requested review of D116893: [mlir][Bufferize] NFC - Introduce areCastCompatible assertions to catch misformed CastOp early.
Sun, Jan 9, 8:52 AM · Restricted Project

Fri, Jan 7

nicolasvasilache added a comment to D116457: [mlir][linalg][bufferize] Fix CallOp bufferization.

One note is to add comments/doc re what is a heuristic and how combining with "reuse any opoperand" type of heuristic may create undesirable cases (e.g. the constant case).

Fri, Jan 7, 6:20 AM · Restricted Project
nicolasvasilache updated subscribers of D116687: [mlir][linalg][bufferize] Generalize destination-passing style detection.

This is also related to D115706 (cc @silvas).

Fri, Jan 7, 6:17 AM · Restricted Project
nicolasvasilache accepted D116456: [mlir][linalg][bufferize][NFC] Add `analyzeOp` helper function.
Fri, Jan 7, 5:49 AM · Restricted Project
nicolasvasilache accepted D116455: [mlir][linalg][bufferize][NFC] Simplify buffer API of BufferizationState.
Fri, Jan 7, 5:49 AM · Restricted Project
nicolasvasilache updated subscribers of D115706: [mlir][linalg][bufferize][NFC] Analyze OpOperands instead of OpResults.

Note: during the peer-review session we identified the fat that this current impl pushes bufferization further into "destination-passing style"-land and that we may want to generalize in the future (e.g. this cannot work with the torch-mlir as is).
We discussed that we could alternatively:

  1. pick any dominating tensor in the program (not just an op operand) as a candidate for "inplace"
  2. perform SSA use-def analysis on that tensor
  3. use it as the result

This would support something like %c = torch.mm(%a, %b) while avoiding to materialize a new %c for each op.

Fri, Jan 7, 5:47 AM · Restricted Project
nicolasvasilache accepted D115706: [mlir][linalg][bufferize][NFC] Analyze OpOperands instead of OpResults.
Fri, Jan 7, 5:43 AM · Restricted Project
nicolasvasilache accepted D115840: [mlir][linalg][bufferize][NFC] Add explicit inplaceable attrs to test cases.
Fri, Jan 7, 5:31 AM · Restricted Project
nicolasvasilache accepted D116454: [mlir][linalg][bufferize] Fix copy elision in `getResultBuffer`.
Fri, Jan 7, 5:06 AM · Restricted Project
nicolasvasilache added a comment to D116601: [mlir][memref] Tighten verification of memref.reinterpret_cast.

Side note: I think we could also drop memref.view and just use this instead.
This would be a good starter task.

Fri, Jan 7, 1:15 AM · Restricted Project
nicolasvasilache accepted D116601: [mlir][memref] Tighten verification of memref.reinterpret_cast.

Nice cleanup!

Fri, Jan 7, 1:10 AM · Restricted Project

Thu, Jan 6

nicolasvasilache committed rG07c009ed5506: [mlir][Linalg] Fix invalid FailureOr construction from LogicalResult::success (authored by nicolasvasilache).
[mlir][Linalg] Fix invalid FailureOr construction from LogicalResult::success
Thu, Jan 6, 3:43 PM
nicolasvasilache committed rG9cd7e880fd22: [mlir][Linalg] NFC - Modernize more transformation patterns. (authored by nicolasvasilache).
[mlir][Linalg] NFC - Modernize more transformation patterns.
Thu, Jan 6, 2:41 PM
nicolasvasilache closed D116763: [mlir][Linalg] NFC - Modernize more transformation patterns..
Thu, Jan 6, 2:41 PM · Restricted Project
nicolasvasilache updated the diff for D116763: [mlir][Linalg] NFC - Modernize more transformation patterns..

Rebase.

Thu, Jan 6, 1:59 PM · Restricted Project
nicolasvasilache committed rG4a661602ef2d: [mlir][Linalg] NFC - Modernize APIs and get rid of unnecessary tiling paterns. (authored by nicolasvasilache).
[mlir][Linalg] NFC - Modernize APIs and get rid of unnecessary tiling paterns.
Thu, Jan 6, 1:28 PM
nicolasvasilache closed D116733: [mlir][Linalg] NFC - Modernize APIs and get rid of unnecessary tiling paterns..
Thu, Jan 6, 1:27 PM · Restricted Project
nicolasvasilache requested review of D116763: [mlir][Linalg] NFC - Modernize more transformation patterns..
Thu, Jan 6, 12:27 PM · Restricted Project
nicolasvasilache updated the diff for D116733: [mlir][Linalg] NFC - Modernize APIs and get rid of unnecessary tiling paterns..

Add expander helpers.

Thu, Jan 6, 6:08 AM · Restricted Project