Page MenuHomePhabricator
People nicolasvasilache

nicolasvasilache (Nicolas Vasilache)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 2 2017, 2:24 AM (182 w, 6 d)

Recent Activity
View All

Yesterday

nicolasvasilache closed D84769: [mlir][Vector] Add linalg.copy-based pattern for splitting vector.transfer_read into full and partial copies..

Landed in 1a4263d394c1a93757613bde4b1c2cf8d6a7bbb9

Tue, Aug 4, 9:37 AM · Restricted Project
nicolasvasilache committed rG2d0b05969bc0: [mlir][Vector] Relax condition for `splitFullAndPartialTransferPrecondition` (authored by nicolasvasilache).
[mlir][Vector] Relax condition for `splitFullAndPartialTransferPrecondition`
Tue, Aug 4, 7:07 AM
nicolasvasilache closed D85209: [mlir][Vector] Relax condition for `splitFullAndPartialTransferPrecondition`.
Tue, Aug 4, 7:07 AM · Restricted Project
nicolasvasilache requested review of D85209: [mlir][Vector] Relax condition for `splitFullAndPartialTransferPrecondition`.
Tue, Aug 4, 6:52 AM · Restricted Project
nicolasvasilache committed rG1a4263d394c1: [mlir][Vector] Add linalg.copy-based pattern for splitting vector.transfer_read… (authored by nicolasvasilache).
[mlir][Vector] Add linalg.copy-based pattern for splitting vector.transfer_read…
Tue, Aug 4, 5:56 AM
nicolasvasilache updated the diff for D84769: [mlir][Vector] Add linalg.copy-based pattern for splitting vector.transfer_read into full and partial copies..

Typos.

Tue, Aug 4, 5:39 AM · Restricted Project
nicolasvasilache accepted D85048: [mlir] Conversion of ViewOp with memory space to LLVM..
Tue, Aug 4, 3:29 AM · Restricted Project
nicolasvasilache added a comment to D85048: [mlir] Conversion of ViewOp with memory space to LLVM..

Thanks @arpith-jacob

Tue, Aug 4, 2:05 AM · Restricted Project
nicolasvasilache added a comment to D83096: [MLIR] Add an integration test for 2 D vector.transfer_read.

I took the liberty to patch and land as I plan on using this and avoid reinventing the wheel.

Tue, Aug 4, 2:03 AM · Restricted Project
nicolasvasilache accepted D85020: [mlir] provide same APIs as existing LLVMType in the new LLVM type modeling.

Please fix the build though

Tue, Aug 4, 1:45 AM · Restricted Project
nicolasvasilache committed rG4bfbf74e57ad: [MLIR] Add an integration test for 2 D vector.transfer_read (authored by nicolasvasilache).
[MLIR] Add an integration test for 2 D vector.transfer_read
Tue, Aug 4, 1:32 AM
nicolasvasilache closed D83096: [MLIR] Add an integration test for 2 D vector.transfer_read.
Tue, Aug 4, 1:32 AM · Restricted Project

Mon, Aug 3

nicolasvasilache accepted D85042: Remove MLIREDSCInterface library which isn't used anywhere (NFC).
Mon, Aug 3, 12:15 PM · Restricted Project
nicolasvasilache committed rGd313e9c12ed3: [mlir][Vector] Add transformation + pattern to split vector.transfer_read into… (authored by nicolasvasilache).
[mlir][Vector] Add transformation + pattern to split vector.transfer_read into…
Mon, Aug 3, 9:59 AM
nicolasvasilache updated the diff for D84769: [mlir][Vector] Add linalg.copy-based pattern for splitting vector.transfer_read into full and partial copies..

Comments.

Mon, Aug 3, 2:40 AM · Restricted Project
nicolasvasilache committed rG35b65be04112: [mlir][Vector] Add transformation + pattern to split vector.transfer_read into… (authored by nicolasvasilache).
[mlir][Vector] Add transformation + pattern to split vector.transfer_read into…
Mon, Aug 3, 1:56 AM
nicolasvasilache closed D84631: [mlir][Vector] Add transformation + pattern to split vector.transfer_read into full and partial copies..
Mon, Aug 3, 1:55 AM · Restricted Project
nicolasvasilache updated the diff for D84631: [mlir][Vector] Add transformation + pattern to split vector.transfer_read into full and partial copies..

Add comments.

Mon, Aug 3, 1:53 AM · Restricted Project
nicolasvasilache added inline comments to D84631: [mlir][Vector] Add transformation + pattern to split vector.transfer_read into full and partial copies..
Mon, Aug 3, 1:53 AM · Restricted Project

Wed, Jul 29

nicolasvasilache accepted D84428: [MLIR][LinAlg] Use AnyTypeOf for LinalgOperand for better error msg..

Much better, thanks @kumasento

Wed, Jul 29, 6:12 AM · Restricted Project
nicolasvasilache accepted D84628: [mlir][Linalg] Conv {1,2,3}D ops defined with TC syntax.

Nice use of the language :) !

Wed, Jul 29, 6:09 AM · Restricted Project

Tue, Jul 28

nicolasvasilache requested review of D84769: [mlir][Vector] Add linalg.copy-based pattern for splitting vector.transfer_read into full and partial copies..
Tue, Jul 28, 10:17 AM · Restricted Project
nicolasvasilache committed rG64cdd5b3da1a: [mlir][Vector] Drop declarative transforms (authored by nicolasvasilache).
[mlir][Vector] Drop declarative transforms
Tue, Jul 28, 10:14 AM
nicolasvasilache closed D84753: [mlir][Vector] Drop declarative transforms.
Tue, Jul 28, 10:14 AM · Restricted Project
nicolasvasilache accepted D84752: Add edsc intrinsic for CmpIOp.
Tue, Jul 28, 7:01 AM · Restricted Project
nicolasvasilache requested review of D84753: [mlir][Vector] Drop declarative transforms.
Tue, Jul 28, 6:59 AM · Restricted Project
nicolasvasilache updated the diff for D84631: [mlir][Vector] Add transformation + pattern to split vector.transfer_read into full and partial copies..

Deterministic IR.

Tue, Jul 28, 6:35 AM · Restricted Project
nicolasvasilache accepted D84389: [mlir] LLVMType: make getUnderlyingType private.
Tue, Jul 28, 6:26 AM · Restricted Project
nicolasvasilache updated the diff for D84631: [mlir][Vector] Add transformation + pattern to split vector.transfer_read into full and partial copies..

Address review.

Tue, Jul 28, 3:49 AM · Restricted Project

Mon, Jul 27

nicolasvasilache added a reviewer for D84631: [mlir][Vector] Add transformation + pattern to split vector.transfer_read into full and partial copies.: mravishankar.
Mon, Jul 27, 11:49 AM · Restricted Project
nicolasvasilache updated the diff for D84631: [mlir][Vector] Add transformation + pattern to split vector.transfer_read into full and partial copies..

Make alloca default again.

Mon, Jul 27, 11:32 AM · Restricted Project
nicolasvasilache updated the diff for D84631: [mlir][Vector] Add transformation + pattern to split vector.transfer_read into full and partial copies..

Fix map capture, $ is now required for globals.

Mon, Jul 27, 5:11 AM · Restricted Project
nicolasvasilache updated the diff for D84631: [mlir][Vector] Add transformation + pattern to split vector.transfer_read into full and partial copies..

Drop CMake changes.

Mon, Jul 27, 4:05 AM · Restricted Project
Herald added a project to D84631: [mlir][Vector] Add transformation + pattern to split vector.transfer_read into full and partial copies.: Restricted Project.
Mon, Jul 27, 3:47 AM · Restricted Project
nicolasvasilache accepted D82952: [MLIR][Linalg] Retire C++ DotOp in favor of a linalg-ods-gen'd op.

@chelini thanks for your contribution!
Can we please land this?

Mon, Jul 27, 3:41 AM · Restricted Project

Wed, Jul 22

nicolasvasilache accepted D84368: [mlir] [VectorOps] Improve scatter/gather CPU performance.
Wed, Jul 22, 10:48 PM · Restricted Project
nicolasvasilache accepted D84366: [mlir][Linalg] Fixing bug in subview size computation in Linalg tiling..

Thanks for the fix @maheshkhanwalkar

Wed, Jul 22, 10:43 PM · Restricted Project
nicolasvasilache accepted D83756: [mlir][Linalg] emitLoopRanges and emitLoopRangesWithSymbols merged into one.

Looks great, thanks!

Wed, Jul 22, 1:49 AM · Restricted Project
nicolasvasilache accepted D84289: [mlir][VectorOps] Expose SuperVectorizer as a utility.

Thanks Diego!
Note that a lot of this code is old and I have plans to refactor for more general usefulness between affine and linalg, but it is not highest pri for me for now.
In the meantime, exposing more things as "composable transformations" and less as passes is great, thank you for the patch!

Wed, Jul 22, 1:47 AM · Restricted Project

Mon, Jul 20

nicolasvasilache committed rG47cbd9f92282: [mlir][Vector] NFC - Improve VectorInterfaces (authored by nicolasvasilache).
[mlir][Vector] NFC - Improve VectorInterfaces
Mon, Jul 20, 5:25 AM
nicolasvasilache closed D84053: [mlir][Vector] NFC - Improve VectorInterfaces.
Mon, Jul 20, 5:25 AM · Restricted Project
nicolasvasilache added inline comments to D84053: [mlir][Vector] NFC - Improve VectorInterfaces.
Mon, Jul 20, 5:20 AM · Restricted Project
nicolasvasilache updated the diff for D84053: [mlir][Vector] NFC - Improve VectorInterfaces.

Update.

Mon, Jul 20, 5:19 AM · Restricted Project

Fri, Jul 17

Herald added a project to D84053: [mlir][Vector] NFC - Improve VectorInterfaces: Restricted Project.
Fri, Jul 17, 10:34 AM · Restricted Project
nicolasvasilache committed rGcc0a58d7cd3b: [mlir][Vector] Fix masking logic in VectorToSCF (authored by nicolasvasilache).
[mlir][Vector] Fix masking logic in VectorToSCF
Fri, Jul 17, 10:27 AM
nicolasvasilache closed D84051: [mlir][Vector] Fix masking logic in VectorToSCF.
Fri, Jul 17, 10:26 AM · Restricted Project
Herald added a project to D84051: [mlir][Vector] Fix masking logic in VectorToSCF: Restricted Project.
Fri, Jul 17, 10:18 AM · Restricted Project
nicolasvasilache committed rGec62e37c86fa: [mlir] [vector] Add an optional filter to vector contract lowering patterns. (authored by poechsel).
[mlir] [vector] Add an optional filter to vector contract lowering patterns.
Fri, Jul 17, 9:06 AM
nicolasvasilache closed D83960: [mlir] [vector] Add an optional filter to vector contract lowering patterns..
Fri, Jul 17, 9:06 AM · Restricted Project
nicolasvasilache accepted D83960: [mlir] [vector] Add an optional filter to vector contract lowering patterns..

Looks good thanks!

Fri, Jul 17, 8:33 AM · Restricted Project
nicolasvasilache accepted D83158: [mlir] Added support for symbols inside linalg.generic and map concatenation.
Fri, Jul 17, 8:27 AM · Restricted Project
nicolasvasilache committed rG08521abb3a7c: [mlir][EDSC] Allow conditionBuilder to capture the IfOp (authored by nicolasvasilache).
[mlir][EDSC] Allow conditionBuilder to capture the IfOp
Fri, Jul 17, 8:18 AM
nicolasvasilache closed D84025: [mlir][EDSC] Allow conditionBuilder to capture the IfOp.
Fri, Jul 17, 8:18 AM · Restricted Project
nicolasvasilache added a comment to D84025: [mlir][EDSC] Allow conditionBuilder to capture the IfOp.

I've been using this for some fast/slow path lowering of vector.transfer ops, a bunch of stacked revisions are necessary to get there.

Fri, Jul 17, 8:16 AM · Restricted Project
nicolasvasilache updated the diff for D84025: [mlir][EDSC] Allow conditionBuilder to capture the IfOp.

Address review.

Fri, Jul 17, 8:09 AM · Restricted Project
Herald added a project to D84025: [mlir][EDSC] Allow conditionBuilder to capture the IfOp: Restricted Project.
Fri, Jul 17, 6:56 AM · Restricted Project

Thu, Jul 16

nicolasvasilache accepted D83739: [mlir][linalg] Add vectorization transform for CopyOp.

Thanks @ThomasRaoux

Thu, Jul 16, 11:51 PM · Restricted Project
nicolasvasilache requested changes to D83960: [mlir] [vector] Add an optional filter to vector contract lowering patterns..
Thu, Jul 16, 10:03 AM · Restricted Project
nicolasvasilache added inline comments to D83960: [mlir] [vector] Add an optional filter to vector contract lowering patterns..
Thu, Jul 16, 10:03 AM · Restricted Project
nicolasvasilache closed D83476: [mlir][Vector] Fold chains of ExtractOp.

Landed as 22c8a08fd8a1487159564f74f24561964f6a6c97.

Thu, Jul 16, 6:42 AM · Restricted Project
nicolasvasilache added a comment to D83158: [mlir] Added support for symbols inside linalg.generic and map concatenation.

Very sorry for the delay, thanks Jakub!

Thu, Jul 16, 6:19 AM · Restricted Project

Wed, Jul 15

nicolasvasilache accepted D83773: Make linalg::ReshapeOp implement ViewLikeOpInterface.

Thanks Stephan!

Wed, Jul 15, 12:21 AM · Restricted Project

Tue, Jul 14

nicolasvasilache committed rG512da70be781: [mlir][Vector] Degrade masking information when forwarding linalg.copy to… (authored by nicolasvasilache).
[mlir][Vector] Degrade masking information when forwarding linalg.copy to…
Tue, Jul 14, 11:36 PM
nicolasvasilache closed D83782: [mlir][Vector] Degrade masking information when forwarding linalg.copy to vector.transfer.
Tue, Jul 14, 11:36 PM · Restricted Project
nicolasvasilache accepted D83795: Standardize `linalg.generic` on `args_in`/`args_out` instead of `inputCount`/`outputCount`.

Thank you for the cleanup @agrue!
Please let me know if you want me to land this in case you don't have push access.

Tue, Jul 14, 11:21 PM · Restricted Project
Herald added a project to D83782: [mlir][Vector] Degrade masking information when forwarding linalg.copy to vector.transfer: Restricted Project.
Tue, Jul 14, 8:46 AM · Restricted Project

Mon, Jul 13

nicolasvasilache committed rGaffbc0cd1cc8: [mlir] Add alignment attribute to LLVM memory ops and use in vector.transfer (authored by nicolasvasilache).
[mlir] Add alignment attribute to LLVM memory ops and use in vector.transfer
Mon, Jul 13, 2:38 PM
nicolasvasilache closed D83684: [mlir] Add alignment attribute to LLVM memory ops and use in vector.transfer.
Mon, Jul 13, 2:38 PM · Restricted Project
Herald added a project to D83684: [mlir] Add alignment attribute to LLVM memory ops and use in vector.transfer: Restricted Project.
Mon, Jul 13, 8:04 AM · Restricted Project
nicolasvasilache accepted D83666: [mlir][VectorOps] Lower vector.fma to llvm.fmuladd instead of llvm.fma.

Great, is this the root cause of the issue we were seeing on older HW ?

Mon, Jul 13, 3:30 AM · Restricted Project
nicolasvasilache accepted D83627: [mlir] Support operations with multiple results in slicing.
Mon, Jul 13, 1:45 AM · Restricted Project

Fri, Jul 10

nicolasvasilache accepted D83538: [mlir][linalg] Improve aliasing approximation for hoisting transfer read/write. .
Fri, Jul 10, 2:22 PM · Restricted Project
nicolasvasilache added a comment to D83538: [mlir][linalg] Improve aliasing approximation for hoisting transfer read/write. .

This looks good to me, there are more relaxations we can do in the future but we should be good for now.
Thanks, Thomas!

Fri, Jul 10, 2:22 PM · Restricted Project
nicolasvasilache committed rGec2f2cec769c: [mlir][Vector] Add folding for vector.transfer ops (authored by nicolasvasilache).
[mlir][Vector] Add folding for vector.transfer ops
Fri, Jul 10, 1:52 PM
nicolasvasilache closed D83586: [mlir][Vector] Add folding for vector.transfer ops.
Fri, Jul 10, 1:51 PM · Restricted Project
nicolasvasilache updated the diff for D83586: [mlir][Vector] Add folding for vector.transfer ops.

Review

Fri, Jul 10, 1:48 PM · Restricted Project
nicolasvasilache accepted D83585: [mlir] [VectorOps] Merge OUTER/AXPY vector.contract lowering into single case.

Much nicer now, thanks for cleaning this up!

Fri, Jul 10, 12:55 PM · Restricted Project
Herald added a project to D83586: [mlir][Vector] Add folding for vector.transfer ops: Restricted Project.
Fri, Jul 10, 12:53 PM · Restricted Project
nicolasvasilache accepted D83453: [mlir] [VectorOps] Allow AXPY to be expressed as special case of OUTERPRODUCT.
Refactoring to use the new operation seemed another logical unit.
Fri, Jul 10, 12:02 PM · Restricted Project
nicolasvasilache committed rGa490d387e6e6: [mlir][Vector] Add ExtractOp folding when fed by a TransposeOp (authored by nicolasvasilache).
[mlir][Vector] Add ExtractOp folding when fed by a TransposeOp
Fri, Jul 10, 8:11 AM
nicolasvasilache closed D83487: [mlir][Vector] Add ExtractOp folding when fed by a TransposeOp.
Fri, Jul 10, 8:11 AM · Restricted Project
nicolasvasilache added inline comments to D83487: [mlir][Vector] Add ExtractOp folding when fed by a TransposeOp.
Fri, Jul 10, 8:09 AM · Restricted Project
nicolasvasilache committed rG56c638b5c1ca: [mlir][Linalg] Generalize Vectorization of Linalg contractions (authored by nicolasvasilache).
[mlir][Linalg] Generalize Vectorization of Linalg contractions
Fri, Jul 10, 7:30 AM
nicolasvasilache closed D83307: [mlir][Linalg] Generalize Vectorization of Linalg contractions.
Fri, Jul 10, 7:29 AM · Restricted Project
nicolasvasilache updated the diff for D83307: [mlir][Linalg] Generalize Vectorization of Linalg contractions.

Rebase

Fri, Jul 10, 7:23 AM · Restricted Project
nicolasvasilache updated the diff for D83307: [mlir][Linalg] Generalize Vectorization of Linalg contractions.

Format

Fri, Jul 10, 7:22 AM · Restricted Project
nicolasvasilache added inline comments to D83307: [mlir][Linalg] Generalize Vectorization of Linalg contractions.
Fri, Jul 10, 7:20 AM · Restricted Project
nicolasvasilache added inline comments to D83487: [mlir][Vector] Add ExtractOp folding when fed by a TransposeOp.
Fri, Jul 10, 6:50 AM · Restricted Project
nicolasvasilache updated the diff for D83487: [mlir][Vector] Add ExtractOp folding when fed by a TransposeOp.

Fix test

Fri, Jul 10, 6:50 AM · Restricted Project
nicolasvasilache committed rG22c8a08fd8a1: [mlir][Vector] Fold chains of ExtractOp (authored by nicolasvasilache).
[mlir][Vector] Fold chains of ExtractOp
Fri, Jul 10, 6:35 AM
nicolasvasilache updated the diff for D83476: [mlir][Vector] Fold chains of ExtractOp.

Fix tests

Fri, Jul 10, 6:31 AM · Restricted Project
nicolasvasilache added a comment to D83476: [mlir][Vector] Fold chains of ExtractOp.
(but I guess this is optimized by backend again anyway)
Fri, Jul 10, 6:30 AM · Restricted Project
nicolasvasilache added a comment to D83538: [mlir][linalg] Improve aliasing approximation for hoisting transfer read/write. .

Made a quick pass but I do not think the algorithm is complete atm: in order to check lack of aliasing you need to look at whether the static intervals between read/write pairs overlap.
Here the positive example only has trivial intervals (i.e. that reduce to a single point).

Fri, Jul 10, 5:32 AM · Restricted Project
nicolasvasilache added a comment to D83453: [mlir] [VectorOps] Allow AXPY to be expressed as special case of OUTERPRODUCT.

Thanks for adopting what we discussed previously and special casing the impl!

Fri, Jul 10, 5:07 AM · Restricted Project

Thu, Jul 9

Herald added a project to D83487: [mlir][Vector] Add ExtractOp folding when fed by a TransposeOp: Restricted Project.
Thu, Jul 9, 8:55 AM · Restricted Project
Herald added a project to D83476: [mlir][Vector] Fold chains of ExtractOp: Restricted Project.
Thu, Jul 9, 5:36 AM · Restricted Project

Wed, Jul 8

nicolasvasilache accepted D83420: [mlir] [VectorOps] Expose lowering pass options programmatically.
Wed, Jul 8, 2:17 PM · Restricted Project

Tue, Jul 7

nicolasvasilache committed rG24ed3a9403fa: [mlir][Vector] Add ExtractOp folding (authored by nicolasvasilache).
[mlir][Vector] Add ExtractOp folding
Tue, Jul 7, 1:49 PM
nicolasvasilache closed D83150: [mlir][Vector] Add ExtractOp folding.
Tue, Jul 7, 1:49 PM · Restricted Project
nicolasvasilache updated the diff for D83150: [mlir][Vector] Add ExtractOp folding.

Last nits

Tue, Jul 7, 1:44 PM · Restricted Project