- User Since
- Aug 20 2014, 6:06 PM (326 w, 5 d)
Switched to stringattr & AnyRegion
Sat, Nov 21
LG MLIR changes
This seems to be failing on some configurations https://buildkite.com/mlir/mlir-core/builds/9510#4c77cda4-9dce-4b4d-8ad7-c220a892865b , known issue?
Fri, Nov 20
Fix missing :
Thu, Nov 19
Swap it to be a directive & incorporate doc suggestions.
Wed, Nov 18
Don't do recursive walk when finding shape fn lib in test pass.
First scan, mostly looks good thanks!
Switching to Operation* and moving out anon namespace.
Tue, Nov 17
Mon, Nov 16
Nice, only small nits.
I was funnily looking at this this morning, so yay :-) (just scanned but didn't review yet, just wanted to remark as timing is perfect :-))
Sat, Nov 14
Thu, Nov 12
Wed, Nov 11
This seems to breaking clang-5 builds:
Nice improvement :)
Mon, Nov 9
This may be related to failure in https://buildkite.com/mlir/mlir-core/builds/9228#25f0ef1a-60e1-4f0e-a231-417f3747a366
Nice, could we have a Python test too to show the benefit?
Mon, Nov 2
This looks good in general, thanks
Sun, Nov 1
Sat, Oct 31
Fri, Oct 30
Thu, Oct 29
Did one of sanitizers flag this?
Wed, Oct 28
Tue, Oct 27
This order won't be stable between runs though, so any test depends on the ordering would be flaky. Why not add a simple wrapper class locally where you need this? Keeps it local to where the ordering doesn't matter and avoids folks accidentally relying on it accidentally.
Mon, Oct 26
Oct 23 2020
Is this change related to build breakage? (https://buildkite.com/mlir/mlir-core/builds/8813)
Could you expand the description to add the rationale? It is mostly focussed on what but I don't know why
Oct 22 2020
This seems to have broken the build https://buildkite.com/mlir/mlir-core/builds/8787#c1ee666b-58ff-4f6e-816e-2ba4996fa2ee
Oct 21 2020
Oct 20 2020
Looks good, thanks! An extra failure case for line 1189 would be nice to have.
Oct 19 2020
Could you please update the documentation and description of the change?
Looks good - this is little bit of a big review, but I also don't have an idea of how to make it smaller easily. Given the work following on this & verification wrt existing, I feel a little bit more comfortable.
Oct 16 2020
Nice, micro nit: in description add ... as when I initially read it I thought there was requirement for empty block bb1
Nice, to follow the naming convention of other utils folders here, how about mlir/utils/vscode/mlir.natvis ? (or s/vscode/vstudio/? I don't now who which is considered more general/common in folks minds :)).
Woops, I missed this asking for this test. Thanks
Oct 15 2020
Looks good thanks!
Nice - well I think this means I can stop migrating the other OpBuilder usage as these will be migrated again :)
Oct 14 2020
Looks good overall
Oct 13 2020
Looks good, thanks
Oct 12 2020
I think you may need to rebase this on head, seems like you were working of an old version here.
Oct 9 2020
Oct 8 2020
Oct 7 2020
The pre-merge differs here - if you want to appease both you'd probably need to use PRIu64 (https://en.cppreference.com/w/c/types/integer) it seems