Page MenuHomePhabricator

jpienaar (Jacques Pienaar)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 20 2014, 6:06 PM (326 w, 5 d)

Recent Activity

Today

jpienaar added inline comments to D91672: Add a shape function library op.
Mon, Nov 23, 5:15 PM · Restricted Project
jpienaar updated the diff for D91672: Add a shape function library op.

Switched to stringattr & AnyRegion

Mon, Nov 23, 5:15 PM · Restricted Project
jpienaar added a comment to D91480: Avoid appending Pass where already present..

I'm not sure if you're saying that the desired end state is to add a Pass suffix or not?

Mon, Nov 23, 4:54 PM · Restricted Project
jpienaar added a comment to D91480: Avoid appending Pass where already present..

Seems like a "hack" to me, why not fix the source?

Mon, Nov 23, 4:30 PM · Restricted Project

Sat, Nov 21

jpienaar accepted D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref.

LG MLIR changes

Sat, Nov 21, 6:26 AM · Restricted Project, Restricted Project, Restricted Project
jpienaar added a comment to D91896: [mlir] Add microbenchmark for linalg+async-parallel-for.

This seems to be failing on some configurations https://buildkite.com/mlir/mlir-core/builds/9510#4c77cda4-9dce-4b4d-8ad7-c220a892865b , known issue?

Sat, Nov 21, 5:59 AM · Restricted Project

Fri, Nov 20

jpienaar updated the diff for D91761: [FileCheck] Add a literal check modifier.

Fix missing :

Fri, Nov 20, 11:09 AM · Restricted Project
jpienaar retitled D91761: [FileCheck] Add a literal check modifier from [FileCheck] Add a literal check directive to [FileCheck] Add a literal check modifier.
Fri, Nov 20, 10:50 AM · Restricted Project
jpienaar added a comment to D91761: [FileCheck] Add a literal check modifier.

Fair. I'd forgotten about COUNT and that multi-line regexes are possible. (Although I will point out that SAME does not always do the same thing as pasting the directives together with .* separators; see my "FileCheck Follies" lightning talk from the Fall 2016 Dev Meeting.)

Fri, Nov 20, 9:00 AM · Restricted Project

Thu, Nov 19

jpienaar added a comment to D91761: [FileCheck] Add a literal check modifier.

I have to say, I'm not super enthused about this feature. Typically we've added directives when there's no other way to achieve the desired effect

Thu, Nov 19, 7:22 PM · Restricted Project
jpienaar updated the diff for D91761: [FileCheck] Add a literal check modifier.

Swap it to be a directive & incorporate doc suggestions.

Thu, Nov 19, 3:19 PM · Restricted Project
jpienaar added a comment to D91761: [FileCheck] Add a literal check modifier.

On a more general note, I wonder if having new directives is the right way to go. Why not introduce a concept of directive modifier? It could allow multiple modifier to cumulate. We could even introduce modifier in the middle of a directive at some point (though obviously not for a directive that was marked literal).

How about: CHECK{LITERAL}? Or perhaps CHECK{\L}. Other directives would follow naturally and CHECK-EMPTY{\L} would be a nop.

Thu, Nov 19, 6:51 AM · Restricted Project

Wed, Nov 18

jpienaar requested review of D91761: [FileCheck] Add a literal check modifier.
Wed, Nov 18, 9:22 PM · Restricted Project
jpienaar added inline comments to D91672: Add a shape function library op.
Wed, Nov 18, 5:29 PM · Restricted Project
jpienaar updated the diff for D91672: Add a shape function library op.

Don't do recursive walk when finding shape fn lib in test pass.

Wed, Nov 18, 5:29 PM · Restricted Project
jpienaar added a comment to D89107: [mlir][PDL] Add support for PDL bytecode and expose PDL support to OwningRewritePatternList.

First scan, mostly looks good thanks!

Wed, Nov 18, 9:43 AM · Restricted Project
jpienaar added inline comments to D91672: Add a shape function library op.
Wed, Nov 18, 9:41 AM · Restricted Project
jpienaar updated the diff for D91672: Add a shape function library op.

Switching to Operation* and moving out anon namespace.

Wed, Nov 18, 9:41 AM · Restricted Project

Tue, Nov 17

jpienaar requested review of D91672: Add a shape function library op.
Tue, Nov 17, 5:46 PM · Restricted Project

Mon, Nov 16

jpienaar added a comment to D91381: [mlir][OpDefGen] Add support for generating local functions for shared utilities.

Nice

Mon, Nov 16, 9:14 PM · Restricted Project
jpienaar accepted D91571: [mlir][IR] Use tablegen for the BuiltinDialect and operations.

Nice, only small nits.

Mon, Nov 16, 8:52 PM · Restricted Project
jpienaar added a comment to D91571: [mlir][IR] Use tablegen for the BuiltinDialect and operations.

I was funnily looking at this this morning, so yay :-) (just scanned but didn't review yet, just wanted to remark as timing is perfect :-))

Mon, Nov 16, 3:26 PM · Restricted Project

Sat, Nov 14

jpienaar committed rGcf58df29495c: [mlir] Add passes to passes.md to cleanup empty tabs on website index (authored by jpienaar).
[mlir] Add passes to passes.md to cleanup empty tabs on website index
Sat, Nov 14, 11:26 AM
jpienaar committed rG02ef4bcb9ab8: [mlir][shape] Make attr-dict placement consistent (authored by jpienaar).
[mlir][shape] Make attr-dict placement consistent
Sat, Nov 14, 10:29 AM
jpienaar requested review of D91480: Avoid appending Pass where already present..
Sat, Nov 14, 9:55 AM · Restricted Project

Thu, Nov 12

jpienaar accepted D91282: [mlir][Python] Fix 'unreferenced local variable' warning on MSVC..
Thu, Nov 12, 6:35 AM · Restricted Project

Wed, Nov 11

jpienaar added inline comments to D91224: [mlir][sparse] integrate sparse annotation into generic linalg op.
Wed, Nov 11, 2:31 PM · Restricted Project
jpienaar added a comment to D82860: Port ObjCMTAction to new option parsing system.

This seems to breaking clang-5 builds:

Wed, Nov 11, 8:39 AM · Restricted Project, Restricted Project
jpienaar accepted D91212: [mlir][Pass] Remove the verifierPass now that verification is run during normal pass execution.

Nice improvement :)

Wed, Nov 11, 7:56 AM · Restricted Project

Mon, Nov 9

jpienaar added a comment to D90960: [mlir] ODS-backed python binding generator for custom op classes.

Nice, thanks

Mon, Nov 9, 8:50 PM · Restricted Project
jpienaar added a comment to D90803: [MLIR] Support `global_memref` and `get_global_memref` in standard -> LLVM conversion..

This may be related to failure in https://buildkite.com/mlir/mlir-core/builds/9228#25f0ef1a-60e1-4f0e-a231-417f3747a366

Mon, Nov 9, 11:41 AM · Restricted Project
jpienaar added a comment to D90960: [mlir] ODS-backed python binding generator for custom op classes.

Nice, could we have a Python test too to show the benefit?

Mon, Nov 9, 8:36 AM · Restricted Project

Mon, Nov 2

jpienaar added inline comments to D90573: [mlir] Set random starting index.
Mon, Nov 2, 3:24 PM · Restricted Project
jpienaar accepted D90651: [MLIR] Remove unnecessary CHECK's from tests for which we do not run FileCheck..

Thanks

Mon, Nov 2, 3:15 PM · Restricted Project
jpienaar accepted D90196: [mlir] Optimize Op definitions and registration to optimize for code size.

This looks good in general, thanks

Mon, Nov 2, 10:33 AM · Restricted Project

Sun, Nov 1

jpienaar requested review of D90573: [mlir] Set random starting index.
Sun, Nov 1, 2:00 PM · Restricted Project

Sat, Oct 31

jpienaar added a comment to D90088: Add a `-verify-roundtrip` option to `mlir-opt` intended to validate custom printer/parser completeness.

I wonder if we should just make it the default?

IMO, it depends on the user running mlir-opt. If I'm iterating locally, I generally wouldn't want these additional cost/complexity of running this. For tests that run automatically, that default is probably fine. I would strongly prefer that we keep mlir-opt defaults useful for users iterating locally and generally using mlir-opt as a development tool. For testing, could we just have another frontend(alias of mlir-opt?) that has better defaults for testing use cases? We've had conversations of sane defaults in the past, and it seems like the truly contentious ones always have this divide between local development and testing.

Sat, Oct 31, 9:55 AM · Restricted Project

Fri, Oct 30

jpienaar added a comment to D90469: [TableGen] Add !interleave operator to concatenate a list of values with delimiters.

Nice reduction

Fri, Oct 30, 9:23 PM · Restricted Project, Restricted Project
jpienaar accepted D90405: [mlir] Add shape.is_broadcastable..

Thanks

Fri, Oct 30, 9:16 PM · Restricted Project

Thu, Oct 29

jpienaar added a comment to D90375: [mlir] Reorder shape assuming bufferization..

Did one of sanitizers flag this?

Thu, Oct 29, 6:08 AM · Restricted Project
jpienaar added inline comments to D90379: [MLIR] Support walks over regions and blocks.
Thu, Oct 29, 6:06 AM · Restricted Project

Wed, Oct 28

jpienaar accepted D90359: [mlir][Inliner] Add a new hook for checking if it is legal to inline a callable into a call.

Nice, thanks

Wed, Oct 28, 6:08 PM · Restricted Project

Tue, Oct 27

jpienaar added a comment to D90229: [MLIR] Define an order on `Value`s.

This order won't be stable between runs though, so any test depends on the ordering would be flaky. Why not add a simple wrapper class locally where you need this? Keeps it local to where the ordering doesn't matter and avoids folks accidentally relying on it accidentally.

Tue, Oct 27, 6:15 AM · Restricted Project

Mon, Oct 26

jpienaar accepted D89659: [mlir][StorageUniquer] Refactor parametric storage to use sharded dense sets.

Thanks!

Mon, Oct 26, 5:45 PM · Restricted Project
jpienaar accepted D90038: [mlir] use OpBuilderDAG instead of OpBuilder.
Mon, Oct 26, 5:10 PM · Restricted Project
jpienaar accepted D90086: [mlir][Interfaces] Optimize the implementation of InterfaceMap to reduce generated code size..
Mon, Oct 26, 5:08 PM · Restricted Project
jpienaar accepted D90085: [mlir][Interfaces] Generate a struct containing function pointers instead of a class with vtables.
Mon, Oct 26, 4:04 PM · Restricted Project
jpienaar accepted D90087: [mlir][NFC] Remove unnecessary PatternRewriter::create methods.
Mon, Oct 26, 4:01 PM · Restricted Project
jpienaar accepted D90084: [mlir][SIdeEffectInterface][NFC] Move several InterfaceMethods to the extraClassDeclarations instead.

Thanks!

Mon, Oct 26, 3:50 PM · Restricted Project

Oct 23 2020

jpienaar accepted D90089: [mlir] NFC: fix trivial typos fix typos in comments and documents.

Thanks

Oct 23 2020, 9:42 PM · Restricted Project
jpienaar accepted D89601: Add an mlir natvis file for debugging with Visual Studio.

SGTM

Oct 23 2020, 12:04 PM · Restricted Project
jpienaar added a comment to D89902: [MLIR] Extract buffer alias analysis for reuse.

Is this change related to build breakage? (https://buildkite.com/mlir/mlir-core/builds/8813)

Oct 23 2020, 7:15 AM · Restricted Project
jpienaar added a comment to D90037: [MLIR] Added test operations to replace linalg and scf in buffer placement tests..

Could you expand the description to add the rationale? It is mostly focussed on what but I don't know why

Oct 23 2020, 7:03 AM · Restricted Project

Oct 22 2020

jpienaar accepted D89967: [mlir] Do not start threads in AsyncRuntime.

Thanks

Oct 22 2020, 8:26 AM · Restricted Project
jpienaar added a comment to D89292: [mlir] Convert from Async dialect to LLVM coroutines.

This seems to have broken the build https://buildkite.com/mlir/mlir-core/builds/8787#c1ee666b-58ff-4f6e-816e-2ba4996fa2ee

Oct 22 2020, 7:36 AM · Restricted Project

Oct 21 2020

jpienaar added a comment to D89470: [mlir] ODS: support TableGen dag objects to specify OpBuilder parameters.

An extra failure case for line 1189 would be nice to have.

Yeah, we should also add -verify-diagnostics to Tablegen.

I don't think that works as easily: most error reporting via print fatal error here, this is different from the opt tool where error is returned and propagated up, so we can verify in the driver. I think only think verify brings additionally is to flag unexpected errors, that FileCheck won't. Is there anything else?

Splitting the input file into chunks without having to have as many RUN lines as the file has different checks.

Oct 21 2020, 7:38 AM · Restricted Project
jpienaar added a comment to D89470: [mlir] ODS: support TableGen dag objects to specify OpBuilder parameters.

An extra failure case for line 1189 would be nice to have.

Yeah, we should also add -verify-diagnostics to Tablegen.

Oct 21 2020, 6:45 AM · Restricted Project

Oct 20 2020

jpienaar accepted D89470: [mlir] ODS: support TableGen dag objects to specify OpBuilder parameters.

Looks good, thanks! An extra failure case for line 1189 would be nice to have.

Oct 20 2020, 5:38 PM · Restricted Project
jpienaar accepted D89660: [mlir][SymbolTable] Use Identifier instead of StringRef when looking up symbol name attributes.

Nice, thanks

Oct 20 2020, 4:31 PM · Restricted Project
jpienaar added inline comments to D89833: [mlir][shape] Split out structural type conversions for shape dialect..
Oct 20 2020, 4:30 PM · Restricted Project

Oct 19 2020

jpienaar accepted D89103: [mlir][NFC] Move around the code related to PatternRewriting to improve layering.
Oct 19 2020, 8:57 PM · Restricted Project
jpienaar added a comment to D89756: Relax the restriction that parsed arguments must match op arguments in ODS..

Could you please update the documentation and description of the change?

Oct 19 2020, 5:31 PM · Restricted Project
jpienaar accepted D89598: [mlir] Simplify DDR matching patterns with equal operands for operators where it's applicable..

Nice, thanks!

Oct 19 2020, 2:53 PM · Restricted Project
jpienaar added inline comments to D89659: [mlir][StorageUniquer] Refactor parametric storage to use sharded dense sets.
Oct 19 2020, 2:44 PM · Restricted Project
jpienaar accepted D84580: [mlir] Add a conversion pass between PDL and the PDL Interpreter Dialect.

Looks good - this is little bit of a big review, but I also don't have an idea of how to make it smaller easily. Given the work following on this & verification wrt existing, I feel a little bit more comfortable.

Oct 19 2020, 12:34 PM · Restricted Project

Oct 16 2020

jpienaar accepted D89604: [mlir] Add canonicalization for cond_br that feed into a cond_br on the same condition.

Nice, micro nit: in description add ... as when I initially read it I thought there was requirement for empty block bb1

Oct 16 2020, 7:35 PM · Restricted Project
jpienaar added a comment to D89601: Add an mlir natvis file for debugging with Visual Studio.

Nice, to follow the naming convention of other utils folders here, how about mlir/utils/vscode/mlir.natvis ? (or s/vscode/vstudio/? I don't now who which is considered more general/common in folks minds :)).

This is following the convention of the other natvis files.
./clang/utils/ClangVisualizers/clang.natvis
./llvm/utils/LLVMVisualizers/llvm.natvis

Oct 16 2020, 6:48 PM · Restricted Project
jpienaar added a comment to D89601: Add an mlir natvis file for debugging with Visual Studio.

Nice, to follow the naming convention of other utils folders here, how about mlir/utils/vscode/mlir.natvis ? (or s/vscode/vstudio/? I don't now who which is considered more general/common in folks minds :)).

Oct 16 2020, 5:24 PM · Restricted Project
jpienaar added a comment to D89598: [mlir] Simplify DDR matching patterns with equal operands for operators where it's applicable..

Nice

Oct 16 2020, 4:16 PM · Restricted Project
jpienaar accepted D89593: [mlir] Failure when const matcher fails, added a test to catch.

Woops, I missed this asking for this test. Thanks

Oct 16 2020, 3:01 PM · Restricted Project
jpienaar accepted D89522: [mlir] Update SCCP and the Inliner to use SymbolTableCollection for symbol lookups.
Oct 16 2020, 11:48 AM · Restricted Project
jpienaar accepted D89504: [mlir] Add a utility class, ThreadLocalCache, for storing non static thread local objects..

Thanks!

Oct 16 2020, 11:46 AM · Restricted Project

Oct 15 2020

jpienaar accepted D89505: [mlir] Optimize symbol related checks in SymbolDCE.
Oct 15 2020, 5:00 PM · Restricted Project
jpienaar accepted D89512: [mlir] Add a new SymbolUserOpInterface class.
Oct 15 2020, 4:59 PM · Restricted Project
jpienaar accepted D89161: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher.

Looks good thanks!

Oct 15 2020, 1:18 PM · Restricted Project
jpienaar added a comment to D89470: [mlir] ODS: support TableGen dag objects to specify OpBuilder parameters.

Nice - well I think this means I can stop migrating the other OpBuilder usage as these will be migrated again :)

Oct 15 2020, 8:17 AM · Restricted Project

Oct 14 2020

jpienaar committed rG008c0ea6a411: [DDR] Introduce implicit equality check for the source pattern operands with… (authored by rdzhabarov).
[DDR] Introduce implicit equality check for the source pattern operands with…
Oct 14 2020, 11:05 AM
jpienaar closed D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..
Oct 14 2020, 11:05 AM · Restricted Project
jpienaar committed rGf4ad76deb8a7: [mlir] More changes to avoid args now inserted.NFC (authored by jpienaar).
[mlir] More changes to avoid args now inserted.NFC
Oct 14 2020, 10:48 AM
jpienaar added inline comments to D89161: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher.
Oct 14 2020, 8:21 AM · Restricted Project
jpienaar added a comment to D89354: [mlir][ASM] Refactor how attribute/type aliases are specified..

Looks good overall

Oct 14 2020, 8:17 AM · Restricted Project

Oct 13 2020

jpienaar committed rG7271c1bcb960: [DDR] Introduce implicit equality check for the source pattern operands with… (authored by rdzhabarov).
[DDR] Introduce implicit equality check for the source pattern operands with…
Oct 13 2020, 4:17 PM
jpienaar closed D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..
Oct 13 2020, 4:17 PM · Restricted Project
jpienaar accepted D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

Looks good, thanks

Oct 13 2020, 2:41 PM · Restricted Project
jpienaar added inline comments to D89161: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher.
Oct 13 2020, 2:34 PM · Restricted Project

Oct 12 2020

jpienaar added a comment to D89161: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher.

I think you may need to rebase this on head, seems like you were working of an old version here.

Oct 12 2020, 1:33 PM · Restricted Project
jpienaar added a comment to D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

Nice, thanks

Oct 12 2020, 1:18 PM · Restricted Project

Oct 9 2020

jpienaar added a comment to D89169: [mlir, win] Mark several MLRI tests as unsupported on system-windows.

Thanks

Oct 9 2020, 5:03 PM · Restricted Project

Oct 8 2020

jpienaar accepted D89014: Give attributes C++ namespaces..
Oct 8 2020, 10:01 AM · Restricted Project

Oct 7 2020

jpienaar added inline comments to D84580: [mlir] Add a conversion pass between PDL and the PDL Interpreter Dialect.
Oct 7 2020, 11:02 AM · Restricted Project
jpienaar added a comment to D88943: Fix build warning for uint64_t.

The pre-merge differs here - if you want to appease both you'd probably need to use PRIu64 (https://en.cppreference.com/w/c/types/integer) it seems

Oct 7 2020, 8:57 AM · Restricted Project

Oct 6 2020

jpienaar added a comment to D84107: Add indented raw_ostream class.

Also, this seems like something that would go into llvm/Support and not mlir/Support.

Oct 6 2020, 8:19 AM · Restricted Project

Oct 5 2020

jpienaar added inline comments to D88809: [MLIR] Add a foldTrait() mechanism to allow traits to define folding and test it with an Involution trait.
Oct 5 2020, 10:22 AM · Restricted Project
jpienaar added inline comments to D88696: [mlir] Split alloc-like op LLVM lowerings into base and separate derived classes..
Oct 5 2020, 9:40 AM · Restricted Project

Oct 3 2020

jpienaar added a reverting change for rGbe185b6a7355: Revert "Add indented raw_ostream class": rG9b851527d533: Add indented raw_ostream class.
Oct 3 2020, 3:18 PM
jpienaar committed rG9b851527d533: Add indented raw_ostream class (authored by jpienaar).
Add indented raw_ostream class
Oct 3 2020, 3:18 PM
jpienaar added a reverting change for rG78530ce65375: Add indented raw_ostream class: rGbe185b6a7355: Revert "Add indented raw_ostream class".
Oct 3 2020, 9:42 AM
jpienaar committed rGbe185b6a7355: Revert "Add indented raw_ostream class" (authored by jpienaar).
Revert "Add indented raw_ostream class"
Oct 3 2020, 9:42 AM
jpienaar added a reverting change for D84107: Add indented raw_ostream class: rGbe185b6a7355: Revert "Add indented raw_ostream class".
Oct 3 2020, 9:42 AM · Restricted Project
jpienaar committed rG78530ce65375: Add indented raw_ostream class (authored by jpienaar).
Add indented raw_ostream class
Oct 3 2020, 8:54 AM