Page MenuHomePhabricator

jpienaar (Jacques Pienaar)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 20 2014, 6:06 PM (346 w, 5 d)

Recent Activity

Sat, Apr 10

jpienaar added a comment to D99548: [mlir] introduce "encoding" attribute to tensor type.

I like structure too as it captures information about the structure of the values to me. encoding makes me think jpeg or Levensthein distance and the like.

Sat, Apr 10, 7:54 AM · Restricted Project

Thu, Apr 8

jpienaar accepted D99713: Refactor the architecture of mlir-reduce.

I think this looks good to go and we can always iterate

Thu, Apr 8, 8:46 AM · Restricted Project

Wed, Apr 7

jpienaar added inline comments to D100042: [MLIR] Do not yield values from an assuming op that are never used.
Wed, Apr 7, 4:54 PM · Restricted Project
jpienaar committed rG628dda08b82f: [mlir,shape] Update min/max op description (authored by jpienaar).
[mlir,shape] Update min/max op description
Wed, Apr 7, 8:22 AM

Tue, Apr 6

jpienaar committed rG8b109bc2eae0: [mlir,shape] Add max/min folder for simple case (authored by jpienaar).
[mlir,shape] Add max/min folder for simple case
Tue, Apr 6, 8:23 PM
jpienaar added inline comments to D99548: [mlir] introduce "encoding" attribute to tensor type.
Tue, Apr 6, 7:45 PM · Restricted Project
jpienaar committed rGe74e6afcf13a: [shape] Add min and max ops (authored by jpienaar).
[shape] Add min and max ops
Tue, Apr 6, 5:59 PM
jpienaar closed D99986: [shape] Add min and max ops.
Tue, Apr 6, 5:59 PM · Restricted Project
jpienaar requested review of D99986: [shape] Add min and max ops.
Tue, Apr 6, 12:56 PM · Restricted Project
jpienaar committed rG96caf3817f47: [mlir] Hoist out getRequestedOpDefinitions helper (authored by jpienaar).
[mlir] Hoist out getRequestedOpDefinitions helper
Tue, Apr 6, 12:53 PM
jpienaar closed D99793: [mlir] Hoist out getRequestedOpDefinitions helper.
Tue, Apr 6, 12:53 PM · Restricted Project
jpienaar added inline comments to D99713: Refactor the architecture of mlir-reduce.
Tue, Apr 6, 6:40 AM · Restricted Project

Fri, Apr 2

jpienaar requested review of D99793: [mlir] Hoist out getRequestedOpDefinitions helper.
Fri, Apr 2, 6:18 AM · Restricted Project

Thu, Apr 1

jpienaar updated the summary of D99713: Refactor the architecture of mlir-reduce.
Thu, Apr 1, 7:05 AM · Restricted Project

Mon, Mar 29

jpienaar added a comment to D99529: Update python deps for buildbot-mlir-nvidia..

Thanks!

Mon, Mar 29, 12:04 PM

Fri, Mar 26

jpienaar committed rG7ce07c649438: [mlir] Remove unneeded ShapeFunctionLibraryTerminatorOp (authored by jpienaar).
[mlir] Remove unneeded ShapeFunctionLibraryTerminatorOp
Fri, Mar 26, 4:04 PM
jpienaar accepted D99442: Fix deletion of operations through the rewriter in a pattern matching a consumer operation.
Fri, Mar 26, 2:35 PM · Restricted Project

Wed, Mar 24

jpienaar committed rG5d6b4aa80d6d: [mlir] Compare elements directly rather than creating pair first (authored by jpienaar).
[mlir] Compare elements directly rather than creating pair first
Wed, Mar 24, 2:39 PM
jpienaar closed D99300: [mlir] Compare elements directly rather than creating pair first.
Wed, Mar 24, 2:39 PM · Restricted Project
jpienaar requested review of D99300: [mlir] Compare elements directly rather than creating pair first.
Wed, Mar 24, 2:23 PM · Restricted Project

Tue, Mar 23

jpienaar added a comment to D99197: [MLIR][Shape] Derive more concrete type for `shape.shape_of`.

This seems as expected (capturing what is known in the non-error case when building), I'm surprised no tests needed updating - guessing as we don't have one exercising this builder. Could you perhaps add a small C++ unit test for it?

Tue, Mar 23, 10:58 AM · Restricted Project
jpienaar added a comment to D99143: [ODS] Implement a new 'hasCanonicalizeMethod' bit for cann patterns..

I'd prefer something like

Tue, Mar 23, 7:40 AM · Restricted Project

Mon, Mar 22

jpienaar requested review of D99133: [mlir] Add alias for input to shaped type op interface.
Mon, Mar 22, 7:29 PM · Restricted Project
jpienaar accepted D98986: [mlir][Pattern] Add better support for using interfaces/traits to match root operations in rewrite patterns.

Nice, thanks

Mon, Mar 22, 5:30 PM · Restricted Project
jpienaar added a comment to D98986: [mlir][Pattern] Add better support for using interfaces/traits to match root operations in rewrite patterns.

Nice, any performance tests you did?

Mon, Mar 22, 5:25 PM · Restricted Project
jpienaar added inline comments to D99007: Add a mechanism for Dialects to customize printing/parsing operations when they are unregistered.
Mon, Mar 22, 3:26 PM · Restricted Project
jpienaar committed rGcec244354bb1: Fix the order of directives and the target string (authored by Chia-hungDuan).
Fix the order of directives and the target string
Mon, Mar 22, 11:10 AM
jpienaar closed D99060: Fix the order of directives and the target string.
Mon, Mar 22, 11:10 AM · Restricted Project
jpienaar accepted D99060: Fix the order of directives and the target string.

Good catch

Mon, Mar 22, 6:22 AM · Restricted Project

Sun, Mar 21

jpienaar added a comment to D99047: Fix toy language example.

Did https://github.com/llvm/llvm-project/commit/113baa2b9fd3c8db30d33ecc3f068af48dcce52d address this?

Sun, Mar 21, 6:54 PM · Restricted Project
jpienaar committed rG113baa2b9fd3: Update examples post OwningRewritePatternList change (authored by jpienaar).
Update examples post OwningRewritePatternList change
Sun, Mar 21, 3:22 PM
jpienaar accepted D99039: [PatternMatching] Add convenience insert method to OwningRewritePatternList. NFC..

LG, thanks

Sun, Mar 21, 1:03 PM · Restricted Project
jpienaar accepted D99025: Change the default value for `preloadDialectsInContext` for MlirOptMain.

Thanks!

Sun, Mar 21, 1:01 PM · Restricted Project
jpienaar removed a reviewer for D99028: Change OwningRewritePatternList to carry an MLIRContext with it.: jpienaar.

Looks like a nice cleanup, I see:

Sun, Mar 21, 1:00 PM · Restricted Project

Fri, Mar 19

jpienaar accepted D97887: [mlir] Enhance InferShapedTypeOpInterface and move LinalgOps to use them..

LG to me interface wise modulo some ergonomics and questions others have there. Thanks!

Fri, Mar 19, 10:16 AM · Restricted Project

Wed, Mar 17

jpienaar added a comment to D97887: [mlir] Enhance InferShapedTypeOpInterface and move LinalgOps to use them..

I have not yet dug into the guts of the discussion and the implementation details, I'll just comment on 2 things:

There was push back against using OpFoldResult instead of Value. From experience the use of OpFoldResult is really important.

Where it makes sense, it is crucial to move towards a ValueOrAttr abstraction rather than stay stuck in Value land.
Maybe it does not (yet?) make sense for the Shape world and that is perfectly fine.

Wed, Mar 17, 1:24 PM · Restricted Project

Tue, Mar 16

jpienaar accepted D98473: [mlir][AttrTypeDefGen] Add support for custom parameter comparators.
Tue, Mar 16, 12:40 PM · Restricted Project

Mar 10 2021

jpienaar accepted D95723: [mlir][PDL] Add support for variadic operands and results in the PDL byte code.

I'll probably need to go through these again later, but looks good from check and can be refined later.

Mar 10 2021, 10:12 AM · Restricted Project
jpienaar accepted D95722: [mlir][PDL] Add support for variadic operands and results in the PDL Interpreter.
Mar 10 2021, 10:06 AM · Restricted Project
jpienaar accepted D95721: [mlir][PDL] Add support for variadic operands and results in PDL.

Nice, thanks

Mar 10 2021, 9:59 AM · Restricted Project
jpienaar accepted D95720: [mlir][pdl] Remove CreateNativeOp in favor of a more general ApplyNativeRewriteOp..
Mar 10 2021, 9:54 AM · Restricted Project
jpienaar accepted D95719: [mlir][pdl] Restructure how results are represented..
Mar 10 2021, 9:45 AM · Restricted Project

Mar 9 2021

jpienaar accepted D98309: [mlir] Optimize the implementation of RegionDCE.
Mar 9 2021, 6:22 PM · Restricted Project
jpienaar accepted D93085: Add a mechanism for Dialects to provide a fallback for OpInterface.

Nice, thanks

Mar 9 2021, 5:34 PM · Restricted Project
jpienaar added a comment to D97887: [mlir] Enhance InferShapedTypeOpInterface and move LinalgOps to use them..

Adding Stephan as I'll be OOO

Mar 9 2021, 2:39 PM · Restricted Project
jpienaar added a reviewer for D97887: [mlir] Enhance InferShapedTypeOpInterface and move LinalgOps to use them.: herhut.
Mar 9 2021, 2:38 PM · Restricted Project
jpienaar added inline comments to D97887: [mlir] Enhance InferShapedTypeOpInterface and move LinalgOps to use them..
Mar 9 2021, 2:38 PM · Restricted Project
jpienaar accepted D98290: [mlir][IR] Add an Operation::eraseOperands that supports batch erasure.

Nice, thanks

Mar 9 2021, 1:25 PM · Restricted Project

Mar 8 2021

jpienaar added inline comments to D97887: [mlir] Enhance InferShapedTypeOpInterface and move LinalgOps to use them..
Mar 8 2021, 10:17 AM · Restricted Project
jpienaar accepted D98177: [mlir][Shape] Allow shape.split_at to return extent tensors and lower it to std.subtensor.
Mar 8 2021, 7:18 AM · Restricted Project
jpienaar added inline comments to D98162: Switch generatedTypeParser/generatedAttributeParser to return an OptionalParseResult.
Mar 8 2021, 6:29 AM · Restricted Project

Mar 5 2021

jpienaar accepted D98071: [mlir][IR] Add a new SymbolUserMap class.

Thanks this will help a lot :)

Mar 5 2021, 3:36 PM · Restricted Project
jpienaar accepted D98074: Fix Dialect doc generation to special case for the Builtin dialect empty name.

Thanks :)

Mar 5 2021, 1:44 PM · Restricted Project
jpienaar added a comment to D97622: [mlir] Add OpAdaptorVerifier trait.

Is there more planned here? Seems like uses of this trait right now will result in double verification + double code size?

Mar 5 2021, 8:18 AM · Restricted Project

Mar 4 2021

jpienaar updated the diff for D97622: [mlir] Add OpAdaptorVerifier trait.

Added heading and expanded comment

Mar 4 2021, 9:04 PM · Restricted Project
jpienaar accepted D97980: [mlir][AsmPrinter] Don't use string comparison when filtering list attributes.
Mar 4 2021, 2:18 PM · Restricted Project
jpienaar requested review of D97972: Add quiet mode for mlir-opt.
Mar 4 2021, 12:15 PM · Restricted Project
jpienaar accepted D97900: [mlir] Add a DialectAsmParser::getChecked method.

Nice improvement, thanks

Mar 4 2021, 5:24 AM · Restricted Project

Mar 3 2021

jpienaar added inline comments to D97900: [mlir] Add a DialectAsmParser::getChecked method.
Mar 3 2021, 9:10 PM · Restricted Project
jpienaar added a comment to D97887: [mlir] Enhance InferShapedTypeOpInterface and move LinalgOps to use them..

It's fine to have these separate for review, but please merge to avoid updating the interface in two consecutive changes where one undos part of the previous

Mar 3 2021, 6:46 PM · Restricted Project
jpienaar added a comment to D97839: [mlir][ODS] Get rid of limitations in rewriters generator.

Nice!

Mar 3 2021, 6:50 AM · Restricted Project

Mar 2 2021

jpienaar added a comment to D93085: Add a mechanism for Dialects to provide a fallback for OpInterface.

I forget, what was River's suggestion to make this more efficient?

There wasn't an efficiency aspect left, the idea River had was about generating a different base class with TableGen so that the subclass implementation for the interface fallback could be friendlier to write.

Mar 2 2021, 7:14 PM · Restricted Project
jpienaar accepted D97804: [mlir][IR] Refactor the internal implementation of Value.

Thanks!

Mar 2 2021, 4:36 PM · Restricted Project
jpienaar accepted D97804: [mlir][IR] Refactor the internal implementation of Value.

Nice, thanks for the super fast improvement!

Mar 2 2021, 2:03 PM · Restricted Project
jpienaar added a comment to D97390: [mlir][ODS] Use StringLiteral instead of StringRef when applicable.

Is this something that we want to make a convention, then we'd want to then capture in https://mlir.llvm.org/getting_started/DeveloperGuide/ (I don't believe it is a LLVM convention)

Mar 2 2021, 9:31 AM · Restricted Project
jpienaar accepted D97728: [mlir][Shape] Make shape_eq nary.

LGTM, I'll leave more to Tres who knows these better

Mar 2 2021, 8:50 AM · Restricted Project
jpienaar added inline comments to D97716: [mlir][Shape] Make cstr_eq more like cstr_broadcastable.
Mar 2 2021, 8:43 AM · Restricted Project
jpienaar accepted D97716: [mlir][Shape] Make cstr_eq more like cstr_broadcastable.
Mar 2 2021, 8:43 AM · Restricted Project

Mar 1 2021

jpienaar updated subscribers of D97652: Remove use of tuple for multi-result operation result type storage.

Thanks, reverted,

Mar 1 2021, 10:40 AM · Restricted Project
jpienaar added a reverting change for rG08f0764ff551: Remove use of tuple for multiresult type storage: rG87e05eb03b1b: Revert "Remove use of tuple for multiresult type storage".
Mar 1 2021, 10:40 AM
jpienaar committed rG87e05eb03b1b: Revert "Remove use of tuple for multiresult type storage" (authored by jpienaar).
Revert "Remove use of tuple for multiresult type storage"
Mar 1 2021, 10:40 AM
jpienaar added a reverting change for D97652: Remove use of tuple for multi-result operation result type storage: rG87e05eb03b1b: Revert "Remove use of tuple for multiresult type storage".
Mar 1 2021, 10:40 AM · Restricted Project
jpienaar committed rG08f0764ff551: Remove use of tuple for multiresult type storage (authored by jpienaar).
Remove use of tuple for multiresult type storage
Mar 1 2021, 9:31 AM
jpienaar closed D97652: Remove use of tuple for multi-result operation result type storage.
Mar 1 2021, 9:31 AM · Restricted Project
jpienaar added a comment to D97652: Remove use of tuple for multi-result operation result type storage.

I know River had a better/alternate approach in mind here too

Mar 1 2021, 5:38 AM · Restricted Project
jpienaar updated the diff for D97652: Remove use of tuple for multi-result operation result type storage.

Only access union element that was set for case

Mar 1 2021, 5:30 AM · Restricted Project
jpienaar committed rG2f0b4db5ea52: [mlir] Add convenience grouping for tensor type inference (authored by jpienaar).
[mlir] Add convenience grouping for tensor type inference
Mar 1 2021, 5:21 AM
jpienaar closed D97636: [mlir] Add convenience trait grouping for tensor shaped type inference.
Mar 1 2021, 5:21 AM · Restricted Project

Feb 28 2021

jpienaar requested review of D97652: Remove use of tuple for multi-result operation result type storage.
Feb 28 2021, 6:23 PM · Restricted Project
jpienaar accepted D95718: [mlir][pdl][NFC] Rename InputOp to OperandOp.
Feb 28 2021, 2:21 PM · Restricted Project
jpienaar accepted D95717: [mlir][pdl] Add a new !pdl.range<> type.
Feb 28 2021, 2:19 PM · Restricted Project
jpienaar requested review of D97636: [mlir] Add convenience trait grouping for tensor shaped type inference.
Feb 28 2021, 9:55 AM · Restricted Project

Feb 27 2021

jpienaar requested review of D97622: [mlir] Add OpAdaptorVerifier trait.
Feb 27 2021, 8:32 PM · Restricted Project
jpienaar requested review of D97621: [mlir] Change to requiring location for infer*.
Feb 27 2021, 7:18 PM · Restricted Project
jpienaar committed rGdd2f50a4d051: [mlir] Improve test coverage for print-op-graph (authored by jpienaar).
[mlir] Improve test coverage for print-op-graph
Feb 27 2021, 10:19 AM

Feb 26 2021

jpienaar committed rG91ab48ea6baf: [mlir] Add regions to OpAdaptor (authored by jpienaar).
[mlir] Add regions to OpAdaptor
Feb 26 2021, 4:25 PM
jpienaar closed D97519: [mlir] Add regions to OpAdaptor.
Feb 26 2021, 4:25 PM · Restricted Project
jpienaar added inline comments to D97589: [mlir] Add support for generating Attribute classes for ODS.
Feb 26 2021, 4:16 PM · Restricted Project
jpienaar accepted D93363: Change the error message when `-split-input-file` is used with mlir-opt to make it recognizable by IDEs.
Feb 26 2021, 3:31 PM · Restricted Project
jpienaar requested changes to D97532: [mlir] Enhance InferShapedTypeOpInterface and move LinalgOps to use them..
Feb 26 2021, 3:26 PM · Restricted Project

Feb 25 2021

jpienaar requested review of D97519: [mlir] Add regions to OpAdaptor.
Feb 25 2021, 6:22 PM · Restricted Project

Feb 22 2021

jpienaar accepted D97241: Move the MLIR integration tests as a subdirectory of test (NFC).

So this will avoid that long pause at the end?

Feb 22 2021, 5:13 PM · Restricted Project

Feb 21 2021

jpienaar committed rG04c66edd3251: [mlir] Add simple jupyter kernel (authored by jpienaar).
[mlir] Add simple jupyter kernel
Feb 21 2021, 6:18 PM
jpienaar closed D95742: [mlir] Add simple jupyter kernel.
Feb 21 2021, 6:18 PM · Restricted Project

Feb 20 2021

jpienaar committed rGfa211f3ce9a9: Update test error string post pass registration change (authored by jpienaar).
Update test error string post pass registration change
Feb 20 2021, 3:55 PM
jpienaar committed rG02d7b260c697: [mlir] Register the print-op-graph pass using ODS (authored by jpienaar).
[mlir] Register the print-op-graph pass using ODS
Feb 20 2021, 3:42 PM

Feb 19 2021

jpienaar committed rG3bec7ed59e1b: Different fix for gcc bug (authored by jpienaar).
Different fix for gcc bug
Feb 19 2021, 4:41 PM

Feb 18 2021

jpienaar accepted D95716: [mlir][pdl][NFC] Extract the execution of each bytecode operation into its own function.
Feb 18 2021, 5:12 PM · Restricted Project
jpienaar committed rGd690cbf821f1: Add DivOp to the Shape dialect (authored by Jing).
Add DivOp to the Shape dialect
Feb 18 2021, 4:59 PM
jpienaar closed D96907: Add DivOp to the Shape dialect.
Feb 18 2021, 4:59 PM · Restricted Project