Page MenuHomePhabricator

[flang][openacc] Add clause validity tests for the parallel directive
ClosedPublic

Authored by clementval on Fri, Nov 20, 8:13 AM.

Diff Detail

Event Timeline

clementval created this revision.Fri, Nov 20, 8:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Nov 20, 8:13 AM
clementval requested review of this revision.Fri, Nov 20, 8:13 AM
clementval edited the summary of this revision. (Show Details)Fri, Nov 20, 8:41 AM
clementval added a project: Restricted Project.
sameeranjoshi accepted this revision.Fri, Nov 20, 9:43 AM

IIUC, the rational for adding these tests was to just add clauses which might be missing from the list of AccClause ?

This revision is now accepted and ready to land.Fri, Nov 20, 9:43 AM
clementval added a comment.EditedFri, Nov 20, 10:22 AM

IIUC, the rational for adding these tests was to just add clauses which might be missing from the list of AccClause ?

Thanks for the review! I'm currently passing on all directive and make sure that all accepted clauses are actually accepted and restrictions are in place correctly. In this case, ACC.td and the sema restrictions were correct already but just wanted to make sure to add those tests to avoid future regression.