Page MenuHomePhabricator

sameeranjoshi (sameeran joshi)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 14 2020, 10:41 AM (24 w, 1 d)

Recent Activity

Today

sameeranjoshi requested review of D88556: [Flang][OpenMP] Fix issue in only a single nowait clause can appear on a sections directive..
Wed, Sep 30, 4:51 AM · Restricted Project

Mon, Sep 28

sameeranjoshi updated the diff for D87906: [Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct..

Worked on below points:

  1. Moved some helper functions to tools.h which can be shared between OpenMP/OpenACC and Fortran constructs.
  2. Emit a more better error message.
  3. Added more tests.
  4. Used ConstructStack to check labels.
Mon, Sep 28, 5:44 AM · Restricted Project, Restricted Project

Thu, Sep 24

sameeranjoshi added inline comments to D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend.
Thu, Sep 24, 11:31 AM · Restricted Project
sameeranjoshi added a comment to D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend.

@sameeranjoshi Apologies, I missed some of your comments.

Thanks for working on it.
Few comments inline:

  1. For an out-of-tree build, I see check-flang target failing with
/unittests/Frontend/CompilerInstanceTest.cpp:17:10: fatal error: filesystem: No such file or directory
 #include <filesystem>
          ^~~~~~~~~~~~

I used gcc/g++ 7.5 version.
I haven't checked in-tree still, and others/bots might have checked it.

I haven't been able to reproduce it, but note that filesystem is a C++17 header. AFAIK, in GCC-7 you have to use <experimental/filesystem> instead of <filesystem>. This suggests README.md should be updated: https://github.com/llvm/llvm-project/blob/master/flang/README.md#supported-c-compilers (we probably need an RFC for this). Since this #include was introduced elsewhere, I suggest that we move this discussion either to Slack or flang-dev.

Thu, Sep 24, 11:26 AM · Restricted Project
sameeranjoshi added inline comments to D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend.
Thu, Sep 24, 11:23 AM · Restricted Project

Wed, Sep 23

sameeranjoshi accepted D88108: [flang][driver] Fix options flang in the frontend driver.
Wed, Sep 23, 7:16 AM · Restricted Project
sameeranjoshi accepted D88110: [flang][driver] Add missing dependency in CMake files.
Wed, Sep 23, 7:16 AM · Restricted Project

Tue, Sep 22

sameeranjoshi added a comment to D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend.

Thanks for working on it.
Few comments inline:

Tue, Sep 22, 8:40 AM · Restricted Project

Mon, Sep 21

sameeranjoshi added inline comments to D87906: [Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct..
Mon, Sep 21, 8:10 AM · Restricted Project, Restricted Project
sameeranjoshi updated the diff for D87906: [Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct..

Worked on review comments.

Mon, Sep 21, 6:53 AM · Restricted Project, Restricted Project

Fri, Sep 18

sameeranjoshi requested review of D87906: [Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct..
Fri, Sep 18, 7:46 AM · Restricted Project, Restricted Project

Wed, Sep 16

sameeranjoshi added a comment to D87270: [Flang] Add GettingInvolved documentation page and sidebar..

@sameeranjoshi I see this merged but I don't see any changes to the sidebar in my local build.

Wed, Sep 16, 12:51 AM · Restricted Project

Tue, Sep 15

sameeranjoshi updated the diff for D87270: [Flang] Add GettingInvolved documentation page and sidebar..

Update with changes.

Tue, Sep 15, 1:00 AM · Restricted Project

Sun, Sep 13

sameeranjoshi added inline comments to D87270: [Flang] Add GettingInvolved documentation page and sidebar..
Sun, Sep 13, 10:44 PM · Restricted Project
sameeranjoshi updated the diff for D87270: [Flang] Add GettingInvolved documentation page and sidebar..
Sun, Sep 13, 9:48 PM · Restricted Project

Fri, Sep 11

sameeranjoshi accepted D87242: [flang] Add new documentation main page.
Fri, Sep 11, 6:08 AM · Restricted Project
sameeranjoshi added a comment to D87242: [flang] Add new documentation main page.

Thanks ! Builds and pages Look good.

Fri, Sep 11, 5:27 AM · Restricted Project

Thu, Sep 10

sameeranjoshi added a comment to D87242: [flang] Add new documentation main page.

The TOC tree is displayed in the right indexsidebar, if it could be displayed at the top (see http://llvm.org/docs/CMake.html for reference) of individual pages that would be better and it would help reader initially to navigate to the internal section in the respective page.
Further I went on to apply D87226(contains a fixed side bar index links ) and the TOC disappears probably due to above mentioned issue.

Can you help me understand what you mean here? When I build the pages they look like this to me:

Compare that to the reference page you linked me to (same browser, same computer):

I don't see a difference in the two for style. Both seem to have previous | next | index links in the top (and bottom) bars, as well as the indexsidebar as you point out. The indexsidebar seems to be a standard default from sphinx. LLVM uses a special one in llvm/docs/_templates/indexsidebar.html which does not have the previous/next topic links and instead has the permalinks to other articles.

Thu, Sep 10, 12:08 PM · Restricted Project

Wed, Sep 9

sameeranjoshi added a comment to D86131: [FLANG] Pick `.md` files when building sphinx documentation..

Hi @hans
The problem here is the version of recommonmark.
We strictly need version 0.5.0 or above.
See the note at https://www.sphinx-doc.org/en/master/usage/markdown.html#configuration
and https://github.com/llvm/llvm-project/blob/0fd425af071a9bc5c0891a4db09f4d9a466b7be9/flang/docs/conf.py#L44

Wed, Sep 9, 4:31 AM · Restricted Project, Restricted Project

Tue, Sep 8

sameeranjoshi added a comment to D87242: [flang] Add new documentation main page.

The web-pages seem to work properly for me with below configurations.

Name: sphinx-markdown-tables
Version: 0.0.15
Name: recommonmark
Version: 0.6.0
Tue, Sep 8, 10:32 AM · Restricted Project

Mon, Sep 7

sameeranjoshi requested review of D87270: [Flang] Add GettingInvolved documentation page and sidebar..
Mon, Sep 7, 10:14 PM · Restricted Project
sameeranjoshi updated subscribers of D87242: [flang] Add new documentation main page.

I have a GettingInvolved.md can you include it as well if it makes sense to add it with this patch and the original authors agree.
Most of the content comes from mailing list meeting minutes from Gary(Thanks @gak).

Mon, Sep 7, 11:53 AM · Restricted Project
sameeranjoshi accepted D87226: [flang] Convert release notes to markdown.

Thanks for revisiting this.

Mon, Sep 7, 11:18 AM · Restricted Project
sameeranjoshi accepted D82931: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0.
Mon, Sep 7, 10:52 AM · Restricted Project, Restricted Project

Aug 31 2020

sameeranjoshi added a comment to D86875: [Flang][NFC] Remove license comments from files in docs/ folder..

Why?

Aug 31 2020, 8:03 AM · Restricted Project
sameeranjoshi requested review of D86875: [Flang][NFC] Remove license comments from files in docs/ folder..
Aug 31 2020, 6:12 AM · Restricted Project
sameeranjoshi accepted D86089: [flang][driver]Add experimental flang driver and frontend with help screen.

Thank you for changes.
I was able to build successfully out-of-tree.
Please update the README.md with the necessary changes.

Aug 31 2020, 4:14 AM · Restricted Project, Restricted Project, Restricted Project

Aug 22 2020

sameeranjoshi added a comment to D86131: [FLANG] Pick `.md` files when building sphinx documentation..

Thanks @sscalpone, this issue was mentioned long back during the doxygen related patches.
llvm, mlir and might be other projects in tree seem to show the same issue.
https://reviews.llvm.org/D78136#1987218

Aug 22 2020, 10:31 AM · Restricted Project, Restricted Project

Aug 21 2020

sameeranjoshi requested changes to D86089: [flang][driver]Add experimental flang driver and frontend with help screen.

Thanks for working on it.
A few review comments/questions on changes in flang part from the patch.

Aug 21 2020, 11:24 AM · Restricted Project, Restricted Project, Restricted Project

Aug 20 2020

sameeranjoshi added a comment to D86089: [flang][driver]Add experimental flang driver and frontend with help screen.

Thanks for the work.

Aug 20 2020, 1:30 PM · Restricted Project, Restricted Project, Restricted Project

Aug 19 2020

sameeranjoshi updated the diff for D86131: [FLANG] Pick `.md` files when building sphinx documentation..

Thanks @kiranchandramohan.
Updated diff.

Aug 19 2020, 1:22 AM · Restricted Project, Restricted Project

Aug 18 2020

sameeranjoshi updated the diff for D86131: [FLANG] Pick `.md` files when building sphinx documentation..

Address review comments.
For viewing on github
https://github.com/Sameeranjoshi/llvm-project/tree/arcpatch-D86131/flang

Aug 18 2020, 12:47 PM · Restricted Project, Restricted Project
sameeranjoshi abandoned D85828: [Flang] Move mark down documentation(md) files to reStructuredText(rst) file format..

Sphinx support for .md files.
https://reviews.llvm.org/D86131

Aug 18 2020, 3:31 AM · Restricted Project
sameeranjoshi added a project to D86131: [FLANG] Pick `.md` files when building sphinx documentation.: Restricted Project.
Aug 18 2020, 3:29 AM · Restricted Project, Restricted Project
sameeranjoshi updated the summary of D86131: [FLANG] Pick `.md` files when building sphinx documentation..
Aug 18 2020, 3:29 AM · Restricted Project, Restricted Project
sameeranjoshi requested review of D86131: [FLANG] Pick `.md` files when building sphinx documentation..
Aug 18 2020, 3:28 AM · Restricted Project, Restricted Project

Aug 17 2020

sameeranjoshi updated the diff for D85884: [Flang] Move markdown files(.MD) from documentation/ to docs/.

Fix review comments.

Aug 17 2020, 11:10 AM · Restricted Project
sameeranjoshi added a comment to D85884: [Flang] Move markdown files(.MD) from documentation/ to docs/.

I think you missed one.

Aug 17 2020, 4:45 AM · Restricted Project

Aug 13 2020

sameeranjoshi added a comment to D85828: [Flang] Move mark down documentation(md) files to reStructuredText(rst) file format..

Thanks for detailed information @mehdi_amini and all folks.
TL;DR version:
There is a sweet spot on this issue.
Sphinx supports now .md files.
LLVM has as well added changes in config files to pick up .md files, needs to extend this to flang.

Aug 13 2020, 10:43 AM · Restricted Project
sameeranjoshi added a comment to D85884: [Flang] Move markdown files(.MD) from documentation/ to docs/.

The docs still render on github.
See a more friendly version below.
https://github.com/Sameeranjoshi/llvm-project/tree/sam-move-md-to-docs/flang/docs

Aug 13 2020, 2:12 AM · Restricted Project
sameeranjoshi requested review of D85884: [Flang] Move markdown files(.MD) from documentation/ to docs/.
Aug 13 2020, 2:09 AM · Restricted Project

Aug 12 2020

sameeranjoshi added a comment to D85828: [Flang] Move mark down documentation(md) files to reStructuredText(rst) file format..

I still see a few mentions of the old documentation dir location in the codebase:

llvm-project/flang$ git grep 'documentation/' .
README.md:Start with the [compiler overview](documentation/Overview.md).
README.md:read [Fortran For C Programmers](documentation/FortranForCProgrammers.md)
README.md:flang's specifications of the [Fortran grammar](documentation/f2018-grammar.txt)
README.md:the [OpenMP grammar](documentation/OpenMP-4.5-grammar.txt).
README.md:in [this document](documentation/Extensions.md).
README.md:see the [discussion of intrinsics](documentation/Intrinsics.md).
README.md:see the discussion of [runtime descriptors](documentation/RuntimeDescriptor.md).
README.md:read the [style guide](documentation/C++style.md)
README.md:also review [how flang uses modern C++ features](documentation/C++17.md).
docs/Character.rst:   <!--===- documentation/Character.rst
docs/OpenMP-4.5-grammar.txt:#===-- documentation/OpenMP-4.5-grammar.txt --------------------------------===#
docs/f2018-grammar.txt:#===-- documentation/f2018-grammar.txt -------------------------------------===#
docs/flang-c-style.el:;;===-- documentation/flang-c-style.el ------------------------------------===;;
lib/Evaluate/intrinsics.cpp:// documentation/intrinsics.md and section 16 of the Fortran 2018 standard
Aug 12 2020, 11:48 AM · Restricted Project
sameeranjoshi added a comment to D85828: [Flang] Move mark down documentation(md) files to reStructuredText(rst) file format..

+1 @DavidTruby - For pointing the reason for MLIR to use .md files.
It's correct that LLVM uses Sphinx infrastructure to build docs for any sub-project except MLIR.

Aug 12 2020, 11:47 AM · Restricted Project
sameeranjoshi updated the diff for D85828: [Flang] Move mark down documentation(md) files to reStructuredText(rst) file format..

To ease in reviewing the output of files when merged in llvm-project.
I have pushed in my local fork of llvm-project.
https://github.com/Sameeranjoshi/llvm-project/blob/sam-docu-rst/flang/

Aug 12 2020, 4:56 AM · Restricted Project
sameeranjoshi requested review of D85828: [Flang] Move mark down documentation(md) files to reStructuredText(rst) file format..
Aug 12 2020, 4:51 AM · Restricted Project

Aug 11 2020

sameeranjoshi updated the diff for D85470: [Flang] Fix release blocker issue #46931 related to documentation. .

Updated copyright year.

Aug 11 2020, 4:53 AM · Restricted Project

Aug 8 2020

sameeranjoshi added reviewers for D85470: [Flang] Fix release blocker issue #46931 related to documentation. : bero, rovka.
Aug 8 2020, 9:52 AM · Restricted Project

Aug 7 2020

sameeranjoshi added a reviewer for D85470: [Flang] Fix release blocker issue #46931 related to documentation. : tskeith.
Aug 7 2020, 10:32 AM · Restricted Project
sameeranjoshi added a comment to D85470: [Flang] Fix release blocker issue #46931 related to documentation. .

Sticking to llvm style sounds good. But as soon as it is changed in llvm we won't match the llvm style any more. Does clang have copies like this too?

I believe clang uses some cmake infrastructure to get doxygen and sphinx to pick up the theming stuff from LLVM. I at least can't see copies in clang.

Aug 7 2020, 7:54 AM · Restricted Project
sameeranjoshi added a comment to D85470: [Flang] Fix release blocker issue #46931 related to documentation. .

Thanks for adding all this infrastructure!
I don't see any CMake changes here though, where is the new flag added?

Aug 7 2020, 7:35 AM · Restricted Project
sameeranjoshi added a comment to D85470: [Flang] Fix release blocker issue #46931 related to documentation. .

Why do you need to copy files from llvm?

Aug 7 2020, 12:38 AM · Restricted Project

Aug 6 2020

sameeranjoshi updated the summary of D85470: [Flang] Fix release blocker issue #46931 related to documentation. .
Aug 6 2020, 11:05 PM · Restricted Project
sameeranjoshi added a comment to D84864: [flang] Add release notes for LLVM 11 release.

No objection to first moving documentation to docs. If someone takes this on, there are links that need to be updated, relatively in the project and in for example Gary's call notes.

Aug 6 2020, 1:06 PM · Restricted Project
sameeranjoshi added a comment to D84864: [flang] Add release notes for LLVM 11 release.

Thanks @richard.barton.arm I just noticed this revision from the flang-dev thread you commented today.
Take a look at the review at https://reviews.llvm.org/D85470

Aug 6 2020, 1:03 PM · Restricted Project
sameeranjoshi added inline comments to D85470: [Flang] Fix release blocker issue #46931 related to documentation. .
Aug 6 2020, 1:02 PM · Restricted Project
sameeranjoshi retitled D85470: [Flang] Fix release blocker issue #46931 related to documentation. from [Flang] Support for sphinx builds. Fix release blocker issue #46931 related to documentation. This commit add a new flag `-DLLVM_ENABLE_SPHINX=ON` to cmake command to generate sphinx documentation, along with new targets `docs-flang-html` and... to [Flang] Fix release blocker issue #46931 related to documentation. .
Aug 6 2020, 1:00 PM · Restricted Project
sameeranjoshi requested review of D85470: [Flang] Fix release blocker issue #46931 related to documentation. .
Aug 6 2020, 12:55 PM · Restricted Project

Jul 31 2020

sameeranjoshi added a comment to D84290: [Flang] Fix for the scenario when type guard has intrinsic type specification and Selector is NOT unlimited Polymorphic..

Thanks for working @inderjeet-hcl. Do let us know if you still see any issues in committing changes.

Jul 31 2020, 11:26 AM · Restricted Project, Restricted Project
sameeranjoshi updated the diff for D84504: [flang]Verify C7107, C7108, C7109 from - Clause 7 constraint checks for f18..

Changes in commit message for using arc.

Jul 31 2020, 11:14 AM · Restricted Project, Restricted Project
sameeranjoshi added a comment to D85014: [Flang] Checks for constraint C7110-C7115..

@PeteSteinfeld I see that I have no access to move it.

Jul 31 2020, 10:36 AM · Restricted Project
sameeranjoshi updated the diff for D85014: [Flang] Checks for constraint C7110-C7115..

Upstream comments addressed.

Jul 31 2020, 10:12 AM · Restricted Project
sameeranjoshi requested review of D85014: [Flang] Checks for constraint C7110-C7115..
Jul 31 2020, 3:14 AM · Restricted Project

Jul 28 2020

sameeranjoshi accepted D84290: [Flang] Fix for the scenario when type guard has intrinsic type specification and Selector is NOT unlimited Polymorphic..

I can build and test successfully.
I have verified bugs Bug 46789 & Bug 46830.
Please wait for a day before you commit until other reviewers accept it.

Jul 28 2020, 2:02 AM · Restricted Project, Restricted Project

Jul 27 2020

sameeranjoshi added inline comments to D84290: [Flang] Fix for the scenario when type guard has intrinsic type specification and Selector is NOT unlimited Polymorphic..
Jul 27 2020, 10:53 PM · Restricted Project, Restricted Project
sameeranjoshi updated the summary of D84504: [flang]Verify C7107, C7108, C7109 from - Clause 7 constraint checks for f18..
Jul 27 2020, 9:44 AM · Restricted Project, Restricted Project
sameeranjoshi updated the diff for D84504: [flang]Verify C7107, C7108, C7109 from - Clause 7 constraint checks for f18..

Revert to older message.

Jul 27 2020, 9:42 AM · Restricted Project, Restricted Project
sameeranjoshi added inline comments to D84290: [Flang] Fix for the scenario when type guard has intrinsic type specification and Selector is NOT unlimited Polymorphic..
Jul 27 2020, 9:25 AM · Restricted Project, Restricted Project
sameeranjoshi added a comment to D84290: [Flang] Fix for the scenario when type guard has intrinsic type specification and Selector is NOT unlimited Polymorphic..

Thank you for working !
This patch builds successfully but fails for check-flang for me.

Jul 27 2020, 4:19 AM · Restricted Project, Restricted Project

Jul 24 2020

sameeranjoshi updated the diff for D84504: [flang]Verify C7107, C7108, C7109 from - Clause 7 constraint checks for f18..

Add missing constraint number in sources.

Jul 24 2020, 11:11 AM · Restricted Project, Restricted Project
sameeranjoshi updated the diff for D84504: [flang]Verify C7107, C7108, C7109 from - Clause 7 constraint checks for f18..

Address review comments.

Jul 24 2020, 11:04 AM · Restricted Project, Restricted Project
sameeranjoshi added inline comments to D84504: [flang]Verify C7107, C7108, C7109 from - Clause 7 constraint checks for f18..
Jul 24 2020, 4:20 AM · Restricted Project, Restricted Project
Herald added a reviewer for D84504: [flang]Verify C7107, C7108, C7109 from - Clause 7 constraint checks for f18.: DavidTruby.
Jul 24 2020, 3:13 AM · Restricted Project, Restricted Project
Herald added a project to D84503: [flang][NFC] Verify C781 from - Clause 7 constraint checks for f18.: Restricted Project.
Jul 24 2020, 3:03 AM · Restricted Project, Restricted Project

Jul 22 2020

sameeranjoshi added inline comments to D84290: [Flang] Fix for the scenario when type guard has intrinsic type specification and Selector is NOT unlimited Polymorphic..
Jul 22 2020, 5:51 AM · Restricted Project, Restricted Project
sameeranjoshi accepted D83946: [flang] Run non-gtest unit tests with lit..
Jul 22 2020, 4:17 AM · Restricted Project
sameeranjoshi retitled D84290: [Flang] Fix for the scenario when type guard has intrinsic type specification and Selector is NOT unlimited Polymorphic. from Fix for the scenario when type guard has intrinsic type specification and Selector is NOT unlimited Polymorphic. to [Flang] Fix for the scenario when type guard has intrinsic type specification and Selector is NOT unlimited Polymorphic..
Jul 22 2020, 3:01 AM · Restricted Project, Restricted Project
sameeranjoshi added a comment to D84290: [Flang] Fix for the scenario when type guard has intrinsic type specification and Selector is NOT unlimited Polymorphic..

You could have reduced the effort of writing summary, by just pointing to the bugzilla issue.

Jul 22 2020, 3:01 AM · Restricted Project, Restricted Project
sameeranjoshi added a comment to D84290: [Flang] Fix for the scenario when type guard has intrinsic type specification and Selector is NOT unlimited Polymorphic..

Additional compilation error will come in selecttype01.f90 and symbol11.f90 test cases and it is expected with the patch. Also I am uploading patch file to add "RUN: line" in newly added test case selecttype04.f90.

  1. selecttype01.f90: Addition error will come at line 122 and 130 selecttype01.f90:122:3: error: If selector is not Unlimited Polymorphic, intrinsic type specification must not be specified in type guard statement type is (integer) ^^^^^^^^^^^^^^^^^

    selecttype01.f90:130:3: error: If selector is not Unlimited Polymorphic, intrinsic type specification must not be specified in type guard statement type is (integer) ^^^^^^^^^^^^^^^^^
  1. symbol11.f90: Addition error will come at line 74.

symbol11.f90:74:3: error: If selector is not Unlimited Polymorphic, intrinsic type specification must not be specified in type guard statement

type is (integer(kind=8))
^^^^^^^^^^^^^^^^^^^^^^^^^

Thank you for finding this! Some comments below:

Jul 22 2020, 2:58 AM · Restricted Project, Restricted Project

Jun 21 2020

orequest <Osi.Request@amd.com> committed rGfa5d416efdcb: [flang]Fix individual tests with lit when building out of tree (authored by sameeranjoshi).
[flang]Fix individual tests with lit when building out of tree
Jun 21 2020, 10:13 PM
sameeranjoshi closed D82120: [flang]Fix individual tests with lit when building out of tree.
Jun 21 2020, 10:13 PM · Restricted Project, Restricted Project

Jun 18 2020

sameeranjoshi added a comment to D81002: Fix individual tests with lit when building out of tree.

I have created another revision, as I tried updating the current revision but couldn't.
https://reviews.llvm.org/D82120
@CarolineConcatto thanks for pointing the issue and working on it.

Jun 18 2020, 1:09 PM · Restricted Project
sameeranjoshi updated the summary of D82120: [flang]Fix individual tests with lit when building out of tree.
Jun 18 2020, 1:08 PM · Restricted Project, Restricted Project
sameeranjoshi created D82120: [flang]Fix individual tests with lit when building out of tree.
Jun 18 2020, 1:06 PM · Restricted Project, Restricted Project

Jun 16 2020

sameeranjoshi accepted D81764: [flang] Add the Mangler module to flang lowering.

Rebase and update with the functional unittest.

Jun 16 2020, 1:12 PM · Restricted Project, Restricted Project
sameeranjoshi abandoned D79851: [Flang] Semantics for SELECT TYPE.
Jun 16 2020, 7:09 AM · Restricted Project, Restricted Project
sameeranjoshi added a comment to D79851: [Flang] Semantics for SELECT TYPE.

Merged by this commit
https://github.com/llvm/llvm-project/commit/70ad73b6b76838bd7c72123922102b175e5d478a

Jun 16 2020, 7:09 AM · Restricted Project, Restricted Project

Jun 15 2020

sameeranjoshi added a comment to D81764: [flang] Add the Mangler module to flang lowering.

Unit tests on internal naming don't have that dependency. But they do have a dependency on the fixes included in this patch.

Jun 15 2020, 10:23 AM · Restricted Project, Restricted Project
sameeranjoshi added a comment to D81764: [flang] Add the Mangler module to flang lowering.

If @sameeranjoshi can land the unit test patch, maybe we can have some unit tests.

Jun 15 2020, 10:23 AM · Restricted Project, Restricted Project
Sameeran joshi <joshisameeran17@gmail.com> committed rG93f602b339f6: [flang] unit test support for out-of-tree and in-tree using google tests… (authored by sameeranjoshi).
[flang] unit test support for out-of-tree and in-tree using google tests…
Jun 15 2020, 9:50 AM
sameeranjoshi closed D80377: [flang] Google test infrastructure support for unittests.

@isuruf I have set FLANG_INCLUDE_TESTS to ON by default for out-of-tree builds.
If there are still any concerns I can fix in other PR.

Jun 15 2020, 9:47 AM · Restricted Project, Restricted Project
sameeranjoshi updated subscribers of D81764: [flang] Add the Mangler module to flang lowering.

>> But it would probably require some Bridge code. If @sameeranjoshi can land the unit test patch, maybe we can have some unit tests.

Jun 15 2020, 2:41 AM · Restricted Project, Restricted Project

Jun 13 2020

sameeranjoshi added a comment to D81764: [flang] Add the Mangler module to flang lowering.

Will it make sense to add LIT tests(program-units-fir-mangling.f90 in fir-dev) for InternalNames.h with this patch also if any for Mangler.h?
Looks like it was missed in https://reviews.llvm.org/D78838

Jun 13 2020, 10:10 AM · Restricted Project, Restricted Project
sameeranjoshi added inline comments to D80377: [flang] Google test infrastructure support for unittests.
Jun 13 2020, 9:06 AM · Restricted Project, Restricted Project

Jun 12 2020

sameeranjoshi added inline comments to D80377: [flang] Google test infrastructure support for unittests.
Jun 12 2020, 10:45 PM · Restricted Project, Restricted Project
sameeranjoshi updated the diff for D80377: [flang] Google test infrastructure support for unittests.

Formatting issue fixed.

Jun 12 2020, 10:19 AM · Restricted Project, Restricted Project
sameeranjoshi updated the diff for D80377: [flang] Google test infrastructure support for unittests.

@isuruf done.

Jun 12 2020, 10:19 AM · Restricted Project, Restricted Project

Jun 11 2020

Sameeran joshi <joshisameeran17@gmail.com> committed rG70ad73b6b768: [flang] Semantics for SELECT TYPE (authored by sameeranjoshi).
[flang] Semantics for SELECT TYPE
Jun 11 2020, 12:09 PM
sameeranjoshi added a comment to D80377: [flang] Google test infrastructure support for unittests.

@tskeith is that ready to merge?
I have addressed the comments.

Jun 11 2020, 12:07 PM · Restricted Project, Restricted Project
sameeranjoshi updated the diff for D79851: [Flang] Semantics for SELECT TYPE.

Thanks @kiranchandramohan and @PeteSteinfeld for reviewing.
I have addressed them.

Jun 11 2020, 9:19 AM · Restricted Project, Restricted Project

Jun 10 2020

sameeranjoshi updated the diff for D80377: [flang] Google test infrastructure support for unittests.
Jun 10 2020, 11:25 PM · Restricted Project, Restricted Project