Page MenuHomePhabricator

klausler (Peter Klausler)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 9 2020, 11:45 AM (52 w, 3 d)

Recent Activity

Sat, Apr 10

klausler committed rG8f16101c703e: [flang] Accept & fold IEEE_SELECTED_REAL_KIND (authored by klausler).
[flang] Accept & fold IEEE_SELECTED_REAL_KIND
Sat, Apr 10, 10:01 AM
klausler closed D100066: [flang] Accept & fold IEEE_SELECTED_REAL_KIND.
Sat, Apr 10, 10:01 AM · Restricted Project, Restricted Project

Fri, Apr 9

klausler committed rGe11140451b5f: [flang] RANDOM_NUMBER, RANDOM_SEED, RANDOM_INIT in runtime (authored by klausler).
[flang] RANDOM_NUMBER, RANDOM_SEED, RANDOM_INIT in runtime
Fri, Apr 9, 5:03 PM
klausler closed D100064: [flang] RANDOM_NUMBER, RANDOM_SEED, RANDOM_INIT in runtime.
Fri, Apr 9, 5:03 PM · Restricted Project, Restricted Project
klausler added a comment to D100066: [flang] Accept & fold IEEE_SELECTED_REAL_KIND.

ping

Fri, Apr 9, 4:42 PM · Restricted Project, Restricted Project
klausler committed rG5091671c9ba2: [flang] Enforce a limit on recursive PDT instantiations (authored by klausler).
[flang] Enforce a limit on recursive PDT instantiations
Fri, Apr 9, 4:39 PM
klausler closed D100065: [flang] Enforce a limit on recursive PDT instantiations.
Fri, Apr 9, 4:38 PM · Restricted Project, Restricted Project
klausler committed rGb6f22fa5feb6: [flang] Check for conflicting BIND(C) names (authored by klausler).
[flang] Check for conflicting BIND(C) names
Fri, Apr 9, 3:34 PM
klausler closed D100067: [flang] Check for conflicting BIND(C) names.
Fri, Apr 9, 3:33 PM · Restricted Project, Restricted Project
klausler updated the diff for D100066: [flang] Accept & fold IEEE_SELECTED_REAL_KIND.

Remove byte order marks that were inadvertently copied from generated module files for comparison in a new test.

Fri, Apr 9, 1:09 PM · Restricted Project, Restricted Project

Wed, Apr 7

klausler requested review of D100067: [flang] Check for conflicting BIND(C) names.
Wed, Apr 7, 1:25 PM · Restricted Project, Restricted Project
klausler requested review of D100066: [flang] Accept & fold IEEE_SELECTED_REAL_KIND.
Wed, Apr 7, 1:22 PM · Restricted Project, Restricted Project
klausler requested review of D100065: [flang] Enforce a limit on recursive PDT instantiations.
Wed, Apr 7, 1:19 PM · Restricted Project, Restricted Project
klausler requested review of D100064: [flang] RANDOM_NUMBER, RANDOM_SEED, RANDOM_INIT in runtime.
Wed, Apr 7, 1:16 PM · Restricted Project, Restricted Project

Mon, Apr 5

klausler accepted D99892: [flang] Improve constant folding for type parameter inquiries.
Mon, Apr 5, 3:23 PM · Restricted Project, Restricted Project
klausler added a comment to D99892: [flang] Improve constant folding for type parameter inquiries.

Yes, the value of the type parameter is derived from the associated object at the time that the object is instantiated. I believe that the current code is folding the value of the type parameter from the instantiated value. Here's a modified version of your example that illustrates that:

subroutine foo(n)
  type :: t(len)
  integer, len :: len
  end type t

  type(t(n)) :: x1
  real(x1%len) :: r1 ! Error since the KIND of r1 isn't constant
  type(t(4)) :: x2
  real(x2%len) :: r2

  block
    real(x2%len) :: r3 ! OK, the KIND of r3 is x2%len, which is folded to 4
  end block
  n = 99
  block
    real(x2%len) :: r4 ! Still OK, because the x2%len gets folded to 4
  end block
end
Mon, Apr 5, 1:35 PM · Restricted Project, Restricted Project
klausler added inline comments to D99892: [flang] Improve constant folding for type parameter inquiries.
Mon, Apr 5, 11:38 AM · Restricted Project, Restricted Project

Fri, Apr 2

klausler committed rGc115c28914a0: [flang] Address more MSVC build issues with reductions (authored by klausler).
[flang] Address more MSVC build issues with reductions
Fri, Apr 2, 3:01 PM
klausler closed D99806: [flang] Address more MSVC build issues with reduction & numeric intrinsics.
Fri, Apr 2, 3:01 PM · Restricted Project, Restricted Project
klausler added a comment to D99806: [flang] Address more MSVC build issues with reduction & numeric intrinsics.

Thanks

I don't see any other error for now.

Fri, Apr 2, 1:55 PM · Restricted Project, Restricted Project
klausler updated the diff for D99806: [flang] Address more MSVC build issues with reduction & numeric intrinsics.

Two more sites for the previous fix for a MSVC spurious error.

Fri, Apr 2, 1:31 PM · Restricted Project, Restricted Project
klausler updated the diff for D99806: [flang] Address more MSVC build issues with reduction & numeric intrinsics.

Add attempted MSVC work-around to dodge error on "accumulator.template GetResult(...)" in function template.

Fri, Apr 2, 12:31 PM · Restricted Project, Restricted Project
klausler added a comment to D99666: [flang] Implement reductions in the runtime.

@klausler We have a buildbot failing with the following error. https://lab.llvm.org/buildbot/#/builders/33/builds/3439

FAILED: tools/flang/unittests/RuntimeGTest/CMakeFiles/FlangRuntimeTests.dir/Reduction.cpp.o 
/usr/bin/clang++-10  -DGTEST_HAS_RTTI=0 -DGTEST_HAS_TR1_TUPLE=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/flang/unittests/RuntimeGTest -I/home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/llvm-project/flang/unittests/RuntimeGTest -I/home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/llvm-project/flang/include -Itools/flang/include -Iinclude -I/home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/llvm-project/llvm/include -I/home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/llvm-project/llvm/utils/unittest/googletest/include -I/home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/llvm-project/llvm/utils/unittest/googlemock/include -isystem /home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/llvm-project/llvm/../mlir/include -isystem tools/mlir/include -isystem tools/clang/include -isystem /home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/llvm-project/llvm/../clang/include -stdlib=libc++ -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -Werror -Wno-deprecated-copy -Wno-string-conversion -Wno-unused-command-line-argument -Wstring-conversion           -Wcovered-switch-default -Wno-nested-anon-types -O3     -Wno-variadic-macros -Wno-gnu-zero-variadic-macro-arguments -fno-exceptions -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/flang/unittests/RuntimeGTest/CMakeFiles/FlangRuntimeTests.dir/Reduction.cpp.o -MF tools/flang/unittests/RuntimeGTest/CMakeFiles/FlangRuntimeTests.dir/Reduction.cpp.o.d -o tools/flang/unittests/RuntimeGTest/CMakeFiles/FlangRuntimeTests.dir/Reduction.cpp.o -c /home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/llvm-project/flang/unittests/RuntimeGTest/Reduction.cpp
/home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/llvm-project/flang/unittests/RuntimeGTest/Reduction.cpp:25:18: error: no viable conversion from '__bit_iterator<std::__1::vector<bool, std::__1::allocator<bool> >, true>' to 'const void *'
  std::memcpy(p, &x, bytes);
                 ^~
/home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/llvm-project/flang/unittests/RuntimeGTest/Reduction.cpp:49:5: note: in instantiation of function template specialization 'StoreElement<std::__1::__bit_const_reference<std::__1::vector<bool, std::__1::allocator<bool> > > >' requested here
    StoreElement(p, x, elemLen);
    ^
/home/flang/flang-aarch64-ubuntu-clang/flang-aarch64-ubuntu-clang/llvm-project/flang/unittests/RuntimeGTest/Reduction.cpp:66:13: note: in instantiation of function template specialization 'MakeArray<Fortran::common::TypeCategory::Logical, 1, bool>' requested here
  auto mask{MakeArray<TypeCategory::Logical, 1>(
            ^
/usr/include/string.h:43:70: note: passing argument to parameter '__src' here
extern void *memcpy (void *__restrict __dest, const void *__restrict __src,
                                                                     ^
1 error generated.
Fri, Apr 2, 12:17 PM · Restricted Project, Restricted Project
klausler updated the diff for D99806: [flang] Address more MSVC build issues with reduction & numeric intrinsics.

Exclude more entry points.

Fri, Apr 2, 12:00 PM · Restricted Project, Restricted Project
klausler requested review of D99806: [flang] Address more MSVC build issues with reduction & numeric intrinsics.
Fri, Apr 2, 11:10 AM · Restricted Project, Restricted Project
klausler committed rG78a39d2a4166: [flang] TRANSFER() intrinsic function (authored by klausler).
[flang] TRANSFER() intrinsic function
Fri, Apr 2, 10:42 AM
klausler closed D99799: [flang] TRANSFER() intrinsic function.
Fri, Apr 2, 10:42 AM · Restricted Project, Restricted Project
klausler updated the diff for D99799: [flang] TRANSFER() intrinsic function.

Fix typo in comment (thanks!)

Fri, Apr 2, 10:10 AM · Restricted Project, Restricted Project
klausler requested review of D99799: [flang] TRANSFER() intrinsic function.
Fri, Apr 2, 9:42 AM · Restricted Project, Restricted Project
klausler requested review of D99798: [flang] TRANSFER() intrinsic function.
Fri, Apr 2, 9:33 AM · Restricted Project, Restricted Project
klausler committed rGdd43e13c0058: [flang] Fix MSVC build breakage (authored by klausler).
[flang] Fix MSVC build breakage
Fri, Apr 2, 8:29 AM

Thu, Apr 1

klausler committed rG273416231b14: [flang] Disable some new unit tests (non-portable results) (authored by klausler).
[flang] Disable some new unit tests (non-portable results)
Thu, Apr 1, 5:04 PM
klausler committed rG287c93c1321b: [flang] Fix unit test failure on POWER (authored by klausler).
[flang] Fix unit test failure on POWER
Thu, Apr 1, 4:20 PM
klausler committed rG5f6c5c63c7c2: [flang] Implement numeric intrinsic functions in runtime (authored by klausler).
[flang] Implement numeric intrinsic functions in runtime
Thu, Apr 1, 3:39 PM
klausler closed D99764: [flang] Implement numeric intrinsic functions in runtime.
Thu, Apr 1, 3:39 PM · Restricted Project, Restricted Project
klausler added a comment to D99666: [flang] Implement reductions in the runtime.

__builtin_complex was added in clang 12. This code won't compile with any released version of clang.

Thu, Apr 1, 1:04 PM · Restricted Project, Restricted Project
klausler requested review of D99764: [flang] Implement numeric intrinsic functions in runtime.
Thu, Apr 1, 1:02 PM · Restricted Project, Restricted Project
klausler committed rG1b88df1c8e4a: [flang] Fix arm clang build (authored by klausler).
[flang] Fix arm clang build
Thu, Apr 1, 12:57 PM
klausler committed rGe372e0f90619: [flang] Implement reductions in the runtime (authored by klausler).
[flang] Implement reductions in the runtime
Thu, Apr 1, 11:24 AM
klausler closed D99666: [flang] Implement reductions in the runtime.
Thu, Apr 1, 11:24 AM · Restricted Project, Restricted Project
klausler updated the diff for D99666: [flang] Implement reductions in the runtime.

Address portability issues with old GCC revisions; add COUNT.

Thu, Apr 1, 11:23 AM · Restricted Project, Restricted Project
klausler added a comment to D99666: [flang] Implement reductions in the runtime.

Thanks for catching the bugs with the gtest macros and older GCC's. I'll clean them up and do some more testing before pushing this code.

Thu, Apr 1, 8:46 AM · Restricted Project, Restricted Project

Wed, Mar 31

klausler committed rG7f8da0791c33: [flang] Refine checks for pointer initialization targets (authored by klausler).
[flang] Refine checks for pointer initialization targets
Wed, Mar 31, 11:32 AM
klausler closed D99665: [flang] Refine checks for pointer initialization targets.
Wed, Mar 31, 11:32 AM · Restricted Project, Restricted Project
klausler added inline comments to D99665: [flang] Refine checks for pointer initialization targets.
Wed, Mar 31, 10:36 AM · Restricted Project, Restricted Project
klausler requested review of D99666: [flang] Implement reductions in the runtime.
Wed, Mar 31, 9:25 AM · Restricted Project, Restricted Project
klausler requested review of D99665: [flang] Refine checks for pointer initialization targets.
Wed, Mar 31, 9:21 AM · Restricted Project, Restricted Project

Mon, Mar 29

klausler accepted D99342: [flang] Fix CHECK() calls on erroneous procedure declarations.
Mon, Mar 29, 9:54 AM · Restricted Project, Restricted Project

Thu, Mar 25

klausler committed rGd811c829af61: [flang] fix spurious runtime crash on TRIM('') (authored by klausler).
[flang] fix spurious runtime crash on TRIM('')
Thu, Mar 25, 12:37 PM
klausler closed D99296: [flang] Fix runtime crash on TRIM('').
Thu, Mar 25, 12:36 PM · Restricted Project, Restricted Project
klausler updated the diff for D99296: [flang] Fix runtime crash on TRIM('').

One more tweak for clarity.

Thu, Mar 25, 11:10 AM · Restricted Project, Restricted Project
klausler updated the diff for D99296: [flang] Fix runtime crash on TRIM('').

Rework the fix.

Thu, Mar 25, 11:07 AM · Restricted Project, Restricted Project
klausler accepted D99346: [flang] fold LOGICAL intrinsic calls.
Thu, Mar 25, 10:22 AM · Restricted Project, Restricted Project
klausler added a comment to D99296: [flang] Fix runtime crash on TRIM('').

Regarding CFI_establish, the Fortran standard says in 18.5.5.5 about elem_len :

elem_len: If type is equal to CFI_type_struct, CFI_type_other, or a Fortran character type code, elem_len shall be greater than zero and equal to the storage size in bytes of an element of the object. Otherwise, elem_len will be ignored.

So it look like the implementation/unittests are following the standard. But it is weird that it should be forbidden to establish zero length characters in the C interoperability context. I see no harm in that, so I am OK with your change.

However, do zero sized struct/ CFI_type_other make sense ? I guess in the C interoperability context, empty structs are not thing since they are technically illegal in C, but outside of the C interoperability context, I do not think empty derived types are forbidden.

Thu, Mar 25, 10:20 AM · Restricted Project, Restricted Project
klausler added inline comments to D99342: [flang] Fix CHECK() calls on erroneous procedure declarations.
Thu, Mar 25, 10:18 AM · Restricted Project, Restricted Project
klausler accepted D99340: [flang] Fix error compiling std::min on macos.

Thank you.

Thu, Mar 25, 10:16 AM · Restricted Project, Restricted Project

Wed, Mar 24

klausler added reviewers for D99296: [flang] Fix runtime crash on TRIM(''): sscalpone, jeanPerier.
Wed, Mar 24, 2:51 PM · Restricted Project, Restricted Project
klausler requested review of D99296: [flang] Fix runtime crash on TRIM('').
Wed, Mar 24, 1:37 PM · Restricted Project, Restricted Project
klausler committed rG5da55bfc18f6: [flang] Fix output buffering bug (positionability assumption) (authored by klausler).
[flang] Fix output buffering bug (positionability assumption)
Wed, Mar 24, 11:39 AM
klausler closed D99198: [flang] Fix output buffering bug.
Wed, Mar 24, 11:39 AM · Restricted Project, Restricted Project
klausler accepted D99208: [flang] Save binding labels as strings.
Wed, Mar 24, 10:59 AM · Restricted Project, Restricted Project
klausler added a comment to D99198: [flang] Fix output buffering bug.

LGTM

Wed, Mar 24, 9:57 AM · Restricted Project, Restricted Project

Tue, Mar 23

klausler updated the diff for D99198: [flang] Fix output buffering bug.

Added a unit test.

Tue, Mar 23, 5:21 PM · Restricted Project, Restricted Project
klausler added a reviewer for D99198: [flang] Fix output buffering bug: PeteSteinfeld.
Tue, Mar 23, 1:51 PM · Restricted Project, Restricted Project
klausler added a comment to D99198: [flang] Fix output buffering bug.

I'm wondering if it's possible to construct a test-case for this "shuffle it around" situation, so that some newbie (like me ...) doesn't break it accidentally when making changes?

It gets exercised pretty thoroughly by the I/O tests in the FCVS Fortran '77 suite, especially by codes doing direct and sequential I/O, and the flang/unittests/Runtime/external-io.cpp test really shook it out on the read path (and still passes with this change now that it's used on the write path). But it would be nice to be able to make the code work harder by e.g. using an artificially small buffer size. I've done that in the past during development (but obviously not for console output, sorry) but I'm not sure how it could be made part of a unit testing framework.

Yes, I am asking without fully understanding the overall infrastructure. A way to test without having to write 64KB+ of data would be nice - but not sure how easy that is to achieve either.
From what I can tell from a quick look, the buffer functionality itself isn't being tested, it is the IO functionality that is layered on top of it that gets tested - so it wouldn't be very easy to implement a dummy STORE class that tracks the actual output and expects to see certain strings - even if we could make the buffer size smaller.
Maybe the right thing would be to actually add a small test-suite for the buffer itself, along with some kind of variable setting for the buffer-size?

These are just my thoughts, as a newbie to this project.

Tue, Mar 23, 1:50 PM · Restricted Project, Restricted Project
klausler accepted D99208: [flang] Save binding labels as strings.
Tue, Mar 23, 1:48 PM · Restricted Project, Restricted Project
klausler added a comment to D99198: [flang] Fix output buffering bug.

I'm wondering if it's possible to construct a test-case for this "shuffle it around" situation, so that some newbie (like me ...) doesn't break it accidentally when making changes?

Tue, Mar 23, 11:05 AM · Restricted Project, Restricted Project
klausler requested review of D99198: [flang] Fix output buffering bug.
Tue, Mar 23, 9:53 AM · Restricted Project, Restricted Project

Mon, Mar 22

klausler accepted D99111: [flang] Disallow erroneous procedure declarations.
Mon, Mar 22, 2:43 PM · Restricted Project, Restricted Project
klausler accepted D99085: [flang] Specific procedures named the same as the generic and a derived type.
Mon, Mar 22, 9:23 AM · Restricted Project, Restricted Project

Fri, Mar 19

klausler accepted D98303: [flang] Update output format test to use GTest.
Fri, Mar 19, 11:00 AM · Restricted Project, Restricted Project

Thu, Mar 18

klausler added a comment to D98303: [flang] Update output format test to use GTest.

@klausler D98652 hopefully demonstrates that runtime crashes are caught by death tests. This revision has been rebased on D98652 - I hope this sufficiently demonstrates that these tests accurately catch crashes. We could also work on another patch that intentionally crashes each of the APIs tested above not already tested in D98652.

Thu, Mar 18, 5:14 PM · Restricted Project, Restricted Project
klausler committed rG0d8331c06be6: [flang] Refine symbol sorting (authored by klausler).
[flang] Refine symbol sorting
Thu, Mar 18, 11:18 AM
klausler closed D98878: [flang] Refine symbol sorting.
Thu, Mar 18, 11:18 AM · Restricted Project, Restricted Project
klausler added a comment to D98743: [flang] Order Symbols by source provenance.

Fixed by https://reviews.llvm.org/D98878

Thu, Mar 18, 10:31 AM · Restricted Project, Restricted Project
klausler requested review of D98878: [flang] Refine symbol sorting.
Thu, Mar 18, 10:30 AM · Restricted Project, Restricted Project
klausler added a comment to D98743: [flang] Order Symbols by source provenance.

Hi @klausler , looks like this patch is causing failures in one of our public builders:

Thu, Mar 18, 10:06 AM · Restricted Project, Restricted Project

Tue, Mar 16

klausler committed rG539bbbe7b516: [flang] Fix build error (unused data member warning) (authored by klausler).
[flang] Fix build error (unused data member warning)
Tue, Mar 16, 5:21 PM
klausler closed D98752: [flang] Fix build error (unused data member warning).
Tue, Mar 16, 5:21 PM · Restricted Project, Restricted Project
klausler added a reviewer for D98752: [flang] Fix build error (unused data member warning): tskeith.
Tue, Mar 16, 5:07 PM · Restricted Project, Restricted Project
klausler requested review of D98752: [flang] Fix build error (unused data member warning).
Tue, Mar 16, 4:49 PM · Restricted Project, Restricted Project
klausler committed rG46ade6d0ef8f: [flang] Order Symbols by source provenance (authored by klausler).
[flang] Order Symbols by source provenance
Tue, Mar 16, 3:25 PM
klausler closed D98743: [flang] Order Symbols by source provenance.
Tue, Mar 16, 3:25 PM · Restricted Project, Restricted Project
klausler requested review of D98743: [flang] Order Symbols by source provenance.
Tue, Mar 16, 2:37 PM · Restricted Project, Restricted Project

Mon, Mar 15

klausler committed rG6811b961000f: [flang] Runtime: implement INDEX intrinsic function (authored by klausler).
[flang] Runtime: implement INDEX intrinsic function
Mon, Mar 15, 2:19 PM
klausler closed D98553: [flang] Runtime: implement INDEX intrinsic function.
Mon, Mar 15, 2:19 PM · Restricted Project, Restricted Project
klausler accepted D98256: [flang] Save AllocateObject and PointerObject analyzed expression.

Looks great; thanks!

Mon, Mar 15, 9:29 AM · Restricted Project, Restricted Project

Mar 12 2021

klausler committed rG59f213c162a4: [flang] Fix static build of flang (authored by klausler).
[flang] Fix static build of flang
Mar 12 2021, 5:39 PM
klausler closed D98568: [flang] Fix static build of flang.
Mar 12 2021, 5:39 PM · Restricted Project, Restricted Project
klausler requested review of D98568: [flang] Fix static build of flang.
Mar 12 2021, 5:21 PM · Restricted Project, Restricted Project
klausler committed rGbbd0dc3d6506: [flang] Ensure pointer function results are acceptable variables (authored by klausler).
[flang] Ensure pointer function results are acceptable variables
Mar 12 2021, 4:05 PM
klausler closed D98555: [flang] Ensure pointer function results are acceptable variables.
Mar 12 2021, 4:05 PM · Restricted Project, Restricted Project
klausler committed rG170e906159ac: [flang] Update DE/ALLOCATE statement runtime message processing (authored by klausler).
[flang] Update DE/ALLOCATE statement runtime message processing
Mar 12 2021, 3:42 PM
klausler closed D98551: [flang] Update DE/ALLOCATE statement runtime message processing.
Mar 12 2021, 3:42 PM · Restricted Project, Restricted Project
klausler requested review of D98555: [flang] Ensure pointer function results are acceptable variables.
Mar 12 2021, 1:53 PM · Restricted Project, Restricted Project
klausler requested review of D98553: [flang] Runtime: implement INDEX intrinsic function.
Mar 12 2021, 1:49 PM · Restricted Project, Restricted Project
klausler requested review of D98551: [flang] Update DE/ALLOCATE statement runtime message processing.
Mar 12 2021, 1:37 PM · Restricted Project, Restricted Project
klausler accepted D98522: [flang] Build intrinsic .mod files in include/flang.
Mar 12 2021, 9:37 AM · Restricted Project, Restricted Project
klausler accepted D98357: [flang] Make the symbol count used for collating symbols static.
Mar 12 2021, 8:49 AM · Restricted Project, Restricted Project

Mar 11 2021

klausler accepted D98430: [flang] Handle type-bound procedures with alternate returns.

I verified that the default passed-object dummy argument is indeed the first dummy argument in F,2018, not the first named dummy argument (which would have made sense too).

Mar 11 2021, 10:10 AM · Restricted Project, Restricted Project