Page MenuHomePhabricator

klausler (Peter Klausler)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 9 2020, 11:45 AM (28 w, 4 d)

Recent Activity

Fri, Oct 23

klausler accepted D90074: [flang] An erroneous type bound procedure was causing a call to CHECK().
Fri, Oct 23, 1:30 PM · Restricted Project, Restricted Project
klausler accepted D90049: [flang] Tighten rules to resolve procedure as intrinsic procedure.

Looks great to me; thanks!

Fri, Oct 23, 10:41 AM · Restricted Project, Restricted Project

Wed, Oct 21

klausler accepted D89369: [flang][windows] Support platform-specific path separator..

There may be path separators with UNIX assumptions in the runtime I/O support library, too.

Wed, Oct 21, 10:01 AM · Restricted Project, Restricted Project
klausler accepted D89367: [flang][msvc] Fix lambda capture ambiguity. NFC..
Wed, Oct 21, 9:59 AM · Restricted Project, Restricted Project
klausler accepted D88794: [flang] Fix pimpl idiom for IntrinsicProcTable..
Wed, Oct 21, 9:58 AM · Restricted Project, Restricted Project
klausler accepted D89717: [flang] Another validity of the TARGET= argument of ASSOCIATED() for objects.
Wed, Oct 21, 9:52 AM · Restricted Project, Restricted Project

Mon, Oct 19

klausler added a comment to D89717: [flang] Another validity of the TARGET= argument of ASSOCIATED() for objects.

Why is this a fatal error, rather than a warning? If the TARGET= argument lacks both POINTER and TARGET attributes, the result will always be false, and we can warn about that.

Mon, Oct 19, 11:27 AM · Restricted Project, Restricted Project

Fri, Oct 16

klausler accepted D89581: [flang] Disallow pointer constants.

Please add a comment that lays out our reasoning for the prohibition against combining PARAMETER and POINTER, since the standards do not explicitly preclude it. (The PARAMETER attribute requires a entity-decl to have an initialization that is a constant-expr, and the only form of initialization that allows a constant-expr is the one that's not a "=>" pointer initialization.) See C811, C807, & 8.5.13.

Fri, Oct 16, 11:59 AM · Restricted Project, Restricted Project
klausler accepted D89473: [flang] Document and use intrinsic subroutine argument intents.
Fri, Oct 16, 10:24 AM · Restricted Project, Restricted Project

Thu, Oct 15

klausler accepted D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).

LGTM and thanks!

Thu, Oct 15, 1:19 PM · Restricted Project, Restricted Project
klausler added inline comments to D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).
Thu, Oct 15, 10:56 AM · Restricted Project, Restricted Project
klausler committed rG2aad6a0884e3: [flang][msvc] Avoid a reinterpret_cast (authored by klausler).
[flang][msvc] Avoid a reinterpret_cast
Thu, Oct 15, 10:39 AM
klausler closed D89435: [flang][msvc] Avoid a reinterpret_cast.
Thu, Oct 15, 10:39 AM · Restricted Project, Restricted Project
klausler added inline comments to D89473: [flang] Document and use intrinsic subroutine argument intents.
Thu, Oct 15, 9:27 AM · Restricted Project, Restricted Project

Wed, Oct 14

klausler added a comment to D88798: [flang] Fix heap overflow in Real formatting..

Please see https://reviews.llvm.org/D89435 for a proposed alternative patch.

Wed, Oct 14, 4:37 PM · Restricted Project, Restricted Project
klausler requested review of D89435: [flang][msvc] Avoid a reinterpret_cast.
Wed, Oct 14, 4:37 PM · Restricted Project, Restricted Project
klausler added a comment to D88798: [flang] Fix heap overflow in Real formatting..

I think a better fix would be to generalize ToUInt64 as a template elsewhere. I'll prepare a patch and add you as the reviewer.

Wed, Oct 14, 11:56 AM · Restricted Project, Restricted Project

Thu, Oct 8

klausler committed rG3e86eda18c37: [flang] Allow "name: value" in compiler directives (authored by klausler).
[flang] Allow "name: value" in compiler directives
Thu, Oct 8, 10:02 AM
klausler closed D89017: [flang] Allow "name: value" in compiler directives.
Thu, Oct 8, 10:02 AM · Restricted Project, Restricted Project
klausler accepted D88981: [flang] Rework host runtime folding and enable REAL(2) folding with it..

There's a lot of work here and it's quite well done; thank you.

Thu, Oct 8, 10:00 AM · Restricted Project, Restricted Project

Wed, Oct 7

klausler requested review of D89017: [flang] Allow "name: value" in compiler directives.
Wed, Oct 7, 4:09 PM · Restricted Project, Restricted Project
klausler committed rGd56fdc8e95df: [flang][msvc] Avoid dependence on long double (authored by klausler).
[flang][msvc] Avoid dependence on long double
Wed, Oct 7, 3:13 PM
klausler closed D88752: [flang][msvc] Avoid dependence on long double.
Wed, Oct 7, 3:12 PM · Restricted Project, Restricted Project
klausler committed rG88afb6e86774: [flang] Semantic checks for bad usage of whole assumed-size arrays (authored by klausler).
[flang] Semantic checks for bad usage of whole assumed-size arrays
Wed, Oct 7, 2:43 PM
klausler closed D88691: [flang] Semantic checks for bad usage of whole assumed-size arrays.
Wed, Oct 7, 2:43 PM · Restricted Project, Restricted Project

Tue, Oct 6

klausler committed rG53bf28b80cf9: [flang] Track CHARACTER length better in TypeAndShape (authored by klausler).
[flang] Track CHARACTER length better in TypeAndShape
Tue, Oct 6, 8:52 AM
klausler closed D88689: [flang] Track CHARACTER length better in TypeAndShape.
Tue, Oct 6, 8:52 AM · Restricted Project, Restricted Project
klausler updated the diff for D88752: [flang][msvc] Avoid dependence on long double.

Rebased to current master branch.

Tue, Oct 6, 8:49 AM · Restricted Project, Restricted Project

Mon, Oct 5

klausler added a comment to D88689: [flang] Track CHARACTER length better in TypeAndShape.

ping

Mon, Oct 5, 4:05 PM · Restricted Project, Restricted Project
klausler added a comment to D88691: [flang] Semantic checks for bad usage of whole assumed-size arrays.

ping

Mon, Oct 5, 4:05 PM · Restricted Project, Restricted Project
klausler committed rG567462b48eba: [flang] Correct kP scaling on F output (authored by klausler).
[flang] Correct kP scaling on F output
Mon, Oct 5, 1:59 PM
klausler closed D88610: [flang] Correct kP scaling on F output.
Mon, Oct 5, 1:59 PM · Restricted Project, Restricted Project
klausler committed rG07cb4c013c43: [flang] Make binary->decimal conversion buffer sizes accurate (authored by klausler).
[flang] Make binary->decimal conversion buffer sizes accurate
Mon, Oct 5, 1:12 PM
klausler closed D88688: [flang] Make binary->decimal conversion buffer sizes accurate.
Mon, Oct 5, 1:12 PM · Restricted Project, Restricted Project
klausler added a comment to D88798: [flang] Fix heap overflow in Real formatting..

This works, but maybe the memcpy should be in a constructor for BinaryFloatingPointNumber -- it already has a memcpy in its default constructor, after an assertion that the size is not smaller (which would be removed).

Mon, Oct 5, 11:38 AM · Restricted Project, Restricted Project
klausler added a reviewer for D88688: [flang] Make binary->decimal conversion buffer sizes accurate: tskeith.
Mon, Oct 5, 11:35 AM · Restricted Project, Restricted Project
klausler added a reviewer for D88610: [flang] Correct kP scaling on F output: PeteSteinfeld.
Mon, Oct 5, 11:34 AM · Restricted Project, Restricted Project
klausler added a comment to D88511: [flang][msvc] long double is not different from double..

See D88752, which avoids the needless usage of the native floating types.

Mon, Oct 5, 11:33 AM · Restricted Project, Restricted Project
klausler added a comment to D88797: [flang] Fix copy elision assumption..

A much smaller work-around: extend the sole constructor of Restorer to accept a reference and a value, and then modify ScopedSet to construct its result as part of the return statement. Restorer doesn't need move construction or move assignment for its clients.

Mon, Oct 5, 11:29 AM · Restricted Project, Restricted Project
klausler added a comment to D88793: [flang] Fix assumptions on std::forward_list iterator implementation..

There seems to be no good reason for this strategy. Possible other implementations:

  1. Use of std::deque which all direct insertion at the end. It also does not require an heap allocation for every element inserted.
  2. Use of std::vector. When emitting diagnostics, all elements are copied to a std::vector anyway.
  3. Insertion and the beginning of std::forward_list. Again, the list is sorted anyway before messages are printed.
Mon, Oct 5, 11:19 AM · Restricted Project, Restricted Project
klausler added a comment to rGd4a1db4f3fd7: [flang][msvc] Workaround 'forgotten' symbols in FoldOperation. NFC..

Does this fail for you because you compile with -Werror? The warning is a false positive in Clang: http://llvm.org/PR35450

Mon, Oct 5, 10:05 AM

Fri, Oct 2

klausler requested review of D88752: [flang][msvc] Avoid dependence on long double.
Fri, Oct 2, 1:03 PM · Restricted Project, Restricted Project
klausler added inline comments to D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).
Fri, Oct 2, 10:43 AM · Restricted Project, Restricted Project
klausler added inline comments to D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).
Fri, Oct 2, 9:01 AM · Restricted Project, Restricted Project
klausler accepted D88711: [flang][NFC] Fix mis-matched struct/class declarations.

The other specialization of this template is a class, though, so maybe the best fix is to change the earlier template struct to a class so that they all are so. I've got a fix on the way that does that, I think.

The only other specialization I see is immediately above and it's a struct.

Fri, Oct 2, 8:58 AM · Restricted Project, Restricted Project

Thu, Oct 1

klausler committed rG3261aefc72b3: [flang] Extend runtime API for PAUSE to allow a stop code (authored by klausler).
[flang] Extend runtime API for PAUSE to allow a stop code
Thu, Oct 1, 5:22 PM
klausler closed D88692: [flang] Extend runtime API for PAUSE to allow a stop code.
Thu, Oct 1, 5:22 PM · Restricted Project, Restricted Project
klausler committed rGa94d943f1a3f: [flang] Fix actions at end of output record (authored by klausler).
[flang] Fix actions at end of output record
Thu, Oct 1, 5:19 PM
klausler closed D88685: [flang] Fix actions at end of output record.
Thu, Oct 1, 5:18 PM · Restricted Project, Restricted Project
klausler committed rG61687f3a48c2: [flang] Fix buffering read->write transition (authored by klausler).
[flang] Fix buffering read->write transition
Thu, Oct 1, 5:15 PM
klausler closed D88612: flang] Fix buffering read->write transition.
Thu, Oct 1, 5:14 PM · Restricted Project, Restricted Project
klausler added a comment to D88711: [flang][NFC] Fix mis-matched struct/class declarations.

The other specialization of this template is a class, though, so maybe the best fix is to change the earlier template struct to a class so that they all are so. I've got a fix on the way that does that, I think.

Thu, Oct 1, 4:55 PM · Restricted Project, Restricted Project
klausler committed rG75a5ec1bad18: [flang][msvc] Rework a MSVC work-around to avoid clang warning (authored by klausler).
[flang][msvc] Rework a MSVC work-around to avoid clang warning
Thu, Oct 1, 4:53 PM
klausler closed D88695: [flang][msvc] Rework a MSVC work-around to avoid clang warning.
Thu, Oct 1, 4:53 PM · Restricted Project, Restricted Project
klausler committed rGe99d184d5493: [flang] Readability improvement in binary->decimal conversion (authored by klausler).
[flang] Readability improvement in binary->decimal conversion
Thu, Oct 1, 3:50 PM
klausler closed D88604: [flang] Readability improvement in binary->decimal conversion.
Thu, Oct 1, 3:50 PM · Restricted Project, Restricted Project
klausler requested review of D88695: [flang][msvc] Rework a MSVC work-around to avoid clang warning.
Thu, Oct 1, 12:52 PM · Restricted Project, Restricted Project
klausler requested review of D88692: [flang] Extend runtime API for PAUSE to allow a stop code.
Thu, Oct 1, 12:15 PM · Restricted Project, Restricted Project
klausler requested review of D88691: [flang] Semantic checks for bad usage of whole assumed-size arrays.
Thu, Oct 1, 12:10 PM · Restricted Project, Restricted Project
klausler requested review of D88689: [flang] Track CHARACTER length better in TypeAndShape.
Thu, Oct 1, 11:49 AM · Restricted Project, Restricted Project
klausler requested review of D88688: [flang] Make binary->decimal conversion buffer sizes accurate.
Thu, Oct 1, 11:28 AM · Restricted Project, Restricted Project
klausler requested review of D88685: [flang] Fix actions at end of output record.
Thu, Oct 1, 11:01 AM · Restricted Project, Restricted Project
klausler committed rGe29c9d77f128: [flang] Fix WRITE after BACKSPACE (authored by klausler).
[flang] Fix WRITE after BACKSPACE
Thu, Oct 1, 10:34 AM
klausler closed D88675: [flang] Fix WRITE after BACKSPACE.
Thu, Oct 1, 10:34 AM · Restricted Project, Restricted Project
klausler committed rGdf6de2222c66: [flang] Fix INQUIRE of access and formatting possibilities (authored by klausler).
[flang] Fix INQUIRE of access and formatting possibilities
Thu, Oct 1, 10:28 AM
klausler closed D88673: [flang] Fix INQUIRE of access and formatting possibilities.
Thu, Oct 1, 10:28 AM · Restricted Project, Restricted Project
klausler raised a concern with rGd4a1db4f3fd7: [flang][msvc] Workaround 'forgotten' symbols in FoldOperation. NFC..

This change broke the build with clang.

Thu, Oct 1, 10:02 AM
klausler committed rGcdfb95ad580f: [flang] Add checks for misuse of formatted I/O APIs in unformatted I/O statement (authored by klausler).
[flang] Add checks for misuse of formatted I/O APIs in unformatted I/O statement
Thu, Oct 1, 9:58 AM
klausler closed D88672: [flang] Add checks for misuse of formatted I/O APIs in unformatted I/O statement.
Thu, Oct 1, 9:58 AM · Restricted Project, Restricted Project
klausler requested review of D88675: [flang] Fix WRITE after BACKSPACE.
Thu, Oct 1, 9:52 AM · Restricted Project, Restricted Project
klausler requested review of D88673: [flang] Fix INQUIRE of access and formatting possibilities.
Thu, Oct 1, 9:45 AM · Restricted Project, Restricted Project
klausler requested review of D88672: [flang] Add checks for misuse of formatted I/O APIs in unformatted I/O statement.
Thu, Oct 1, 9:35 AM · Restricted Project, Restricted Project

Wed, Sep 30

klausler committed rG4fb679d3b159: [flang] Fix Gw.d format output (authored by klausler).
[flang] Fix Gw.d format output
Wed, Sep 30, 6:03 PM
klausler closed D88618: [flang] Fix Gw.d format output.
Wed, Sep 30, 6:03 PM · Restricted Project, Restricted Project
klausler committed rGe24f0ac7a389: [flang] Allow record advancement in external formatted sequential READ (authored by klausler).
[flang] Allow record advancement in external formatted sequential READ
Wed, Sep 30, 5:17 PM
klausler closed D88607: [flang] Allow record advancement in external formatted sequential READ.
Wed, Sep 30, 5:17 PM · Restricted Project, Restricted Project
klausler committed rG37b2e2b04cf4: [flang] Semantic analysis for FINAL subroutines (authored by klausler).
[flang] Semantic analysis for FINAL subroutines
Wed, Sep 30, 3:47 PM
klausler closed D88613: [flang] Semantic analysis for FINAL subroutines.
Wed, Sep 30, 3:47 PM · Restricted Project, Restricted Project
klausler removed reviewers for D88613: [flang] Semantic analysis for FINAL subroutines: nicolasvasilache, aartbik, JDevlieghere, Restricted Project.
Wed, Sep 30, 3:11 PM · Restricted Project, Restricted Project
klausler updated the diff for D88613: [flang] Semantic analysis for FINAL subroutines.

Previous update to this review had inadvertent changes to other files because I neglected to rebase after updating master; now fixed. Sorry for the scare!

Wed, Sep 30, 3:09 PM · Restricted Project, Restricted Project
klausler requested review of D88618: [flang] Fix Gw.d format output.
Wed, Sep 30, 3:01 PM · Restricted Project, Restricted Project
klausler updated the diff for D88613: [flang] Semantic analysis for FINAL subroutines.

Worked around clang error noticed by code reviewer, & added
a "const" suggested by the clang-tidy bot.

Wed, Sep 30, 2:54 PM · Restricted Project, Restricted Project
klausler committed rG0c3c8f4ae69a: [flang] Fix descriptor-based array data item I/O for list-directed CHARACTER &… (authored by klausler).
[flang] Fix descriptor-based array data item I/O for list-directed CHARACTER &…
Wed, Sep 30, 2:03 PM
klausler closed D88606: [flang] Fix descriptor-based array data item I/O for list-directed CHARACTER & LOGICAL.
Wed, Sep 30, 2:03 PM · Restricted Project, Restricted Project
klausler added inline comments to D88613: [flang] Semantic analysis for FINAL subroutines.
Wed, Sep 30, 1:57 PM · Restricted Project, Restricted Project
klausler requested review of D88613: [flang] Semantic analysis for FINAL subroutines.
Wed, Sep 30, 1:27 PM · Restricted Project, Restricted Project
klausler retitled D88610: [flang] Correct kP scaling on F output from Correct kP scaling on F output to [flang] Correct kP scaling on F output.
Wed, Sep 30, 1:17 PM · Restricted Project, Restricted Project
klausler retitled D88607: [flang] Allow record advancement in external formatted sequential READ from Allow record advancement in external formatted sequential READ to [flang] Allow record advancement in external formatted sequential READ.
Wed, Sep 30, 1:17 PM · Restricted Project, Restricted Project
klausler retitled D88606: [flang] Fix descriptor-based array data item I/O for list-directed CHARACTER & LOGICAL from Fix descriptor-based array data item I/O for list-directed CHARACTER & LOGICAL to [flang] Fix descriptor-based array data item I/O for list-directed CHARACTER & LOGICAL.
Wed, Sep 30, 1:16 PM · Restricted Project, Restricted Project
klausler retitled D88604: [flang] Readability improvement in binary->decimal conversion from Readability improvement in binary->decimal conversion to [flang] Readability improvement in binary->decimal conversion.
Wed, Sep 30, 1:14 PM · Restricted Project, Restricted Project
klausler requested review of D88612: flang] Fix buffering read->write transition.
Wed, Sep 30, 1:13 PM · Restricted Project, Restricted Project
klausler requested review of D88610: [flang] Correct kP scaling on F output.
Wed, Sep 30, 1:07 PM · Restricted Project, Restricted Project
klausler requested review of D88607: [flang] Allow record advancement in external formatted sequential READ.
Wed, Sep 30, 1:00 PM · Restricted Project, Restricted Project
klausler requested review of D88606: [flang] Fix descriptor-based array data item I/O for list-directed CHARACTER & LOGICAL.
Wed, Sep 30, 12:47 PM · Restricted Project, Restricted Project
klausler requested review of D88604: [flang] Readability improvement in binary->decimal conversion.
Wed, Sep 30, 12:39 PM · Restricted Project, Restricted Project
klausler added inline comments to D88313: [flang] Failed call to CHECK() for call to ASSOCIATED(NULL()).
Wed, Sep 30, 11:06 AM · Restricted Project, Restricted Project

Tue, Sep 29

klausler added a comment to D88511: [flang][msvc] long double is not different from double..

Is there no access to 80-bit extended precision at all in MSVC?

Tue, Sep 29, 1:13 PM · Restricted Project, Restricted Project
klausler accepted D88504: [flang][msvc] Workaround 'forgotten' symbols in FoldOperation. NFC..

If the magic MSVC option works around this compiler bug, and perhaps others, it seems to me like a cleaner way to avoid their problems.

Tue, Sep 29, 12:25 PM · Restricted Project, Restricted Project
klausler accepted D88509: [flang][msvc] Define implicit conversion from UnsignedInt128 to int64_t..

Your "analogous conversion" from uint32 to int64 can't lose information, though.

Tue, Sep 29, 12:12 PM · Restricted Project, Restricted Project
klausler accepted D88508: [flang][msvc] Define access flags under Windows. NFC..
Tue, Sep 29, 11:43 AM · Restricted Project, Restricted Project