Page MenuHomePhabricator

clementval (Valentin Clement)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 12 2019, 1:05 PM (69 w, 4 d)

Recent Activity

Sun, Apr 4

clementval added a comment to D99835: [flang][MSVC] Fix compilation of external-hello-world test with MSVC..

Could you please update D96069 instead?

I lost access to my old account.

Sun, Apr 4, 7:05 AM · Restricted Project, Restricted Project

Thu, Apr 1

clementval added inline comments to D99757: [flang][OpenMP] Add semantic check for occurrence of constructs nested inside a SIMD region.
Thu, Apr 1, 8:39 PM · Restricted Project, Restricted Project

Fri, Mar 26

clementval added inline comments to D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.
Fri, Mar 26, 8:48 AM · Restricted Project, Restricted Project
clementval added a comment to D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

I'll take this patch over from Rin and take it to completion.

Fri, Mar 26, 7:41 AM · Restricted Project, Restricted Project

Tue, Mar 23

clementval added a comment to D93560: [openacc][openmp] Reduce number of generated file and prefer inclusion of .inc.

Great change, thanks for doing it!

Can we fold the .h.inc files into the .inc files too? I haven't seen .h.inc files elsewhere in the build.

Tue, Mar 23, 7:52 AM · Restricted Project
clementval committed rGd709dcc09097: [openacc][openmp] Reduce number of generated file and prefer inclusion of .inc (authored by clementval).
[openacc][openmp] Reduce number of generated file and prefer inclusion of .inc
Tue, Mar 23, 6:17 AM
clementval closed D93560: [openacc][openmp] Reduce number of generated file and prefer inclusion of .inc.
Tue, Mar 23, 6:17 AM · Restricted Project

Mon, Mar 22

clementval updated the diff for D93560: [openacc][openmp] Reduce number of generated file and prefer inclusion of .inc.

Rebase and address review comment

Mon, Mar 22, 6:25 PM · Restricted Project

Wed, Mar 17

clementval added a comment to D93560: [openacc][openmp] Reduce number of generated file and prefer inclusion of .inc.

I'd prefer using the name "impl" for the implementation, but my LGTM does not depend on it.

Wed, Mar 17, 4:33 AM · Restricted Project

Tue, Mar 16

clementval added a comment to D93560: [openacc][openmp] Reduce number of generated file and prefer inclusion of .inc.

The reason why MLIR does not split declaration and implementation-generation might be that nobody yet wanted to invest the work to split them. While I would not request splitting tablegen-generated files into separate files, fusing feels like a step backwards. If only implementation details change, with a merged output everything that includes OMP.h must be recompiled as well. I don't see how a separation into declaration and implementation causes the number of files to explode.

Tue, Mar 16, 11:43 AM · Restricted Project
clementval added a comment to D98603: [Flang] [OpenMP] Add function for mapping OpenMP Parser clause classes with the corresponding clause kind.

The clang-tidy seems to identify the case style as invalid for this function name GenerateFlangClauseParserKindMap
Any changes required regarding this ? All other functions in the file DirectiveEmitter.cpp follows the same naming convention.

Tue, Mar 16, 11:40 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Mar 15

clementval added inline comments to D98603: [Flang] [OpenMP] Add function for mapping OpenMP Parser clause classes with the corresponding clause kind.
Mon, Mar 15, 5:10 PM · Restricted Project, Restricted Project, Restricted Project
clementval added a comment to D93560: [openacc][openmp] Reduce number of generated file and prefer inclusion of .inc.

However, emitting everything into a single file and selecting using preprocessor directives doesn't seem what other tablegen targets are doing. E.g. for intrinsics there is IntrinsicImpl.inc, IntrinsicEnums.inc. Clang has Attrs.inc, AttrImpl.inc, AttrVisitor.inc, etc.

Mon, Mar 15, 12:55 PM · Restricted Project
clementval added reviewers for D93560: [openacc][openmp] Reduce number of generated file and prefer inclusion of .inc: jdenny, Meinersbur.
Mon, Mar 15, 12:27 PM · Restricted Project
clementval accepted D98603: [Flang] [OpenMP] Add function for mapping OpenMP Parser clause classes with the corresponding clause kind.

LGTM. Thanks for working on that. I'll probably make use of this in the OpenACC part where it makes sense.

Mon, Mar 15, 10:56 AM · Restricted Project, Restricted Project, Restricted Project

Mar 9 2021

clementval added inline comments to D97964: [flang][OpenMP] Add semantic check for occurrence of multiple list items in aligned clause for simd directive.
Mar 9 2021, 1:16 PM · Restricted Project
clementval accepted D97964: [flang][OpenMP] Add semantic check for occurrence of multiple list items in aligned clause for simd directive.

LGTM. Please address small comments.

Mar 9 2021, 12:41 PM · Restricted Project
clementval accepted D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.
Mar 9 2021, 11:12 AM · Restricted Project, Restricted Project, Restricted Project

Mar 8 2021

clementval added inline comments to D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops..
Mar 8 2021, 11:52 AM · Restricted Project, Restricted Project
clementval added inline comments to D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops..
Mar 8 2021, 11:25 AM · Restricted Project, Restricted Project

Mar 5 2021

clementval added inline comments to D97964: [flang][OpenMP] Add semantic check for occurrence of multiple list items in aligned clause for simd directive.
Mar 5 2021, 2:27 PM · Restricted Project
clementval committed rGc3e5f504a0c5: [flang][fir] Add FIR Types parser diagnostic tests + cleanup (authored by clementval).
[flang][fir] Add FIR Types parser diagnostic tests + cleanup
Mar 5 2021, 11:59 AM
clementval closed D97643: [flang][fir] Add FIR Types parser diagnostic tests + cleanup.
Mar 5 2021, 11:58 AM · Restricted Project
clementval updated the diff for D97643: [flang][fir] Add FIR Types parser diagnostic tests + cleanup.

Rebase + format

Mar 5 2021, 11:45 AM · Restricted Project
clementval committed rGd090f427780f: [flang][fir] Add diagnostic tests for FIR ops verifier (authored by clementval).
[flang][fir] Add diagnostic tests for FIR ops verifier
Mar 5 2021, 7:21 AM
clementval closed D97996: [flang][fir] Add diagnostic tests for FIR ops verifier.
Mar 5 2021, 7:21 AM · Restricted Project

Mar 4 2021

clementval added inline comments to D97996: [flang][fir] Add diagnostic tests for FIR ops verifier.
Mar 4 2021, 6:44 PM · Restricted Project
clementval updated the diff for D97996: [flang][fir] Add diagnostic tests for FIR ops verifier.

Address review comment

Mar 4 2021, 6:43 PM · Restricted Project
clementval requested review of D97996: [flang][fir] Add diagnostic tests for FIR ops verifier.
Mar 4 2021, 5:48 PM · Restricted Project
clementval added a comment to D97964: [flang][OpenMP] Add semantic check for occurrence of multiple list items in aligned clause for simd directive.
Mar 4 2021, 3:43 PM · Restricted Project
clementval added a comment to D93560: [openacc][openmp] Reduce number of generated file and prefer inclusion of .inc.

@thakis If it still makes sense to make the directive TableGen backend closer to your initial proposal (D83636) please have a look. Otherwise I'll abandon this revision.
@jdoerfert

Mar 4 2021, 6:59 AM · Restricted Project

Feb 28 2021

clementval requested review of D97643: [flang][fir] Add FIR Types parser diagnostic tests + cleanup.
Feb 28 2021, 2:16 PM · Restricted Project

Feb 26 2021

clementval accepted D97500: [flang][fir] Add remaining Ops. Updates to pre-existing Ops..

I'm working on the diagnostic tests.

Feb 26 2021, 1:15 PM · Restricted Project, Restricted Project

Feb 25 2021

clementval added inline comments to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.
Feb 25 2021, 9:00 AM · Restricted Project, Restricted Project, Restricted Project

Feb 24 2021

clementval committed rG841f6995cd33: [flang][fir][NFC] Move remaining types to TableGen type definition (authored by clementval).
[flang][fir][NFC] Move remaining types to TableGen type definition
Feb 24 2021, 5:24 PM
clementval closed D96987: [flang][fir][NFC] Move remaining types to TableGen type definition.
Feb 24 2021, 5:23 PM · Restricted Project
clementval updated the diff for D96987: [flang][fir][NFC] Move remaining types to TableGen type definition.

Rebase

Feb 24 2021, 10:38 AM · Restricted Project

Feb 23 2021

clementval updated the diff for D96987: [flang][fir][NFC] Move remaining types to TableGen type definition.

Sync with fir-dev

Feb 23 2021, 6:16 PM · Restricted Project
clementval accepted D97328: [flang][fir][NFC] remove unused function.

LGTM

Feb 23 2021, 12:55 PM · Restricted Project

Feb 22 2021

clementval updated the diff for D96987: [flang][fir][NFC] Move remaining types to TableGen type definition.

Rebase + address review comment

Feb 22 2021, 6:23 PM · Restricted Project
clementval added a comment to D96987: [flang][fir][NFC] Move remaining types to TableGen type definition.

@rriddle Are you happy with the latest changes?

Feb 22 2021, 7:01 AM · Restricted Project

Feb 19 2021

clementval added a comment to D96987: [flang][fir][NFC] Move remaining types to TableGen type definition.

Do the parsers/printers here have any test coverage?

Feb 19 2021, 7:49 PM · Restricted Project
clementval updated the diff for D96987: [flang][fir][NFC] Move remaining types to TableGen type definition.

Address review comment

Feb 19 2021, 7:48 PM · Restricted Project
clementval updated the diff for D96987: [flang][fir][NFC] Move remaining types to TableGen type definition.

Sync with fir-dev

Feb 19 2021, 6:45 PM · Restricted Project
clementval added inline comments to D97073: [flang][fir] Update flang test tool support classes..
Feb 19 2021, 12:49 PM · Restricted Project, Restricted Project
clementval accepted D97073: [flang][fir] Update flang test tool support classes..

LGTM. There are couple of clang-tidy warnings you might wants to go over before pushing.

Feb 19 2021, 12:18 PM · Restricted Project, Restricted Project
clementval updated the diff for D96987: [flang][fir][NFC] Move remaining types to TableGen type definition.

Format

Feb 19 2021, 9:02 AM · Restricted Project

Feb 18 2021

clementval added inline comments to D96987: [flang][fir][NFC] Move remaining types to TableGen type definition.
Feb 18 2021, 6:49 PM · Restricted Project
clementval updated the diff for D96987: [flang][fir][NFC] Move remaining types to TableGen type definition.

Remove useless change

Feb 18 2021, 6:49 PM · Restricted Project
clementval updated the diff for D96987: [flang][fir][NFC] Move remaining types to TableGen type definition.

Address review comment

Feb 18 2021, 6:46 PM · Restricted Project
clementval added a comment to D96982: [flang] Extension: forward refs to dummy args under IMPLICIT NONE.

+1 I have seen this being used in many weather simulation code.

Feb 18 2021, 12:29 PM · Restricted Project, Restricted Project
clementval requested review of D96987: [flang][fir][NFC] Move remaining types to TableGen type definition.
Feb 18 2021, 12:23 PM · Restricted Project

Feb 17 2021

clementval accepted D96908: [flang][fir][NFC] Merge tablegen files..
Feb 17 2021, 4:56 PM · Restricted Project

Feb 16 2021

clementval committed rG5ef029d26719: [flang][fir][NFC] Move ComplexType to TableGen type definition (authored by clementval).
[flang][fir][NFC] Move ComplexType to TableGen type definition
Feb 16 2021, 6:53 PM
clementval closed D96575: [flang][fir][NFC] Move ComplexType to TableGen type definition.
Feb 16 2021, 6:52 PM · Restricted Project
clementval updated the diff for D96575: [flang][fir][NFC] Move ComplexType to TableGen type definition.

Rebase

Feb 16 2021, 6:43 PM · Restricted Project
clementval committed rG61b8a3e7c5ac: [flang][fir][NFC] Move BoxProcType to TableGen type definition (authored by clementval).
[flang][fir][NFC] Move BoxProcType to TableGen type definition
Feb 16 2021, 6:27 PM
clementval closed D96514: [flang][fir][NFC] Move BoxProcType to TableGen type definition.
Feb 16 2021, 6:27 PM · Restricted Project
clementval updated the diff for D96514: [flang][fir][NFC] Move BoxProcType to TableGen type definition.

Rebase

Feb 16 2021, 6:26 PM · Restricted Project
clementval committed rG209bc67b78f4: [flang][fir][NFC] Move CharacterType and BoxCharType to TableGen type definition (authored by clementval).
[flang][fir][NFC] Move CharacterType and BoxCharType to TableGen type definition
Feb 16 2021, 6:15 PM
clementval closed D96446: [flang][fir][NFC] Move CharacterType and BoxCharType to TableGen type definition.
Feb 16 2021, 6:15 PM · Restricted Project, Restricted Project
clementval updated the diff for D96446: [flang][fir][NFC] Move CharacterType and BoxCharType to TableGen type definition.

Rebase

Feb 16 2021, 12:52 PM · Restricted Project, Restricted Project
clementval committed rGb86dbe0c23e3: Fix flang after D76342 (authored by clementval).
Fix flang after D76342
Feb 16 2021, 12:38 PM
clementval closed D96808: Fix flang after D76342.
Feb 16 2021, 12:38 PM · Restricted Project
clementval added a comment to D76342: [OpenMP] Implement '#pragma omp tile'.

A fix is ready here https://reviews.llvm.org/D96808

Feb 16 2021, 12:31 PM · Restricted Project, Restricted Project
clementval requested review of D96808: Fix flang after D76342.
Feb 16 2021, 12:31 PM · Restricted Project
clementval added a comment to D76342: [OpenMP] Implement '#pragma omp tile'.

@Meinersbur / @ABataev This patch is making Flang buildbots failing.

Feb 16 2021, 12:05 PM · Restricted Project, Restricted Project
clementval committed rG8260232cdd13: [flang][fir] Add fir-opt tool (authored by clementval).
[flang][fir] Add fir-opt tool
Feb 16 2021, 8:49 AM
clementval closed D96535: [flang][fir] Add fir-opt tool.
Feb 16 2021, 8:48 AM · Restricted Project
clementval updated the diff for D96535: [flang][fir] Add fir-opt tool.

Rebase

Feb 16 2021, 7:36 AM · Restricted Project
clementval reopened D96535: [flang][fir] Add fir-opt tool.
Feb 16 2021, 7:25 AM · Restricted Project

Feb 12 2021

clementval added a reverting change for rGdf1eeaa7b404: [flang][fir] Add fir-opt tool: rGaf186e937238: Revert "[flang][fir] Add fir-opt tool".
Feb 12 2021, 7:28 PM
clementval committed rGaf186e937238: Revert "[flang][fir] Add fir-opt tool" (authored by clementval).
Revert "[flang][fir] Add fir-opt tool"
Feb 12 2021, 7:28 PM
clementval added a reverting change for D96535: [flang][fir] Add fir-opt tool: rGaf186e937238: Revert "[flang][fir] Add fir-opt tool".
Feb 12 2021, 7:28 PM · Restricted Project
clementval committed rG8c1b63307f06: [flang][fir][NFC] Move FieldType to TableGen type definition (authored by clementval).
[flang][fir][NFC] Move FieldType to TableGen type definition
Feb 12 2021, 7:23 PM
clementval closed D96610: [flang][fir][NFC] Move FieldType to TableGen type definition.
Feb 12 2021, 7:23 PM · Restricted Project, Restricted Project
clementval committed rGdf1eeaa7b404: [flang][fir] Add fir-opt tool (authored by clementval).
[flang][fir] Add fir-opt tool
Feb 12 2021, 7:21 PM
clementval closed D96535: [flang][fir] Add fir-opt tool.
Feb 12 2021, 7:20 PM · Restricted Project
clementval accepted D96633: [flang][NFC] Minor format changes, documentation.
Feb 12 2021, 2:55 PM · Restricted Project
clementval accepted D96630: [flang][fir][NFC] Move code from FIRDialect.h into a new header..
Feb 12 2021, 2:53 PM · Restricted Project
clementval updated the diff for D96446: [flang][fir][NFC] Move CharacterType and BoxCharType to TableGen type definition.

Keep fir_ prefix

Feb 12 2021, 1:33 PM · Restricted Project, Restricted Project
clementval updated the diff for D96575: [flang][fir][NFC] Move ComplexType to TableGen type definition.

Keep fir_ prefix

Feb 12 2021, 1:26 PM · Restricted Project
clementval updated the diff for D96514: [flang][fir][NFC] Move BoxProcType to TableGen type definition.

Keep fir_ prefix

Feb 12 2021, 1:18 PM · Restricted Project
clementval updated the diff for D96610: [flang][fir][NFC] Move FieldType to TableGen type definition.

Keep fir_ prefix

Feb 12 2021, 1:12 PM · Restricted Project, Restricted Project
clementval added a comment to D96610: [flang][fir][NFC] Move FieldType to TableGen type definition.

LGTM

All these type refactoring to table gen are fairly mechanical, I'm fine if you just push them with post-commit review. Or you could migrate all of them at once and sent one revision. Whatever works best.

Feb 12 2021, 12:14 PM · Restricted Project, Restricted Project
clementval updated the diff for D96610: [flang][fir][NFC] Move FieldType to TableGen type definition.

Add printer

Feb 12 2021, 8:07 AM · Restricted Project, Restricted Project
clementval added a project to D96610: [flang][fir][NFC] Move FieldType to TableGen type definition: Restricted Project.
Feb 12 2021, 8:07 AM · Restricted Project, Restricted Project
clementval requested review of D96610: [flang][fir][NFC] Move FieldType to TableGen type definition.
Feb 12 2021, 7:52 AM · Restricted Project, Restricted Project

Feb 11 2021

clementval requested review of D96575: [flang][fir][NFC] Move ComplexType to TableGen type definition.
Feb 11 2021, 8:13 PM · Restricted Project
clementval committed rGa48bee2294b6: [flang][fir][NFC] Move BoxType to TableGen type definition (authored by clementval).
[flang][fir][NFC] Move BoxType to TableGen type definition
Feb 11 2021, 3:10 PM
clementval closed D96476: [flang][fir][NFC] Move BoxType to TableGen type definition.
Feb 11 2021, 3:10 PM · Restricted Project
clementval added inline comments to D96535: [flang][fir] Add fir-opt tool.
Feb 11 2021, 1:38 PM · Restricted Project
clementval updated the diff for D96535: [flang][fir] Add fir-opt tool.

Address review comments

Feb 11 2021, 1:38 PM · Restricted Project
clementval updated the diff for D96535: [flang][fir] Add fir-opt tool.

Address review comment

Feb 11 2021, 1:12 PM · Restricted Project
clementval added a comment to D96535: [flang][fir] Add fir-opt tool.

Thanks, I wrote exactly this locally before seeing this patch! :)

Thanks for the review.

Feb 11 2021, 1:12 PM · Restricted Project
clementval updated the diff for D96535: [flang][fir] Add fir-opt tool.

Add missing new line

Feb 11 2021, 12:46 PM · Restricted Project
clementval added inline comments to D96514: [flang][fir][NFC] Move BoxProcType to TableGen type definition.
Feb 11 2021, 12:02 PM · Restricted Project
clementval requested review of D96535: [flang][fir] Add fir-opt tool.
Feb 11 2021, 12:01 PM · Restricted Project
clementval updated the diff for D96476: [flang][fir][NFC] Move BoxType to TableGen type definition.

Fix warning error + rebase

Feb 11 2021, 11:39 AM · Restricted Project
clementval reopened D96476: [flang][fir][NFC] Move BoxType to TableGen type definition.
Feb 11 2021, 11:39 AM · Restricted Project