Page MenuHomePhabricator

clementval (Valentin Clement)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 12 2019, 1:05 PM (50 w, 3 d)

Recent Activity

Wed, Nov 25

clementval updated the diff for D91873: [flang][openacc] Add clause validity tests for the kernels directive.

Allow wait clause multiple times

Wed, Nov 25, 1:07 PM · Restricted Project, Restricted Project
clementval updated the diff for D92123: [flang][openacc] Update serial construct clauses for OpenACC 3.1.

Push correct patch version

Wed, Nov 25, 12:48 PM · Restricted Project, Restricted Project
clementval added a project to D92120: [flang][openacc] Update reference to OpenACC 3.1 specification: Restricted Project.
Wed, Nov 25, 12:29 PM · Restricted Project, Restricted Project, Restricted Project
clementval added a project to D92123: [flang][openacc] Update serial construct clauses for OpenACC 3.1: Restricted Project.
Wed, Nov 25, 12:29 PM · Restricted Project, Restricted Project
clementval requested review of D92123: [flang][openacc] Update serial construct clauses for OpenACC 3.1.
Wed, Nov 25, 12:24 PM · Restricted Project, Restricted Project
clementval abandoned D91883: [flang][openacc] Add clause validity tests for the serial directive.

Close this patch since clauses have changed For OpenACC 3.1 and these tests will be added to a new patch where clauses will be changes as well.

Wed, Nov 25, 12:16 PM · Restricted Project, Restricted Project
clementval requested review of D92120: [flang][openacc] Update reference to OpenACC 3.1 specification.
Wed, Nov 25, 12:01 PM · Restricted Project, Restricted Project, Restricted Project
clementval added inline comments to D90184: [flang][openacc] Semantic check for cache directive.
Wed, Nov 25, 7:28 AM · Restricted Project, Restricted Project
clementval committed rGe73d8c793a50: [flang][openacc] Semantic check for cache directive (authored by clementval).
[flang][openacc] Semantic check for cache directive
Wed, Nov 25, 7:28 AM
clementval closed D90184: [flang][openacc] Semantic check for cache directive.
Wed, Nov 25, 7:28 AM · Restricted Project, Restricted Project

Tue, Nov 24

clementval added a project to D92065: [flang][openacc] Lower parallel loop combined construct: Restricted Project.
Tue, Nov 24, 4:31 PM · Restricted Project, Restricted Project
clementval requested review of D92065: [flang][openacc] Lower parallel loop combined construct.
Tue, Nov 24, 4:31 PM · Restricted Project, Restricted Project
clementval added a project to D92064: [flang][openacc] Remove duplicated code for clause lowering: Restricted Project.
Tue, Nov 24, 4:30 PM · Restricted Project, Restricted Project
clementval requested review of D92064: [flang][openacc] Remove duplicated code for clause lowering.
Tue, Nov 24, 4:26 PM · Restricted Project, Restricted Project
clementval added a comment to D90488: [flang][openacc] Lower init and shutdown directive.

I'm fine with leaving it there for now, looking forward to see everything upstream!

Tue, Nov 24, 4:02 PM · Restricted Project, Restricted Project
clementval added a comment to D90488: [flang][openacc] Lower init and shutdown directive.

If this can't be tested / is dead code, I'm not super comfortable having this in-tree. What is the plan for fir-dev development to move upstream, I'm still quite puzzled and don't understand why the development does not happen in tree, I think I asked on the mailing list but never got an answer.

Tue, Nov 24, 2:57 PM · Restricted Project, Restricted Project
clementval added a comment to D90488: [flang][openacc] Lower init and shutdown directive.

Do you have tests for this?

Test still live in the fir-dev branch. Since not all the infra is present for the test to be executed, there were not upstreamed yet. the rest of the fir-dev branch should be upstream very soon but I can hardly influence that.

I'd like to see IR -> IR unit-test (mlir-opt style) provided here. I don't think it is reasonable to upstream code without proper testing.

Tue, Nov 24, 1:53 PM · Restricted Project, Restricted Project
clementval added a comment to D90489: [flang][openacc] Lower wait directive.

Same as D90488: what is the testing story here?

Tue, Nov 24, 12:56 PM · Restricted Project, Restricted Project
clementval added a comment to D90488: [flang][openacc] Lower init and shutdown directive.

Do you have tests for this?

Tue, Nov 24, 12:56 PM · Restricted Project, Restricted Project
clementval updated the diff for D90184: [flang][openacc] Semantic check for cache directive.

Rebase + add couple of test cases

Tue, Nov 24, 12:54 PM · Restricted Project, Restricted Project
clementval added inline comments to D90184: [flang][openacc] Semantic check for cache directive.
Tue, Nov 24, 12:54 PM · Restricted Project, Restricted Project
clementval added inline comments to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Tue, Nov 24, 8:34 AM · Restricted Project, Restricted Project
clementval added a comment to D89879: [Flang][OpenMP-5.0] Semantic checks for flush construct..

Some small comments

Tue, Nov 24, 7:31 AM · Restricted Project, Restricted Project
clementval added a comment to D89583: [Flang][OpenMP] Semantic checks for Atomic construct..

I guess you need to rebase this now that the memory-order-clause is in.

Tue, Nov 24, 7:27 AM · Restricted Project, Restricted Project

Mon, Nov 23

clementval added a comment to D91653: [LLVMFrontend][openacc] Add basic unit tests for functions in LLVMFrontendOpenACC.

@Meinersbur Ping.

Mon, Nov 23, 11:28 AM · Restricted Project

Sat, Nov 21

clementval added a comment to D89860: [Flang][OpenMP 4.5] Add semantic check for OpenMP ordered and collapse clause.

Fine for me too

Sat, Nov 21, 3:04 PM · Restricted Project, Restricted Project, Restricted Project
clementval committed rG952c9d3a91de: [NFC] Fix typo in atomic (authored by clementval).
[NFC] Fix typo in atomic
Sat, Nov 21, 11:33 AM
clementval committed rGaa179d809909: [flang][openmp] Separate memory-order-clause parser creating OmpClause node (authored by clementval).
[flang][openmp] Separate memory-order-clause parser creating OmpClause node
Sat, Nov 21, 11:32 AM
clementval closed D91839: [flang][openmp] Separate memory-order-clause parser creating OmpClause node.
Sat, Nov 21, 11:31 AM · Restricted Project, Restricted Project
clementval accepted D91909: [flang][openmp] Fix bug in `OmpClause::Hint` clause which was missing to generate inside in OMP.cpp.inc file..
Sat, Nov 21, 3:55 AM · Restricted Project, Restricted Project

Fri, Nov 20

clementval committed rG553e364194ac: [flang][openacc] Add clause validity tests for the host_data directive (authored by clementval).
[flang][openacc] Add clause validity tests for the host_data directive
Fri, Nov 20, 5:17 PM
clementval closed D91889: [flang][openacc] Add clause validity tests for the host_data directive.
Fri, Nov 20, 5:17 PM · Restricted Project
clementval updated the diff for D91889: [flang][openacc] Add clause validity tests for the host_data directive.

Rebase

Fri, Nov 20, 5:10 PM · Restricted Project
clementval added a comment to D91889: [flang][openacc] Add clause validity tests for the host_data directive.

LGTM.

Fri, Nov 20, 5:05 PM · Restricted Project
clementval committed rG755674b715b1: [flang][openacc] Add clause validity tests for the parallel directive (authored by clementval).
[flang][openacc] Add clause validity tests for the parallel directive
Fri, Nov 20, 5:05 PM
clementval closed D91871: [flang][openacc] Add clause validity tests for the parallel directive.
Fri, Nov 20, 5:05 PM · Restricted Project, Restricted Project
clementval requested review of D91889: [flang][openacc] Add clause validity tests for the host_data directive.
Fri, Nov 20, 12:49 PM · Restricted Project
clementval requested review of D91888: [flang][openacc] Add clause validaty tests for data construct + fix default restriction.
Fri, Nov 20, 12:40 PM · Restricted Project
clementval added a project to D91883: [flang][openacc] Add clause validity tests for the serial directive: Restricted Project.
Fri, Nov 20, 11:28 AM · Restricted Project, Restricted Project
clementval updated the diff for D91883: [flang][openacc] Add clause validity tests for the serial directive.

Remove blank lines added by mistake

Fri, Nov 20, 11:21 AM · Restricted Project, Restricted Project
clementval requested review of D91883: [flang][openacc] Add clause validity tests for the serial directive.
Fri, Nov 20, 11:01 AM · Restricted Project, Restricted Project
clementval added a comment to D91871: [flang][openacc] Add clause validity tests for the parallel directive.

IIUC, the rational for adding these tests was to just add clauses which might be missing from the list of AccClause ?

Fri, Nov 20, 10:22 AM · Restricted Project, Restricted Project
clementval added a comment to D90786: [flang][openacc] Add more parsing/sema tests for init and shutdown directives.

Is there any conclusion on this ?

Fri, Nov 20, 10:18 AM · Restricted Project
clementval updated the diff for D91839: [flang][openmp] Separate memory-order-clause parser creating OmpClause node.

Fix spec references in comment

Fri, Nov 20, 10:16 AM · Restricted Project, Restricted Project
clementval added inline comments to D91839: [flang][openmp] Separate memory-order-clause parser creating OmpClause node.
Fri, Nov 20, 10:14 AM · Restricted Project, Restricted Project
clementval added a project to D91873: [flang][openacc] Add clause validity tests for the kernels directive: Restricted Project.
Fri, Nov 20, 8:42 AM · Restricted Project, Restricted Project
clementval requested review of D91873: [flang][openacc] Add clause validity tests for the kernels directive.
Fri, Nov 20, 8:42 AM · Restricted Project, Restricted Project
clementval updated the summary of D91871: [flang][openacc] Add clause validity tests for the parallel directive.
Fri, Nov 20, 8:41 AM · Restricted Project, Restricted Project
clementval requested review of D91871: [flang][openacc] Add clause validity tests for the parallel directive.
Fri, Nov 20, 8:13 AM · Restricted Project, Restricted Project
clementval added inline comments to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Fri, Nov 20, 8:08 AM · Restricted Project, Restricted Project
clementval added a project to D91839: [flang][openmp] Separate memory-order-clause parser creating OmpClause node: Restricted Project.
Fri, Nov 20, 4:45 AM · Restricted Project, Restricted Project

Thu, Nov 19

clementval updated the diff for D91839: [flang][openmp] Separate memory-order-clause parser creating OmpClause node.

Remove commented line

Thu, Nov 19, 7:49 PM · Restricted Project, Restricted Project
clementval requested review of D91839: [flang][openmp] Separate memory-order-clause parser creating OmpClause node.
Thu, Nov 19, 7:47 PM · Restricted Project, Restricted Project

Wed, Nov 18

clementval added a comment to D90834: [Flang][OpenMP][NFC][2/2] Reorder OmpStructureChecker and simplify it..

Small style comment

Wed, Nov 18, 11:38 AM · Restricted Project, Restricted Project

Tue, Nov 17

clementval added a comment to D91653: [LLVMFrontend][openacc] Add basic unit tests for functions in LLVMFrontendOpenACC.

@Meinersbur Thanks for the review. Just updated the patch.

Tue, Nov 17, 4:21 PM · Restricted Project
clementval updated the diff for D91653: [LLVMFrontend][openacc] Add basic unit tests for functions in LLVMFrontendOpenACC.

New line

Tue, Nov 17, 4:20 PM · Restricted Project
clementval updated the diff for D91653: [LLVMFrontend][openacc] Add basic unit tests for functions in LLVMFrontendOpenACC.

Address review comments

Tue, Nov 17, 4:19 PM · Restricted Project
clementval accepted D91643: [LLVMFronted][tests] Add basic OpenMP parsing tests..

LGTM

Tue, Nov 17, 11:47 AM · Restricted Project, Restricted Project
clementval edited reviewers for D91653: [LLVMFrontend][openacc] Add basic unit tests for functions in LLVMFrontendOpenACC, added: Meinersbur; removed: clementval.
Tue, Nov 17, 11:46 AM · Restricted Project
clementval requested review of D91653: [LLVMFrontend][openacc] Add basic unit tests for functions in LLVMFrontendOpenACC.
Tue, Nov 17, 11:34 AM · Restricted Project
clementval added a comment to D91470: Switch libLLVMFrontendOpenACC to be a regular CMake library and not a "component".

I see. We should add some unittests for the functions in that file.

Tue, Nov 17, 7:10 AM · Restricted Project

Fri, Nov 13

clementval added a comment to D91470: Switch libLLVMFrontendOpenACC to be a regular CMake library and not a "component".

I think it is very unusual to have a library in LLVM that isn't used in LLVM and so does not come with any testing, so yes it'd be better to do so.
I'm not actually sure if llvm-config just relies implicitly on this?

Fri, Nov 13, 6:11 PM · Restricted Project
clementval added a comment to D91470: Switch libLLVMFrontendOpenACC to be a regular CMake library and not a "component".

You are right, at the moment it is not connected directly to LLVM itself. It was done like this a little bit blindly follow what was done for for the libLLVMFrontendOpenMP.

Is the code in ACC.cpp the kind of thing that could be unit-tested?

Fri, Nov 13, 5:45 PM · Restricted Project
clementval accepted D91470: Switch libLLVMFrontendOpenACC to be a regular CMake library and not a "component".

@clementval : it isn't clear why this is in llvm/lib/Frontend/? Should this be a top-level frontend/lib kind of structure? There isn't any user of this inside LLVM right now other than flang and it isn't clear to me how it connects to LLVM itself.

Fri, Nov 13, 5:35 PM · Restricted Project
clementval requested changes to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.
Fri, Nov 13, 5:19 PM · Restricted Project, Restricted Project, Restricted Project
clementval added a comment to D90848: llvmbuildectomy - part 2.

Are there any OpenACC specific tests?

AFAICT after a quick look through the monorepo, there doesn't seem to be any llvm-specific tests for OpenACC.

Fri, Nov 13, 5:17 PM · Restricted Project
clementval added a comment to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

@clementval had some changes for the OpenACC reduction operator in the following commit. I am not sure whether it is related to this issue.
https://reviews.llvm.org/D86296

Fri, Nov 13, 8:10 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Nov 12

clementval added inline comments to D90834: [Flang][OpenMP][NFC][2/2] Reorder OmpStructureChecker and simplify it..
Thu, Nov 12, 7:53 AM · Restricted Project, Restricted Project

Mon, Nov 9

clementval accepted D89860: [Flang][OpenMP 4.5] Add semantic check for OpenMP ordered and collapse clause.
Mon, Nov 9, 12:40 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Nov 5

clementval committed rG9914a8737f52: [flang][openacc] Add parsing tests and semantic check for set directive (authored by clementval).
[flang][openacc] Add parsing tests and semantic check for set directive
Thu, Nov 5, 7:59 PM
clementval closed D90771: [flang][openacc] Add parsing tests and semantic check for set directive.
Thu, Nov 5, 7:59 PM · Restricted Project, Restricted Project
clementval updated the diff for D90771: [flang][openacc] Add parsing tests and semantic check for set directive.

Rebase

Thu, Nov 5, 7:51 PM · Restricted Project, Restricted Project
clementval updated the diff for D90771: [flang][openacc] Add parsing tests and semantic check for set directive.

Rebase + address review comment

Thu, Nov 5, 7:35 PM · Restricted Project, Restricted Project
clementval committed rGa8a10acba2a7: [openacc][openmp] Allow duplicate between required and allowed once/exclusive (authored by clementval).
[openacc][openmp] Allow duplicate between required and allowed once/exclusive
Thu, Nov 5, 1:21 PM
clementval closed D90770: [openacc][openmp] Allow duplicate between required and allowed once/exclusive.
Thu, Nov 5, 1:21 PM · Restricted Project
clementval updated the diff for D90770: [openacc][openmp] Allow duplicate between required and allowed once/exclusive.

Rebase + address review comments

Thu, Nov 5, 12:02 PM · Restricted Project
clementval added inline comments to D90770: [openacc][openmp] Allow duplicate between required and allowed once/exclusive.
Thu, Nov 5, 11:42 AM · Restricted Project
clementval added inline comments to D90770: [openacc][openmp] Allow duplicate between required and allowed once/exclusive.
Thu, Nov 5, 7:21 AM · Restricted Project
clementval accepted D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause.

Ok from my side. Maybe @kiranchandramohan wants to double check the latest changes.

Thu, Nov 5, 7:18 AM · Restricted Project, Restricted Project, Restricted Project
clementval added a comment to D90834: [Flang][OpenMP][NFC][2/2] Reorder OmpStructureChecker and simplify it..

Thanks for moving those to TableGen and common infra. This makes lots of sense. Small comment about the list with comma.

Thu, Nov 5, 7:17 AM · Restricted Project, Restricted Project
clementval added inline comments to D90786: [flang][openacc] Add more parsing/sema tests for init and shutdown directives.
Thu, Nov 5, 7:11 AM · Restricted Project

Wed, Nov 4

clementval committed rG1dad9d4282cc: [flang][openacc] Lower wait directive (authored by clementval).
[flang][openacc] Lower wait directive
Wed, Nov 4, 6:16 PM
clementval closed D90489: [flang][openacc] Lower wait directive.
Wed, Nov 4, 6:16 PM · Restricted Project, Restricted Project
clementval updated the diff for D90489: [flang][openacc] Lower wait directive.

Rebase

Wed, Nov 4, 4:58 PM · Restricted Project, Restricted Project
clementval committed rG4ec7f7e45a6c: [flang][openacc] Lower init and shutdown directive (authored by clementval).
[flang][openacc] Lower init and shutdown directive
Wed, Nov 4, 4:31 PM
clementval closed D90488: [flang][openacc] Lower init and shutdown directive.
Wed, Nov 4, 4:30 PM · Restricted Project, Restricted Project
clementval updated the diff for D90488: [flang][openacc] Lower init and shutdown directive.

Rebase

Wed, Nov 4, 3:15 PM · Restricted Project, Restricted Project
clementval committed rGb45ea4451a9e: [flang][openacc] Lower update directive (authored by clementval).
[flang][openacc] Lower update directive
Wed, Nov 4, 12:48 PM
clementval closed D90472: [flang][openacc] Lower update directive.
Wed, Nov 4, 12:48 PM · Restricted Project, Restricted Project
clementval requested review of D90786: [flang][openacc] Add more parsing/sema tests for init and shutdown directives.
Wed, Nov 4, 12:31 PM · Restricted Project
clementval updated the diff for D90472: [flang][openacc] Lower update directive.

Rebase

Wed, Nov 4, 12:28 PM · Restricted Project, Restricted Project
clementval committed rGc71adeff24ca: [flang][openacc] Lower enter data directive (authored by clementval).
[flang][openacc] Lower enter data directive
Wed, Nov 4, 12:18 PM
clementval closed D90470: [flang][openacc] Lower enter data directive.
Wed, Nov 4, 12:17 PM · Restricted Project, Restricted Project
clementval updated the diff for D90470: [flang][openacc] Lower enter data directive.

Rebase

Wed, Nov 4, 11:56 AM · Restricted Project, Restricted Project
clementval committed rG2e73a1f9faaf: [flang][openacc] Lower exit data directive (authored by clementval).
[flang][openacc] Lower exit data directive
Wed, Nov 4, 11:35 AM
clementval closed D90467: [flang][openacc] Lower exit data directive.
Wed, Nov 4, 11:34 AM · Restricted Project, Restricted Project
clementval added a project to D90771: [flang][openacc] Add parsing tests and semantic check for set directive: Restricted Project.
Wed, Nov 4, 9:00 AM · Restricted Project, Restricted Project
clementval updated the diff for D90771: [flang][openacc] Add parsing tests and semantic check for set directive.

Remove unwanted code

Wed, Nov 4, 8:59 AM · Restricted Project, Restricted Project
clementval requested review of D90771: [flang][openacc] Add parsing tests and semantic check for set directive.
Wed, Nov 4, 8:58 AM · Restricted Project, Restricted Project
clementval requested review of D90770: [openacc][openmp] Allow duplicate between required and allowed once/exclusive.
Wed, Nov 4, 8:55 AM · Restricted Project