Page MenuHomePhabricator

tskeith (Tim Keith)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 19 2019, 3:28 PM (56 w, 3 d)

Recent Activity

Fri, Jan 15

tskeith accepted D94815: [flang] Create names to allow access to inaccessible specifics.
Fri, Jan 15, 2:14 PM · Restricted Project, Restricted Project
tskeith accepted D94781: [flang] Disallow INTENT attribute on procedure dummy arguments.
Fri, Jan 15, 7:52 AM · Restricted Project, Restricted Project

Thu, Jan 14

tskeith committed rGd6acf3c2012b: [flang] Fix use-associated procedure in generic (authored by tskeith).
[flang] Fix use-associated procedure in generic
Thu, Jan 14, 4:32 PM
tskeith closed D94696: [flang] Fix use-associated procedure in generic.
Thu, Jan 14, 4:32 PM · Restricted Project, Restricted Project
tskeith requested review of D94696: [flang] Fix use-associated procedure in generic.
Thu, Jan 14, 9:04 AM · Restricted Project, Restricted Project
tskeith added inline comments to D94228: [flang][driver] Support fixed form detection.
Thu, Jan 14, 7:13 AM · Restricted Project, Restricted Project
tskeith committed rG3e41ab18db22: [flang] Fix dangling pointer in LabelEnforce (authored by tskeith).
[flang] Fix dangling pointer in LabelEnforce
Thu, Jan 14, 6:53 AM
tskeith closed D94618: [flang] Fix dangling pointer in LabelEnforce.
Thu, Jan 14, 6:52 AM · Restricted Project, Restricted Project

Wed, Jan 13

tskeith accepted D94636: [flang] Fix some module file issues exposed by Whizard.
Wed, Jan 13, 4:14 PM · Restricted Project, Restricted Project
tskeith committed rG18278ff1aac4: [flang] Fix accessibility of USEd name in .mod file (authored by tskeith).
[flang] Fix accessibility of USEd name in .mod file
Wed, Jan 13, 12:53 PM
tskeith closed D94602: [flang] Fix accessibility of USEd name in .mod file.
Wed, Jan 13, 12:53 PM · Restricted Project, Restricted Project
tskeith added a reviewer for D94618: [flang] Fix dangling pointer in LabelEnforce: sameeranjoshi.
Wed, Jan 13, 11:14 AM · Restricted Project, Restricted Project
tskeith requested review of D94618: [flang] Fix dangling pointer in LabelEnforce.
Wed, Jan 13, 11:02 AM · Restricted Project, Restricted Project
tskeith added inline comments to D93453: [flang][driver] Add support for `-I`.
Wed, Jan 13, 9:31 AM · Restricted Project, Restricted Project
tskeith requested review of D94602: [flang] Fix accessibility of USEd name in .mod file.
Wed, Jan 13, 7:40 AM · Restricted Project, Restricted Project

Tue, Jan 12

tskeith accepted D94561: [flang] Fix classification of shape inquiries in specification exprs.
Tue, Jan 12, 6:30 PM · Restricted Project, Restricted Project
tskeith added inline comments to D94228: [flang][driver] Support fixed form detection.
Tue, Jan 12, 5:16 PM · Restricted Project, Restricted Project

Mon, Dec 28

tskeith committed rGf782d5ea86f6: [flang] Detect call to abstract interface (authored by tskeith).
[flang] Detect call to abstract interface
Mon, Dec 28, 4:42 PM
tskeith closed D93872: [flang] Detect call to abstract interface.
Mon, Dec 28, 4:42 PM · Restricted Project, Restricted Project
tskeith requested review of D93872: [flang] Detect call to abstract interface.
Mon, Dec 28, 1:24 PM · Restricted Project, Restricted Project
tskeith committed rGd55627d221be: [flang] Fix bugs in .mod file for abstract interface (authored by tskeith).
[flang] Fix bugs in .mod file for abstract interface
Mon, Dec 28, 8:51 AM
tskeith closed D93572: [flang] Fix bugs in .mod file for abstract interface.
Mon, Dec 28, 8:50 AM · Restricted Project, Restricted Project

Dec 18 2020

tskeith committed rGbf0870d8640d: [flang] Fix bug in IMPLICIT NONE(EXTERNAL) (authored by tskeith).
[flang] Fix bug in IMPLICIT NONE(EXTERNAL)
Dec 18 2020, 5:44 PM
tskeith closed D93552: [flang] Fix bug in IMPLICIT NONE(EXTERNAL).
Dec 18 2020, 5:44 PM · Restricted Project, Restricted Project
tskeith requested review of D93572: [flang] Fix bugs in .mod file for abstract interface.
Dec 18 2020, 4:50 PM · Restricted Project, Restricted Project
tskeith added inline comments to D93552: [flang] Fix bug in IMPLICIT NONE(EXTERNAL).
Dec 18 2020, 11:31 AM · Restricted Project, Restricted Project
tskeith added inline comments to D93051: [Flang][openmp] Add semantic checks for OpenMP critical construct..
Dec 18 2020, 10:24 AM · Restricted Project
tskeith requested review of D93552: [flang] Fix bug in IMPLICIT NONE(EXTERNAL).
Dec 18 2020, 9:31 AM · Restricted Project, Restricted Project
tskeith retitled D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive from [flang]Add General Semantic Checks for Allocate Directive to [flang][openmp] Add General Semantic Checks for Allocate Directive.
Dec 18 2020, 7:19 AM · Restricted Project, Restricted Project

Dec 17 2020

tskeith committed rGf6b577ed5bf6: [flang] Fix -intrinsic-module-directory in flang script (authored by tskeith).
[flang] Fix -intrinsic-module-directory in flang script
Dec 17 2020, 7:09 PM
tskeith closed D93496: [flang] Fix -intrinsic-module-directory in flang script.
Dec 17 2020, 7:08 PM · Restricted Project, Restricted Project
tskeith added a comment to D93496: [flang] Fix -intrinsic-module-directory in flang script.

You need a test that depends on intrinsic modules:

Dec 17 2020, 4:56 PM · Restricted Project, Restricted Project
tskeith requested review of D93496: [flang] Fix -intrinsic-module-directory in flang script.
Dec 17 2020, 3:53 PM · Restricted Project, Restricted Project
tskeith added inline comments to D93401: [flang][driver] Add support for `-D`, `-U`.
Dec 17 2020, 8:25 AM · Restricted Project, Restricted Project

Dec 16 2020

tskeith added inline comments to D92672: [flang][openacc] Enforce restriction on routine directive and clauses.
Dec 16 2020, 11:11 AM · Restricted Project, Restricted Project
tskeith accepted D93345: [flang] Handle undeclared names in EQUIVALENCE statements.
Dec 16 2020, 11:01 AM · Restricted Project, Restricted Project
tskeith committed rG7082de56b7ad: [flang] Handle multiple names for same operator (authored by tskeith).
[flang] Handle multiple names for same operator
Dec 16 2020, 7:07 AM
tskeith closed D93344: [flang] Handle multiple names for same operator.
Dec 16 2020, 7:07 AM · Restricted Project, Restricted Project
tskeith updated the diff for D93344: [flang] Handle multiple names for same operator.

Make operatorPrefix constexpr.

Dec 16 2020, 7:02 AM · Restricted Project, Restricted Project

Dec 15 2020

tskeith added a comment to D93344: [flang] Handle multiple names for same operator.

I'm not sure how to layer one patch on top of another. I tried doing an "arc patch D93343" followed by "arc patch D93344". The second command said that it successfully committed the patch, but then it said "Cherry Pick Failed!" How do I combine both patches?

Dec 15 2020, 4:42 PM · Restricted Project, Restricted Project
tskeith added a comment to D93344: [flang] Handle multiple names for same operator.

Could the same effect be accomplished by instead canonicalizing operator(...) names in the output of the prescanner?

Dec 15 2020, 4:41 PM · Restricted Project, Restricted Project
tskeith added a comment to D93345: [flang] Handle undeclared names in EQUIVALENCE statements.

Sorry, I didn't see Peter's comments until after I submitted mine.

Dec 15 2020, 4:23 PM · Restricted Project, Restricted Project
tskeith added inline comments to D93345: [flang] Handle undeclared names in EQUIVALENCE statements.
Dec 15 2020, 4:22 PM · Restricted Project, Restricted Project
tskeith committed rG3a0352b85c14: [flang] Fix bug with USE of USE of generic (authored by tskeith).
[flang] Fix bug with USE of USE of generic
Dec 15 2020, 4:12 PM
tskeith closed D93343: [flang] Fix bug with USE of USE of generic.
Dec 15 2020, 4:12 PM · Restricted Project, Restricted Project
tskeith accepted D93322: [flang] Implement STORAGE_SIZE(), SIZEOF(), C_SIZEOF().
Dec 15 2020, 4:10 PM · Restricted Project, Restricted Project
tskeith accepted D93320: [flang] Fix false error message for "ptr => func()" array conformance.
Dec 15 2020, 3:09 PM · Restricted Project, Restricted Project
tskeith added inline comments to D93320: [flang] Fix false error message for "ptr => func()" array conformance.
Dec 15 2020, 2:55 PM · Restricted Project, Restricted Project
tskeith added a comment to D93344: [flang] Handle multiple names for same operator.

Note: this change depends on D93343

Dec 15 2020, 2:48 PM · Restricted Project, Restricted Project
tskeith requested review of D93344: [flang] Handle multiple names for same operator.
Dec 15 2020, 2:47 PM · Restricted Project, Restricted Project
tskeith requested review of D93343: [flang] Fix bug with USE of USE of generic.
Dec 15 2020, 2:46 PM · Restricted Project, Restricted Project

Dec 9 2020

tskeith abandoned D92978: [flang] Fix bug with USE of USE of generic.

I'm going to look at this more. There may be another problem.

Dec 9 2020, 4:41 PM · Restricted Project, Restricted Project
tskeith requested review of D92978: [flang] Fix bug with USE of USE of generic.
Dec 9 2020, 3:54 PM · Restricted Project, Restricted Project

Dec 7 2020

tskeith accepted D92783: [flang] Improve initializer semantics, esp. for component default values.

LGTM

Dec 7 2020, 1:36 PM · Restricted Project, Restricted Project

Dec 4 2020

tskeith added inline comments to D92638: [Flang][openmp]Fix crash in OpenMP semantic check( bug 48308).
Dec 4 2020, 8:54 AM · Restricted Project

Dec 3 2020

tskeith accepted D92501: [flang] Fix bogus message on interface procedure argument names.
Dec 3 2020, 10:24 AM · Restricted Project, Restricted Project

Dec 2 2020

tskeith committed rG86f59de13b80: [flang] Fix bugs related to merging generics during USE (authored by tskeith).
[flang] Fix bugs related to merging generics during USE
Dec 2 2020, 3:14 PM
tskeith closed D92492: [flang] Fix bugs related to merging generics during USE.
Dec 2 2020, 3:14 PM · Restricted Project, Restricted Project
tskeith added inline comments to D92492: [flang] Fix bugs related to merging generics during USE.
Dec 2 2020, 3:13 PM · Restricted Project, Restricted Project
tskeith updated the diff for D92492: [flang] Fix bugs related to merging generics during USE.

Address review comments

Dec 2 2020, 3:12 PM · Restricted Project, Restricted Project
tskeith committed rG1f525ece4abf: [flang][NFC] Add GetTopLevelUnitContaining functions (authored by tskeith).
[flang][NFC] Add GetTopLevelUnitContaining functions
Dec 2 2020, 10:29 AM
tskeith closed D92491: [flang][NFC] Add GetTopLevelUnitContaining functions.
Dec 2 2020, 10:29 AM · Restricted Project, Restricted Project
tskeith added inline comments to D92491: [flang][NFC] Add GetTopLevelUnitContaining functions.
Dec 2 2020, 10:28 AM · Restricted Project, Restricted Project
tskeith added inline comments to D92492: [flang] Fix bugs related to merging generics during USE.
Dec 2 2020, 10:28 AM · Restricted Project, Restricted Project
tskeith added a comment to D92492: [flang] Fix bugs related to merging generics during USE.

Note that this change depends on https://reviews.llvm.org/D92491

Dec 2 2020, 9:19 AM · Restricted Project, Restricted Project
tskeith added reviewers for D92492: [flang] Fix bugs related to merging generics during USE: klausler, PeteSteinfeld.
Dec 2 2020, 9:18 AM · Restricted Project, Restricted Project
tskeith added reviewers for D92491: [flang][NFC] Add GetTopLevelUnitContaining functions: klausler, PeteSteinfeld.
Dec 2 2020, 9:18 AM · Restricted Project, Restricted Project
tskeith requested review of D92492: [flang] Fix bugs related to merging generics during USE.
Dec 2 2020, 9:16 AM · Restricted Project, Restricted Project
tskeith requested review of D92491: [flang][NFC] Add GetTopLevelUnitContaining functions.
Dec 2 2020, 9:15 AM · Restricted Project, Restricted Project

Nov 25 2020

tskeith added inline comments to D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.
Nov 25 2020, 4:36 PM · Restricted Project, Restricted Project, Restricted Project

Nov 21 2020

tskeith removed a reviewer for D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause: tskeith.
Nov 21 2020, 6:09 PM · Restricted Project, Restricted Project, Restricted Project

Nov 16 2020

tskeith accepted D91560: [flang] Duplicate names for ac-implied-do variables erroneously cause errors.
Nov 16 2020, 12:25 PM · Restricted Project, Restricted Project
tskeith accepted D91537: [flang][f18] Remove "-fdebug-resolve-names".
Nov 16 2020, 7:38 AM · Restricted Project, Restricted Project

Nov 13 2020

tskeith accepted D91440: [flang] Fix "EQ" comparison of arrays.
Nov 13 2020, 2:31 PM · Restricted Project, Restricted Project
tskeith requested changes to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.
Nov 13 2020, 1:31 PM · Restricted Project, Restricted Project, Restricted Project

Nov 12 2020

tskeith accepted D91375: [flang] Include source information in an invalid file-unit-number message.
Nov 12 2020, 1:07 PM · Restricted Project, Restricted Project

Nov 11 2020

tskeith added a comment to D91209: [flang] Fix CheckSpecificationExpr handling of associated names.

Probably IsModule and IsSubmodule have to be made inline.

Nov 11 2020, 7:50 AM · Restricted Project, Restricted Project

Nov 10 2020

tskeith accepted D91214: [flang] Use IMPLICIT from scope of external function reference.
Nov 10 2020, 4:26 PM · Restricted Project, Restricted Project
tskeith added inline comments to D91210: [flang][MSVC] Use list<Message> rather than forward_list<> in Messages.
Nov 10 2020, 4:25 PM · Restricted Project, Restricted Project

Oct 30 2020

tskeith accepted D90499: [flang] Plug error recovery hole for erroneous subscripts.
Oct 30 2020, 4:33 PM · Restricted Project, Restricted Project
tskeith accepted D90492: [flang] Better error messages & more cases caught for bad forward refs.
Oct 30 2020, 4:23 PM · Restricted Project, Restricted Project

Oct 23 2020

tskeith accepted D90049: [flang] Tighten rules to resolve procedure as intrinsic procedure.
Oct 23 2020, 9:21 AM · Restricted Project, Restricted Project

Oct 20 2020

tskeith accepted D89829: [flang] Fix call to CHECK() on erroneous subroutine declaration.
Oct 20 2020, 3:41 PM · Restricted Project, Restricted Project

Oct 19 2020

tskeith accepted D87906: [Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct..
Oct 19 2020, 7:29 AM · Restricted Project, Restricted Project
tskeith accepted D89611: [flang] Add name match checks for interface procedures.
Oct 19 2020, 7:08 AM · Restricted Project, Restricted Project

Oct 17 2020

tskeith added inline comments to D89611: [flang] Add name match checks for interface procedures.
Oct 17 2020, 8:31 AM · Restricted Project, Restricted Project

Oct 16 2020

tskeith added a comment to D89340: [MLIR, OpenMP] Introduce extra helper function for clauses of `ParallelOp`.
  1. Does the EnumToString function in the parser work for this enum value?
Oct 16 2020, 8:50 AM · Restricted Project, Restricted Project, Restricted Project

Oct 15 2020

tskeith added inline comments to D87906: [Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct..
Oct 15 2020, 7:32 AM · Restricted Project, Restricted Project

Oct 14 2020

tskeith added inline comments to D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause.
Oct 14 2020, 10:28 AM · Restricted Project, Restricted Project, Restricted Project

Oct 9 2020

tskeith added inline comments to D87906: [Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct..
Oct 9 2020, 9:19 AM · Restricted Project, Restricted Project

Oct 5 2020

tskeith accepted D88688: [flang] Make binary->decimal conversion buffer sizes accurate.
Oct 5 2020, 11:38 AM · Restricted Project, Restricted Project
tskeith added inline comments to D87906: [Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct..
Oct 5 2020, 9:19 AM · Restricted Project, Restricted Project

Oct 2 2020

tskeith added a comment to D88723: [flang] Fix build errors for clang-10.

FYI, the io-stmt.h warning is fixed in https://reviews.llvm.org/D88711 (with them all declared as class). The other change is still needed.

Oct 2 2020, 1:12 PM · Restricted Project, Restricted Project
tskeith committed rG11622d0fed8c: [flang][NFC] Fix mis-matched struct/class declarations (authored by tskeith).
[flang][NFC] Fix mis-matched struct/class declarations
Oct 2 2020, 1:09 PM
tskeith closed D88711: [flang][NFC] Fix mis-matched struct/class declarations.
Oct 2 2020, 1:09 PM · Restricted Project, Restricted Project
tskeith updated the diff for D88711: [flang][NFC] Fix mis-matched struct/class declarations.

Make them all class rather than struct.

Oct 2 2020, 1:08 PM · Restricted Project, Restricted Project
tskeith accepted D88723: [flang] Fix build errors for clang-10.
Oct 2 2020, 6:50 AM · Restricted Project, Restricted Project
tskeith added a project to D88723: [flang] Fix build errors for clang-10: Restricted Project.
Oct 2 2020, 6:50 AM · Restricted Project, Restricted Project

Oct 1 2020

tskeith added a comment to D88711: [flang][NFC] Fix mis-matched struct/class declarations.

The other specialization of this template is a class, though, so maybe the best fix is to change the earlier template struct to a class so that they all are so. I've got a fix on the way that does that, I think.

Oct 1 2020, 5:37 PM · Restricted Project, Restricted Project
tskeith retitled D88711: [flang][NFC] Fix mis-matched struct/class declarations from [flang] Fix mis-matched struct/class declarations to [flang][NFC] Fix mis-matched struct/class declarations.
Oct 1 2020, 4:53 PM · Restricted Project, Restricted Project