Page MenuHomePhabricator

tskeith (Tim Keith)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 19 2019, 3:28 PM (32 w, 6 d)

Recent Activity

Today

tskeith committed rG6d2d73059fda: [flang] Fix compilation warning in check-directive-structure.h (authored by tskeith).
[flang] Fix compilation warning in check-directive-structure.h
Wed, Aug 5, 6:04 PM
tskeith closed D85383: [flang] Fix compilation warning in check-directive-structure.h.
Wed, Aug 5, 6:03 PM · Restricted Project, Restricted Project
tskeith requested review of D85383: [flang] Fix compilation warning in check-directive-structure.h.
Wed, Aug 5, 5:37 PM · Restricted Project, Restricted Project
tskeith accepted D84334: [flang] Version information in flang/f18.

Thanks, looks good to me.

Wed, Aug 5, 4:41 PM · Restricted Project
tskeith added inline comments to D84334: [flang] Version information in flang/f18.
Wed, Aug 5, 3:35 PM · Restricted Project
tskeith added a comment to D85363: [flang] Add options to control IMPLICIT NONE.

The gfortran options is -fimplicit-none. It doesn't appear to have an inverse, but following the convention would be -fno-implicit-none. I think there is value using the same spelling for this option.

But -fno-implicit-none would mean "don't assume IMPLICIT NONE where it doesn't appear", not "ignore IMPLICIT NONE where it does appear." Not the same thing.

Wed, Aug 5, 2:48 PM · Restricted Project, Restricted Project
tskeith requested review of D85363: [flang] Add options to control IMPLICIT NONE.
Wed, Aug 5, 2:17 PM · Restricted Project, Restricted Project
tskeith requested changes to D84334: [flang] Version information in flang/f18.
Wed, Aug 5, 7:23 AM · Restricted Project
tskeith retitled D84334: [flang] Version information in flang/f18 from Version information in flang/f18 to [flang] Version information in flang/f18.
Wed, Aug 5, 7:00 AM · Restricted Project

Yesterday

tskeith added a comment to D84334: [flang] Version information in flang/f18.
  • For the macros, I think the flang/test/Preprocessing" directory would be the best place but that directory is full of non-tests (which we need to delete really) so we can't add a real test there at the moment. Perhaps add a new test to flang/test/Driver for now that runs flang with -E and checks the substitutions work.

The preprocessing tests are being executed now so that would be a good place to add a test.

Tue, Aug 4, 7:40 AM · Restricted Project

Mon, Aug 3

tskeith accepted D85166: [flang] Implement runtime support for INQUIRE statements.
Mon, Aug 3, 5:09 PM · Restricted Project, Restricted Project
tskeith accepted D85161: [flang] Defer "next input record" processing until handlers established.
Mon, Aug 3, 4:19 PM · Restricted Project, Restricted Project
tskeith accepted D85160: [flang] Acquire file accessibility, size, positioning.
Mon, Aug 3, 4:16 PM · Restricted Project, Restricted Project
tskeith accepted D85163: [flang] Handle spaces (more) correctly in REAL input.
Mon, Aug 3, 4:04 PM · Restricted Project, Restricted Project
tskeith accepted D85162: [flang] Remove unneeded RoundDefault enumerator, and fix spelling in comments.
Mon, Aug 3, 3:21 PM · Restricted Project, Restricted Project
tskeith accepted D85164: [flang] Make preprocessing behavior tests runnable as regression tests.
Mon, Aug 3, 2:58 PM · Restricted Project, Restricted Project
tskeith committed rG0d454e8e0870: [flang] Fix bug detecting intrinsic function (authored by tskeith).
[flang] Fix bug detecting intrinsic function
Mon, Aug 3, 12:22 PM
tskeith closed D85136: [flang] Fix bug detecting intrinsic function.
Mon, Aug 3, 12:22 PM · Restricted Project, Restricted Project
tskeith requested review of D85136: [flang] Fix bug detecting intrinsic function.
Mon, Aug 3, 7:44 AM · Restricted Project, Restricted Project

Sat, Aug 1

tskeith accepted D85078: [flang] Fix multi-config generator builds.

Works for me -- thanks.

Sat, Aug 1, 5:31 PM · Restricted Project

Fri, Jul 31

tskeith added a comment to D84022: [flang] Fix multi-config generator builds..

@tskeith could you explain your rationale for reverting this please? I don't think it's reasonable to expect all patches to be tested with out-of-tree configurations by people that don't perform them, and reverting here seems to raise that expectation.

Out-of-tree builds is a supported configuration, documented in the README. I don't think developers should be expected to test every possible build configuration, but if a change breaks a build and can't be fixed right away it should be reverted.

Fri, Jul 31, 3:00 PM · Restricted Project
tskeith added a comment to D84022: [flang] Fix multi-config generator builds..

I've reverted this in 765b81f6b9 so that out-of-tree builds work while we figure this out.

Fri, Jul 31, 11:12 AM · Restricted Project
tskeith added a reverting change for rG332170356e35: [flang] Fix multi-config generator builds.: rG765b81f6b93f: Revert "[flang] Fix multi-config generator builds.".
Fri, Jul 31, 11:11 AM
tskeith committed rG765b81f6b93f: Revert "[flang] Fix multi-config generator builds." (authored by tskeith).
Revert "[flang] Fix multi-config generator builds."
Fri, Jul 31, 11:11 AM
tskeith added a reverting change for D84022: [flang] Fix multi-config generator builds.: rG765b81f6b93f: Revert "[flang] Fix multi-config generator builds.".
Fri, Jul 31, 11:11 AM · Restricted Project

Thu, Jul 30

tskeith accepted D84904: [flang] Fixes for RESHAPE().
Thu, Jul 30, 4:03 PM · Restricted Project, Restricted Project
tskeith added inline comments to D84904: [flang] Fixes for RESHAPE().
Thu, Jul 30, 9:11 AM · Restricted Project, Restricted Project
tskeith added inline comments to D84904: [flang] Fixes for RESHAPE().
Thu, Jul 30, 9:06 AM · Restricted Project, Restricted Project
tskeith committed rG38272f45fed3: [flang] Create HostAssoc symbols for uplevel references (authored by tskeith).
[flang] Create HostAssoc symbols for uplevel references
Thu, Jul 30, 7:12 AM
tskeith closed D84889: [flang] Create HostAssoc symbols for uplevel references.
Thu, Jul 30, 7:12 AM · Restricted Project, Restricted Project

Wed, Jul 29

tskeith requested review of D84889: [flang] Create HostAssoc symbols for uplevel references.
Wed, Jul 29, 2:32 PM · Restricted Project, Restricted Project
tskeith committed rG2c662f3d3d95: [flang] Fix bug with intrinsic in type declaration stmt (authored by tskeith).
[flang] Fix bug with intrinsic in type declaration stmt
Wed, Jul 29, 7:24 AM
tskeith closed D84702: [flang] Fix bug with intrinsic in type declaration stmt.
Wed, Jul 29, 7:23 AM · Restricted Project, Restricted Project

Tue, Jul 28

tskeith committed rG9500d48de367: [flang][NFC] Extract name resolution for OpenACC & OpenMP into new file (authored by tskeith).
[flang][NFC] Extract name resolution for OpenACC & OpenMP into new file
Tue, Jul 28, 4:39 PM
tskeith closed D84768: [flang][NFC] Extract name resolution for OpenACC & OpenMP into new file.
Tue, Jul 28, 4:38 PM · Restricted Project, Restricted Project
tskeith updated the diff for D84768: [flang][NFC] Extract name resolution for OpenACC & OpenMP into new file.

Fix clang-tidy warnings. Remove unused ResolveVariable.

Tue, Jul 28, 4:36 PM · Restricted Project, Restricted Project
tskeith added inline comments to D84768: [flang][NFC] Extract name resolution for OpenACC & OpenMP into new file.
Tue, Jul 28, 12:00 PM · Restricted Project, Restricted Project
tskeith added a comment to D84768: [flang][NFC] Extract name resolution for OpenACC & OpenMP into new file.

On my laptop with this change I see resolve-names.cpp taking about 15% less time and memory to compile.

Tue, Jul 28, 10:16 AM · Restricted Project, Restricted Project
tskeith requested review of D84768: [flang][NFC] Extract name resolution for OpenACC & OpenMP into new file.
Tue, Jul 28, 10:14 AM · Restricted Project, Restricted Project

Mon, Jul 27

tskeith added inline comments to D84702: [flang] Fix bug with intrinsic in type declaration stmt.
Mon, Jul 27, 2:13 PM · Restricted Project, Restricted Project
Herald added a project to D84702: [flang] Fix bug with intrinsic in type declaration stmt: Restricted Project.
Mon, Jul 27, 1:58 PM · Restricted Project, Restricted Project
tskeith committed rG4a4cafabc906: [flang] Temp Driver - pass the flag to change the default integer kind through… (authored by AlexisPerry).
[flang] Temp Driver - pass the flag to change the default integer kind through…
Mon, Jul 27, 9:58 AM
tskeith closed D84266: [flang] Temp Driver - pass the flag to change the default integer kind through to F18_FC.
Mon, Jul 27, 9:58 AM · Restricted Project, Restricted Project
tskeith added a comment to D84266: [flang] Temp Driver - pass the flag to change the default integer kind through to F18_FC.

I don't know what changed between my last patch and now, but I am unable to land this patch myself. I keep getting the following error:
EXCEPTION: (ConduitClientException) ERR-CONDUIT-CALL: Conduit API method "harbormaster.buildable.search" does not exist. at [<arcanist>/src/conduit/ConduitFuture.php:65]

Do any of you know how to fix this error so I can land the patch? If this isn't fixable, would one of you be willing to land the patch on my behalf? Thanks!

Mon, Jul 27, 9:55 AM · Restricted Project, Restricted Project

Sun, Jul 26

tskeith committed rG7454acdf3b7d: [flang] Fix implicit declarations in statement functions (authored by tskeith).
[flang] Fix implicit declarations in statement functions
Sun, Jul 26, 12:14 PM
tskeith closed D84588: [flang] Fix implicit declarations in statement functions.
Sun, Jul 26, 12:14 PM · Restricted Project, Restricted Project

Sat, Jul 25

Herald added a project to D84588: [flang] Fix implicit declarations in statement functions: Restricted Project.
Sat, Jul 25, 8:23 AM · Restricted Project, Restricted Project

Fri, Jul 24

tskeith added inline comments to D83998: [flang][openacc] Basic name resolution infrastructure for OpenACC construct.
Fri, Jul 24, 12:43 PM · Restricted Project, Restricted Project
tskeith added inline comments to D84504: [flang]Verify C7107, C7108, C7109 from - Clause 7 constraint checks for f18..
Fri, Jul 24, 12:40 PM · Restricted Project, Restricted Project
tskeith accepted D83998: [flang][openacc] Basic name resolution infrastructure for OpenACC construct.
Fri, Jul 24, 9:12 AM · Restricted Project, Restricted Project

Thu, Jul 23

tskeith committed rG412056e2d02f: [flang] Implicitly convert result of statement function (authored by tskeith).
[flang] Implicitly convert result of statement function
Thu, Jul 23, 5:16 PM
tskeith closed D84452: [flang] Implicitly convert result of statement function.
Thu, Jul 23, 5:16 PM · Restricted Project, Restricted Project
tskeith added a comment to D84452: [flang] Implicitly convert result of statement function.

Is there a test for this?

Thu, Jul 23, 5:13 PM · Restricted Project, Restricted Project
tskeith updated the diff for D84452: [flang] Implicitly convert result of statement function.

Address review comments.

Thu, Jul 23, 5:11 PM · Restricted Project, Restricted Project
tskeith added inline comments to D83998: [flang][openacc] Basic name resolution infrastructure for OpenACC construct.
Thu, Jul 23, 5:02 PM · Restricted Project, Restricted Project
Herald added a project to D84452: [flang] Implicitly convert result of statement function: Restricted Project.
Thu, Jul 23, 11:17 AM · Restricted Project, Restricted Project
tskeith accepted D83917: [flang] Fix an assertion error when a BOZ literal is used as a relational operator.
Thu, Jul 23, 7:39 AM · Restricted Project, Restricted Project

Sat, Jul 18

tskeith accepted D84060: [flang] Improve output from a STOP statement.
Sat, Jul 18, 10:54 AM · Restricted Project, Restricted Project

Wed, Jul 15

tskeith added inline comments to D83917: [flang] Fix an assertion error when a BOZ literal is used as a relational operator.
Wed, Jul 15, 4:43 PM · Restricted Project, Restricted Project
tskeith committed rGfa5e4482e01f: [flang] Don't use-associate intrinsics (authored by tskeith).
[flang] Don't use-associate intrinsics
Wed, Jul 15, 3:08 PM
tskeith closed D83905: [flang] Don't use-associate intrinsics.
Wed, Jul 15, 3:08 PM · Restricted Project, Restricted Project
Herald added a project to D83905: [flang] Don't use-associate intrinsics: Restricted Project.
Wed, Jul 15, 2:07 PM · Restricted Project, Restricted Project
tskeith committed rGb297563a751e: [flang] Fix erroneous application of SAVE statement (authored by tskeith).
[flang] Fix erroneous application of SAVE statement
Wed, Jul 15, 1:03 PM
tskeith closed D83899: [flang] Fix erroneous application of SAVE statement.
Wed, Jul 15, 1:03 PM · Restricted Project, Restricted Project
Herald added a project to D83899: [flang] Fix erroneous application of SAVE statement: Restricted Project.
Wed, Jul 15, 12:32 PM · Restricted Project, Restricted Project

Tue, Jul 14

tskeith accepted D83807: [flang][openacc] Semantic checks for OpenACC 3.0 clauses validity.
Tue, Jul 14, 5:34 PM · Restricted Project, Restricted Project
tskeith added inline comments to D83807: [flang][openacc] Semantic checks for OpenACC 3.0 clauses validity.
Tue, Jul 14, 2:01 PM · Restricted Project, Restricted Project
tskeith accepted D83809: [flang] Implement anonymous units in the runtime.
Tue, Jul 14, 12:51 PM · Restricted Project, Restricted Project
tskeith accepted D83808: [flang] Refine CR handling.
Tue, Jul 14, 12:51 PM · Restricted Project, Restricted Project
tskeith accepted D83806: [flang] Tuning up binary->decimal conversion.
Tue, Jul 14, 12:48 PM · Restricted Project, Restricted Project
tskeith accepted D83793: [flang] Fix a crash when an array constructor contains an unlimited polymorphic value.
Tue, Jul 14, 11:31 AM · Restricted Project, Restricted Project

Mon, Jul 13

tskeith committed rG3780d3eb1001: [flang] Use octal escapes for character literals in modfiles (authored by tskeith).
[flang] Use octal escapes for character literals in modfiles
Mon, Jul 13, 12:19 PM
tskeith closed D83703: [flang] Use octal escapes for character literals in modfiles.
Mon, Jul 13, 12:19 PM · Restricted Project, Restricted Project
tskeith added inline comments to D83703: [flang] Use octal escapes for character literals in modfiles.
Mon, Jul 13, 12:08 PM · Restricted Project, Restricted Project
tskeith updated the diff for D83703: [flang] Use octal escapes for character literals in modfiles.

Use common::ScopedSet instead of explicit destructor.

Mon, Jul 13, 12:06 PM · Restricted Project, Restricted Project
tskeith added a comment to D83488: [flang] Change the default F18_FC to gfortran.

When I build with this change I'm seeing a couple of modfile tests failing. The problem is that when isPGF90 is false, parser::useHexadecimalEscapeSequences is set to be true which affects how escape sequences are written in character literals in modfiles.

Mon, Jul 13, 11:34 AM · Restricted Project, Restricted Project
Herald added a project to D83703: [flang] Use octal escapes for character literals in modfiles: Restricted Project.
Mon, Jul 13, 11:29 AM · Restricted Project, Restricted Project
tskeith added a comment to D83649: [flang][openacc] OpenACC 3.0 parser.

When I try to build this (on macos) I get a missing include for unordered_map:

In file included from ../../flang/lib/Semantics/check-omp-structure.h:159:
include/llvm/Frontend/OpenMP/OMP.cpp.inc:2123:6: error: no template named 'unordered_map' in namespace 'std'
std::unordered_map<llvm::omp::Directive, OpenMPDirectiveClauses>
~~~~~^

Adding the include to check-omp-structure.h fixes the build problem.

Mon, Jul 13, 7:14 AM · Restricted Project, Restricted Project

Thu, Jul 9

tskeith accepted D83515: [flang] Fix frontend build with -DBUILD_SHARED_LIBS=On.
Thu, Jul 9, 3:47 PM · Restricted Project, Restricted Project
tskeith accepted D83491: [flang] Fix a crash when creating generics from a copy.
Thu, Jul 9, 3:06 PM · Restricted Project, Restricted Project
tskeith added inline comments to D83491: [flang] Fix a crash when creating generics from a copy.
Thu, Jul 9, 11:07 AM · Restricted Project, Restricted Project

Wed, Jul 8

tskeith accepted D83410: [flang] Fix a crash when cosubscript list is empty.
Wed, Jul 8, 10:09 AM · Restricted Project, Restricted Project

Tue, Jul 7

tskeith accepted D83352: [flang] Fix CHARACTER length folding problem.
Tue, Jul 7, 3:41 PM · Restricted Project, Restricted Project
tskeith added inline comments to D83320: Hand port modfile01.f90 from test_modfile.sh to FileCheck.
Tue, Jul 7, 2:19 PM · Restricted Project
tskeith accepted D83336: [flang] Support for image selectors.
Tue, Jul 7, 1:31 PM · Restricted Project, Restricted Project
tskeith committed rG4b9b64d561e9: [flang] Added missing runtime I/O definitions (authored by zacharyselk).
[flang] Added missing runtime I/O definitions
Tue, Jul 7, 12:34 PM
tskeith closed D83112: [flang] Added missing runtime I/O definitions.
Tue, Jul 7, 12:34 PM · Restricted Project
tskeith committed rGc6a23df691fb: [flang] Make 'num_images()' intrinsic (authored by ktras).
[flang] Make 'num_images()' intrinsic
Tue, Jul 7, 12:31 PM
tskeith closed D83142: [flang] Make 'num_images()' intrinsic.
Tue, Jul 7, 12:31 PM · Restricted Project, Restricted Project
tskeith added a comment to D83142: [flang] Make 'num_images()' intrinsic.

@ktras, do you have the necessary permissions to commit this or do you need someone to do it for you?

Tue, Jul 7, 10:00 AM · Restricted Project, Restricted Project

Jul 6 2020

tskeith added a comment to D83237: [flang] Add missing include for std::min.

We must have overlapped here somehow, I actually created a revision for this a couple of hours ago
https://reviews.llvm.org/D83227

Jul 6 2020, 1:04 PM · Restricted Project, Restricted Project
tskeith committed rG1b183918184e: [flang] Add missing include for std::min (authored by tskeith).
[flang] Add missing include for std::min
Jul 6 2020, 1:03 PM
tskeith closed D83237: [flang] Add missing include for std::min.
Jul 6 2020, 1:03 PM · Restricted Project, Restricted Project
Herald added a project to D83237: [flang] Add missing include for std::min: Restricted Project.
Jul 6 2020, 9:19 AM · Restricted Project, Restricted Project
tskeith added inline comments to D83142: [flang] Make 'num_images()' intrinsic.
Jul 6 2020, 8:59 AM · Restricted Project, Restricted Project

Jul 4 2020

tskeith accepted D83162: [flang] Add fixes and missing stmts to I/O runtime API handlers (ext. I/O part 8).
Jul 4 2020, 11:49 AM · Restricted Project, Restricted Project
tskeith accepted D83151: [flang] Extend & fix per-I/O-statement state (ext. I/O work part 7).
Jul 4 2020, 10:45 AM · Restricted Project, Restricted Project
tskeith accepted D82903: [flang] Bug fix for ambiguous references to data and functions.
Jul 4 2020, 10:45 AM · Restricted Project, Restricted Project

Jul 3 2020

tskeith accepted D83108: [flang] Improve API for runtime allocator (I/O runtime work part 3).
Jul 3 2020, 8:34 AM · Restricted Project, Restricted Project

Jul 2 2020

tskeith accepted D83104: [flang] External I/O runtime work, repackaged (part 2).
Jul 2 2020, 4:45 PM · Restricted Project, Restricted Project