This is an archive of the discontinued LLVM Phabricator instance.

[flang][openacc] Add clause validity tests for the parallel directive
ClosedPublic

Authored by clementval on Nov 20 2020, 8:13 AM.

Diff Detail

Event Timeline

clementval created this revision.Nov 20 2020, 8:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 20 2020, 8:13 AM
clementval requested review of this revision.Nov 20 2020, 8:13 AM
clementval edited the summary of this revision. (Show Details)Nov 20 2020, 8:41 AM
clementval added a project: Restricted Project.
sameeranjoshi accepted this revision.Nov 20 2020, 9:43 AM

IIUC, the rational for adding these tests was to just add clauses which might be missing from the list of AccClause ?

This revision is now accepted and ready to land.Nov 20 2020, 9:43 AM
clementval added a comment.EditedNov 20 2020, 10:22 AM

IIUC, the rational for adding these tests was to just add clauses which might be missing from the list of AccClause ?

Thanks for the review! I'm currently passing on all directive and make sure that all accepted clauses are actually accepted and restrictions are in place correctly. In this case, ACC.td and the sema restrictions were correct already but just wanted to make sure to add those tests to avoid future regression.