This is an archive of the discontinued LLVM Phabricator instance.

[CodeGen][X86] Remove unused trivial check-prefixes from all CodeGen/X86 directory.
ClosedPublic

Authored by pengfei on Nov 15 2020, 7:52 AM.

Details

Summary

I had manually removed unused prefixes from CodeGen/X86 directory for more than 100 tests.
I checked the change history for each of them at the beginning, and then I mainly focused on the format since I found all of the unused prefixes were result from either insensible copy or residuum after functional update.
I think it's OK to remove the remaining X86 tests by script now. I wrote a rough script which works for me in most tests. I put it in llvm/utils temporarily for review and hope it may help other components owners.
The tests in this patch are all generated by the tool and checked by update tool for the autogenerated tests. I skimmed them and checked about 30 tests and didn't find any unexpected changes.

Diff Detail

Event Timeline

pengfei created this revision.Nov 15 2020, 7:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 15 2020, 7:52 AM
pengfei requested review of this revision.Nov 15 2020, 7:52 AM
mtrofin accepted this revision.Nov 15 2020, 8:20 AM

Thanks for doing this! LGTM, but please wait for signoff from a x86 owner.

Thanks!

This revision is now accepted and ready to land.Nov 15 2020, 8:20 AM
MaskRay accepted this revision.Nov 15 2020, 9:54 AM

For these utils/update_llc_test_checks.py tests, have you verified that running them does not give warnings? (update_llc_test_checks.py reports warnings if there are unsatisfied check prefixes)

LGTM - please can you reply to llvm-dev's unused-prefix thread mentioning your script (and how to use it) to help others still working on this?

For these utils/update_llc_test_checks.py tests, have you verified that running them does not give warnings? (update_llc_test_checks.py reports warnings if there are unsatisfied check prefixes)

The script checks conflicting warning for them and put those tests into Failed list. I only added the Done ones in this patch. I also run update_llc/mir_test_checks.py manually for all autogenerated tests in this patch. No warning been reported except a unparseable one for error check.

LGTM - please can you reply to llvm-dev's unused-prefix thread mentioning your script (and how to use it) to help others still working on this?

Sure, I'll put the usage in that thread.

This revision was landed with ongoing or failed builds.Nov 15 2020, 6:08 PM
This revision was automatically updated to reflect the committed changes.