Page MenuHomePhabricator

mtrofin (Mircea Trofin)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 10 2015, 11:03 PM (297 w, 1 d)

Recent Activity

Yesterday

mtrofin added inline comments to D89707: [AutoFDO][llvm-profgen] Parse mmap events from perf script.
Wed, Oct 21, 3:57 PM · Restricted Project
mtrofin requested review of D89912: [NFC][MC] Use MCRegister for ReachingDefAnalysis APIs.
Wed, Oct 21, 2:37 PM · Restricted Project
mtrofin added reviewers for D89858: [NFC] Set return type of getStackPointerRegisterToSaveRestore to Register: dsanders, qcolombet.
Wed, Oct 21, 9:08 AM · Restricted Project
mtrofin accepted D89858: [NFC] Set return type of getStackPointerRegisterToSaveRestore to Register.

lgtm

Wed, Oct 21, 9:05 AM · Restricted Project
mtrofin added a comment to D81515: [llvm] Release-mode ML InlineAdvisor.

Hi Mircea, Could you also provide the information on what specific tf-nightly, protobuf version did you guys use to save the two frozen models? Unfortunately, I don't seem to load the models using a number of tf-nighly versions and am receiving

google.protobuf.message.DecodeError: Error parsing message

After further investigations, I noticed this has been done using the new TF's SavedModel method and Keras : https://tensorflow.google.cn/tutorials/keras/save_and_load?hl=en#save_checkpoints_during_training

Would you provide scripts to load the model and see the layers?

Thanks,

  • Amir
Wed, Oct 21, 8:51 AM · Restricted Project

Tue, Oct 20

mtrofin committed rG5e731625f3d6: [NFC][MC] Use [MC]Register in MachineVerifier (authored by mtrofin).
[NFC][MC] Use [MC]Register in MachineVerifier
Tue, Oct 20, 8:43 PM
mtrofin closed D89815: [NFC][MC] Use [MC]Register in MachineVerifier.
Tue, Oct 20, 8:42 PM · Restricted Project
mtrofin requested review of D89815: [NFC][MC] Use [MC]Register in MachineVerifier.
Tue, Oct 20, 12:11 PM · Restricted Project
mtrofin committed rGe902269c493c: [NFC][Regalloc] Type 2 statics in terms of Register (authored by mtrofin).
[NFC][Regalloc] Type 2 statics in terms of Register
Tue, Oct 20, 11:28 AM
mtrofin closed D89718: [NFC][Regalloc] Type 2 statics in terms of Register.
Tue, Oct 20, 11:28 AM · Restricted Project

Mon, Oct 19

mtrofin added a comment to D89617: Prepend "uniq" to symbol names hash with -funique-internal-linkage-names.

Incorporating snehasishk@'s suggestion that "llvmuniq" is a better prefix for tools to search on.

Having "llvmuniq" makes reduces chances of collisions with other suffixes that might get introduced. Consistent with the ".llvm." prefix for lto global name promotion suffixes.

Mon, Oct 19, 12:39 PM · Restricted Project
mtrofin requested review of D89718: [NFC][Regalloc] Type 2 statics in terms of Register.
Mon, Oct 19, 11:16 AM · Restricted Project
mtrofin committed rG225065b9a8e7: [NFC][MC] Type [MC]Register uses in MachineTraceMetrics (authored by mtrofin).
[NFC][MC] Type [MC]Register uses in MachineTraceMetrics
Mon, Oct 19, 10:03 AM
mtrofin closed D89710: [NFC][MC] Type [MC]Register uses in MachineTraceMetrics.
Mon, Oct 19, 10:03 AM · Restricted Project
mtrofin requested review of D89710: [NFC][MC] Type [MC]Register uses in MachineTraceMetrics.
Mon, Oct 19, 9:25 AM · Restricted Project
mtrofin committed rGd454328ea885: [ML] Add final reward logging facility. (authored by mtrofin).
[ML] Add final reward logging facility.
Mon, Oct 19, 8:49 AM
mtrofin closed D89626: [ML] Add final reward logging facility..
Mon, Oct 19, 8:49 AM · Restricted Project

Sun, Oct 18

mtrofin added inline comments to D89626: [ML] Add final reward logging facility..
Sun, Oct 18, 10:15 PM · Restricted Project

Sat, Oct 17

mtrofin requested review of D89626: [ML] Add final reward logging facility..
Sat, Oct 17, 9:08 AM · Restricted Project
mtrofin committed rG57d3e9cd9bca: [NFC][ML] Avoid source of some signed/unsigned warnings in TFUtilsTest (authored by mtrofin).
[NFC][ML] Avoid source of some signed/unsigned warnings in TFUtilsTest
Sat, Oct 17, 9:07 AM
mtrofin added inline comments to D89617: Prepend "uniq" to symbol names hash with -funique-internal-linkage-names.
Sat, Oct 17, 8:05 AM · Restricted Project

Wed, Oct 14

mtrofin committed rGc8fcffe775c1: [NFC][MC] Use MCRegister in Machine{Sink|Pipeliner}.cpp (authored by mtrofin).
[NFC][MC] Use MCRegister in Machine{Sink|Pipeliner}.cpp
Wed, Oct 14, 8:42 AM
mtrofin closed D89328: [NFC][MC] Use MCRegister in Machine{Sink|Pipeliner}.cpp.
Wed, Oct 14, 8:42 AM · Restricted Project

Tue, Oct 13

mtrofin requested review of D89328: [NFC][MC] Use MCRegister in Machine{Sink|Pipeliner}.cpp.
Tue, Oct 13, 9:48 AM · Restricted Project
mtrofin committed rG08097fc6a974: [NFC][Regalloc] Use MCRegister in MachineCopyPropagation (authored by mtrofin).
[NFC][Regalloc] Use MCRegister in MachineCopyPropagation
Tue, Oct 13, 9:05 AM
mtrofin closed D89250: [NFC][Regalloc] Use MCRegister in MachineCopyPropagation.
Tue, Oct 13, 9:05 AM · Restricted Project

Mon, Oct 12

mtrofin requested review of D89250: [NFC][Regalloc] Use MCRegister in MachineCopyPropagation.
Mon, Oct 12, 9:39 AM · Restricted Project
mtrofin committed rG43d347995c33: [NFC][MC] Use MCRegister in LiveRangeMatrix (authored by mtrofin).
[NFC][MC] Use MCRegister in LiveRangeMatrix
Mon, Oct 12, 8:55 AM
mtrofin closed D89145: [NFC][MC] Use MCRegister in LiveRangeMatrix.
Mon, Oct 12, 8:54 AM · Restricted Project
mtrofin committed rG596a9f6b89d0: [NFC][Regalloc] Pass VirtRegMap by reference. (authored by mtrofin).
[NFC][Regalloc] Pass VirtRegMap by reference.
Mon, Oct 12, 8:42 AM
mtrofin closed D89171: [NFC][Regalloc] Pass VirtRegMap by reference..
Mon, Oct 12, 8:42 AM · Restricted Project

Fri, Oct 9

mtrofin requested review of D89171: [NFC][Regalloc] Pass VirtRegMap by reference..
Fri, Oct 9, 4:46 PM · Restricted Project
mtrofin committed rGc11c20fb0036: [NFC][Regalloc] VirtRegAuxInfo::Hint does not need to be a field (authored by mtrofin).
[NFC][Regalloc] VirtRegAuxInfo::Hint does not need to be a field
Fri, Oct 9, 1:42 PM
mtrofin committed rG62e2ac6461d4: [NFC][Regalloc] Fix coding style in CalcSpillWeights (authored by mtrofin).
[NFC][Regalloc] Fix coding style in CalcSpillWeights
Fri, Oct 9, 12:22 PM
mtrofin requested review of D89145: [NFC][MC] Use MCRegister in LiveRangeMatrix.
Fri, Oct 9, 10:05 AM · Restricted Project

Thu, Oct 8

mtrofin committed rG4cfc4025cc14: [NFC][MC] MCRegister API typing. (authored by mtrofin).
[NFC][MC] MCRegister API typing.
Thu, Oct 8, 3:09 PM
mtrofin closed D89018: [NFC][MC] MCRegister API typing..
Thu, Oct 8, 3:08 PM · Restricted Project
mtrofin added inline comments to D89018: [NFC][MC] MCRegister API typing..
Thu, Oct 8, 11:21 AM · Restricted Project
mtrofin updated the diff for D89018: [NFC][MC] MCRegister API typing..

feedback

Thu, Oct 8, 11:21 AM · Restricted Project

Wed, Oct 7

mtrofin requested review of D89018: [NFC][MC] MCRegister API typing..
Wed, Oct 7, 4:13 PM · Restricted Project
mtrofin committed rG297655c123b3: [NFC][regalloc] Use MCRegister instead of unsigned in InterferenceCache (authored by mtrofin).
[NFC][regalloc] Use MCRegister instead of unsigned in InterferenceCache
Wed, Oct 7, 2:49 PM
mtrofin closed D88930: [NFC][regalloc] Use MCRegister instead of unsigned in InterferenceCache.
Wed, Oct 7, 2:49 PM · Restricted Project
mtrofin committed rGac2018da616c: [NFC][MLInliner] Getters should return by reference (authored by mtrofin).
[NFC][MLInliner] Getters should return by reference
Wed, Oct 7, 1:56 PM

Tue, Oct 6

mtrofin requested review of D88930: [NFC][regalloc] Use MCRegister instead of unsigned in InterferenceCache.
Tue, Oct 6, 2:40 PM · Restricted Project
mtrofin committed rGd85b845cb255: [NFC][MC] Type uses of MCRegUnitIterator as MCRegister (authored by mtrofin).
[NFC][MC] Type uses of MCRegUnitIterator as MCRegister
Tue, Oct 6, 12:10 PM
mtrofin closed D88862: [NFC][MC] Type uses of MCRegUnitIterator as MCRegister.
Tue, Oct 6, 12:10 PM · Restricted Project

Mon, Oct 5

mtrofin committed rG36bb1fb1fe62: [MLInliner] Factor out logging (authored by mtrofin).
[MLInliner] Factor out logging
Mon, Oct 5, 6:09 PM
mtrofin closed D88770: [MLInliner] Factor out logging.
Mon, Oct 5, 6:09 PM · Restricted Project
mtrofin added a reviewer for D88862: [NFC][MC] Type uses of MCRegUnitIterator as MCRegister: gjain.
Mon, Oct 5, 4:52 PM · Restricted Project
mtrofin requested review of D88862: [NFC][MC] Type uses of MCRegUnitIterator as MCRegister.
Mon, Oct 5, 4:51 PM · Restricted Project
mtrofin added inline comments to D88770: [MLInliner] Factor out logging.
Mon, Oct 5, 4:40 PM · Restricted Project
mtrofin updated the diff for D88770: [MLInliner] Factor out logging.

feedback

Mon, Oct 5, 4:40 PM · Restricted Project
mtrofin committed rGb268e24d4349: [NFC][regalloc] Separate iteration from AllocationOrder (authored by mtrofin).
[NFC][regalloc] Separate iteration from AllocationOrder
Mon, Oct 5, 4:19 PM
mtrofin closed D88256: [NFC][regalloc] Separate iteration from AllocationOrder.
Mon, Oct 5, 4:19 PM · Restricted Project
mtrofin added inline comments to D88256: [NFC][regalloc] Separate iteration from AllocationOrder.
Mon, Oct 5, 2:42 PM · Restricted Project
mtrofin updated the diff for D88256: [NFC][regalloc] Separate iteration from AllocationOrder.

feedback

Mon, Oct 5, 2:42 PM · Restricted Project
mtrofin added inline comments to D88256: [NFC][regalloc] Separate iteration from AllocationOrder.
Mon, Oct 5, 12:15 PM · Restricted Project
mtrofin updated the diff for D88256: [NFC][regalloc] Separate iteration from AllocationOrder.

feedback

Mon, Oct 5, 12:15 PM · Restricted Project
mtrofin committed rG82ebbcfb059b: [NFC][regalloc] Model weight normalization as a virtual (authored by mtrofin).
[NFC][regalloc] Model weight normalization as a virtual
Mon, Oct 5, 11:42 AM
mtrofin closed D88713: [NFC][regalloc] Model weight normalization as a virtual.
Mon, Oct 5, 11:42 AM · Restricted Project
mtrofin added inline comments to D88770: [MLInliner] Factor out logging.
Mon, Oct 5, 11:31 AM · Restricted Project
mtrofin updated the diff for D88770: [MLInliner] Factor out logging.

feedback

Mon, Oct 5, 11:31 AM · Restricted Project
mtrofin added a comment to D88256: [NFC][regalloc] Separate iteration from AllocationOrder.

Gentle reminder - thanks!

Mon, Oct 5, 10:00 AM · Restricted Project
mtrofin added a reviewer for D88713: [NFC][regalloc] Model weight normalization as a virtual: wmi.
Mon, Oct 5, 9:23 AM · Restricted Project

Sat, Oct 3

mtrofin committed rG0a3523299dec: [MC] Assert that MCRegUnitIterator operates over MCRegisters (authored by mtrofin).
[MC] Assert that MCRegUnitIterator operates over MCRegisters
Sat, Oct 3, 1:18 PM
mtrofin closed D88705: [MC] Assert that MCRegUnitIterator operates over MCRegisters.
Sat, Oct 3, 1:18 PM · Restricted Project

Fri, Oct 2

mtrofin requested review of D88770: [MLInliner] Factor out logging.
Fri, Oct 2, 8:30 PM · Restricted Project
mtrofin updated the diff for D88713: [NFC][regalloc] Model weight normalization as a virtual.

added virtual dtor

Fri, Oct 2, 9:19 AM · Restricted Project
mtrofin added a reviewer for D88705: [MC] Assert that MCRegUnitIterator operates over MCRegisters: wmi.
Fri, Oct 2, 8:00 AM · Restricted Project

Thu, Oct 1

mtrofin requested review of D88713: [NFC][regalloc] Model weight normalization as a virtual.
Thu, Oct 1, 4:55 PM · Restricted Project
mtrofin requested review of D88705: [MC] Assert that MCRegUnitIterator operates over MCRegisters.
Thu, Oct 1, 2:42 PM · Restricted Project
mtrofin committed rG17640c5aac64: [NFC] Let (MC)Register APIs check isStackSlot (authored by mtrofin).
[NFC] Let (MC)Register APIs check isStackSlot
Thu, Oct 1, 9:56 AM
mtrofin closed D88598: [NFC] Let (MC)Register APIs check isStackSlot.
Thu, Oct 1, 9:55 AM · Restricted Project

Wed, Sep 30

mtrofin added a comment to D88256: [NFC][regalloc] Separate iteration from AllocationOrder.

gentle reminder - thanks!

Wed, Sep 30, 12:02 PM · Restricted Project
mtrofin requested review of D88598: [NFC] Let (MC)Register APIs check isStackSlot.
Wed, Sep 30, 10:46 AM · Restricted Project
mtrofin committed rGd6de40f8865e: [NFC][regalloc] Make VirtRegAuxInfo part of allocator state (authored by mtrofin).
[NFC][regalloc] Make VirtRegAuxInfo part of allocator state
Wed, Sep 30, 8:13 AM
mtrofin closed D88499: [NFC][regalloc] Make VirtRegAuxInfo part of allocator state.
Wed, Sep 30, 8:13 AM · Restricted Project

Tue, Sep 29

mtrofin updated the summary of D88256: [NFC][regalloc] Separate iteration from AllocationOrder.
Tue, Sep 29, 11:11 AM · Restricted Project
mtrofin updated the diff for D88256: [NFC][regalloc] Separate iteration from AllocationOrder.

updated to follow iterator style (begin() / end())

Tue, Sep 29, 11:11 AM · Restricted Project
mtrofin committed rG6d193ba3337e: [NFC][regalloc] Unit test for AllocationOrder iteration. (authored by mtrofin).
[NFC][regalloc] Unit test for AllocationOrder iteration.
Tue, Sep 29, 10:48 AM
mtrofin closed D88455: [NFC][regalloc] Unit test for AllocationOrder iteration..
Tue, Sep 29, 10:48 AM · Restricted Project
mtrofin updated the summary of D88499: [NFC][regalloc] Make VirtRegAuxInfo part of allocator state.
Tue, Sep 29, 10:42 AM · Restricted Project
mtrofin added a comment to D88499: [NFC][regalloc] Make VirtRegAuxInfo part of allocator state.

Hi,

From the perspective of the caller, this patch exposes some implementation details that I am not sure are worth it.

Put differently, what is the expected benefits of moving VRAI life-time to the allocators?

VRAI are relatively light-weight objects and I wouldn't expect saving on the constructor to bring us any gain. So what are we after here?

Cheers,
-Quentin

Tue, Sep 29, 10:40 AM · Restricted Project
mtrofin added inline comments to D88455: [NFC][regalloc] Unit test for AllocationOrder iteration..
Tue, Sep 29, 10:33 AM · Restricted Project
mtrofin updated the diff for D88455: [NFC][regalloc] Unit test for AllocationOrder iteration..

newline

Tue, Sep 29, 10:33 AM · Restricted Project
mtrofin requested review of D88499: [NFC][regalloc] Make VirtRegAuxInfo part of allocator state.
Tue, Sep 29, 9:11 AM · Restricted Project

Mon, Sep 28

mtrofin requested review of D88455: [NFC][regalloc] Unit test for AllocationOrder iteration..
Mon, Sep 28, 4:44 PM · Restricted Project
mtrofin added a comment to D88256: [NFC][regalloc] Separate iteration from AllocationOrder.

Hi,

I like that we take the iterator path, but I don't think the current patch is clearer than the previous implementation.

First we duplicate some logic from AllocationOrder to AllocationOrder::Iterator (see my inline comment), second, I found the AllocationOrder::getIterator not iterator friendly.
What I mean here is that I would have expected a AllocationOrder::begin and AllocationOrder::end, so that we can use range based loop and so on.

As is I don't really see the value of that refactoring.

Cheers,
-Quentin

Mon, Sep 28, 4:13 PM · Restricted Project
mtrofin accepted D88371: Guard `find_library(tensorflow_c_api ...)` by checking for TENSORFLOW_C_LIB_PATH to be set by the user.

lgtm, thanks for doing this!

Mon, Sep 28, 2:06 PM · Restricted Project
mtrofin added a comment to D88371: Guard `find_library(tensorflow_c_api ...)` by checking for TENSORFLOW_C_LIB_PATH to be set by the user.

There are 2 types of TF dependencies, orthogonal from each other, controlled by TENSORFLOW_AOT_PATH and TENSORFLOW_C_LIB_PATH, respectively.

Mon, Sep 28, 8:26 AM · Restricted Project

Thu, Sep 24

mtrofin added a comment to D88256: [NFC][regalloc] Separate iteration from AllocationOrder.
In D88256#2293981, @wmi wrote:

Is the intention to have multiple iterators live for the same AllocationOrder?

Thu, Sep 24, 6:28 PM · Restricted Project
mtrofin added inline comments to D88256: [NFC][regalloc] Separate iteration from AllocationOrder.
Thu, Sep 24, 6:23 PM · Restricted Project
mtrofin requested review of D88256: [NFC][regalloc] Separate iteration from AllocationOrder.
Thu, Sep 24, 12:55 PM · Restricted Project
mtrofin committed rG89aad892a596: [NFC][regalloc] Remove unused API in AllocationOrder (authored by mtrofin).
[NFC][regalloc] Remove unused API in AllocationOrder
Thu, Sep 24, 12:26 PM
mtrofin closed D88197: [NFC][regalloc] Remove unused API in AllocationOrder.
Thu, Sep 24, 12:26 PM · Restricted Project

Wed, Sep 23

mtrofin requested review of D88197: [NFC][regalloc] Remove unused API in AllocationOrder.
Wed, Sep 23, 8:11 PM · Restricted Project
mtrofin committed rG271928792e80: Add REQUIRES to embed-bitcode-noopt.ll (authored by mtrofin).
Add REQUIRES to embed-bitcode-noopt.ll
Wed, Sep 23, 10:13 AM
mtrofin committed rG437358be7179: [clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode. (authored by mtrofin).
[clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode.
Wed, Sep 23, 9:36 AM
mtrofin closed D88114: [clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode..
Wed, Sep 23, 9:35 AM · Restricted Project
mtrofin updated the diff for D88114: [clang]Test ensuring -fembed-bitcode passed to cc1 captures pre-opt bitcode..

newline at end of file

Wed, Sep 23, 9:01 AM · Restricted Project