Details

Reviewers

rriddle
ftynse
nicolasvasilache
herhut
bondhugula
mravishankar

Commits

rGe708471395b6: [mlir][NFC] Cleanup AffineOps directory structure

Summary

NFC - Moved AffineOps related transforms

Change AffineOps Dialect structure to better group both IR and Tranforms. This included extracting transforms directly related to AffineOps. Also move AffineOps to Affine.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

rsuderman created this revision.Mar 13 2020, 1:55 PM

Herald added a reviewer: mravishankar. · View Herald TranscriptMar 13 2020, 1:55 PM

Herald added a reviewer: nicolasvasilache. · View Herald Transcript

Herald added a reviewer: herhut. · View Herald Transcript

Herald added a reviewer: aartbik. · View Herald Transcript

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: llvm-commits, Joonsoo, liufengdb and 15 others. · View Herald Transcript

Harbormaster completed remote builds in B49184: Diff 250297.Mar 13 2020, 2:03 PM

I think this has a lot of conflict potential with a revision by @ftynse, maybe check with him?

Updated CMake build to pass.

Updating D76161: Moved AffineOps IR / Transforms

Change AffineOps Dialect structure to better group both IR and Tranforms. This
included extracting transforms direclty related to AffineOps

Typo

Updating D76161: Moved AffineOps IR / Transforms

Change AffineOps Dialect structure to better group both IR and Tranforms. This
included extracting transforms direclty related to AffineOps

In D76161#1922471, @nicolasvasilache wrote:

I think this has a lot of conflict potential with a revision by @ftynse, maybe check with him?

I'll make sure to loop him in on the review.

rsuderman retitled this revision from Moved AffineOps IR / Transforms Change AffineOps Dialect structure to better group both IR and Tranforms. This included extracting transforms direclty related to AffineOps to Moved AffineOps IR / TransformsChange AffineOps Dialect structure to better group both IR and Tranforms. Thisincluded extracting transforms direclty related to AffineOps.Mar 13 2020, 4:34 PM

rsuderman removed reviewers: mravishankar, nicolasvasilache, herhut, aartbik.

Herald added a reviewer: mravishankar. · View Herald TranscriptMar 13 2020, 4:34 PM

Herald added a reviewer: nicolasvasilache. · View Herald Transcript

Herald added a reviewer: herhut. · View Herald Transcript

rsuderman edited reviewers, added: rriddle, ftynse; removed: mravishankar, nicolasvasilache, herhut.Mar 13 2020, 4:34 PM

Herald added a reviewer: mravishankar. · View Herald TranscriptMar 13 2020, 4:34 PM

Herald added a reviewer: nicolasvasilache. · View Herald Transcript

Herald added a reviewer: herhut. · View Herald Transcript

mehdi_amini added inline comments.Mar 13 2020, 5:11 PM

mlir/test/lib/Transforms/TestVectorizationUtils.cpp
16	Since you had to change all of them, and since every downstream user will have to adjust, what about also renaming the mlir/Dialect/AffineOps into mlir/Dialect/Affine ?

Harbormaster failed remote builds in B49192: Diff 250325!Mar 13 2020, 5:17 PM

Harbormaster failed remote builds in B49191: Diff 250324!

clang-format

Harbormaster failed remote builds in B49203: Diff 250338!Mar 13 2020, 6:54 PM

Please see this discussion started by @ftynse
https://llvm.discourse.group/t/rfc-canonical-file-paths-to-dialects/621
If we are doing a move, we might as well get the directory names renamed consistently. AffineOps -> Affine

bondhugula requested changes to this revision.Mar 13 2020, 9:04 PM

This revision now requires changes to proceed.Mar 13 2020, 9:04 PM

@rsuderman @mehdi_amini @bondhugula the renaming AffineOps -> Affine is part of the conflicting changes @ftynse has in flight and was holding off on submitting because internal integration would be impacted.

In D76161#1922847, @nicolasvasilache wrote:

@rsuderman @mehdi_amini @bondhugula the renaming AffineOps -> Affine is part of the conflicting changes @ftynse has in flight and was holding off on submitting because internal integration would be impacted.

Its been over a week, that isn't great justification. I'm pretty sure he's just on vacation.

mlir/include/mlir/InitAllPasses.h
29	Duplicate?

Move AffineOps to Affine

Should be updated for comments.

mlir/include/mlir/InitAllPasses.h
29	I don't see a duplicate? AffineOps/Passes.h was newly added in this CL.
mlir/test/lib/Transforms/TestVectorizationUtils.cpp
16	Moved AffineOps to Affine.

rsuderman edited the summary of this revision. (Show Details)

bmahjour removed a subscriber: bmahjour.Mar 16 2020, 11:52 AM

rriddle accepted this revision.Mar 16 2020, 11:52 AM

rriddle marked an inline comment as done.

rriddle added inline comments.

mlir/include/mlir/Dialect/Affine/EDSC/Intrinsics.h
7–8	Can you update each of these header guard comments now?
mlir/include/mlir/Dialect/Affine/Passes.h
10	AffineOps -> Affine
mlir/include/mlir/InitAllPasses.h
29	It was previously showing `+ #include "mlir/Dialect/FxpMathOps/Passes.h"`

Harbormaster failed remote builds in B49337: Diff 250600!Mar 16 2020, 12:01 PM

Update for rriddle@ comments and synced to head.

Addressed rriddle@ comments and synced to head.

Harbormaster failed remote builds in B49347: Diff 250614!Mar 16 2020, 1:08 PM

git clang-format

Harbormaster failed remote builds in B49353: Diff 250621!Mar 16 2020, 2:13 PM

mravishankar resigned from this revision.Mar 17 2020, 12:46 PM

Sync to head and reupdate.

Harbormaster completed remote builds in B49511: Diff 250921.Mar 17 2020, 3:40 PM

Can you sync to head?

Sync to head

Harbormaster failed remote builds in B49807: Diff 251492!Mar 19 2020, 4:28 PM

bondhugula accepted this revision.Mar 19 2020, 6:41 PM

This revision is now accepted and ready to land.Mar 19 2020, 6:41 PM

Synced to head.

Harbormaster failed remote builds in B49932: Diff 251715!Mar 20 2020, 1:01 PM

Closed by commit rGe708471395b6: [mlir][NFC] Cleanup AffineOps directory structure (authored by Rob Suderman <suderman@google.com>, committed by rriddle). · Explain WhyMar 20 2020, 2:40 PM

This revision was automatically updated to reflect the committed changes.

NFC - Moved AffineOps IR / TransformsClosedPublicActions

Details

Diff Detail

Event Timeline

Updating D76161: Moved AffineOps IR / Transforms

Updating D76161: Moved AffineOps IR / Transforms

Large Diff

Revision ContentsChangeset List

Diff 251772

mlir/docs/Interfaces.md

mlir/docs/Tutorials/Toy/Ch-5.md

mlir/examples/toy/Ch5/mlir/LowerToAffineLoops.cpp

mlir/examples/toy/Ch6/mlir/LowerToAffineLoops.cpp

mlir/examples/toy/Ch6/mlir/LowerToLLVM.cpp

mlir/examples/toy/Ch7/mlir/LowerToAffineLoops.cpp

mlir/examples/toy/Ch7/mlir/LowerToLLVM.cpp

mlir/include/mlir/Dialect/Affine/CMakeLists.txt

mlir/include/mlir/Dialect/Affine/EDSC/Builders.h

mlir/include/mlir/Dialect/Affine/EDSC/Intrinsics.h

mlir/include/mlir/Dialect/Affine/IR/AffineOps.h

mlir/include/mlir/Dialect/Affine/IR/AffineOps.td

mlir/include/mlir/Dialect/Affine/IR/AffineOpsBase.td

mlir/include/mlir/Dialect/Affine/IR/AffineValueMap.h

mlir/include/mlir/Dialect/Affine/IR/CMakeLists.txt

mlir/include/mlir/Dialect/Affine/Passes.h

mlir/include/mlir/Dialect/AffineOps/AffineOps.h

mlir/include/mlir/Dialect/AffineOps/AffineOps.td

mlir/include/mlir/Dialect/AffineOps/AffineOpsBase.td

mlir/include/mlir/Dialect/AffineOps/AffineValueMap.h

mlir/include/mlir/Dialect/AffineOps/CMakeLists.txt

mlir/include/mlir/Dialect/AffineOps/EDSC/Builders.h

mlir/include/mlir/Dialect/AffineOps/EDSC/Intrinsics.h

mlir/include/mlir/Dialect/CMakeLists.txt

mlir/include/mlir/Dialect/Linalg/IR/LinalgOps.td

mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td

mlir/include/mlir/Dialect/Linalg/Transforms/LinalgTransformPatterns.td

mlir/include/mlir/Dialect/Vector/VectorOps.td

mlir/include/mlir/Dialect/VectorOps/VectorOps.td

mlir/include/mlir/InitAllDialects.h

mlir/include/mlir/InitAllPasses.h

mlir/include/mlir/Transforms/Passes.h

mlir/lib/Analysis/AffineAnalysis.cpp

mlir/lib/Analysis/AffineStructures.cpp

mlir/lib/Analysis/CMakeLists.txt

mlir/lib/Analysis/LoopAnalysis.cpp

mlir/lib/Analysis/NestedMatcher.cpp

mlir/lib/Analysis/SliceAnalysis.cpp

mlir/lib/Analysis/Utils.cpp

mlir/lib/Conversion/AffineToStandard/AffineToStandard.cpp

mlir/lib/Conversion/AffineToStandard/CMakeLists.txt

mlir/lib/Conversion/LoopsToGPU/CMakeLists.txt

mlir/lib/Conversion/LoopsToGPU/LoopsToGPU.cpp

mlir/lib/Conversion/LoopsToGPU/LoopsToGPUPass.cpp

mlir/lib/Conversion/VectorToLoops/ConvertVectorToLoops.cpp

mlir/lib/Dialect/Affine/CMakeLists.txt

mlir/lib/Dialect/Affine/EDSC/Builders.cpp

mlir/lib/Dialect/Affine/EDSC/CMakeLists.txt

mlir/lib/Dialect/Affine/IR/AffineOps.cpp

mlir/lib/Dialect/Affine/IR/AffineValueMap.cpp

mlir/lib/Dialect/Affine/IR/CMakeLists.txt

mlir/lib/Dialect/Affine/Transforms/AffineDataCopyGeneration.cpp

mlir/lib/Dialect/Affine/Transforms/AffineLoopInvariantCodeMotion.cpp

mlir/lib/Dialect/Affine/Transforms/CMakeLists.txt

mlir/lib/Dialect/Affine/Transforms/SimplifyAffineStructures.cpp

mlir/lib/Dialect/AffineOps/AffineOps.cpp

mlir/lib/Dialect/AffineOps/AffineValueMap.cpp

mlir/lib/Dialect/AffineOps/CMakeLists.txt

mlir/lib/Dialect/AffineOps/EDSC/Builders.cpp

mlir/lib/Dialect/CMakeLists.txt

mlir/lib/Dialect/Linalg/EDSC/Builders.cpp

mlir/lib/Dialect/Linalg/EDSC/CMakeLists.txt

mlir/lib/Dialect/Linalg/Transforms/CMakeLists.txt

mlir/lib/Dialect/Linalg/Transforms/LinalgToLoops.cpp

mlir/lib/Dialect/Linalg/Transforms/Promotion.cpp

mlir/lib/Dialect/Linalg/Transforms/Tiling.cpp

mlir/lib/Dialect/Linalg/Utils/CMakeLists.txt

mlir/lib/Dialect/Linalg/Utils/Utils.cpp

mlir/lib/Dialect/LoopOps/Transforms/CMakeLists.txt

mlir/lib/Dialect/LoopOps/Transforms/ParallelLoopSpecialization.cpp

mlir/lib/Dialect/LoopOps/Transforms/ParallelLoopTiling.cpp

NFC - Moved AffineOps IR / Transforms
ClosedPublic
Actions

Revision Contents
Changeset List