Page MenuHomePhabricator

mravishankar (Mahesh Ravishankar)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 6 2015, 1:11 PM (306 w, 6 d)

Recent Activity

Today

mravishankar committed rG11ea2e2448a5: [mlir][Linalg] NFC: Expose some utility functions used for promotion. (authored by mravishankar).
[mlir][Linalg] NFC: Expose some utility functions used for promotion.
Mon, Nov 23, 10:36 AM
mravishankar closed D91503: [mlir][Linalg] Expose some utility functions used for promotion..
Mon, Nov 23, 10:36 AM · Restricted Project
mravishankar committed rGe65a5e5b00a3: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers) (authored by mravishankar).
[mlir][Linalg] Fuse sequence of Linalg operation (on buffers)
Mon, Nov 23, 10:32 AM
mravishankar closed D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).
Mon, Nov 23, 10:31 AM · Restricted Project
mravishankar updated the diff for D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).

Updating the change with https://reviews.llvm.org/D91503 to address some failures.

Mon, Nov 23, 10:05 AM · Restricted Project
mravishankar reopened D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).

Reopening since the commit was reverted.

Mon, Nov 23, 9:11 AM · Restricted Project

Fri, Nov 20

mravishankar updated the diff for D91503: [mlir][Linalg] Expose some utility functions used for promotion..

Reupload after reopening

Fri, Nov 20, 3:58 PM · Restricted Project
mravishankar reopened D91503: [mlir][Linalg] Expose some utility functions used for promotion..

Reopening to land after fix.

Fri, Nov 20, 3:57 PM · Restricted Project
mravishankar requested review of D91899: [mlir][Linalg] Make sure the value used to obtain tile shape is a SubViewOp/SubTensorOp..
Fri, Nov 20, 3:56 PM · Restricted Project

Thu, Nov 19

mravishankar committed rG0c59f51592ef: [mlir][Linalg] NFC: Expose some utility functions used for promotion. (authored by mravishankar).
[mlir][Linalg] NFC: Expose some utility functions used for promotion.
Thu, Nov 19, 7:06 PM
mravishankar closed D91503: [mlir][Linalg] Expose some utility functions used for promotion..
Thu, Nov 19, 7:05 PM · Restricted Project
mravishankar committed rGf8284d21a8e2: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers) (authored by mravishankar).
[mlir][Linalg] Fuse sequence of Linalg operation (on buffers)
Thu, Nov 19, 7:03 PM
mravishankar closed D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).
Thu, Nov 19, 7:03 PM · Restricted Project
mravishankar committed rG8b525c9c19f8: [mlir][Linalg] Add utility function that return static loop bounds of Linalg ops (authored by mravishankar).
[mlir][Linalg] Add utility function that return static loop bounds of Linalg ops
Thu, Nov 19, 7:01 PM
mravishankar closed D91749: [mlir][Linalg] Add utility function that return static loop bounds of Linalg ops.
Thu, Nov 19, 7:01 PM · Restricted Project
mravishankar updated the diff for D91749: [mlir][Linalg] Add utility function that return static loop bounds of Linalg ops.

Address comments

Thu, Nov 19, 7:00 PM · Restricted Project
mravishankar added inline comments to D91749: [mlir][Linalg] Add utility function that return static loop bounds of Linalg ops.
Thu, Nov 19, 6:58 PM · Restricted Project

Wed, Nov 18

mravishankar added reviewers for D91749: [mlir][Linalg] Add utility function that return static loop bounds of Linalg ops: antiagainst, ThomasRaoux, asaadaldien, hanchung.
Wed, Nov 18, 4:10 PM · Restricted Project
mravishankar requested review of D91749: [mlir][Linalg] Add utility function that return static loop bounds of Linalg ops.
Wed, Nov 18, 4:05 PM · Restricted Project
mravishankar updated the diff for D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).

Rebase

Wed, Nov 18, 4:02 PM · Restricted Project
mravishankar added inline comments to D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).
Wed, Nov 18, 4:00 PM · Restricted Project
mravishankar updated the diff for D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).

Address comments and rebase

Wed, Nov 18, 3:58 PM · Restricted Project

Tue, Nov 17

mravishankar updated the diff for D91503: [mlir][Linalg] Expose some utility functions used for promotion..

Address comment and rebase

Tue, Nov 17, 4:43 PM · Restricted Project
mravishankar committed rGb13415b59b1f: [mlir][Linalg] Add dependence type to LinalgDependenceGraphElem. (authored by mravishankar).
[mlir][Linalg] Add dependence type to LinalgDependenceGraphElem.
Tue, Nov 17, 4:33 PM
mravishankar closed D91502: [mlir][Linalg] Add dependence type to LinalgDependenceGraphElem..
Tue, Nov 17, 4:33 PM · Restricted Project

Sun, Nov 15

mravishankar added reviewers for D91322: [mlir][Linalg] Allow promotion of fused views.: antiagainst, ThomasRaoux, asaadaldien, hanchung.
Sun, Nov 15, 10:27 AM · Restricted Project
mravishankar added a comment to D91322: [mlir][Linalg] Allow promotion of fused views..

On a second look it seems like globbbing promotion with tile+fuse is maybe doing too much in one go. It might be better to avoid this. Instead https://reviews.llvm.org/D91503 exposes some utility functions that a client can use to figure out which views to promote. I am leaving this patch here for now, but intend to abandon this.

Sun, Nov 15, 10:26 AM · Restricted Project
mravishankar added reviewers for D91503: [mlir][Linalg] Expose some utility functions used for promotion.: antiagainst, hanchung, asaadaldien, ThomasRaoux.
Sun, Nov 15, 10:24 AM · Restricted Project
mravishankar added reviewers for D91502: [mlir][Linalg] Add dependence type to LinalgDependenceGraphElem.: antiagainst, hanchung, ThomasRaoux, asaadaldien.
Sun, Nov 15, 10:23 AM · Restricted Project
mravishankar requested review of D91503: [mlir][Linalg] Expose some utility functions used for promotion..
Sun, Nov 15, 10:22 AM · Restricted Project
mravishankar requested review of D91502: [mlir][Linalg] Add dependence type to LinalgDependenceGraphElem..
Sun, Nov 15, 10:22 AM · Restricted Project

Fri, Nov 13

mravishankar requested changes to D91357: [mlir][linalg] Start a named ops to generic ops pass.

Same comment as Nicolas. Seems like it is easily generalizable to all Named ops.

Fri, Nov 13, 1:07 PM · Restricted Project
mravishankar accepted D91403: [mlir][StandardToSPIRV] Extend support for lowering cmpi to SPIRV..
Fri, Nov 13, 1:05 PM · Restricted Project
mravishankar abandoned D91100: [mlir] Add eraseOp method to OpBuilder..

I refactored my dependent changes to not require this patch. So abandoning this for now. Would be good to resolve this though.

Fri, Nov 13, 12:45 PM · Restricted Project
mravishankar updated the diff for D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).

Make Tile+Fuse only tile the fusable loops and leave the unfused loops
as is. The TileAndFuse pattern does the tiling of the unfused
operations.
Address other comments.

Fri, Nov 13, 12:44 PM · Restricted Project
mravishankar committed rGbf3861bf71b6: [mlir][Linalg] Change LinalgDependenceGraph to use LinalgOp. (authored by mravishankar).
[mlir][Linalg] Change LinalgDependenceGraph to use LinalgOp.
Fri, Nov 13, 12:35 PM
mravishankar closed D91101: [mlir][Linalg] Change LinalgDependenceGraph to use LinalgOp..
Fri, Nov 13, 12:35 PM · Restricted Project
mravishankar updated the diff for D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).

Make the tileAndFuse only tile the fusable loops. Also address comments.

Fri, Nov 13, 12:16 PM · Restricted Project

Thu, Nov 12

mravishankar added a comment to D91100: [mlir] Add eraseOp method to OpBuilder..

I'm assuming the intent here is to allow for reusing the same bit of functionality from both pattern and non-pattern code? This is not the direction that I intended to move things given that I think it starts pushing OpBuilder further and further away from what it is intended to focus on(building IR). The direction I have intended to move to solve this problem is to evolve the PatternRewriter class into a more general OpRewriter class. The only method on PatternRewriter that is specific to patterns is notifyMatchFailure, but I think we could rename that to notifyRewriteFailure and it still works as a general concept. (At least, it looked fine in my WIP revision that does this, which I had intended to start pushing on soon). Thoughts on that direction?

Thu, Nov 12, 12:53 PM · Restricted Project
mravishankar committed rG5ca20851e44c: [mlir][Linalg] Improve the logic to perform tile and fuse with better… (authored by mravishankar).
[mlir][Linalg] Improve the logic to perform tile and fuse with better…
Thu, Nov 12, 12:26 AM
mravishankar closed D90579: [mlir][Linalg] Improve the logic to perform tile and fuse with better dependence tracking..
Thu, Nov 12, 12:25 AM · Restricted Project

Wed, Nov 11

mravishankar added inline comments to D90579: [mlir][Linalg] Improve the logic to perform tile and fuse with better dependence tracking..
Wed, Nov 11, 11:04 PM · Restricted Project
mravishankar updated the diff for D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).

Rebase

Wed, Nov 11, 11:04 PM · Restricted Project
mravishankar updated the diff for D90579: [mlir][Linalg] Improve the logic to perform tile and fuse with better dependence tracking..

Addressing missed minor comments.

Wed, Nov 11, 11:03 PM · Restricted Project
mravishankar requested review of D91322: [mlir][Linalg] Allow promotion of fused views..
Wed, Nov 11, 10:57 PM · Restricted Project
mravishankar updated the diff for D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).

Rebase

Wed, Nov 11, 10:57 PM · Restricted Project
mravishankar updated the diff for D90579: [mlir][Linalg] Improve the logic to perform tile and fuse with better dependence tracking..

Address comments

Wed, Nov 11, 10:56 PM · Restricted Project

Tue, Nov 10

mravishankar added inline comments to D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).
Tue, Nov 10, 1:43 AM · Restricted Project
mravishankar updated the diff for D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).

Move pass to test pass.

Tue, Nov 10, 1:43 AM · Restricted Project
mravishankar updated the diff for D90579: [mlir][Linalg] Improve the logic to perform tile and fuse with better dependence tracking..

Rebase

Tue, Nov 10, 1:42 AM · Restricted Project

Mon, Nov 9

mravishankar updated the summary of D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).
Mon, Nov 9, 1:32 PM · Restricted Project
mravishankar added reviewers for D91101: [mlir][Linalg] Change LinalgDependenceGraph to use LinalgOp.: hanchung, antiagainst, ThomasRaoux, asaadaldien.
Mon, Nov 9, 1:31 PM · Restricted Project
mravishankar updated the diff for D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).

Move missing files from parent change to here.

Mon, Nov 9, 1:28 PM · Restricted Project
mravishankar updated the diff for D91101: [mlir][Linalg] Change LinalgDependenceGraph to use LinalgOp..

Move files to the dependent change.

Mon, Nov 9, 1:27 PM · Restricted Project
mravishankar updated the diff for D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).

Split out parts not related to Fusion itself into separate changes.

Mon, Nov 9, 1:22 PM · Restricted Project
mravishankar requested review of D91101: [mlir][Linalg] Change LinalgDependenceGraph to use LinalgOp..
Mon, Nov 9, 1:22 PM · Restricted Project
mravishankar requested review of D91100: [mlir] Add eraseOp method to OpBuilder..
Mon, Nov 9, 1:21 PM · Restricted Project
mravishankar updated the diff for D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).

Rebase and fix test.

Mon, Nov 9, 1:08 PM · Restricted Project
mravishankar accepted D89989: [MLIR][SPIRVToLLVM] Enhanced conversion for entry point ops.

Seems like this changed to rely on having a single execution mode op per function. I think that is true. Approving this for landing.

Mon, Nov 9, 1:05 PM · Restricted Project
mravishankar updated the diff for D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).

Rebase

Mon, Nov 9, 11:16 AM · Restricted Project
mravishankar updated the diff for D90579: [mlir][Linalg] Improve the logic to perform tile and fuse with better dependence tracking..

Rebase and address comments

Mon, Nov 9, 11:16 AM · Restricted Project

Sat, Nov 7

mravishankar added a comment to D90579: [mlir][Linalg] Improve the logic to perform tile and fuse with better dependence tracking..

Can we split out the NFC part that extends support for operand + index in the dependence analysis and land that separately ?

Sat, Nov 7, 11:20 PM · Restricted Project

Fri, Nov 6

mravishankar added reviewers for D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers): hanchung, antiagainst, ThomasRaoux, asaadaldien.
Fri, Nov 6, 4:33 PM · Restricted Project
mravishankar requested review of D90991: [mlir][Linalg] Fuse sequence of Linalg operation (on buffers).
Fri, Nov 6, 4:33 PM · Restricted Project
mravishankar updated the diff for D90579: [mlir][Linalg] Improve the logic to perform tile and fuse with better dependence tracking..

Rebase

Fri, Nov 6, 4:33 PM · Restricted Project

Tue, Nov 3

mravishankar accepted D90474: [mlir][vector] Make linalg FillOp vectorization use Transfer op.
Tue, Nov 3, 2:30 PM · Restricted Project
mravishankar requested changes to D90474: [mlir][vector] Make linalg FillOp vectorization use Transfer op.

Just one question based on some questions.

Tue, Nov 3, 12:11 PM · Restricted Project
mravishankar resigned from D90652: [mlir][Asm] Add support for using an alias for trailing operation locations.
Tue, Nov 3, 9:00 AM · Restricted Project

Mon, Nov 2

mravishankar accepted D90655: [mlir][spirv] Support for a few more decorations in (de)serialization.

Cool! Thanks!

Mon, Nov 2, 9:28 PM · Restricted Project
mravishankar committed rG04776bd0ed50: [mlir][Linalg] Add more utility functions to LinalgDependenceGraph. (authored by mravishankar).
[mlir][Linalg] Add more utility functions to LinalgDependenceGraph.
Mon, Nov 2, 4:35 PM
mravishankar closed D90582: [mlir][Linalg] Add more utility functions to LinalgDependenceGraph..
Mon, Nov 2, 4:35 PM · Restricted Project

Sun, Nov 1

mravishankar added a reviewer for D90582: [mlir][Linalg] Add more utility functions to LinalgDependenceGraph.: ThomasRaoux.
Sun, Nov 1, 10:43 PM · Restricted Project
mravishankar requested review of D90582: [mlir][Linalg] Add more utility functions to LinalgDependenceGraph..
Sun, Nov 1, 10:42 PM · Restricted Project
mravishankar added reviewers for D90579: [mlir][Linalg] Improve the logic to perform tile and fuse with better dependence tracking.: antiagainst, asaadaldien, hanchung.
Sun, Nov 1, 9:54 PM · Restricted Project
mravishankar added a reviewer for D90579: [mlir][Linalg] Improve the logic to perform tile and fuse with better dependence tracking.: ThomasRaoux.
Sun, Nov 1, 9:33 PM · Restricted Project
mravishankar requested review of D90579: [mlir][Linalg] Improve the logic to perform tile and fuse with better dependence tracking..
Sun, Nov 1, 9:33 PM · Restricted Project
mravishankar added inline comments to D89989: [MLIR][SPIRVToLLVM] Enhanced conversion for entry point ops.
Sun, Nov 1, 9:16 PM · Restricted Project

Sat, Oct 31

mravishankar accepted D90475: [mlir][Linalg] Add support for tileAndDistribute on tensors..

Change is fairly straight-forward, but not sure what the issue with scf.parallel is. Is it the semantics of the op or the implementation of the distribution logic. If it is the latter, then maybe I can take a look there. Change looks fine as is though.

Sat, Oct 31, 7:19 AM · Restricted Project

Thu, Oct 29

mravishankar added a comment to D90363: [MLIR] Move eraseArguments and eraseResults to FunctionLike.

THanks for moving the method to Block. Other knowledgable people can comment on rest of the patch.

Thu, Oct 29, 10:10 AM · Restricted Project

Tue, Oct 27

mravishankar committed rG9d5239d39e48: [mlir][Linalg] Add fusion of IndexedGenericOp with TensorReshapeOp by expansion. (authored by mravishankar).
[mlir][Linalg] Add fusion of IndexedGenericOp with TensorReshapeOp by expansion.
Tue, Oct 27, 4:16 PM
mravishankar closed D90082: [mlir][Linalg] Add fusion of IndexedGenericOp with TensorReshapeOp by expansion..
Tue, Oct 27, 4:16 PM · Restricted Project
mravishankar updated the diff for D90082: [mlir][Linalg] Add fusion of IndexedGenericOp with TensorReshapeOp by expansion..

Address comments.

Tue, Oct 27, 10:02 AM · Restricted Project
mravishankar added a comment to D90076: [MLIR] Move eraseArguments helper from FuncOp to FunctionLike.

I guess we could add that part to an eraseArguments(ArrayRef<unsigned> indices) method on the Block class. That could be used by eraseArguments on the FunctionLike trait as well as your case. Is that what you mean?

Tue, Oct 27, 9:26 AM · Restricted Project

Mon, Oct 26

mravishankar committed rG78f37b74da60: [mlir][Linalg] Miscalleneous enhancements to cover more fusion cases. (authored by mravishankar).
[mlir][Linalg] Miscalleneous enhancements to cover more fusion cases.
Mon, Oct 26, 4:18 PM
mravishankar closed D90118: [mlir][Linalg] Miscalleneous enhancements to cover more fusion cases..
Mon, Oct 26, 4:17 PM · Restricted Project
mravishankar resigned from D85464: [MLIR] [CMake] Support building MLIR standalone.
Mon, Oct 26, 10:32 AM · Restricted Project
mravishankar resigned from D90022: [MLIR][SPIRV] Start module combiner..
Mon, Oct 26, 10:32 AM · Restricted Project
mravishankar added a comment to D90076: [MLIR] Move eraseArguments helper from FuncOp to FunctionLike.

Can this logic be generalized for all Regions? In the patch https://reviews.llvm.org/D90118 I need to drop arguments for region of an linalg::IndexedGenericOp. Having this method there would be more ergonomic.

Mon, Oct 26, 10:31 AM · Restricted Project
mravishankar requested changes to D89989: [MLIR][SPIRVToLLVM] Enhanced conversion for entry point ops.

Curious what you need this information for?

Mon, Oct 26, 10:25 AM · Restricted Project
mravishankar accepted D89491: [mlir][Linalg] Add basic support for TileAndFuse on Linalg on tensors..

Thanks for the refactoring. Make sense now. Exciting!

Mon, Oct 26, 10:12 AM · Restricted Project

Sun, Oct 25

mravishankar added a reviewer for D90118: [mlir][Linalg] Miscalleneous enhancements to cover more fusion cases.: hanchung.
Sun, Oct 25, 7:01 AM · Restricted Project
mravishankar requested review of D90118: [mlir][Linalg] Miscalleneous enhancements to cover more fusion cases..
Sun, Oct 25, 6:57 AM · Restricted Project

Oct 24 2020

mravishankar resigned from D90038: [mlir] use OpBuilderDAG instead of OpBuilder.
Oct 24 2020, 3:44 PM · Restricted Project
mravishankar resigned from D89324: [mlir][gpu] Allow gpu.launch_func to be async..
Oct 24 2020, 3:43 PM · Restricted Project
mravishankar requested changes to D89491: [mlir][Linalg] Add basic support for TileAndFuse on Linalg on tensors..

Seems to be some failing tests here. Will circle back after that is fixed.

Oct 24 2020, 3:42 PM · Restricted Project

Oct 23 2020

mravishankar added a reviewer for D90082: [mlir][Linalg] Add fusion of IndexedGenericOp with TensorReshapeOp by expansion.: hanchung.
Oct 23 2020, 4:39 PM · Restricted Project
mravishankar requested review of D90082: [mlir][Linalg] Add fusion of IndexedGenericOp with TensorReshapeOp by expansion..
Oct 23 2020, 4:38 PM · Restricted Project
mravishankar committed rGb6204b995eaa: [mlir][Vector] Introduce UnrollVectorOptions to control vector unrolling. (authored by mravishankar).
[mlir][Vector] Introduce UnrollVectorOptions to control vector unrolling.
Oct 23 2020, 1:53 PM
mravishankar closed D89744: [mlir][Vector] Introduce UnrollVectorOptions to control vector unrolling..
Oct 23 2020, 1:52 PM · Restricted Project
mravishankar updated the diff for D89744: [mlir][Vector] Introduce UnrollVectorOptions to control vector unrolling..

Rebase

Oct 23 2020, 12:56 PM · Restricted Project