Page MenuHomePhabricator
People rsuderman

rsuderman (Rob Suderman)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 2 2020, 10:50 AM (38 w, 3 d)

Recent Activity
View All

Wed, Sep 2

rsuderman accepted D87055: [mlir] Support default valued attribute in StructsGen.

Looks good to me. One nit: it may be worth reordering the includes into the test to remove that pesky pre-merge check error.

Wed, Sep 2, 9:33 PM · Restricted Project

Aug 18 2020

rsuderman committed rG55565752306e: Added std.floor operation to match std.ceil (authored by rsuderman).
Added std.floor operation to match std.ceil
Aug 18 2020, 10:36 AM
rsuderman closed D85940: Added std.floor operation to match std.ceil.
Aug 18 2020, 10:36 AM · Restricted Project
rsuderman updated the diff for D85940: Added std.floor operation to match std.ceil.

Sync to head.

Aug 18 2020, 10:11 AM · Restricted Project

Aug 17 2020

rsuderman updated the diff for D85940: Added std.floor operation to match std.ceil.

Updated for nit comments.

Aug 17 2020, 3:52 PM · Restricted Project
rsuderman requested review of D86115: Nit dropped part of comparison.
Aug 17 2020, 3:51 PM · Restricted Project
rsuderman updated the diff for D85940: Added std.floor operation to match std.ceil.

Sync to head.

Aug 17 2020, 10:10 AM · Restricted Project
rsuderman added a reviewer for D85940: Added std.floor operation to match std.ceil: rriddle.
Aug 17 2020, 9:49 AM · Restricted Project

Aug 13 2020

rsuderman retitled D85940: Added std.floor operation to match std.ceil from Added std.floor operation to make std.ceil to Added std.floor operation to match std.ceil.
Aug 13 2020, 3:13 PM · Restricted Project
rsuderman requested review of D85940: Added std.floor operation to match std.ceil.
Aug 13 2020, 3:01 PM · Restricted Project

Jun 10 2020

rsuderman added inline comments to D81611: Updated IndexCastOp to support tensor<index> cast.
Jun 10 2020, 4:41 PM · Restricted Project
rsuderman updated the diff for D81611: Updated IndexCastOp to support tensor<index> cast.

jpienaar@ comment for removing pipe into mlir-opt

Jun 10 2020, 4:41 PM · Restricted Project
rsuderman added a comment to D81611: Updated IndexCastOp to support tensor<index> cast.

Comment updated.

Jun 10 2020, 3:35 PM · Restricted Project
rsuderman retitled D81611: Updated IndexCastOp to support tensor<index> cast from Updated IndexCastOp to support tensor<index> cast with updated folder to Updated IndexCastOp to support tensor<index> cast.
Jun 10 2020, 3:35 PM · Restricted Project
rsuderman added inline comments to D81611: Updated IndexCastOp to support tensor<index> cast.
Jun 10 2020, 3:35 PM · Restricted Project
rsuderman updated the diff for D81611: Updated IndexCastOp to support tensor<index> cast.

Removed unneeded parts othe Standard/ops.mlir checks.

Jun 10 2020, 3:35 PM · Restricted Project
rsuderman updated the summary of D81611: Updated IndexCastOp to support tensor<index> cast.
Jun 10 2020, 3:35 PM · Restricted Project
rsuderman added inline comments to D81611: Updated IndexCastOp to support tensor<index> cast.
Jun 10 2020, 3:35 PM · Restricted Project
rsuderman updated the diff for D81611: Updated IndexCastOp to support tensor<index> cast.

Removed unneeded folder.

Jun 10 2020, 3:35 PM · Restricted Project
rsuderman updated the diff for D81611: Updated IndexCastOp to support tensor<index> cast.

Updated to include IR tests for index_cast.

Jun 10 2020, 3:01 PM · Restricted Project
rsuderman created D81611: Updated IndexCastOp to support tensor<index> cast.
Jun 10 2020, 1:21 PM · Restricted Project

Apr 24 2020

rsuderman created D78850: Memory corruption issure for DenseStringElementsAttr.
Apr 24 2020, 8:02 PM · Restricted Project
rsuderman updated the diff for D78844: Sparse String Elements support..

Removed unneeded helper function.

Apr 24 2020, 6:58 PM · Restricted Project
rsuderman updated the diff for D78844: Sparse String Elements support..

Inserted missing newline.

Apr 24 2020, 6:26 PM · Restricted Project
rsuderman updated the diff for D78844: Sparse String Elements support..

Added getZeroValue() for string.

Apr 24 2020, 6:26 PM · Restricted Project
rsuderman created D78844: Sparse String Elements support..
Apr 24 2020, 5:53 PM · Restricted Project

Apr 23 2020

rsuderman updated the diff for D78600: DenseStringElementsAttr added to default attribute types.

Final comment.

Apr 23 2020, 7:01 PM · Restricted Project
rsuderman added inline comments to D78600: DenseStringElementsAttr added to default attribute types.
Apr 23 2020, 7:01 PM · Restricted Project
rsuderman updated the diff for D78600: DenseStringElementsAttr added to default attribute types.

Final comments a sync to head.

Apr 23 2020, 7:01 PM · Restricted Project
rsuderman updated the diff for D78600: DenseStringElementsAttr added to default attribute types.

Deleted unnecessary newline

Apr 23 2020, 3:15 PM · Restricted Project
rsuderman updated the diff for D78600: DenseStringElementsAttr added to default attribute types.

Full diff

Apr 23 2020, 3:15 PM · Restricted Project
rsuderman added a comment to D78600: DenseStringElementsAttr added to default attribute types.

Updated for the most part. I am not sure we can handle a dense serialization format like floats / strings due to the variable length of our data.

Apr 23 2020, 3:15 PM · Restricted Project
rsuderman updated the diff for D78600: DenseStringElementsAttr added to default attribute types.

Tweaked iterator behavior.

Apr 23 2020, 2:07 PM · Restricted Project
rsuderman updated the diff for D78600: DenseStringElementsAttr added to default attribute types.

rriddle@ comments round 2

Apr 23 2020, 11:52 AM · Restricted Project

Apr 22 2020

rsuderman added a comment to D78600: DenseStringElementsAttr added to default attribute types.

Addressed code comments and updated CL description.

Apr 22 2020, 1:03 PM · Restricted Project
rsuderman updated the summary of D78600: DenseStringElementsAttr added to default attribute types.
Apr 22 2020, 1:03 PM · Restricted Project
rsuderman updated the diff for D78600: DenseStringElementsAttr added to default attribute types.

Squashed commits.

Apr 22 2020, 1:03 PM · Restricted Project
rsuderman updated the diff for D78600: DenseStringElementsAttr added to default attribute types.

Missed one comment

Apr 22 2020, 1:03 PM · Restricted Project
rsuderman updated the diff for D78600: DenseStringElementsAttr added to default attribute types.

Updating with full diff

Apr 22 2020, 12:30 PM · Restricted Project
rsuderman updated the diff for D78600: DenseStringElementsAttr added to default attribute types.

Updated for rriddle@ comments

Apr 22 2020, 12:30 PM · Restricted Project

Apr 21 2020

rsuderman created D78600: DenseStringElementsAttr added to default attribute types.
Apr 21 2020, 5:21 PM · Restricted Project
rsuderman retitled D78600: DenseStringElementsAttr added to default attribute types from Implemented a DenseStringsElementsAttr for handling tensors of strings. This include the necessary logic for parsing and printing the attributes, along with escape logic. TestDialect was updated to include a custom type to test the string... to DenseStringElementsAttr added to default attribute types.
Apr 21 2020, 5:21 PM · Restricted Project

Apr 15 2020

rsuderman accepted D78258: [mlir][Inliner] Store the resolved call by-value instead of by-reference.
Apr 15 2020, 5:06 PM · Restricted Project

Apr 10 2020

rsuderman accepted D77909: [mlir][Pass] Allow duplicate pass registration..
Apr 10 2020, 3:04 PM · Restricted Project

Mar 20 2020

rsuderman updated the diff for D76161: NFC - Moved AffineOps IR / Transforms.

Synced to head.

Mar 20 2020, 12:28 PM · Restricted Project

Mar 19 2020

rsuderman updated the diff for D76161: NFC - Moved AffineOps IR / Transforms.

Sync to head

Mar 19 2020, 3:54 PM · Restricted Project
rsuderman accepted D76436: [mlir] Rename CMake target MLIRQuantOps to MLIRQuant.
Mar 19 2020, 3:54 PM · Restricted Project

Mar 18 2020

rsuderman updated the diff for D76326: Introduced CallOp Dialect Conversion.

Updated for final comments

Mar 18 2020, 5:55 PM · Restricted Project
rsuderman updated the diff for D76326: Introduced CallOp Dialect Conversion.

Updated comment in DialectConversion.cpp

Mar 18 2020, 4:51 PM · Restricted Project
rsuderman updated the diff for D76326: Introduced CallOp Dialect Conversion.

Second comment update.

Mar 18 2020, 4:51 PM · Restricted Project
rsuderman added inline comments to D76326: Introduced CallOp Dialect Conversion.
Mar 18 2020, 4:51 PM · Restricted Project
rsuderman updated the diff for D76326: Introduced CallOp Dialect Conversion.

Missed updated comment.

Mar 18 2020, 4:51 PM · Restricted Project
rsuderman updated the diff for D76326: Introduced CallOp Dialect Conversion.

Update for rriddle@ comments

Mar 18 2020, 4:51 PM · Restricted Project

Mar 17 2020

rsuderman updated the diff for D76161: NFC - Moved AffineOps IR / Transforms.

Sync to head and reupdate.

Mar 17 2020, 3:07 PM · Restricted Project
rsuderman created D76326: Introduced CallOp Dialect Conversion.
Mar 17 2020, 2:35 PM · Restricted Project
rsuderman abandoned D76172: Added StandardOps DialectConversion support.
Mar 17 2020, 2:02 PM · Restricted Project
rsuderman created D76318: NFC - Rename QuantOps to Quant.
Mar 17 2020, 1:29 PM · Restricted Project
rsuderman abandoned D76251: NFC - Rename QuantOps to Quant.

Nuking due to local corrupted git repo.

Mar 17 2020, 1:29 PM · Restricted Project
rsuderman created D76317: NFC - Renamed VectorOps to Vector.
Mar 17 2020, 1:29 PM · Restricted Project
rsuderman abandoned D76302: NFC - Moved VectorOps to Vector.

Arc diff broke git repo. Attempting to redo.

Mar 17 2020, 1:29 PM · Restricted Project
rsuderman abandoned D76315: Moved VectorOps to Vector.
Mar 17 2020, 1:29 PM · Restricted Project
rsuderman created D76315: Moved VectorOps to Vector.
Mar 17 2020, 1:29 PM · Restricted Project
rsuderman retitled D76302: NFC - Moved VectorOps to Vector from Moved VectorOps to Vector to NFC - Moved VectorOps to Vector.
Mar 17 2020, 12:23 PM · Restricted Project
rsuderman created D76302: NFC - Moved VectorOps to Vector.
Mar 17 2020, 11:16 AM · Restricted Project
rsuderman abandoned D76258: NFC - Rename VectorOps Dialect to the Vector Dialect.

Moving to a separate CL to better handle internal integration.

Mar 17 2020, 11:16 AM · Restricted Project
rsuderman updated the diff for D76258: NFC - Rename VectorOps Dialect to the Vector Dialect.

Synced to head.

Mar 17 2020, 10:43 AM · Restricted Project

Mar 16 2020

rsuderman added a comment to D76258: NFC - Rename VectorOps Dialect to the Vector Dialect.

Fixed rriddle@ requests

Mar 16 2020, 8:12 PM · Restricted Project
rsuderman updated the diff for D76258: NFC - Rename VectorOps Dialect to the Vector Dialect.

Corrected VectorOps header.

Mar 16 2020, 8:12 PM · Restricted Project
rsuderman retitled D76251: NFC - Rename QuantOps to Quant from Rename QuantOps to Quant to NFC - Rename QuantOps to Quant.
Mar 16 2020, 6:03 PM · Restricted Project
rsuderman added a comment to D76258: NFC - Rename VectorOps Dialect to the Vector Dialect.
In D76258#1925536, @aartbik wrote:

Although purely mechanical, this is of course a very visible change. Can you state a bit more in the description on where, when, and why the rename was decided?

Mar 16 2020, 6:03 PM · Restricted Project
rsuderman retitled D76258: NFC - Rename VectorOps Dialect to the Vector Dialect from Rename VectorOps directory to Vector to NFC - Rename VectorOps Dialect to the Vector Dialect.
Mar 16 2020, 6:03 PM · Restricted Project
rsuderman created D76258: NFC - Rename VectorOps Dialect to the Vector Dialect.
Mar 16 2020, 3:51 PM · Restricted Project
rsuderman updated the diff for D76251: NFC - Rename QuantOps to Quant.

Moved remaining QuantOps folder

Mar 16 2020, 3:18 PM · Restricted Project
rsuderman created D76251: NFC - Rename QuantOps to Quant.
Mar 16 2020, 2:12 PM · Restricted Project
rsuderman added a reviewer for D76251: NFC - Rename QuantOps to Quant: rriddle.
Mar 16 2020, 2:12 PM · Restricted Project
rsuderman updated the diff for D76161: NFC - Moved AffineOps IR / Transforms.

git clang-format

Mar 16 2020, 1:40 PM · Restricted Project
rsuderman updated the diff for D76161: NFC - Moved AffineOps IR / Transforms.

Update for rriddle@ comments and synced to head.

Mar 16 2020, 12:34 PM · Restricted Project
rsuderman added a comment to D76161: NFC - Moved AffineOps IR / Transforms.

Addressed rriddle@ comments and synced to head.

Mar 16 2020, 12:34 PM · Restricted Project
rsuderman retitled D76161: NFC - Moved AffineOps IR / Transforms from Moved AffineOps IR / TransformsChange AffineOps Dialect structure to better group both IR and Tranforms. Thisincluded extracting transforms direclty related to AffineOps to NFC - Moved AffineOps IR / Transforms.
Mar 16 2020, 11:27 AM · Restricted Project
rsuderman added a comment to D76161: NFC - Moved AffineOps IR / Transforms.

Should be updated for comments.

Mar 16 2020, 11:27 AM · Restricted Project
rsuderman updated the diff for D76161: NFC - Moved AffineOps IR / Transforms.

Move AffineOps to Affine

Mar 16 2020, 11:27 AM · Restricted Project

Mar 13 2020

rsuderman updated the diff for D76161: NFC - Moved AffineOps IR / Transforms.

clang-format

Mar 13 2020, 6:22 PM · Restricted Project
rsuderman updated the diff for D76172: Added StandardOps DialectConversion support.

Clang-format

Mar 13 2020, 6:22 PM · Restricted Project
rsuderman created D76172: Added StandardOps DialectConversion support.
Mar 13 2020, 6:22 PM · Restricted Project
rsuderman abandoned D74884: Added CallOpSignatureConversion pattern.
Mar 13 2020, 6:22 PM
rsuderman retitled D76161: NFC - Moved AffineOps IR / Transforms from Moved AffineOps IR / Transforms Change AffineOps Dialect structure to better group both IR and Tranforms. This included extracting transforms direclty related to AffineOps to Moved AffineOps IR / TransformsChange AffineOps Dialect structure to better group both IR and Tranforms. Thisincluded extracting transforms direclty related to AffineOps.
Mar 13 2020, 4:45 PM · Restricted Project
rsuderman edited reviewers for D76161: NFC - Moved AffineOps IR / Transforms, added: rriddle, ftynse; removed: mravishankar, nicolasvasilache, herhut.
Mar 13 2020, 4:45 PM · Restricted Project
rsuderman added a comment to D76161: NFC - Moved AffineOps IR / Transforms.
In D76161#1922471, @nicolasvasilache wrote:

I think this has a lot of conflict potential with a revision by @ftynse, maybe check with him?

Mar 13 2020, 4:45 PM · Restricted Project
rsuderman updated the diff for D76161: NFC - Moved AffineOps IR / Transforms.
  1. Updating D76161: Moved AffineOps IR / Transforms
Mar 13 2020, 4:45 PM · Restricted Project
rsuderman updated the diff for D76161: NFC - Moved AffineOps IR / Transforms.

Updated CMake build to pass.

Mar 13 2020, 4:45 PM · Restricted Project
rsuderman created D76161: NFC - Moved AffineOps IR / Transforms.
Mar 13 2020, 2:01 PM · Restricted Project

Mar 12 2020

rsuderman updated the diff for D76112: [mlir][NFC] Removed unnecessary StandardOp includes.

Rebased on head.

Mar 12 2020, 7:04 PM · Restricted Project
rsuderman created D76112: [mlir][NFC] Removed unnecessary StandardOp includes.
Mar 12 2020, 5:43 PM · Restricted Project
rsuderman retitled D76112: [mlir][NFC] Removed unnecessary StandardOp includes from NFC - Removed unnecessary StandardOp includes A number of transform import StandardOps despite not being dependent on it. Cleaned it up to better understand what dialects each of these transforms depend on. to NFC - Removed unnecessary StandardOp includesA number of transform import StandardOps despite notbeing dependent on it. Cleaned it up to better understandwhat dialects each of these transforms depend on..
Mar 12 2020, 5:43 PM · Restricted Project

Feb 21 2020

rsuderman updated the diff for D74940: Move StandardOps/Ops.h to StandardOps/IR/Ops.h.

Fixed rebase build error.

Feb 21 2020, 11:29 AM · Restricted Project
rsuderman updated the diff for D74940: Move StandardOps/Ops.h to StandardOps/IR/Ops.h.

Rebase at head.

Feb 21 2020, 11:27 AM · Restricted Project
rsuderman added a comment to D74940: Move StandardOps/Ops.h to StandardOps/IR/Ops.h.

Build failure is an unrelated clang-tidy error.

Feb 21 2020, 11:18 AM · Restricted Project
rsuderman updated the diff for D74940: Move StandardOps/Ops.h to StandardOps/IR/Ops.h.

(quickly correct place of _IR_)

Feb 21 2020, 10:51 AM · Restricted Project
rsuderman updated the diff for D74940: Move StandardOps/Ops.h to StandardOps/IR/Ops.h.

Updated StandardOps/IR/Ops.h header guard

Feb 21 2020, 10:51 AM · Restricted Project

Feb 20 2020

rsuderman updated the summary of D74940: Move StandardOps/Ops.h to StandardOps/IR/Ops.h.
Feb 20 2020, 6:24 PM · Restricted Project