Page MenuHomePhabricator

rsuderman (Rob Suderman)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 2 2020, 10:50 AM (54 w, 20 h)

Recent Activity

Yesterday

rsuderman committed rG1d973b7ded12: [MLIR][TOSA] First lowerings from Tosa to Linalg (authored by rsuderman).
[MLIR][TOSA] First lowerings from Tosa to Linalg
Thu, Jan 14, 11:26 AM
rsuderman closed D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.
Thu, Jan 14, 11:25 AM · Restricted Project
rsuderman updated the diff for D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.

Nit fixes.

Thu, Jan 14, 11:15 AM · Restricted Project

Wed, Jan 13

rsuderman added inline comments to D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.
Wed, Jan 13, 1:23 PM · Restricted Project
rsuderman updated the diff for D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.

Added missing static qualifier.

Wed, Jan 13, 1:22 PM · Restricted Project
rsuderman updated the diff for D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.

Removed redundant checks, added more failure test cases.

Wed, Jan 13, 1:21 PM · Restricted Project

Tue, Jan 12

rsuderman updated the diff for D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.

Changed to a single function for generating generic op contents.

Tue, Jan 12, 5:07 PM · Restricted Project

Mon, Jan 11

rsuderman updated the diff for D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.

River Riddle comments

Mon, Jan 11, 5:37 PM · Restricted Project
rsuderman added inline comments to D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.
Mon, Jan 11, 5:27 PM · Restricted Project
rsuderman updated the diff for D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.

Updates to tosa to linalg testing

Mon, Jan 11, 5:27 PM · Restricted Project
rsuderman updated the diff for D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.

Additional round of comments.

Mon, Jan 11, 4:59 PM · Restricted Project
rsuderman committed rGf75f391fc68c: [MLIR][Linalg] Refactor transforms to use linalg::getDynOperands helper (authored by rsuderman).
[MLIR][Linalg] Refactor transforms to use linalg::getDynOperands helper
Mon, Jan 11, 4:30 PM
rsuderman closed D94340: [MLIR][Linalg] Refactor transforms to use linalg::getDynOperands helper.
Mon, Jan 11, 4:29 PM · Restricted Project
rsuderman updated the diff for D94340: [MLIR][Linalg] Refactor transforms to use linalg::getDynOperands helper.

Utils header guard change.

Mon, Jan 11, 3:57 PM · Restricted Project

Fri, Jan 8

rsuderman updated the diff for D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.

Change from OpConversionPattern to RewritePattern

Fri, Jan 8, 5:42 PM · Restricted Project
rsuderman updated the diff for D94340: [MLIR][Linalg] Refactor transforms to use linalg::getDynOperands helper.

River's comments for pairing down deps.

Fri, Jan 8, 5:20 PM · Restricted Project
rsuderman updated the diff for D94340: [MLIR][Linalg] Refactor transforms to use linalg::getDynOperands helper.

Moved from Linalg/Utils to StandardOps/Utils

Fri, Jan 8, 4:53 PM · Restricted Project
rsuderman updated the diff for D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.

Handled remaining comments from Mehdi/Sean

Fri, Jan 8, 4:32 PM · Restricted Project
rsuderman added a reviewer for D94340: [MLIR][Linalg] Refactor transforms to use linalg::getDynOperands helper: mehdi_amini.
Fri, Jan 8, 2:04 PM · Restricted Project
rsuderman requested review of D94340: [MLIR][Linalg] Refactor transforms to use linalg::getDynOperands helper.
Fri, Jan 8, 2:03 PM · Restricted Project
rsuderman updated the diff for D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.

Made corresponding changes for the code review comments.

Fri, Jan 8, 1:26 PM · Restricted Project

Thu, Jan 7

rsuderman updated the diff for D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.

Some minor fixes before code review.

Thu, Jan 7, 11:03 AM · Restricted Project
rsuderman requested review of D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.
Thu, Jan 7, 10:58 AM · Restricted Project

Thu, Dec 17

rsuderman abandoned D86115: Nit dropped part of comparison.
Thu, Dec 17, 9:16 AM · Restricted Project

Oct 16 2020

rsuderman committed rGc096377905db: Fixed a failure when const matcher fails, added a test to catch (authored by rsuderman).
Fixed a failure when const matcher fails, added a test to catch
Oct 16 2020, 3:03 PM
rsuderman closed D89593: [mlir] Failure when const matcher fails, added a test to catch.
Oct 16 2020, 3:03 PM · Restricted Project
rsuderman retitled D89593: [mlir] Failure when const matcher fails, added a test to catch from Fixed a failure when const matcher fails, added a test to catch to [mlir] Failure when const matcher fails, added a test to catch.
Oct 16 2020, 2:14 PM · Restricted Project
rsuderman added a reviewer for D89593: [mlir] Failure when const matcher fails, added a test to catch: jpienaar.
Oct 16 2020, 2:13 PM · Restricted Project
rsuderman added a reviewer for D89593: [mlir] Failure when const matcher fails, added a test to catch: GMNGeoffrey.
Oct 16 2020, 1:51 PM · Restricted Project
rsuderman requested review of D89593: [mlir] Failure when const matcher fails, added a test to catch.
Oct 16 2020, 1:51 PM · Restricted Project

Oct 15 2020

rsuderman abandoned D89515: Revert commit D89161 due to build failure from no matching constructor.

Managed to land a fix instead. Abandoning revision.

Oct 15 2020, 7:58 PM · Restricted Project
rsuderman committed rGad1fe3963f30: [MLIR] Fix gcc5 in D89161 (authored by rsuderman).
[MLIR] Fix gcc5 in D89161
Oct 15 2020, 5:04 PM
rsuderman closed D89516: [MLIR] Fix gcc5 in D89161.
Oct 15 2020, 5:03 PM · Restricted Project
rsuderman requested review of D89516: [MLIR] Fix gcc5 in D89161.
Oct 15 2020, 5:02 PM · Restricted Project
rsuderman added a reverting change for rG2bf423b0218c: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher: D89515: Revert commit D89161 due to build failure from no matching constructor.
Oct 15 2020, 4:50 PM
rsuderman added a reverting change for D89161: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher: D89515: Revert commit D89161 due to build failure from no matching constructor.
Oct 15 2020, 4:50 PM · Restricted Project
rsuderman requested review of D89515: Revert commit D89161 due to build failure from no matching constructor.
Oct 15 2020, 4:50 PM · Restricted Project
rsuderman committed rG2bf423b0218c: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher (authored by rsuderman).
[mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher
Oct 15 2020, 4:34 PM
rsuderman closed D89161: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher.
Oct 15 2020, 4:34 PM · Restricted Project
rsuderman updated the diff for D89161: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher.

Handled last jpienaar comments

Oct 15 2020, 4:32 PM · Restricted Project

Oct 14 2020

rsuderman updated the diff for D89161: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher.

Added tablegen rewriter error tests.

Oct 14 2020, 12:30 PM · Restricted Project

Oct 13 2020

rsuderman added inline comments to D89161: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher.
Oct 13 2020, 5:19 PM · Restricted Project
rsuderman updated the diff for D89161: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher.

Additional jpienaar changes.

Oct 13 2020, 5:16 PM · Restricted Project

Oct 12 2020

rsuderman updated the diff for D89161: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher.

Rest of jpienaar@ comments

Oct 12 2020, 4:36 PM · Restricted Project
rsuderman added inline comments to D89161: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher.
Oct 12 2020, 4:23 PM · Restricted Project
rsuderman updated the diff for D89161: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher.

Updated for jpienaar@ comments

Oct 12 2020, 4:06 PM · Restricted Project
rsuderman committed rG820e65f9e236: [mlir] fixing typo in parseAttribute that was ignoring caller-specified types (authored by benvanik).
[mlir] fixing typo in parseAttribute that was ignoring caller-specified types
Oct 12 2020, 11:37 AM
rsuderman closed D89255: [mlir] fixing typo in parseAttribute that was ignoring caller-specified types.
Oct 12 2020, 11:37 AM · Restricted Project

Oct 9 2020

rsuderman updated the diff for D89161: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher.

Updated for riverriddle comments.

Oct 9 2020, 2:18 PM · Restricted Project
rsuderman added a reviewer for D89161: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher: jpienaar.
Oct 9 2020, 1:57 PM · Restricted Project
rsuderman removed reviewers for D89161: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher: rriddle, antiagainst.
Oct 9 2020, 1:56 PM · Restricted Project
rsuderman requested review of D89161: [mlir] RewriterGen NativeCodeCall matcher with ConstantOp matcher.
Oct 9 2020, 1:56 PM · Restricted Project

Sep 2 2020

rsuderman accepted D87055: [mlir] Support default valued attribute in StructsGen.

Looks good to me. One nit: it may be worth reordering the includes into the test to remove that pesky pre-merge check error.

Sep 2 2020, 9:33 PM · Restricted Project

Aug 18 2020

rsuderman committed rG55565752306e: Added std.floor operation to match std.ceil (authored by rsuderman).
Added std.floor operation to match std.ceil
Aug 18 2020, 10:36 AM
rsuderman closed D85940: Added std.floor operation to match std.ceil.
Aug 18 2020, 10:36 AM · Restricted Project
rsuderman updated the diff for D85940: Added std.floor operation to match std.ceil.

Sync to head.

Aug 18 2020, 10:11 AM · Restricted Project

Aug 17 2020

rsuderman updated the diff for D85940: Added std.floor operation to match std.ceil.

Updated for nit comments.

Aug 17 2020, 3:52 PM · Restricted Project
rsuderman requested review of D86115: Nit dropped part of comparison.
Aug 17 2020, 3:51 PM · Restricted Project
rsuderman updated the diff for D85940: Added std.floor operation to match std.ceil.

Sync to head.

Aug 17 2020, 10:10 AM · Restricted Project
rsuderman added a reviewer for D85940: Added std.floor operation to match std.ceil: rriddle.
Aug 17 2020, 9:49 AM · Restricted Project

Aug 13 2020

rsuderman retitled D85940: Added std.floor operation to match std.ceil from Added std.floor operation to make std.ceil to Added std.floor operation to match std.ceil.
Aug 13 2020, 3:13 PM · Restricted Project
rsuderman requested review of D85940: Added std.floor operation to match std.ceil.
Aug 13 2020, 3:01 PM · Restricted Project

Jun 10 2020

rsuderman added inline comments to D81611: Updated IndexCastOp to support tensor<index> cast.
Jun 10 2020, 4:41 PM · Restricted Project
rsuderman updated the diff for D81611: Updated IndexCastOp to support tensor<index> cast.

jpienaar@ comment for removing pipe into mlir-opt

Jun 10 2020, 4:41 PM · Restricted Project
rsuderman added a comment to D81611: Updated IndexCastOp to support tensor<index> cast.

Comment updated.

Jun 10 2020, 3:35 PM · Restricted Project
rsuderman retitled D81611: Updated IndexCastOp to support tensor<index> cast from Updated IndexCastOp to support tensor<index> cast with updated folder to Updated IndexCastOp to support tensor<index> cast.
Jun 10 2020, 3:35 PM · Restricted Project
rsuderman added inline comments to D81611: Updated IndexCastOp to support tensor<index> cast.
Jun 10 2020, 3:35 PM · Restricted Project
rsuderman updated the diff for D81611: Updated IndexCastOp to support tensor<index> cast.

Removed unneeded parts othe Standard/ops.mlir checks.

Jun 10 2020, 3:35 PM · Restricted Project
rsuderman updated the summary of D81611: Updated IndexCastOp to support tensor<index> cast.
Jun 10 2020, 3:35 PM · Restricted Project
rsuderman added inline comments to D81611: Updated IndexCastOp to support tensor<index> cast.
Jun 10 2020, 3:35 PM · Restricted Project
rsuderman updated the diff for D81611: Updated IndexCastOp to support tensor<index> cast.

Removed unneeded folder.

Jun 10 2020, 3:35 PM · Restricted Project
rsuderman updated the diff for D81611: Updated IndexCastOp to support tensor<index> cast.

Updated to include IR tests for index_cast.

Jun 10 2020, 3:01 PM · Restricted Project
rsuderman created D81611: Updated IndexCastOp to support tensor<index> cast.
Jun 10 2020, 1:21 PM · Restricted Project

Apr 24 2020

rsuderman created D78850: Memory corruption issure for DenseStringElementsAttr.
Apr 24 2020, 8:02 PM · Restricted Project
rsuderman updated the diff for D78844: Sparse String Elements support..

Removed unneeded helper function.

Apr 24 2020, 6:58 PM · Restricted Project
rsuderman updated the diff for D78844: Sparse String Elements support..

Inserted missing newline.

Apr 24 2020, 6:26 PM · Restricted Project
rsuderman updated the diff for D78844: Sparse String Elements support..

Added getZeroValue() for string.

Apr 24 2020, 6:26 PM · Restricted Project
rsuderman created D78844: Sparse String Elements support..
Apr 24 2020, 5:53 PM · Restricted Project

Apr 23 2020

rsuderman updated the diff for D78600: DenseStringElementsAttr added to default attribute types.

Final comment.

Apr 23 2020, 7:01 PM · Restricted Project
rsuderman added inline comments to D78600: DenseStringElementsAttr added to default attribute types.
Apr 23 2020, 7:01 PM · Restricted Project
rsuderman updated the diff for D78600: DenseStringElementsAttr added to default attribute types.

Final comments a sync to head.

Apr 23 2020, 7:01 PM · Restricted Project
rsuderman updated the diff for D78600: DenseStringElementsAttr added to default attribute types.

Deleted unnecessary newline

Apr 23 2020, 3:15 PM · Restricted Project
rsuderman updated the diff for D78600: DenseStringElementsAttr added to default attribute types.

Full diff

Apr 23 2020, 3:15 PM · Restricted Project
rsuderman added a comment to D78600: DenseStringElementsAttr added to default attribute types.

Updated for the most part. I am not sure we can handle a dense serialization format like floats / strings due to the variable length of our data.

Apr 23 2020, 3:15 PM · Restricted Project
rsuderman updated the diff for D78600: DenseStringElementsAttr added to default attribute types.

Tweaked iterator behavior.

Apr 23 2020, 2:07 PM · Restricted Project
rsuderman updated the diff for D78600: DenseStringElementsAttr added to default attribute types.

rriddle@ comments round 2

Apr 23 2020, 11:52 AM · Restricted Project

Apr 22 2020

rsuderman added a comment to D78600: DenseStringElementsAttr added to default attribute types.

Addressed code comments and updated CL description.

Apr 22 2020, 1:03 PM · Restricted Project
rsuderman updated the summary of D78600: DenseStringElementsAttr added to default attribute types.
Apr 22 2020, 1:03 PM · Restricted Project
rsuderman updated the diff for D78600: DenseStringElementsAttr added to default attribute types.

Squashed commits.

Apr 22 2020, 1:03 PM · Restricted Project
rsuderman updated the diff for D78600: DenseStringElementsAttr added to default attribute types.

Missed one comment

Apr 22 2020, 1:03 PM · Restricted Project
rsuderman updated the diff for D78600: DenseStringElementsAttr added to default attribute types.

Updating with full diff

Apr 22 2020, 12:30 PM · Restricted Project
rsuderman updated the diff for D78600: DenseStringElementsAttr added to default attribute types.

Updated for rriddle@ comments

Apr 22 2020, 12:30 PM · Restricted Project

Apr 21 2020

rsuderman created D78600: DenseStringElementsAttr added to default attribute types.
Apr 21 2020, 5:21 PM · Restricted Project
rsuderman retitled D78600: DenseStringElementsAttr added to default attribute types from Implemented a DenseStringsElementsAttr for handling tensors of strings. This include the necessary logic for parsing and printing the attributes, along with escape logic. TestDialect was updated to include a custom type to test the string... to DenseStringElementsAttr added to default attribute types.
Apr 21 2020, 5:21 PM · Restricted Project

Apr 15 2020

rsuderman accepted D78258: [mlir][Inliner] Store the resolved call by-value instead of by-reference.
Apr 15 2020, 5:06 PM · Restricted Project

Apr 10 2020

rsuderman accepted D77909: [mlir][Pass] Allow duplicate pass registration..
Apr 10 2020, 3:04 PM · Restricted Project

Mar 20 2020

rsuderman updated the diff for D76161: NFC - Moved AffineOps IR / Transforms.

Synced to head.

Mar 20 2020, 12:28 PM · Restricted Project

Mar 19 2020

rsuderman updated the diff for D76161: NFC - Moved AffineOps IR / Transforms.

Sync to head

Mar 19 2020, 3:54 PM · Restricted Project
rsuderman accepted D76436: [mlir] Rename CMake target MLIRQuantOps to MLIRQuant.
Mar 19 2020, 3:54 PM · Restricted Project

Mar 18 2020

rsuderman updated the diff for D76326: Introduced CallOp Dialect Conversion.

Updated for final comments

Mar 18 2020, 5:55 PM · Restricted Project