Page MenuHomePhabricator

bmahjour (Bardia Mahjour)
User

Projects

User does not belong to any projects.

User Details

User Since
May 3 2019, 8:38 AM (90 w, 3 d)

Recent Activity

Thu, Jan 7

bmahjour committed rG573d57824828: [DDG] Data Dependence Graph - DOT printer tests (authored by bmahjour).
[DDG] Data Dependence Graph - DOT printer tests
Thu, Jan 7, 7:53 AM
bmahjour closed D93949: [DDG] Data Dependence Graph - DOT printer tests.
Thu, Jan 7, 7:53 AM · Restricted Project
bmahjour committed rGebfe4de2c04b: [DDG] Fix duplicate edge removal during pi-block formation (authored by bmahjour).
[DDG] Fix duplicate edge removal during pi-block formation
Thu, Jan 7, 7:35 AM
bmahjour closed D94094: [DDG] Fix duplicate edge removal during pi-block formation.
Thu, Jan 7, 7:35 AM · Restricted Project
bmahjour updated the diff for D94094: [DDG] Fix duplicate edge removal during pi-block formation.

clang-format

Thu, Jan 7, 7:28 AM · Restricted Project

Wed, Jan 6

bmahjour added a reviewer for D94176: [SplitEdge] Add new parameter to SplitEdge to name the newly created basic block: jamieschmeiser.
Wed, Jan 6, 1:13 PM · Restricted Project

Tue, Jan 5

bmahjour requested review of D94094: [DDG] Fix duplicate edge removal during pi-block formation.
Tue, Jan 5, 8:36 AM · Restricted Project

Wed, Dec 30

bmahjour added a comment to D90159: [DDG] Data Dependence Graph - DOT printer .

Should this have some tests? Even if guarded by REQUIRES: if some feature is needed.

Wed, Dec 30, 11:42 AM · Restricted Project, Restricted Project
bmahjour requested review of D93949: [DDG] Data Dependence Graph - DOT printer tests.
Wed, Dec 30, 11:40 AM · Restricted Project

Dec 18 2020

bmahjour added inline comments to D78938: Make LLVM build in C++20 mode.
Dec 18 2020, 2:52 PM · Restricted Project, Restricted Project

Dec 16 2020

bmahjour committed rG6eff12788ee8: [DDG] Data Dependence Graph - DOT printer - recommit (authored by bmahjour).
[DDG] Data Dependence Graph - DOT printer - recommit
Dec 16 2020, 9:38 AM
bmahjour added a comment to D90159: [DDG] Data Dependence Graph - DOT printer .

Can I help fixing the Windows build problem?

I think I have a fix (please see the updated patch), but don't have access to a windows machine to verify. Would you be able to try building with MSVC and let me know if it passes?

Dec 16 2020, 9:31 AM · Restricted Project, Restricted Project

Dec 15 2020

bmahjour updated the diff for D90159: [DDG] Data Dependence Graph - DOT printer .
Dec 15 2020, 7:17 AM · Restricted Project, Restricted Project
bmahjour added a comment to D90159: [DDG] Data Dependence Graph - DOT printer .

Can I help fixing the Windows build problem?

Dec 15 2020, 7:17 AM · Restricted Project, Restricted Project

Dec 14 2020

bmahjour added a reverting change for rGfd4a10732c8b: [DDG] Data Dependence Graph - DOT printer: rGa29ecca7819a: Revert "[DDG] Data Dependence Graph - DOT printer".
Dec 14 2020, 1:55 PM
bmahjour committed rGa29ecca7819a: Revert "[DDG] Data Dependence Graph - DOT printer" (authored by bmahjour).
Revert "[DDG] Data Dependence Graph - DOT printer"
Dec 14 2020, 1:55 PM
bmahjour added a reverting change for D90159: [DDG] Data Dependence Graph - DOT printer : rGa29ecca7819a: Revert "[DDG] Data Dependence Graph - DOT printer".
Dec 14 2020, 1:55 PM · Restricted Project, Restricted Project
bmahjour committed rGfd4a10732c8b: [DDG] Data Dependence Graph - DOT printer (authored by bmahjour).
[DDG] Data Dependence Graph - DOT printer
Dec 14 2020, 1:42 PM
bmahjour closed D90159: [DDG] Data Dependence Graph - DOT printer .
Dec 14 2020, 1:42 PM · Restricted Project, Restricted Project
bmahjour updated the diff for D90159: [DDG] Data Dependence Graph - DOT printer .

fix formatting and use interleaveComma instead of interleave.

Dec 14 2020, 1:07 PM · Restricted Project, Restricted Project
bmahjour accepted D93063: [LV] Disable epilogue vectorization for scalable VFs.

LGTM

Dec 14 2020, 7:38 AM · Restricted Project

Dec 10 2020

bmahjour added inline comments to D93063: [LV] Disable epilogue vectorization for scalable VFs.
Dec 10 2020, 1:23 PM · Restricted Project

Dec 9 2020

bmahjour added inline comments to D90159: [DDG] Data Dependence Graph - DOT printer .
Dec 9 2020, 12:17 PM · Restricted Project, Restricted Project
bmahjour updated the diff for D90159: [DDG] Data Dependence Graph - DOT printer .

Thanks for the review @Meinersbur and sorry for taking so long to address your comments.

Dec 9 2020, 12:16 PM · Restricted Project, Restricted Project

Dec 8 2020

bmahjour committed rG4c70b6ee45e8: [LV] Make optimal-epilog-vectorization-profitability.ll more robust (authored by bmahjour).
[LV] Make optimal-epilog-vectorization-profitability.ll more robust
Dec 8 2020, 9:35 AM

Dec 7 2020

bmahjour added a comment to D89566: [LV] Epilogue Vectorization with Optimal Control Flow.

Should this really be enabled by default given the current (lack of) cost modelling? Primarily concerned about the code size regression this causes.

Dec 7 2020, 1:45 PM · Restricted Project
bmahjour committed rG4db9b78c8146: [LV] Epilogue Vectorization with Optimal Control Flow - Default Enablement (authored by bmahjour).
[LV] Epilogue Vectorization with Optimal Control Flow - Default Enablement
Dec 7 2020, 11:30 AM

Dec 2 2020

bmahjour added a comment to D84951: [LV] Try to sink users recursively for first-order recurrences..

Sorry, I meant to do a more thorough review before approving. I had a closer look today and found some nits and a couple of questions. Please see inline comments.

Dec 2 2020, 3:39 PM · Restricted Project
bmahjour added a comment to D89566: [LV] Epilogue Vectorization with Optimal Control Flow.

OK great. It sounds like there's agreement on the further direction overall and we can work on that in-tree. I'll work on getting the pieces ready to handle live-ins/live-outs in VPlan as required. As for the sekeleton creator, I might be able to take a look over the next week.

LGTM, thanks (meant to respond a bit earlier today :)

Dec 2 2020, 7:15 AM · Restricted Project
bmahjour committed rGa7e2c2693997: [LV] Epilogue Vectorization with Optimal Control Flow (Recommit) (authored by bmahjour).
[LV] Epilogue Vectorization with Optimal Control Flow (Recommit)
Dec 2 2020, 7:10 AM

Dec 1 2020

bmahjour added a reverting change for rG9c5504adceb5: [LV] Epilogue Vectorization with Optimal Control Flow: rGc94af03f7f32: Revert "[LV] Epilogue Vectorization with Optimal Control Flow".
Dec 1 2020, 9:51 AM
bmahjour added a reverting change for D89566: [LV] Epilogue Vectorization with Optimal Control Flow: rGc94af03f7f32: Revert "[LV] Epilogue Vectorization with Optimal Control Flow".
Dec 1 2020, 9:51 AM · Restricted Project
bmahjour committed rGc94af03f7f32: Revert "[LV] Epilogue Vectorization with Optimal Control Flow" (authored by bmahjour).
Revert "[LV] Epilogue Vectorization with Optimal Control Flow"
Dec 1 2020, 9:51 AM
bmahjour committed rG9c5504adceb5: [LV] Epilogue Vectorization with Optimal Control Flow (authored by bmahjour).
[LV] Epilogue Vectorization with Optimal Control Flow
Dec 1 2020, 9:05 AM
bmahjour closed D89566: [LV] Epilogue Vectorization with Optimal Control Flow.
Dec 1 2020, 9:05 AM · Restricted Project

Nov 27 2020

bmahjour added inline comments to D89566: [LV] Epilogue Vectorization with Optimal Control Flow.
Nov 27 2020, 2:19 PM · Restricted Project
bmahjour updated the diff for D89566: [LV] Epilogue Vectorization with Optimal Control Flow.
Nov 27 2020, 2:19 PM · Restricted Project
bmahjour added inline comments to D89566: [LV] Epilogue Vectorization with Optimal Control Flow.
Nov 27 2020, 7:37 AM · Restricted Project

Nov 26 2020

bmahjour updated the diff for D89566: [LV] Epilogue Vectorization with Optimal Control Flow.

Forgot to remove target triple and attributes from target independent tests. They're fixed now.

Nov 26 2020, 12:58 PM · Restricted Project
bmahjour updated the diff for D89566: [LV] Epilogue Vectorization with Optimal Control Flow.
Nov 26 2020, 12:46 PM · Restricted Project
bmahjour added a comment to D89566: [LV] Epilogue Vectorization with Optimal Control Flow.

Thank you for your reviews @SjoerdMeijer @fhahn .

Nov 26 2020, 12:46 PM · Restricted Project

Nov 24 2020

bmahjour added inline comments to D89566: [LV] Epilogue Vectorization with Optimal Control Flow.
Nov 24 2020, 1:44 PM · Restricted Project
bmahjour updated the diff for D89566: [LV] Epilogue Vectorization with Optimal Control Flow.

Rebased, addressed comments, and added more tests (including one for the limited case of live-out supported).

Nov 24 2020, 1:44 PM · Restricted Project

Nov 16 2020

bmahjour added inline comments to D89566: [LV] Epilogue Vectorization with Optimal Control Flow.
Nov 16 2020, 10:09 AM · Restricted Project
bmahjour updated the diff for D89566: [LV] Epilogue Vectorization with Optimal Control Flow.
Nov 16 2020, 10:09 AM · Restricted Project

Nov 12 2020

bmahjour added a comment to D89566: [LV] Epilogue Vectorization with Optimal Control Flow.

Yeah, that could be the case. There are some (micro)benchmarks with a very small execution time, so more susceptible to fluctuations. Have you tried the CTMark subset and TEST_SUITE_BENCHMARKING_ONLY variable? Anyway, if it is too noisy, it was at least a good testing exercise.

I've tried both CTMark and TEST_SUITE_BENCHMARKING_ONLY .

Nov 12 2020, 9:03 AM · Restricted Project
bmahjour updated the diff for D89566: [LV] Epilogue Vectorization with Optimal Control Flow.

Add link to the doc in comments.

Nov 12 2020, 9:01 AM · Restricted Project

Nov 11 2020

bmahjour updated the diff for D89566: [LV] Epilogue Vectorization with Optimal Control Flow.

Update llvm docs.

Nov 11 2020, 8:14 AM · Restricted Project
bmahjour updated the diff for D89566: [LV] Epilogue Vectorization with Optimal Control Flow.

Addressed more comments.

Nov 11 2020, 7:13 AM · Restricted Project
bmahjour added a comment to D89566: [LV] Epilogue Vectorization with Optimal Control Flow.

This is a big change, and here are some notes from my first pass reading through this. Some high level questions here, and find some questions inlined:

  • Think we need a doc update with the new vectorization skeleton? The picture in the description of this change? Don't know how feasible that is, some ascii art too as comments?

Sure, I had a similar comment in D88819. I find the textual graph horrendous. I'll create a section under https://llvm.org/docs/Vectorizers.html and put the diagram there.

Nov 11 2020, 7:11 AM · Restricted Project

Nov 9 2020

bmahjour added a comment to D89566: [LV] Epilogue Vectorization with Optimal Control Flow.

My observations here are:

  • Performance of both patches for SPEC are the same. The advantage of D88819 on ThunderX2 might be a coincidence (knock on effect, e.g. (loop) alignment) or some micro-architecture reason.
  • This patch D89566 can handle more loops, but it is not reflected in the SPEC numbers (cold/not executed code?).
  • The beauty of D88819 is that the changes are very minimal, but looks like it's worth spending extra lines of code here in D89566 to helps in vectorising more.

To me, that shows there's more potential with this patch.
I don't think I can be the arbiter in this, so it's best if other reviewers comment too.

Nov 9 2020, 5:06 PM · Restricted Project
bmahjour added a comment to D89566: [LV] Epilogue Vectorization with Optimal Control Flow.

No regressions so enable by default?

Nov 9 2020, 4:49 PM · Restricted Project
bmahjour updated the diff for D89566: [LV] Epilogue Vectorization with Optimal Control Flow.

Update test cases for default enablement.

Nov 9 2020, 4:48 PM · Restricted Project
bmahjour added a comment to D89566: [LV] Epilogue Vectorization with Optimal Control Flow.

Here are the numbers for SPEC2017 intrate suite on POWER9:

Nov 9 2020, 10:26 AM · Restricted Project

Nov 6 2020

bmahjour added a comment to D89566: [LV] Epilogue Vectorization with Optimal Control Flow.

Just checking/summarising: is there consensus that this is the patch that is going to do epilogue vectorisation, and not D88819? Or does that depend on perf numbers as Florian suggested?

I think we should go with this, unless @fhahn finds that D88819 can outperform it (unlikely). There are more loops that can be transformed with this patch and I've listed other advantages in the description. @mivnay do you agree?

Are you blocking D88819 without running benchmarks? i.e. Without a comparison on any one of the architectures. For x264, D88819 might give better numbers....

Nov 6 2020, 10:36 AM · Restricted Project
bmahjour resigned from D88819: [LV] Support for Remainder loop vectorization.
Nov 6 2020, 10:28 AM · Restricted Project
bmahjour added a comment to D89566: [LV] Epilogue Vectorization with Optimal Control Flow.

Just checking/summarising: is there consensus that this is the patch that is going to do epilogue vectorisation, and not D88819? Or does that depend on perf numbers as Florian suggested?

Nov 6 2020, 9:31 AM · Restricted Project
bmahjour added inline comments to D89566: [LV] Epilogue Vectorization with Optimal Control Flow.
Nov 6 2020, 9:24 AM · Restricted Project
bmahjour updated the diff for D89566: [LV] Epilogue Vectorization with Optimal Control Flow.

Addressed code review comments + check for optsize and minsize.

Nov 6 2020, 9:23 AM · Restricted Project

Nov 3 2020

bmahjour added a comment to D89566: [LV] Epilogue Vectorization with Optimal Control Flow.

I have not looked at any of the details here, but a very high level comment is that this isn't very VPlany. If we do want to push things in that direction, then it is at least worth thinking about how this and vplan will co-exist, even if vplan isn't ready for it yet. It would be great to get to a point where all this information is in the vplan and we can compare epilog remainders vs scalar remainders vs whatever else, and come up with a good total cost based on the estimated trip count. Just something to think about.

Nov 3 2020, 1:59 PM · Restricted Project
bmahjour added a comment to D90159: [DDG] Data Dependence Graph - DOT printer .

ping!

Nov 3 2020, 9:58 AM · Restricted Project, Restricted Project

Oct 29 2020

bmahjour updated the diff for D89566: [LV] Epilogue Vectorization with Optimal Control Flow.

Removed executePlanForEpilogueVectorization, improved code reuse for creatInductionResumeValues, and added more test coverage including a case with double IV.

Oct 29 2020, 7:53 AM · Restricted Project

Oct 27 2020

bmahjour added inline comments to D89566: [LV] Epilogue Vectorization with Optimal Control Flow.
Oct 27 2020, 1:29 PM · Restricted Project

Oct 26 2020

bmahjour added a comment to D89566: [LV] Epilogue Vectorization with Optimal Control Flow.

ping!

Oct 26 2020, 8:22 AM · Restricted Project
bmahjour requested review of D90159: [DDG] Data Dependence Graph - DOT printer .
Oct 26 2020, 8:01 AM · Restricted Project, Restricted Project

Oct 16 2020

bmahjour added a comment to D88819: [LV] Support for Remainder loop vectorization.

Please see D89566 for the alternative approach.

Oct 16 2020, 10:32 AM · Restricted Project
bmahjour updated the summary of D89566: [LV] Epilogue Vectorization with Optimal Control Flow.
Oct 16 2020, 10:30 AM · Restricted Project
bmahjour requested review of D89566: [LV] Epilogue Vectorization with Optimal Control Flow.
Oct 16 2020, 10:30 AM · Restricted Project

Oct 15 2020

bmahjour added inline comments to D89322: [LV] Initial VPlan cost modelling.
Oct 15 2020, 12:21 PM · Restricted Project
bmahjour added a comment to D88819: [LV] Support for Remainder loop vectorization.

But setting things up as in the suggested CFG is going to be a bit more tricky and might not turn out to be much simpler in the end. I might give it a try to see if it's feasible.

Oct 15 2020, 10:04 AM · Restricted Project
bmahjour added a comment to D88819: [LV] Support for Remainder loop vectorization.

I also agree with @mivnay's summary above and the general approach of just running ILV again on the remainder loop with the available vplan. If we mark the epilogue loop and put it back in the worklist, it'll be harder/uglier to then modify the CFG to make it more optimal. I do, however, think that the implementation can be improved (see my note below). Please also note that the SCEV and runtime checks cannot be avoided by marking them "noalias" (or similar tricks) because if the iteration count of the loop is small enough to by-pass the main vector loop and large enough to execute the vector epilogue, then the runtime checks need to be executed for the epilogue loop. The only way to avoid the redundant runtime checks is to generate the smaller trip count check first, as illustrated in the CFG I've posted above.

Oct 15 2020, 8:50 AM · Restricted Project
bmahjour added a comment to D88819: [LV] Support for Remainder loop vectorization.

This approach doesn't work when most of the trip counts are always good for original vector loop. In fact, it even performs one additional trip count check when both vector loop and epilog vector loops are executed. For example, if original VF=16 and UF=2, and epilog VF=8 and UF=1, trip count as small as 40 requires 3 trip count checks. Where as, it is 2 in the current implementation.

Oct 15 2020, 8:30 AM · Restricted Project

Oct 13 2020

bmahjour added inline comments to D89322: [LV] Initial VPlan cost modelling.
Oct 13 2020, 10:32 AM · Restricted Project

Oct 6 2020

bmahjour requested changes to D88819: [LV] Support for Remainder loop vectorization.
Oct 6 2020, 8:07 AM · Restricted Project
bmahjour added a reviewer for D88819: [LV] Support for Remainder loop vectorization: bmahjour.
Oct 6 2020, 7:41 AM · Restricted Project
bmahjour added a comment to D88819: [LV] Support for Remainder loop vectorization.

Thanks for working on epilogue vectorization. Incidentally I've also looked into this recently. There has been a long and detailed discussion on the mailing list from back in 2017 about this transformation here http://llvm.1065342.n5.nabble.com/llvm-dev-Proposal-RFC-Epilog-loop-vectorization-td106322.html. Your patch is able to vectorize epilogue loops with fairly small changes to the LV, however the generated CFG is not optimal. For example, while the SCEV and memory checks are not redundantly executed, they are statically duplicated in the code and increase code size unnecessarily. The trip count checks can also be generated in a way that shortens the critical path from the checks to the scalar loop, which is critical for loops that have a small trip count. Based on the followup discussions from the mentioned RFC, the optimal CFG should look more like what I've attached below.

Oct 6 2020, 7:40 AM · Restricted Project

Oct 5 2020

bmahjour added a comment to D84951: [LV] Try to sink users recursively for first-order recurrences..

Any futher comments, @bmahjour?

Oct 5 2020, 11:00 AM · Restricted Project

Sep 8 2020

bmahjour added inline comments to D84589: [CodeMoverUtils] Add optional data dependence checks using Alias Analysis.
Sep 8 2020, 7:04 AM · Restricted Project

Sep 3 2020

bmahjour requested changes to D87094: [CodeMoverUtils]Add option to skip control flow equivalence checks when sure.
Sep 3 2020, 9:20 AM · Restricted Project

Sep 1 2020

bmahjour added inline comments to D86850: [LoopRotate][WIP] Check code-motion safety before hoisting.
Sep 1 2020, 12:08 PM · Restricted Project

Aug 31 2020

bmahjour added inline comments to D86850: [LoopRotate][WIP] Check code-motion safety before hoisting.
Aug 31 2020, 7:00 AM · Restricted Project
bmahjour added a reviewer for D86850: [LoopRotate][WIP] Check code-motion safety before hoisting: fedor.sergeev.
Aug 31 2020, 6:59 AM · Restricted Project

Aug 24 2020

bmahjour added a comment to D86262: [LoopIdiomRecognizePass] Options to disable part or the entire Loop Idiom Recognize Pass.

I think such an option is fine as a temporary stop-gap solution, but the goal should be to fix the underlying issue IMO.

The long term solution would be to make loop-idiom consider compile-time or PGO loop trip count data when deciding to transform loops. For non-constant non-PGO cases the cost modeling would be a heuristic at best, in which case the option would still be useful.

Aug 24 2020, 10:37 AM · Restricted Project
bmahjour added a comment to D86262: [LoopIdiomRecognizePass] Options to disable part or the entire Loop Idiom Recognize Pass.

@lebedev.ri

I'd like to see a PhaseOrdering test showing the IR that is not optimized due to the DA being unaware about these intrinsics.

Aug 24 2020, 10:16 AM · Restricted Project
bmahjour added inline comments to D84951: [LV] Try to sink users recursively for first-order recurrences..
Aug 24 2020, 7:06 AM · Restricted Project

Aug 21 2020

bmahjour accepted D81416: [LV] Interleave to expose ILP for small loops with scalar reductions..
Aug 21 2020, 8:27 AM · Restricted Project, Restricted Project

Aug 20 2020

bmahjour added a comment to D81416: [LV] Interleave to expose ILP for small loops with scalar reductions..

Given that interleaving alone (without vectorization) can still cause major performance improvements shows that this is really an interleaving profitability issue, so the heuristic and the option seem ok to me. To enable the option by default we would need more testing on other platforms. That can be done in a separate patch.

Aug 20 2020, 8:17 AM · Restricted Project, Restricted Project
bmahjour added a comment to D86262: [LoopIdiomRecognizePass] Options to disable part or the entire Loop Idiom Recognize Pass.

Another way that loop idiom can hurt performance is by creating imperfect loop nests. Certain transformations (such as loop interchange and unroll-and-jam) are more difficult (sometimes impossible) to do when loop nests are not perfect.

Aug 20 2020, 7:34 AM · Restricted Project
bmahjour added a comment to D86262: [LoopIdiomRecognizePass] Options to disable part or the entire Loop Idiom Recognize Pass.

I agree with that, it seems to be better to improve DA. Is it feasible?

The theory of data dependence analysis relies on presence of subscripts in array references to be able to produce accurate results. I don't see how we can "improve DA" to address memset/memcpies short of turning them back into loop nests before applying the dependence tests. To do that the loop has to either be materialized before the DA analysis pass is run, or somehow SCEV expressions representing the implied subscripts be synthesized out of thin air. The former must be achieved by a transformation pass, so we would have to turn memset/memcpys into loop nests as soon as possible. For memset/memcpy calls generated by the loop idiom pass, the ideal place for that transformation would be immediately after loop idiom itself, which would have the same effect as preventing loop idiom from creating such loops in the first place when it knows they are not profitable. I don't know of any possible way to do the latter.

Aug 20 2020, 7:21 AM · Restricted Project

Aug 18 2020

bmahjour added inline comments to D84589: [CodeMoverUtils] Add optional data dependence checks using Alias Analysis.
Aug 18 2020, 2:03 PM · Restricted Project

Aug 13 2020

bmahjour added inline comments to D84589: [CodeMoverUtils] Add optional data dependence checks using Alias Analysis.
Aug 13 2020, 9:04 AM · Restricted Project

Aug 11 2020

bmahjour accepted D71539: [SCEV] Look through trivial PHIs..

This patch only improves things for LCSSA phis, not for other trivial phis (multiple equal incoming values).

It would be good to clarify this in the title then.

Aug 11 2020, 1:55 PM · Restricted Project

Aug 4 2020

bmahjour committed rG3c0f34700230: [NFC][LV] Vectorized Loop Skeleton Refactoring (authored by bmahjour).
[NFC][LV] Vectorized Loop Skeleton Refactoring
Aug 4 2020, 11:51 AM
bmahjour closed D83824: [NFC] [LV] Vectorized Loop Skeleton Refactoring.
Aug 4 2020, 11:51 AM · Restricted Project
bmahjour updated the diff for D83824: [NFC] [LV] Vectorized Loop Skeleton Refactoring.

rebase

Aug 4 2020, 11:45 AM · Restricted Project
bmahjour updated subscribers of D84764: Fix computeHostNumPhysicalCores() for Linux on POWER and Linux on Z.

@nemanjai has kindly provided a fix https://reviews.llvm.org/rG62a933b72c5b060bcb2c7332d05082f002d6c65a.

Aug 4 2020, 7:08 AM · Restricted Project

Jul 30 2020

bmahjour requested changes to D71539: [SCEV] Look through trivial PHIs..
Jul 30 2020, 2:57 PM · Restricted Project
bmahjour added a comment to D71539: [SCEV] Look through trivial PHIs..

Some of the tests added in llvm/test/Analysis/ScalarEvolution/trivial-phis.ll come from https://reviews.llvm.org/D71492 but don't have the same expected results. @fhahn do you plan to improve those in this patch or a subsequent patch, or were you planning to leave those to me in D71492?

Jul 30 2020, 2:57 PM · Restricted Project

Jul 28 2020

bmahjour added inline comments to D84589: [CodeMoverUtils] Add optional data dependence checks using Alias Analysis.
Jul 28 2020, 2:36 PM · Restricted Project
bmahjour added inline comments to D84589: [CodeMoverUtils] Add optional data dependence checks using Alias Analysis.
Jul 28 2020, 2:32 PM · Restricted Project