- User Since
- Dec 14 2019, 8:54 PM (79 w, 19 h)
Minor update to test cases.
Rebase on upstream tip. Bring code to date.
Fri, Jun 18
Update commit summary - fix revision number.
Thu, Jun 17
Update revision summary
Drop duplicate attr dict parsing. Fix stale comment.
Rebase on upstream tip. Move op to SCF dialect.
@pifon2a Could I request adding a commit summary (even if one line) on what caused the change? (for eg., "Op dropped because of ...".) Changes like these shouldn't leave the commit summary empty I think - You could even just paste a link to a discourse thread if it was discussed there.
Wed, Jun 16
The commit summary is outdated/does not match the fix. Furthermore, a deque is not needed here any more.
Thank you for the reviews!
Address reviewer comments. Rebase on tip.
Tue, Jun 15
I just had superficial comments. Please do go with @jpienaar or one of the other reviewers' comments.
Mon, Jun 14
@wsmoses MemRefDataFlow has just been moved and been renamed. Could you rebase right away? (so that the rebase becomes easy with no further intervening commits)
Thanks for fixing this - sorry I had missed updating flang.
Sat, Jun 12
Update commit title/summary on phab.
Mark the change NFC.
Make the test case simpler/direct.
Fri, Jun 11
Fix stale comments.
- Please add a test case.
This is now moot given std.execute_region suits the scf dialect and the yield op there could terminate it.
Drop unnecessary include STLExtras.h
Looks good - thanks!
Switched to list of strings on Python API and <count, MlirStringRef array> on the CAPI.
Switch to list of strings on Python API.
Thu, Jun 10
Wed, Jun 9
Drop unnecessary import.
Wed, Jun 2
Thanks for addressing everything - LGTM!
Mon, May 31
I'll be able to review this tomorrow, but a few really minor things I noticed.
Sun, May 30
Thanks for extending this pass. Comments below.
Thu, May 27
index type can be negative as well - very much!
Tue, May 25
Mon, May 24
Sun, May 23
LGTM - some minor comments on compactness.
Fix typo in commit title.