This is an archive of the discontinued LLVM Phabricator instance.

Differential D110684

[RISCV] Define _m intrinsics as builtins, instead of macros.
ClosedPublic

Authored by HsiangKai on Sep 29 2021, 12:52 AM.

Details

Reviewers
craig.topper
rogfer01
frasercrmck
Commits
rG97f0c63783f5: [RISCV] Define _m intrinsics as builtins, instead of macros.
Summary

In the original design, we levarage _mt intrinsics to define macros for
_m intrinsics. Such as,

#define vadd_vv_i8m1_m(op0, op1, op2, op3, op4) \
__builtin_rvv_vadd_vv_i8m1_mt((vbool8_t)(op0), (vint8m1_t)(op1), (vint8m1_t)(op2), (vint8m1_t)(op3), (size_t)(op4), (size_t)VE_TAIL_AGNOSTIC)

However, we could not define generic interface for mask intrinsics any
more due to clang_builtin_alias only accepts clang builtins as its
argument.

In the example,

__rvv_overloaded
__attribute__((clang_builtin_alias(__builtin_rvv_vadd_vv_i8m1_mt)))
 vint8m1_t vadd(vbool8_t op0, vint8m1_t op1, vint8m1_t op2, vint8m1_t
 op3, size_t op4, size_t op5);

op5 is the tail policy argument. When users want to use vadd generic
interface for masked vector add, they need to specify tail policy in the
previous design. In this patch, we define _m intrinsics as clang
builtins to solve the problem.

Diff Detail

Event Timeline

HsiangKai created this revision.Sep 29 2021, 12:52 AM
Herald added subscribers: achieveartificialintelligence, StephenFan, vkmr and 25 others. · View Herald TranscriptSep 29 2021, 12:52 AM
HsiangKai requested review of this revision.Sep 29 2021, 12:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2021, 12:52 AM
Herald added subscribers: cfe-commits, MaskRay. · View Herald Transcript
HsiangKai edited the summary of this revision. (Show Details)Sep 29 2021, 12:56 AM
Harbormaster completed remote builds in B126264: Diff 375798.Sep 29 2021, 1:12 AM
HsiangKai updated this revision to Diff 376890.Oct 4 2021, 7:24 AM

Update test cases.

Harbormaster completed remote builds in B126827: Diff 376890.Oct 4 2021, 7:24 AM
HsiangKai added a comment.Oct 10 2021, 5:41 AM

Ping.

craig.topper added a comment.Oct 11 2021, 1:39 PM

This patch was uploaded without full context.

craig.topper accepted this revision.Oct 11 2021, 2:01 PM

LGTM

This revision is now accepted and ready to land.Oct 11 2021, 2:01 PM
Closed by commit rG97f0c63783f5: [RISCV] Define _m intrinsics as builtins, instead of macros. (authored by HsiangKai). · Explain WhyOct 11 2021, 7:48 PM
This revision was automatically updated to reflect the committed changes.
HsiangKai added a commit: rG97f0c63783f5: [RISCV] Define _m intrinsics as builtins, instead of macros..
nikic added a subscriber: nikic.Oct 12 2021, 1:13 AM

I noticed this a few time in the past already, but this is the worst one yet:

Compile-time: https://llvm-compile-time-tracker.com/compare.php?from=6641d29b70993bce6dbd7e0e0f1040753d38842f&to=97f0c63783f52389bd8842df205379ceade7a89d&stat=instructions
Max-rss: https://llvm-compile-time-tracker.com/compare.php?from=6641d29b70993bce6dbd7e0e0f1040753d38842f&to=97f0c63783f52389bd8842df205379ceade7a89d&stat=max-rss
Plus a >1% increase in clang total binary size.

This happens every time a new slew of RISCV intrinsic permutations gets added, which seem to suffer from an extreme degree of redundancy. Is it possible to do something about this?

aeubanks added a subscriber: aeubanks.Oct 12 2021, 2:03 PM
In D110684#3057498, @nikic wrote:

I noticed this a few time in the past already, but this is the worst one yet:

Compile-time: https://llvm-compile-time-tracker.com/compare.php?from=6641d29b70993bce6dbd7e0e0f1040753d38842f&to=97f0c63783f52389bd8842df205379ceade7a89d&stat=instructions
Max-rss: https://llvm-compile-time-tracker.com/compare.php?from=6641d29b70993bce6dbd7e0e0f1040753d38842f&to=97f0c63783f52389bd8842df205379ceade7a89d&stat=max-rss
Plus a >1% increase in clang total binary size.

This happens every time a new slew of RISCV intrinsic permutations gets added, which seem to suffer from an extreme degree of redundancy. Is it possible to do something about this?

+1, it seems bad to regress overall Clang memory usage by 1% by adding some intrinsics, especially when we're not targeting RISCV.

craig.topper added a comment.Oct 12 2021, 2:31 PM
In D110684#3059698, @aeubanks wrote:
In D110684#3057498, @nikic wrote:

I noticed this a few time in the past already, but this is the worst one yet:

Compile-time: https://llvm-compile-time-tracker.com/compare.php?from=6641d29b70993bce6dbd7e0e0f1040753d38842f&to=97f0c63783f52389bd8842df205379ceade7a89d&stat=instructions
Max-rss: https://llvm-compile-time-tracker.com/compare.php?from=6641d29b70993bce6dbd7e0e0f1040753d38842f&to=97f0c63783f52389bd8842df205379ceade7a89d&stat=max-rss
Plus a >1% increase in clang total binary size.

This happens every time a new slew of RISCV intrinsic permutations gets added, which seem to suffer from an extreme degree of redundancy. Is it possible to do something about this?

+1, it seems bad to regress overall Clang memory usage by 1% by adding some intrinsics, especially when we're not targeting RISCV.

Is the max-rss increase due to the binary size increase?

MaskRay added a comment.Oct 12 2021, 6:22 PM

This has been the first time RISC-V added something and caused performance/memory/test execution regression for other users.

The problem should be considered seriously (I don't even mind reverting the patch.)

HsiangKai added a comment.Oct 12 2021, 8:05 PM

We are working on a patch, D111617, to reduce the large header size caused by abundant RISC-V vector intrinsics.
From the measurement depicted in D103228, it should be helpful for compile time.

HsiangKai mentioned this in D111617: [RISCV] Lazily add RVV C intrinsics..Oct 12 2021, 9:01 PM
HsiangKai added a reverting change: rGff3ed7830449: Revert "[RISCV] Define _m intrinsics as builtins, instead of macros.".Oct 12 2021, 9:22 PM

Large Diff

This large diff affects 119 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
clang/
include/
clang/
Basic/
2 lines
76 lines
lib/
CodeGen/
1 line
test/
CodeGen/
RISCV/
rvv-intrinsics-overloaded/
1264 lines
966 lines
280 lines
280 lines
280 lines
280 lines
280 lines
736 lines
280 lines
967 lines
1264 lines
163 lines
969 lines
297 lines
390 lines
138 lines
1845 lines
613 lines
29 lines
613 lines
613 lines
613 lines
201 lines
1987 lines
297 lines
289 lines
289 lines
289 lines
289 lines
1855 lines
331 lines
326 lines
289 lines
613 lines
797 lines
1637 lines
399 lines
797 lines
56 lines
757 lines
273 lines
2923 lines
19767 lines
969 lines
14548 lines
4548 lines
2925 lines
19767 lines
1 line
969 lines
300 lines
290 lines
290 lines
300 lines
300 lines
300 lines
969 lines
14 lines
1 line
1 line
14 lines
1 line
283 lines
50 lines
301 lines
352 lines
352 lines
50 lines
334 lines
334 lines
301 lines
50 lines
2421 lines
1 line
1 line
914 lines
448 lines
328 lines
658 lines
329 lines
329 lines
967 lines
1 line
219 lines
969 lines
3100 lines
483 lines
1264 lines
236 lines
57 lines
391 lines
721 lines
690 lines
967 lines
618 lines
848 lines
9264 lines
483 lines
483 lines
236 lines
1256 lines
627 lines
642 lines
1256 lines
1264 lines
967 lines
848 lines
9264 lines
1731 lines
448 lines
991 lines
1731 lines
967 lines
391 lines
rvv-intrinsics/
27 lines
utils/
TableGen/
89 lines

Diff 378859

clang/include/clang/Basic/IdentifierTable.h

clang/include/clang/Basic/riscv_vector.td

clang/lib/CodeGen/CGBuiltin.cpp

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vaadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vamoadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vamoand.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vamomax.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vamomin.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vamoor.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vamoswap.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vamoxor.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vand.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vasub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vcompress.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vdiv.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfabs.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfclass.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfcvt.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfdiv.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfirst.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfmax.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfmin.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfmul.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfmv.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfncvt.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfneg.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfrdiv.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfrec7.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfrsqrt7.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfrsub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfsgnj.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfslide1down.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfslide1up.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfsqrt.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfsub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfwadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfwcvt.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfwmul.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfwsub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vget.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vle.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vlmul.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vloxei.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vloxseg.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vlse.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vlseg.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vlsseg.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vluxei.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vluxseg.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmand.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmax.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmfeq.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmfge.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmfgt.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmfle.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmflt.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmfne.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmin.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmmv.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmnand.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmnor.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmnot.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmor.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmsbc.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmsbf.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmseq.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmsge.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmsgt.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmsif.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmsle.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmslt.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmsne.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmsof.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmul.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmxnor.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vmxor.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vnclip.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vncvt.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vneg.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vnot.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vnsra.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vnsrl.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vor.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vpopc.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vreinterpret.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vrem.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vrgather.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vrsub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vsadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vse.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vset.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vsext.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vslide1down.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vslide1up.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vsll.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vsmul.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vsoxei.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vsoxseg.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vsra.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vsrl.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vsse.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vsseg.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vssra.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vssrl.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vssseg.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vssub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vsub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vsuxei.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vsuxseg.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vwadd.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vwcvt.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vwmul.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vwsub.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vxor.c

clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vzext.c

clang/test/CodeGen/RISCV/rvv-intrinsics/vadd-policy.c

clang/utils/TableGen/RISCVVEmitter.cpp