Page MenuHomePhabricator

vkmr (Vineet Kumar)
User

Projects

User does not belong to any projects.

User Details

User Since
May 7 2019, 7:55 AM (100 w, 6 d)

Recent Activity

Thu, Apr 1

vkmr updated the diff for D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept).

Merged more recent changes on main.

Thu, Apr 1, 6:29 PM · Restricted Project, Restricted Project
vkmr updated the diff for D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept).

Revert diff 334860

Thu, Apr 1, 5:02 PM · Restricted Project, Restricted Project
vkmr updated the diff for D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept).

Remove unused header

Thu, Apr 1, 4:57 PM · Restricted Project, Restricted Project
vkmr updated the diff for D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept).

Remove unused header include

Thu, Apr 1, 4:03 PM · Restricted Project, Restricted Project
vkmr added reviewers for D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept): sdesmalen, dmgreen, craig.topper, evandro, bmahjour, fhahn, hussainjk.
Thu, Apr 1, 11:28 AM · Restricted Project, Restricted Project
vkmr updated the summary of D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept).
Thu, Apr 1, 11:19 AM · Restricted Project, Restricted Project
vkmr requested review of D99750: [LV, VP] RFC: VP intrinsics support for the Loop Vectorizer (Proof-of-Concept).
Thu, Apr 1, 10:32 AM · Restricted Project, Restricted Project

Fri, Mar 26

vkmr added a comment to D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

Thanks Hussain for this patch!
For now I have a couple of minor comments, I will take a deeper look later.
Also, I don't quite understand yet how VP handles (or plans to handle) specifying alignment parameter. Does it need VPBuilder (not to be confused with VPlan VPBuilder!) for that? Would it make sense to add the Alignment parameter to VP load/store/scatter/gather intrinsics (much like their masked counterparts) for now, unless there is already a way to specify that?

Fri, Mar 26, 10:22 AM · Restricted Project, Restricted Project

Feb 1 2021

vkmr added inline comments to D95659: [RISCV] Initial support of LoopVectorizer for RISC-V Vector..
Feb 1 2021, 5:08 AM · Restricted Project

Jan 29 2021

vkmr added inline comments to D95659: [RISCV] Initial support of LoopVectorizer for RISC-V Vector..
Jan 29 2021, 10:45 AM · Restricted Project
vkmr added inline comments to D95659: [RISCV] Initial support of LoopVectorizer for RISC-V Vector..
Jan 29 2021, 5:16 AM · Restricted Project

Jan 27 2021

vkmr added a comment to D94708: [IR] Introduce llvm.experimental.vector.splice intrinsic.

FWIW, we have a similar intrinsic in our downstream compiler for RISC-V. We call it experimental.vector.slideleftfill and is same as flavour 2 of this (except the "offset" need not be an immediate) as suggested by @sdesmalen. We have a separate predicated version (experimental.vector.vp.slideleftfill) too which takes additional arguments for the explicit vector length of the two vectors.

Jan 27 2021, 2:27 AM · Restricted Project

Nov 5 2020

vkmr accepted D90715: [VPlan] NFC: Change VFRange to take ElementCount.

LGTM.

Nov 5 2020, 1:09 PM · Restricted Project
vkmr added a comment to D90715: [VPlan] NFC: Change VFRange to take ElementCount.

Other than the minor nit, LGTM.

Nov 5 2020, 7:30 AM · Restricted Project

Oct 29 2020

vkmr added a comment to D90342: [POC][LoopVectorizer] Propagate ElementCount to interfaces in preparation for scalable auto-vec. .

Overall, definitely a good starting point. I just have a couple of minor comments.

Oct 29 2020, 6:13 AM · Restricted Project

Oct 5 2020

vkmr added inline comments to D88409: [SVE] Make ElementCount and TypeSize use a new PolySize class.
Oct 5 2020, 5:34 PM · Restricted Project, Restricted Project

Sep 30 2020

vkmr added inline comments to D88409: [SVE] Make ElementCount and TypeSize use a new PolySize class.
Sep 30 2020, 7:56 AM · Restricted Project, Restricted Project

Aug 14 2020

vkmr added inline comments to D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].
Aug 14 2020, 12:57 PM · Restricted Project
vkmr added inline comments to D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].
Aug 14 2020, 12:41 PM · Restricted Project

Aug 13 2020

vkmr added a comment to D85794: [llvm][LV] Replace `unsigned VF` with `ElementCount VF` [NFCI].

Thanks @fpetrogalli for this proposal! I agree with @rogfer01 and @rengolin in that this approach makes a lot of sense.
I have added a few comments inline. Overall looks good.

Aug 13 2020, 6:08 AM · Restricted Project

May 18 2020

vkmr added inline comments to D79100: [LV] Emit new IR intrinsic llvm.get.active.mask for tail-folded loops.
May 18 2020, 4:18 PM · Restricted Project
vkmr added inline comments to D79100: [LV] Emit new IR intrinsic llvm.get.active.mask for tail-folded loops.
May 18 2020, 3:45 PM · Restricted Project