- User Since
- Feb 12 2020, 11:23 AM (33 w, 3 h)
One nit, otherwise lgtm
break out of loop after MarkLive()
https://reviews.llvm.org/D88529 seems like a nicer solution, wdyt?
This looks good, just a couple nits
overall lgtm with some nits, but I'd like yrouban to take a look at the signal handler
Mon, Sep 28
Documentation done in https://reviews.llvm.org/D88342
Sun, Sep 27
Sat, Sep 26
Fri, Sep 25
preserve loop analyses
I see, I'll work on that.
(I'm not familiar with the intricacies of the inliner, so any pointers like that to remaining blockers are appreciated).
Thu, Sep 24
I think I'm still missing how exactly this will fit into the pipeline. As in where is registerPassBuilderCallbacks() going to be called?
Yep I'll take a look.
Wed, Sep 23
Yeah that makes sense. Or maybe have some global counter, since this is mostly a debugging thing, although that seems fairly hacky.
LTOBackend may also need to deal with this, but I don't know if flags like opt-bisect apply there.
I suppose we can think about interactions with the legacy PM in a later patch, this on its own is an improvement.
Actually, doing verify-each in StandardInstrumentations seems much nicer. Not sure about how to do debugify-each though, filed https://bugs.llvm.org/show_bug.cgi?id=47633.
Turns out this doesn't actually work as intended...
The callbacks need to be done at the addPass() level, or else something like 'default<O3>' only runs the callbacks once, even though it adds a bunch of passes. Will probably revert once I come up with something better.
Makes sense, but do you have an example usage of this?
Tue, Sep 22
instead, just fix all 6 tests failing because of -enable-mssa-loop-dependency
ASan to the rescue:
I believe this is causing issues in Windows builds, e.g. http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/25705 and hangs in http://220.127.116.11/win/summary.html.
I'm seeing a hang locally:
$ ./build/debug/obj/llvm/unittests/Analysis/AnalysisTests.exe --gtest_filter='*IRSimilarityCandidate.IdenticalWithDebug*'
Note: Google Test filter = *IRSimilarityCandidate.IdenticalWithDebug*
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from IRSimilarityCandidate
[ RUN ] IRSimilarityCandidate.IdenticalWithDebug
warning: ignoring debug info with an invalid version (0) in <string>
this causes some tests to fail, let me fix those up
small comment change
asbirlea, you mentioned offline that there were passes that replaced this in the NPM and that this shouldn't be ported, do you know what those are so I can put them in the description of another change pinning tests to the legacy PM?
Mon, Sep 21
add option to disable adding AlwaysInlinerPass
add assertion reason string
I discovered that some tests regarding optimization remarks were failing since AlwaysInlinerPass didn't emit optimization remarks, separated that out into https://reviews.llvm.org/D88067.