Page MenuHomePhabricator

HsiangKai (Hsiangkai Wang)
Kai

Projects

User does not belong to any projects.

User Details

User Since
May 4 2016, 7:01 PM (245 w, 5 d)

Recent Activity

Today

HsiangKai requested review of D94940: [RISCV] Implement vsxseg intrinsics..
Mon, Jan 18, 7:25 PM · Restricted Project
HsiangKai requested review of D94903: [RISCV] Implement vlxseg intrinsics..
Mon, Jan 18, 3:04 AM · Restricted Project
HsiangKai updated the diff for D94863: [RISCV] Implement vssseg intrinsics..

Add test cases for floating point types.

Mon, Jan 18, 1:59 AM · Restricted Project
HsiangKai updated the diff for D94763: [RISCV] Implement vlsseg intrinsics..

Add test cases for floating point types.

Mon, Jan 18, 1:59 AM · Restricted Project
HsiangKai updated the diff for D94688: [RISCV] Implement vsseg intrinsics..

Add test cases for floating point types.

Mon, Jan 18, 1:58 AM · Restricted Project
HsiangKai updated the diff for D94229: [RISCV] Implement vlseg intrinsics..

Add test cases for floating point types.

Mon, Jan 18, 1:57 AM · Restricted Project

Yesterday

HsiangKai added a comment to D92715: [Clang][RISCV] Define RISC-V V builtin types.

Ping. If we all agree to use builtin types to model RVV types, is there any other issues we need to address in this patch?

Sun, Jan 17, 9:42 PM · Restricted Project

Sat, Jan 16

HsiangKai updated the diff for D94863: [RISCV] Implement vssseg intrinsics..

Rebase.

Sat, Jan 16, 6:09 PM · Restricted Project
HsiangKai updated the diff for D94763: [RISCV] Implement vlsseg intrinsics..

Rebase.

Sat, Jan 16, 6:08 PM · Restricted Project
HsiangKai updated the diff for D94688: [RISCV] Implement vsseg intrinsics..

Rebase.

Sat, Jan 16, 6:08 PM · Restricted Project
HsiangKai updated the diff for D94229: [RISCV] Implement vlseg intrinsics..

Rebase.

Sat, Jan 16, 6:02 PM · Restricted Project
HsiangKai committed rG098dbf190a55: [RISCV] Correct alignment settings for vector registers. (authored by HsiangKai).
[RISCV] Correct alignment settings for vector registers.
Sat, Jan 16, 7:22 AM
HsiangKai closed D94751: [RISCV] Correct alignment settings for vector registers..
Sat, Jan 16, 7:21 AM · Restricted Project
HsiangKai requested review of D94863: [RISCV] Implement vssseg intrinsics..
Sat, Jan 16, 5:43 AM · Restricted Project

Fri, Jan 15

HsiangKai committed rG619eb1477599: [NFC][RISCV] Remove useless code in RISCVRegisterInfo.td. (authored by HsiangKai).
[NFC][RISCV] Remove useless code in RISCVRegisterInfo.td.
Fri, Jan 15, 4:09 AM
HsiangKai closed D94750: [NFC][RISCV] Remove useless code in RISCVRegisterInfo.td..
Fri, Jan 15, 4:09 AM · Restricted Project
HsiangKai requested review of D94763: [RISCV] Implement vlsseg intrinsics..
Fri, Jan 15, 3:52 AM · Restricted Project

Thu, Jan 14

HsiangKai updated the diff for D92715: [Clang][RISCV] Define RISC-V V builtin types.

According to "9. Vector Memory Alignment Constraints" in V specification, change the alignment of RVV types to the element size.

Thu, Jan 14, 11:08 PM · Restricted Project
HsiangKai updated the summary of D94749: [RISCV] Correct DWARF number for vector registers..
Thu, Jan 14, 10:59 PM · Restricted Project
HsiangKai requested review of D94751: [RISCV] Correct alignment settings for vector registers..
Thu, Jan 14, 10:58 PM · Restricted Project
HsiangKai requested review of D94750: [NFC][RISCV] Remove useless code in RISCVRegisterInfo.td..
Thu, Jan 14, 10:57 PM · Restricted Project
HsiangKai requested review of D94749: [RISCV] Correct DWARF number for vector registers..
Thu, Jan 14, 10:56 PM · Restricted Project
HsiangKai requested review of D94688: [RISCV] Implement vsseg intrinsics..
Thu, Jan 14, 7:09 AM · Restricted Project
HsiangKai updated the diff for D94229: [RISCV] Implement vlseg intrinsics..
Thu, Jan 14, 7:05 AM · Restricted Project

Wed, Jan 13

HsiangKai updated the diff for D92715: [Clang][RISCV] Define RISC-V V builtin types.

Recover comments.

Wed, Jan 13, 7:36 PM · Restricted Project
HsiangKai updated the diff for D92715: [Clang][RISCV] Define RISC-V V builtin types.

Refine debug info for RVV types.

Wed, Jan 13, 7:22 PM · Restricted Project
HsiangKai added a comment to D94403: [RISCV] Implement new architecture extension macros.

LGTM.

Wed, Jan 13, 6:03 PM · Restricted Project
HsiangKai accepted D94249: [RISCV] Custom lower ISD::VSCALE..

LGTM.

Wed, Jan 13, 5:05 PM · Restricted Project
HsiangKai commandeered D92715: [Clang][RISCV] Define RISC-V V builtin types.
Wed, Jan 13, 8:08 AM · Restricted Project
HsiangKai added a comment to D92715: [Clang][RISCV] Define RISC-V V builtin types.

@liaolucy RISC-V vector types are sizeless types. Sizeless is kind of characteristic for builtin types. If we use attribute to declare RISC-V vector types, the frontend does not know anything about it. I still think to define RISC-V vector types as builtin types is a better way.

Wed, Jan 13, 7:55 AM · Restricted Project
HsiangKai committed rG350c0552c66b: [NFC][RISCV] Add double type in RISC-V V CodeGen test cases for RV32. (authored by HsiangKai).
[NFC][RISCV] Add double type in RISC-V V CodeGen test cases for RV32.
Wed, Jan 13, 7:46 AM
HsiangKai closed D94584: [NFC][RISCV] Add double type in RISC-V V CodeGen test cases for RV32..
Wed, Jan 13, 7:46 AM · Restricted Project
HsiangKai abandoned D93750: [RISCV] Frame handling for RISC-V V extension..

Let's focus on D94465. If there is anyone oppose it, I could reactivate this commit.

Wed, Jan 13, 7:26 AM · Restricted Project
HsiangKai added a comment to D94465: [RISCV] Frame handling for RISC-V V extension. (2nd. version).

I also think one direct memory access is better than two memory accesses. I abandoned D93750 first. If there is anyone oppose it, I could reactivate it.

Wed, Jan 13, 7:25 AM · Restricted Project
HsiangKai added inline comments to D94249: [RISCV] Custom lower ISD::VSCALE..
Wed, Jan 13, 7:18 AM · Restricted Project
HsiangKai accepted D94592: [NFC][AsmPrinter] Windows warning: Use explicit cast.

LGTM.

Wed, Jan 13, 7:02 AM · Restricted Project
HsiangKai requested review of D94584: [NFC][RISCV] Add double type in RISC-V V CodeGen test cases for RV32..
Wed, Jan 13, 1:03 AM · Restricted Project

Tue, Jan 12

HsiangKai requested review of D94583: [RISCV] Update V extension to v1.0-draft 08a0b464..
Tue, Jan 12, 10:54 PM · Restricted Project
HsiangKai committed rG914e2f5a02f4: [NFC] Use generic name for scalable vector stack ID. (authored by HsiangKai).
[NFC] Use generic name for scalable vector stack ID.
Tue, Jan 12, 6:58 PM
HsiangKai closed D94471: [NFC] Use generic name for scalable vector stack ID..
Tue, Jan 12, 6:58 PM · Restricted Project
HsiangKai added a reviewer for D94471: [NFC] Use generic name for scalable vector stack ID.: rogfer01.
Tue, Jan 12, 12:48 AM · Restricted Project
HsiangKai updated the diff for D94465: [RISCV] Frame handling for RISC-V V extension. (2nd. version).

Address @jrtc27's comments.

Tue, Jan 12, 12:42 AM · Restricted Project
HsiangKai requested review of D94471: [NFC] Use generic name for scalable vector stack ID..
Tue, Jan 12, 12:40 AM · Restricted Project

Mon, Jan 11

HsiangKai updated the summary of D94465: [RISCV] Frame handling for RISC-V V extension. (2nd. version).
Mon, Jan 11, 11:46 PM · Restricted Project
HsiangKai added a reviewer for D94465: [RISCV] Frame handling for RISC-V V extension. (2nd. version): kito-cheng.
Mon, Jan 11, 9:06 PM · Restricted Project
HsiangKai requested review of D94465: [RISCV] Frame handling for RISC-V V extension. (2nd. version).
Mon, Jan 11, 9:05 PM · Restricted Project

Sun, Jan 10

HsiangKai added inline comments to D93804: [RISCV] Spilling for RISC-V V extension..
Sun, Jan 10, 11:34 PM · Restricted Project
HsiangKai committed rG5e476061deb8: [NFC][AsmPrinter] Make comments for spill/reload more precise. (authored by HsiangKai).
[NFC][AsmPrinter] Make comments for spill/reload more precise.
Sun, Jan 10, 11:01 PM
HsiangKai closed D94299: [NFC][AsmPrinter] Make comments for spill/reload more precise..
Sun, Jan 10, 11:01 PM · Restricted Project

Fri, Jan 8

HsiangKai requested review of D94299: [NFC][AsmPrinter] Make comments for spill/reload more precise..
Fri, Jan 8, 5:24 AM · Restricted Project

Thu, Jan 7

HsiangKai abandoned D93812: [RISCV] Handle stack rounding only in RISCVFrameLowering..

D89237 is a better way to go.

Thu, Jan 7, 8:27 AM · Restricted Project
HsiangKai abandoned D94144: [RISCV] Support vscale intrinsic and ISDNode..
Thu, Jan 7, 6:59 AM · Restricted Project
HsiangKai requested review of D94229: [RISCV] Implement vlseg intrinsics..
Thu, Jan 7, 4:48 AM · Restricted Project

Wed, Jan 6

HsiangKai added a comment to D93750: [RISCV] Frame handling for RISC-V V extension..

One thing I don't understand is why RVV incoming/outgoing arguments need their own stack slots. I assume they're just passed indirectly, so why do we need to distinguish between arguments and locals rather than just treat them like anything else that ends up being passed indirectly?

Wed, Jan 6, 6:49 AM · Restricted Project
HsiangKai added inline comments to D93750: [RISCV] Frame handling for RISC-V V extension..
Wed, Jan 6, 4:30 AM · Restricted Project
HsiangKai updated the diff for D93750: [RISCV] Frame handling for RISC-V V extension..

Address @craig.topper and @jrtc27's comments.

Wed, Jan 6, 4:02 AM · Restricted Project

Tue, Jan 5

HsiangKai updated the diff for D94144: [RISCV] Support vscale intrinsic and ISDNode..
Tue, Jan 5, 11:38 PM · Restricted Project
HsiangKai accepted D89237: [RISCV] Do not grow the stack a second time when we need to realign the stack.

LGTM.

Tue, Jan 5, 11:30 PM · Restricted Project
HsiangKai requested review of D94144: [RISCV] Support vscale intrinsic and ISDNode..
Tue, Jan 5, 6:51 PM · Restricted Project
HsiangKai added a comment to D91834: [SelectionDAG] Use TypeSize for the stack offset..

As before I still believe there should be a test to protect this fix as presumably you're doing it for a reason.

Tue, Jan 5, 6:53 AM · Restricted Project

Sun, Jan 3

HsiangKai updated the diff for D91834: [SelectionDAG] Use TypeSize for the stack offset..
Sun, Jan 3, 6:31 PM · Restricted Project
HsiangKai added a comment to D93812: [RISCV] Handle stack rounding only in RISCVFrameLowering..

@lenary, is it reasonable to implement targetHandlesStackFrameRounding() and handle the alignment in RISCVFrameLowering.cpp?

Sun, Jan 3, 5:59 PM · Restricted Project
HsiangKai added a comment to D93364: [RISCV] Load/Store vector mask types..

To consider the frame handling in D93750, is it reasonable to load/store whole vector registers for mask types regardless which kind of mask types?

Sun, Jan 3, 5:57 PM · Restricted Project
HsiangKai added a comment to D93750: [RISCV] Frame handling for RISC-V V extension..

Ping.

Sun, Jan 3, 5:54 PM · Restricted Project
HsiangKai added inline comments to D93804: [RISCV] Spilling for RISC-V V extension..
Sun, Jan 3, 5:53 PM · Restricted Project

Fri, Jan 1

HsiangKai committed rGe4337159e3d1: [NFC][RISCV] Move vmsge{u}.vx processing to RISCVAsmParser. (authored by HsiangKai).
[NFC][RISCV] Move vmsge{u}.vx processing to RISCVAsmParser.
Fri, Jan 1, 5:07 PM
HsiangKai closed D93968: [NFC][RISCV] Move vmsge{u}.vx processing to RISCVAsmParser..
Fri, Jan 1, 5:06 PM · Restricted Project
HsiangKai requested review of D93968: [NFC][RISCV] Move vmsge{u}.vx processing to RISCVAsmParser..
Fri, Jan 1, 9:20 AM · Restricted Project

Mon, Dec 28

HsiangKai accepted D93823: [RISCV] Define vmsbf.m/vmsif.m/vmsof.m/viota.m/vid.v intrinsics..

LGTM.

Mon, Dec 28, 5:14 AM · Restricted Project

Sun, Dec 27

HsiangKai updated the diff for D93612: [RISCV] Update V instructions constraints to conform to v1.0.

Rebase on D93784.

Sun, Dec 27, 8:21 PM · Restricted Project
HsiangKai updated the diff for D93364: [RISCV] Load/Store vector mask types..

Rebase on master.

Sun, Dec 27, 8:07 PM · Restricted Project
HsiangKai added inline comments to D93750: [RISCV] Frame handling for RISC-V V extension..
Sun, Dec 27, 6:58 PM · Restricted Project

Sat, Dec 26

HsiangKai added inline comments to D93823: [RISCV] Define vmsbf.m/vmsif.m/vmsof.m/viota.m/vid.v intrinsics..
Sat, Dec 26, 7:11 PM · Restricted Project
HsiangKai updated the diff for D93750: [RISCV] Frame handling for RISC-V V extension..

Deal with the case when there are realignment objects and RVV objects on the stack at the same time.

Sat, Dec 26, 6:10 PM · Restricted Project
HsiangKai accepted D93784: [RISCV] Improve VMConstraint checking on more unary and nullary instructions..

LGTM

Sat, Dec 26, 4:58 AM · Restricted Project

Fri, Dec 25

HsiangKai updated the diff for D93750: [RISCV] Frame handling for RISC-V V extension..
Fri, Dec 25, 7:19 AM · Restricted Project
HsiangKai updated the diff for D93750: [RISCV] Frame handling for RISC-V V extension..
Fri, Dec 25, 7:15 AM · Restricted Project
HsiangKai requested review of D93812: [RISCV] Handle stack rounding only in RISCVFrameLowering..
Fri, Dec 25, 6:45 AM · Restricted Project
HsiangKai updated the diff for D93612: [RISCV] Update V instructions constraints to conform to v1.0.

Address @craig.topper's comments.

Fri, Dec 25, 5:49 AM · Restricted Project

Thu, Dec 24

HsiangKai updated the diff for D93804: [RISCV] Spilling for RISC-V V extension..
Thu, Dec 24, 6:47 AM · Restricted Project
HsiangKai updated the diff for D93750: [RISCV] Frame handling for RISC-V V extension..
Thu, Dec 24, 6:47 AM · Restricted Project
HsiangKai added inline comments to D93750: [RISCV] Frame handling for RISC-V V extension..
Thu, Dec 24, 6:34 AM · Restricted Project
HsiangKai added inline comments to D93750: [RISCV] Frame handling for RISC-V V extension..
Thu, Dec 24, 6:15 AM · Restricted Project
HsiangKai requested review of D93804: [RISCV] Spilling for RISC-V V extension..
Thu, Dec 24, 5:16 AM · Restricted Project

Wed, Dec 23

HsiangKai added inline comments to D93750: [RISCV] Frame handling for RISC-V V extension..
Wed, Dec 23, 7:54 PM · Restricted Project
HsiangKai added inline comments to D93705: [RISCV] Define vector mask-register logical intrinsics..
Wed, Dec 23, 8:48 AM · Restricted Project
HsiangKai added inline comments to D93745: [RISCV] Define the vfsqrt RVV intrinsics.
Wed, Dec 23, 8:46 AM · Restricted Project
HsiangKai updated the diff for D93750: [RISCV] Frame handling for RISC-V V extension..
Wed, Dec 23, 6:03 AM · Restricted Project
HsiangKai added inline comments to D93705: [RISCV] Define vector mask-register logical intrinsics..
Wed, Dec 23, 4:13 AM · Restricted Project
HsiangKai requested review of D93750: [RISCV] Frame handling for RISC-V V extension..
Wed, Dec 23, 1:46 AM · Restricted Project

Mon, Dec 21

HsiangKai committed rG9a8ef927df38: [RISCV] Define vector compare intrinsics. (authored by HsiangKai).
[RISCV] Define vector compare intrinsics.
Mon, Dec 21, 10:32 PM
HsiangKai closed D93368: [RISCV] Define vector compare intrinsics..
Mon, Dec 21, 10:31 PM · Restricted Project
HsiangKai retitled D93613: [RISCV] Add new V instructions and aliases in v1.0-08a0b46. from [RISCV] Add new V instructions in v1.0-08a0b46. to [RISCV] Add new V instructions and aliases in v1.0-08a0b46..
Mon, Dec 21, 2:12 PM · Restricted Project
HsiangKai updated the diff for D93611: [RISCV] Make LMUL field in VTYPE contiguous..
Mon, Dec 21, 6:07 AM · Restricted Project

Sun, Dec 20

HsiangKai added a reviewer for D93614: [RISCV] New vector load/store in V extension v1.0: khchen.
Sun, Dec 20, 11:32 PM · Restricted Project
HsiangKai updated the summary of D93613: [RISCV] Add new V instructions and aliases in v1.0-08a0b46..
Sun, Dec 20, 11:31 PM · Restricted Project
HsiangKai abandoned D93578: [RISCV] Upgrade RISC-V V extension MC to v1.0-08a0b46..

Split this commit into D93611, D93612, D93613, D93614.

Sun, Dec 20, 11:27 PM · Restricted Project
HsiangKai requested review of D93614: [RISCV] New vector load/store in V extension v1.0.
Sun, Dec 20, 11:26 PM · Restricted Project
HsiangKai requested review of D93613: [RISCV] Add new V instructions and aliases in v1.0-08a0b46..
Sun, Dec 20, 11:23 PM · Restricted Project
HsiangKai requested review of D93612: [RISCV] Update V instructions constraints to conform to v1.0.
Sun, Dec 20, 11:21 PM · Restricted Project