Page MenuHomePhabricator

[shape] Add min and max ops
ClosedPublic

Authored by jpienaar on Apr 6 2021, 12:56 PM.

Details

Summary

These are element-wise operations that operates on shapes with equal ranks.
Also add missing printer/parser for join operator.

Diff Detail

Event Timeline

jpienaar created this revision.Apr 6 2021, 12:56 PM
jpienaar requested review of this revision.Apr 6 2021, 12:56 PM
silvas accepted this revision.Apr 6 2021, 1:02 PM

Not sure if you want to add folders in this patch.

mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
407

document the rank mismatch behavior explicitly (UB or propagated error?).

mlir/test/Dialect/Shape/ops.mlir
294

!shape.size test case?

This revision is now accepted and ready to land.Apr 6 2021, 1:02 PM
This revision was automatically updated to reflect the committed changes.
jpienaar marked an inline comment as done.
frgossen added inline comments.Apr 7 2021, 1:29 AM
mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
407

Also of size type (Shape_ShapeOrSizeType). Either documentation or the type should be updated.

424

minimum