Refactor: Simplify boolean conditional return statements in lib/Transforms/Instrumentation

[LegalizeAdulthood]

Summary

Use clang-tidy to simplify boolean conditional return statements.

[eugenis]

LGTM w/ a comment

lib/Transforms/Instrumentation/ThreadSanitizer.cpp

325 ↗

(On Diff #26460)

Please fold all three simple conditionals into the return statement.

[LegalizeAdulthood]

Update from latest
I do not have commit access.

[samsonov]

r251318

lib/Transforms/Instrumentation/AddressSanitizer.cpp

 static bool isInterestingPointerComparisonOrSubtraction(Instruction *I) {
   if (ICmpInst *Cmp = dyn_cast<ICmpInst>(I)) {
     if (!Cmp->isRelational()) return false;
   } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(I)) {
     if (BO->getOpcode() != Instruction::Sub) return false;
   } else {
     return false;
   }
-  if (!isPointerOperand(I->getOperand(0)) ||
-      !isPointerOperand(I->getOperand(1)))
-    return false;
-  return true;
+  return isPointerOperand(I->getOperand(0)) &&
+         isPointerOperand(I->getOperand(1));
 }
 
 bool AddressSanitizer::GlobalIsLinkerInitialized(GlobalVariable *G) {
   // If a global variable does not have dynamic initialization we don't
   // have to instrument it.  However, if a global does not have initializer
   // at all, we assume it has dynamic initializer (in other TU).
   return G->hasInitializer() && !GlobalsMD.get(G).IsDynInit;
 }