This is an archive of the discontinued LLVM Phabricator instance.

Differential D99922

[MLIR][docs] Fixes to operation syntax in Lang Ref
ClosedPublic

Authored by GMNGeoffrey on Apr 5 2021, 9:32 PM.

Details

Reviewers
rriddle
Commits
rG22411d807238: [MLIR][docs] Fixes to operation syntax in Lang Ref

Diff Detail

Event Timeline

GMNGeoffrey created this revision.Apr 5 2021, 9:32 PM
Herald added subscribers: dcaballe, cota, teijeong and 16 others. · View Herald TranscriptApr 5 2021, 9:32 PM
GMNGeoffrey requested review of this revision.Apr 5 2021, 9:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2021, 9:32 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
GMNGeoffrey added a reviewer: rriddle.Apr 5 2021, 9:33 PM
rriddle accepted this revision.Apr 5 2021, 10:09 PM
This revision is now accepted and ready to land.Apr 5 2021, 10:09 PM
Harbormaster completed remote builds in B97226: Diff 335395.Apr 5 2021, 10:29 PM
Closed by commit rG22411d807238: [MLIR][docs] Fixes to operation syntax in Lang Ref (authored by GMNGeoffrey). · Explain WhyApr 5 2021, 10:29 PM
This revision was automatically updated to reflect the committed changes.
GMNGeoffrey added a commit: rG22411d807238: [MLIR][docs] Fixes to operation syntax in Lang Ref.
bondhugula added a subscriber: bondhugula.Apr 6 2021, 2:55 AM

Nice catch! I think I caught another redundancy right below.

mlir/docs/LangRef.md
293

Unrelated but the question mark at the end here isn't needed.

Revision Contents

PathSize
mlir/
docs/
23 lines

Diff 335402

mlir/docs/LangRef.md

Show First 20 Lines • Show All 273 Lines • ▼ Show 20 Lines
These operations only work when targeting LLVM as a backend (e.g. for CPUs and These operations only work when targeting LLVM as a backend (e.g. for CPUs and
GPUs), and are required to align with the LLVM definition of these intrinsics. GPUs), and are required to align with the LLVM definition of these intrinsics.
## Operations ## Operations
Syntax: Syntax:
``` ```
operation ::= op-result-list? (generic-operation | custom-operation) operation ::= op-result-list? (generic-operation | custom-operation)
trailing-location? trailing-location?
generic-operation ::= string-literal `(` value-use-list? `)` successor-list? generic-operation ::= string-literal `(` value-use-list? `)` successor-list?
(`(` region-list `)`)? dictionary-attribute? `:` function-type region-list? dictionary-attribute? `:` function-type
custom-operation ::= bare-id custom-operation-format custom-operation ::= bare-id custom-operation-format
op-result-list ::= op-result (`,` op-result)* `=` op-result-list ::= op-result (`,` op-result)* `=`
op-result ::= value-id (`:` integer-literal) op-result ::= value-id (`:` integer-literal)
successor-list ::= successor (`,` successor)* successor-list ::= `[` successor (`,` successor)* `]`
successor ::= caret-id (`:` bb-arg-list)? successor ::= caret-id (`:` bb-arg-list)?
region-list ::= region (`,` region)* region-list ::= `(` region (`,` region)* `)`
dictionary-attribute ::= `{` (attribute-entry (`,` attribute-entry)*)? `}`
trailing-location ::= (`loc` `(` location `)`)? trailing-location ::= (`loc` `(` location `)`)?
bondhugulaUnsubmitted
Not Done
ReplyInline Actions

Unrelated but the question mark at the end here isn't needed.

bondhugula: Unrelated but the question mark at the end here isn't needed.
``` ```
MLIR introduces a uniform concept called _operations_ to enable describing MLIR introduces a uniform concept called _operations_ to enable describing
many different levels of abstractions and computations. Operations in MLIR are many different levels of abstractions and computations. Operations in MLIR are
fully extensible (there is no fixed list of operations) and have fully extensible (there is no fixed list of operations) and have
application-specific semantics. For example, MLIR supports [target-independent application-specific semantics. For example, MLIR supports [target-independent
operations](Dialects/Standard.md#memory-operations), [affine operations](Dialects/Standard.md#memory-operations), [affine
operations](Dialects/Affine.md), and [target-specific machine operations](Dialects/Affine.md), and [target-specific machine
▲ Show 20 Lines • Show All 540 Lines • Show Last 20 Lines