This is an archive of the discontinued LLVM Phabricator instance.

Refactor: Simplify boolean conditional return statements in lib/Target/XCore
AbandonedPublic

Authored by LegalizeAdulthood on May 25 2015, 1:49 AM.

Reviewers

Summary

Use clang-tidy to simplify boolean conditional return statements

LegalizeAdulthood retitled this revision from to Refactor: Simplify boolean conditional return statements in lib/Target/XCore.

LegalizeAdulthood updated this object.

LegalizeAdulthood edited the test plan for this revision. (Show Details)

LegalizeAdulthood added a subscriber: Unknown Object (MLST).

craig.topper added inline comments.

lib/Target/XCore/XCoreISelLowering.cpp
1464	Push negate through

lib/Target/XCore/XCoreISelLowering.cpp
1464	Fixed.

Update from comments

Path

Size

lib/

Target/

XCore/

4 lines

	Show First 20 Lines • Show All 1,455 Lines • ▼ Show 20 Lines
	CanLowerReturn(CallingConv::ID CallConv, MachineFunction &MF,			CanLowerReturn(CallingConv::ID CallConv, MachineFunction &MF,
	bool isVarArg,			bool isVarArg,
	const SmallVectorImpl<ISD::OutputArg> &Outs,			const SmallVectorImpl<ISD::OutputArg> &Outs,
	LLVMContext &Context) const {			LLVMContext &Context) const {
	SmallVector<CCValAssign, 16> RVLocs;			SmallVector<CCValAssign, 16> RVLocs;
	CCState CCInfo(CallConv, isVarArg, MF, RVLocs, Context);			CCState CCInfo(CallConv, isVarArg, MF, RVLocs, Context);
	if (!CCInfo.CheckReturn(Outs, RetCC_XCore))			if (!CCInfo.CheckReturn(Outs, RetCC_XCore))
	return false;			return false;
	if (CCInfo.getNextStackOffset() != 0 && isVarArg)			return CCInfo.getNextStackOffset() == 0 \|\| !isVarArg;
				craig.topperUnsubmitted Not Done Reply Inline Actions Push negate through craig.topper: Push negate through
				LegalizeAdulthoodAuthorUnsubmitted Not Done Reply Inline Actions Fixed. LegalizeAdulthood: Fixed.
	return false;
	return true;
	}			}

	SDValue			SDValue
	XCoreTargetLowering::LowerReturn(SDValue Chain,			XCoreTargetLowering::LowerReturn(SDValue Chain,
	CallingConv::ID CallConv, bool isVarArg,			CallingConv::ID CallConv, bool isVarArg,
	const SmallVectorImpl<ISD::OutputArg> &Outs,			const SmallVectorImpl<ISD::OutputArg> &Outs,
	const SmallVectorImpl<SDValue> &OutVals,			const SmallVectorImpl<SDValue> &OutVals,
	SDLoc dl, SelectionDAG &DAG) const {			SDLoc dl, SelectionDAG &DAG) const {
	▲ Show 20 Lines • Show All 510 Lines • Show Last 20 Lines