This is an archive of the discontinued LLVM Phabricator instance.

[HIP-Clang, test] Fix use of undef FileCheck var
ClosedPublic

Authored by thopre on Apr 3 2021, 1:20 AM.

Details

Summary

Commit 8129521318accc44c2a009647572f6ebd3fc56dd changed a line defining
PREFIX in clang test CodeGenCUDA/device-stub.cu into a CHECK-NOT
directive. All following lines using PREFIX are therefore using an
undefined variable since the pattern defining PREFIX is not supposed to
occur and CHECK-NOT are checked independently.

This commit replaces all uses of PREFIX by the regex used to define it,
thereby avoiding the problem.

Diff Detail

Event Timeline

thopre requested review of this revision.Apr 3 2021, 1:20 AM
thopre created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2021, 1:20 AM
yaxunl accepted this revision.Apr 4 2021, 6:14 AM

LGTM. Thanks.

This revision is now accepted and ready to land.Apr 4 2021, 6:14 AM
This revision was automatically updated to reflect the committed changes.