Page MenuHomePhabricator

ashi1 (Aaron Enye Shi)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 24 2016, 11:36 AM (268 w, 2 d)

Recent Activity

Yesterday

ashi1 added a comment to D99894: [zorg] Add buildbot for HIP.

No. Cuda builders got that in the code base as a temporary solution while they are working on their annotated script. Exactly the same arguments as yours. And I see that being confusing, and don't think it worth it after all.

To get it working in the production you need to add the support for shell scripts anyway. With that in place you could put your script in the right place and keep working on that while your builder is staged. It seems the right thing to do.

Please feel free to ask if you have questions or will need help with adding the shell script support.

Fri, Apr 16, 11:17 AM
ashi1 requested review of D100666: [zorg] Support relative non .py scripts in AnnotatedBuilder.
Fri, Apr 16, 11:16 AM

Thu, Apr 15

ashi1 updated subscribers of D100404: Add no_pop variant to pragma attributes.

Ping arphaman and aaron.ballman. Also adding @erik.pilkington, who introduced namespaces to clang attribute, for opinions.

Thu, Apr 15, 2:05 PM

Wed, Apr 14

ashi1 added a comment to D99894: [zorg] Add buildbot for HIP.

@gkistanova , is it okay to submit this with a full system path temporarily? /buildbot/hip-build.sh? Or do we have to switch to a python script?

Wed, Apr 14, 11:14 AM

Tue, Apr 13

ashi1 committed rTd590d0b156e4: Reapply [test-suite] Add HIP Tests to External (authored by ashi1).
Reapply [test-suite] Add HIP Tests to External
Tue, Apr 13, 2:38 PM
ashi1 committed rT116d17093f74: [test-suite] Add HIP Tests to External (authored by ashi1).
[test-suite] Add HIP Tests to External
Tue, Apr 13, 2:38 PM
ashi1 added a reverting change for D99997: [test-suite] Add HIP Tests to External: rT42674b53b826: Revert "[test-suite] Add HIP Tests to External".
Tue, Apr 13, 2:38 PM
ashi1 committed rT42674b53b826: Revert "[test-suite] Add HIP Tests to External" (authored by ashi1).
Revert "[test-suite] Add HIP Tests to External"
Tue, Apr 13, 2:38 PM
ashi1 closed D99997: [test-suite] Add HIP Tests to External.
Tue, Apr 13, 2:38 PM
ashi1 updated the diff for D99997: [test-suite] Add HIP Tests to External.

Address Artem's comments.

Tue, Apr 13, 2:01 PM
ashi1 added inline comments to D99997: [test-suite] Add HIP Tests to External.
Tue, Apr 13, 1:49 PM
ashi1 abandoned D98201: [CUDA][HIP] Add #pragma clang force_cuda_device_globals {begin,end}.

Closing this revision, I have a patch to add no_pop variant of #pragma clang attribute push.
https://reviews.llvm.org/D100404
Alternatively, we could look into making no pop the default.

Tue, Apr 13, 11:54 AM
ashi1 requested review of D100404: Add no_pop variant to pragma attributes.
Tue, Apr 13, 11:53 AM

Mon, Apr 12

ashi1 added a comment to D98201: [CUDA][HIP] Add #pragma clang force_cuda_device_globals {begin,end}.

Allowing pragma push to be unmatched, maybe with an explicit option to enable it, would probably be less controversial than adding a new pragma that duplicates existing functionality.

To be clear, the pragma that I mentioned allows unmatching -- #pragma clang force_cuda_host_device begin -- is a preexisting Clang pragma, not the one proposed by this review. It's highly inconsistent for one pragma to error out when unmatched, while the other doesn't. Would you suggest that the pre-existing #pragma clang force_cuda_host_device begin should error out when unmatched?

No, what I'm saying is that we can allow #pragma clang attribute push to be unbalanced if the user requests it. Injecting it with -include is a reasonable use case, IMO and you've correctly pointed out that there's no easy way to add a matching pop.

#pragma clang attribute appears to be a better and more generic mechanism for tinkering with attributes and I would prefer to use it instead of adding more pragmas that do about the same thing.

Mon, Apr 12, 7:42 AM

Fri, Apr 9

ashi1 added a comment to D100060: [zorg] Add HIP builder script.

Looks reasonable overall.

Few drive-by comments below for the pitfalls you may eventually run into later.

Fri, Apr 9, 11:36 AM
ashi1 added inline comments to D99894: [zorg] Add buildbot for HIP.
Fri, Apr 9, 11:25 AM
ashi1 added a reviewer for D99894: [zorg] Add buildbot for HIP: tra.
Fri, Apr 9, 11:22 AM
ashi1 updated the diff for D99997: [test-suite] Add HIP Tests to External.

Revised to Artem's comments, and added empty.hip.

Fri, Apr 9, 9:12 AM
ashi1 added a comment to D99997: [test-suite] Add HIP Tests to External.
In D99997#2672735, @tra wrote:

I've added @beanz as the reviewer who has more cmake know-how.

I'm glad to see HIP support being added to the testsuite. I don't know what your plans are for bringing up an LLVM build/test bot for HIP. If you want, I could probably run a compile-only HIP bot on one of the VMs that run CUDA bots.

Fri, Apr 9, 9:11 AM

Wed, Apr 7

ashi1 added a comment to D99894: [zorg] Add buildbot for HIP.

This HIP builder is dependent on two other patches:

Wed, Apr 7, 11:58 AM
ashi1 planned changes to D100060: [zorg] Add HIP builder script.

Please note, this patch is under-development, and I've added it here, as open uncommitted review to allow HIP builder to use external script.
https://reviews.llvm.org/D99894

Wed, Apr 7, 11:54 AM
ashi1 requested review of D100060: [zorg] Add HIP builder script.
Wed, Apr 7, 11:53 AM
ashi1 committed rGdf59850038d8: [HIP] Fix rocm-detect.hip test path (authored by ashi1).
[HIP] Fix rocm-detect.hip test path
Wed, Apr 7, 10:22 AM
ashi1 closed D100045: [HIP] Fix rocm-detect.hip test path.
Wed, Apr 7, 10:21 AM · Restricted Project
ashi1 requested review of D100045: [HIP] Fix rocm-detect.hip test path.
Wed, Apr 7, 9:19 AM · Restricted Project

Tue, Apr 6

ashi1 requested review of D99997: [test-suite] Add HIP Tests to External.
Tue, Apr 6, 3:36 PM

Mon, Apr 5

ashi1 added inline comments to D99894: [zorg] Add buildbot for HIP.
Mon, Apr 5, 11:44 AM
ashi1 requested review of D99894: [zorg] Add buildbot for HIP.
Mon, Apr 5, 11:42 AM

Thu, Apr 1

ashi1 accepted D99738: [HIP] remove overloaded abs in header.

LGTM, thank you.

Thu, Apr 1, 9:00 AM · Restricted Project

Wed, Mar 31

ashi1 updated the diff for D98201: [CUDA][HIP] Add #pragma clang force_cuda_device_globals {begin,end}.

Merged DiagnosticParseKinds as requested.

Wed, Mar 31, 2:14 PM

Thu, Mar 18

ashi1 added a comment to D98278: [test] Add ability to get error messages from CMake for errc substitution.

Add GetErrcMessages.cmake, which contains a cmake function to automatically get the error messages of various posix error codes needed by lit by running a small C++ program.
Currently ENOENT, EISDIR, EINVAL and EACCES are supplied.
These error messages are then currently supplied to clang, llvm and lld as the errc_messages config parameter.

Regarding Cross compiling: the function uses try_run which when cross compiling may use the CMAKE_CROSSCOMPILING_EMULATOR to run the code.

How does it behave if such a thing isn't hooked up? Ideally it'd fall back silently and these parts of tests would just fail, but not block things overall.

It will fall back to using Python's strerror, potentially failing if pythons strerror would not return the same strings (only the case for MSVC I believe).

Thu, Mar 18, 10:52 AM · Restricted Project, Restricted Project

Mar 16 2021

ashi1 added a comment to D98201: [CUDA][HIP] Add #pragma clang force_cuda_device_globals {begin,end}.

Thank you for the review, please see latest test updates adding tests for static/constexpr local var combinations.

Mar 16 2021, 2:44 PM
ashi1 updated the diff for D98201: [CUDA][HIP] Add #pragma clang force_cuda_device_globals {begin,end}.
Mar 16 2021, 2:41 PM
ashi1 updated the diff for D98201: [CUDA][HIP] Add #pragma clang force_cuda_device_globals {begin,end}.
Mar 16 2021, 2:34 PM
ashi1 added a comment to D98201: [CUDA][HIP] Add #pragma clang force_cuda_device_globals {begin,end}.
In D98201#2617905, @tra wrote:

Interesting. Once the globals are forced to be __device__, what ends up using them? Is that just for the GDB itself to access them? Or are they used by some code? If so, how is the code forced into being __global__/__device__ functions?

I can see this patch being useful for the former case.

Mar 16 2021, 10:59 AM

Mar 8 2021

ashi1 updated subscribers of D98201: [CUDA][HIP] Add #pragma clang force_cuda_device_globals {begin,end}.
Mar 8 2021, 11:04 AM
ashi1 requested review of D98201: [CUDA][HIP] Add #pragma clang force_cuda_device_globals {begin,end}.
Mar 8 2021, 10:58 AM

Jan 14 2021

ashi1 committed rGbe40c12040a0: [HIP] Add signbit(long double) decl (authored by ashi1).
[HIP] Add signbit(long double) decl
Jan 14 2021, 10:29 AM
ashi1 closed D93062: [HIP] Add signbit(long double) decl.
Jan 14 2021, 10:29 AM · Restricted Project
ashi1 added a comment to D93062: [HIP] Add signbit(long double) decl.
In D93062#2496542, @tra wrote:

For CUDA we have tests in the test-suite (https://github.com/llvm/llvm-test-suite/tree/main/External/CUDA) and a handful of buildbots running them (e.g. http://lab.llvm.org:8011/#/builders/55).
AMD should probably set up some public build/test bots for HIP, too.
In this case, manual testing and rollback if something breaks is about all we can do.

Jan 14 2021, 8:43 AM · Restricted Project

Jan 13 2021

ashi1 added a comment to D93062: [HIP] Add signbit(long double) decl.

I was able to shrink down the testcase, but it still requires 2019 MSVC to be installed and Windows Kits 10 at a minimum.

Jan 13 2021, 12:35 PM · Restricted Project
ashi1 added a comment to D93062: [HIP] Add signbit(long double) decl.

Testcase?

Jan 13 2021, 11:55 AM · Restricted Project

Dec 10 2020

ashi1 requested review of D93062: [HIP] Add signbit(long double) decl.
Dec 10 2020, 12:54 PM · Restricted Project

Dec 3 2020

ashi1 retitled D92130: [HIP] cmath demote long double args to double from [HIP] cmath promote long double args to double to [HIP] cmath demote long double args to double.
Dec 3 2020, 3:01 PM · Restricted Project
ashi1 added a comment to D92130: [HIP] cmath demote long double args to double.
In D92130#2423801, @tra wrote:

LGTM in general. Will defer to Sam as it's HIP.

Nit:

long double, promote them to double, and use the fp64

I'd say long double -> double qualifies as a demotion.

Dec 3 2020, 3:01 PM · Restricted Project
ashi1 committed rGba2612ce01ea: [HIP] cmath demote long double args to double (authored by ashi1).
[HIP] cmath demote long double args to double
Dec 3 2020, 3:01 PM
ashi1 closed D92130: [HIP] cmath demote long double args to double.
Dec 3 2020, 3:01 PM · Restricted Project

Dec 2 2020

ashi1 accepted D92418: [hip] Fix host object creation from fatbin.
Dec 2 2020, 7:17 AM · Restricted Project

Dec 1 2020

ashi1 added a comment to D92418: [hip] Fix host object creation from fatbin.

Looks good to me.

Dec 1 2020, 12:33 PM · Restricted Project
ashi1 committed rGcd5897d55908: [HIP] Fix static-lib test CHECK bug (authored by ashi1).
[HIP] Fix static-lib test CHECK bug
Dec 1 2020, 7:50 AM
ashi1 added a comment to D92342: [HIP] Fix HIP test on windows due to lld suffix.

@ashi1 This is causing build failures - please can you take a look ? http://lab.llvm.org:8011/#/builders/14/builds/2514

<stdin>:17:66: note: possible intended match here
 "/b/1/clang-x86_64-debian-new-pass-manager-fast/llvm.obj/bin/llvm-ar" "rcsD" "a.out" "/tmp/a-88f827.o" "/tmp/b-11b5fe.o" "/tmp/a-72b91c.o"
Dec 1 2020, 7:36 AM · Restricted Project

Nov 30 2020

ashi1 committed rGf89e9c8201ea: [HIP] Fix HIP test on windows due to lld suffix (authored by ashi1).
[HIP] Fix HIP test on windows due to lld suffix
Nov 30 2020, 1:06 PM
ashi1 closed D92342: [HIP] Fix HIP test on windows due to lld suffix.
Nov 30 2020, 1:06 PM · Restricted Project
ashi1 added a comment to D92342: [HIP] Fix HIP test on windows due to lld suffix.

Aaron, Could you please update the bugzilla after the fix is landed? Thanks.

Nov 30 2020, 1:05 PM · Restricted Project
ashi1 added a comment to D92342: [HIP] Fix HIP test on windows due to lld suffix.

Although there were no issues with .*llvm-mc, as a precaution, I changed it to .*llvm-mc.* too. In case any systems use llvm-mc.exe instead.

Nov 30 2020, 12:51 PM · Restricted Project
ashi1 requested review of D92342: [HIP] Fix HIP test on windows due to lld suffix.
Nov 30 2020, 12:49 PM · Restricted Project

Nov 25 2020

ashi1 added a comment to D92130: [HIP] cmath demote long double args to double.

There are applications calling functions such as fmod(long double x, long double y), but this produces a "call is ambiguous" error.

Nov 25 2020, 1:14 PM · Restricted Project
ashi1 requested review of D92130: [HIP] cmath demote long double args to double.
Nov 25 2020, 1:12 PM · Restricted Project

Nov 3 2020

ashi1 committed rGca5b31502c82: [HIP] Math Headers to use type promotion (authored by ashi1).
[HIP] Math Headers to use type promotion
Nov 3 2020, 10:41 AM
ashi1 closed D90409: [HIP] Math Headers to use type promotion.
Nov 3 2020, 10:41 AM · Restricted Project, Restricted Project
ashi1 updated the diff for D90409: [HIP] Math Headers to use type promotion.

Revised the patch to match libcxx, fixed a bug in return type resolution, and ran clang-format on this patch.

Nov 3 2020, 8:55 AM · Restricted Project, Restricted Project
ashi1 added a comment to D90409: [HIP] Math Headers to use type promotion.

I tried the previous HIP FMA test, and it looks like libcxx's cmath is expecting fma(float, float, char) to be promoted to (double, double, double) and return type double:
https://cppinsights.io/s/ee45a5ca

Nov 3 2020, 8:47 AM · Restricted Project, Restricted Project
ashi1 added a comment to D90409: [HIP] Math Headers to use type promotion.
In D90409#2363044, @tra wrote:
In D90409#2362554, @tra wrote:

I'm not quite sure what is the problem this patch is intended to solve. Could you give me more details?

@tra, a problem arose with the fma function. When given fma(float, float, char), it was returning a double type. Instead, we want to be more similar to C++ and return the promoted type which is float in this case.
This patch tries to fix a few failures I introduced with my recent HIP header refactoring patch.

That is odd. char should've been promoted to float and fma(flot, float, float) should've been called and this patch should not have been necessary. https://cppinsights.io/s/7cdd71b7
If that's the case, then this patch may not do the right thing either -- it would force the arguments to the derived result type, but if fma(double) is the only choice, the arguments will be implicitly converted to double and back which is probably not what you want.

Perhaps the problem is that fma(flot, float, float) is not visible at the point where the overload resolution happens.

Nov 3 2020, 8:39 AM · Restricted Project, Restricted Project

Oct 29 2020

ashi1 added a comment to D90409: [HIP] Math Headers to use type promotion.
In D90409#2362554, @tra wrote:

I'm not quite sure what is the problem this patch is intended to solve. Could you give me more details?

Oct 29 2020, 1:15 PM · Restricted Project, Restricted Project
ashi1 requested review of D90409: [HIP] Math Headers to use type promotion.
Oct 29 2020, 10:23 AM · Restricted Project, Restricted Project

Oct 27 2020

ashi1 committed rG3700556ecb06: [HIP][NFC] Use correct max in cuda_complex_builtins (authored by ashi1).
[HIP][NFC] Use correct max in cuda_complex_builtins
Oct 27 2020, 12:36 PM

Oct 26 2020

ashi1 abandoned D89584: [AMDGPU][OPENMP] OpenMP AMDGCN Header Support.

Dropping this patch in favour of smaller patches.

Oct 26 2020, 1:23 PM
ashi1 added a comment to D89584: [AMDGPU][OPENMP] OpenMP AMDGCN Header Support.

First off, this is the right direction, thanks for working on this!

Then, we need to split this. There are various things happening here and we can easily do them one by one.
Please reach out if you don't know where to split but basically try to make the patches "as small as possible" such that you write a test against them.
So for example, math and complex stuff are separate. New functions are separate, changing the attributes is separate, ...

I added a bunch of comments and tried to be exhaustive, though once we split it in the separate components I will do another review.

Finally, where are the tests? You only added the test/Inputs stuff.

Oct 26 2020, 1:15 PM

Oct 22 2020

ashi1 closed D89966: [HIP] Fix HIP rounding math intrinsics.

Committed: b2524eb9445a4487115c8f94fd946d2c4c95f652

Oct 22 2020, 2:37 PM
ashi1 updated the diff for D89966: [HIP] Fix HIP rounding math intrinsics.
Oct 22 2020, 8:42 AM
ashi1 updated the diff for D89966: [HIP] Fix HIP rounding math intrinsics.

Updated the rcp rounded functions to use div and default to use 1.0 / __x.

Oct 22 2020, 8:38 AM
ashi1 requested review of D89966: [HIP] Fix HIP rounding math intrinsics.
Oct 22 2020, 8:11 AM

Oct 21 2020

ashi1 updated the diff for D89584: [AMDGPU][OPENMP] OpenMP AMDGCN Header Support.

Added back the #ifdef for few functions that need static with private for OpenMP.

Oct 21 2020, 7:44 AM

Oct 20 2020

ashi1 added inline comments to D89584: [AMDGPU][OPENMP] OpenMP AMDGCN Header Support.
Oct 20 2020, 2:04 PM

Oct 19 2020

ashi1 added inline comments to D89584: [AMDGPU][OPENMP] OpenMP AMDGCN Header Support.
Oct 19 2020, 3:17 PM
ashi1 updated the diff for D89584: [AMDGPU][OPENMP] OpenMP AMDGCN Header Support.

Updated based on review comments.

Oct 19 2020, 3:17 PM

Oct 16 2020

ashi1 requested review of D89584: [AMDGPU][OPENMP] OpenMP AMDGCN Header Support.
Oct 16 2020, 12:16 PM

Oct 15 2020

ashi1 added a comment to D87325: [HIP] Add -emit-pch option to clang driver.

ping @rsmith

Oct 15 2020, 8:00 AM

Oct 6 2020

ashi1 committed rG8d2a0c115e24: [HIP] NFC Add comments to cmath functions (authored by ashi1).
[HIP] NFC Add comments to cmath functions
Oct 6 2020, 8:28 AM
ashi1 committed rG42093562a711: [HIP] NFC properly reference Differential Revision (authored by ashi1).
[HIP] NFC properly reference Differential Revision
Oct 6 2020, 8:21 AM
ashi1 closed D88837: [HIP] Restructure hip headers to add cmath.
Oct 6 2020, 8:21 AM · Restricted Project
ashi1 committed rGaa2b593f1495: [HIP] Restructure hip headers to add cmath (authored by ashi1).
[HIP] Restructure hip headers to add cmath
Oct 6 2020, 7:49 AM

Oct 5 2020

ashi1 updated the diff for D88837: [HIP] Restructure hip headers to add cmath.

Missed one __r for normf.

Oct 5 2020, 1:54 PM · Restricted Project
ashi1 updated the diff for D88837: [HIP] Restructure hip headers to add cmath.

Add missing __ prefix inside of function variables. Fix C++ and C-only macros, so that we don't use bool or the same function names in C-only. Also, use macros to define isfinite, isinf, isnan, and signbit to align with cmath !__cplusplus.

Oct 5 2020, 1:37 PM · Restricted Project
ashi1 added a reviewer for D88837: [HIP] Restructure hip headers to add cmath: b-sumner.

This is a pre-requisite for the next patch to add OpenMP w/ AMDGCN support.

Oct 5 2020, 9:33 AM · Restricted Project
ashi1 added a comment to D88837: [HIP] Restructure hip headers to add cmath.

Ran clang-format on this patch, and also verified on full stack (ROCm, Libraries).

Oct 5 2020, 9:27 AM · Restricted Project
ashi1 retitled D88837: [HIP] Restructure hip headers to add cmath from Update hip headers to add cmath to [HIP] Restructure hip headers to add cmath.
Oct 5 2020, 9:26 AM · Restricted Project
ashi1 requested review of D88837: [HIP] Restructure hip headers to add cmath.
Oct 5 2020, 9:24 AM · Restricted Project

Oct 2 2020

ashi1 accepted D88377: Diagnose invalid target ID for AMDGPU toolchain for assembler.

LGTM

Oct 2 2020, 9:20 AM · Restricted Project

Sep 28 2020

ashi1 added a comment to D88377: Diagnose invalid target ID for AMDGPU toolchain for assembler.

Could you please add full context? Mostly looks good to me.

Sep 28 2020, 8:34 AM · Restricted Project

Sep 22 2020

ashi1 added a comment to D87325: [HIP] Add -emit-pch option to clang driver.
In D87325#2280370, @tra wrote:

If you dd -S and remove -ccc-print-bindingsthis command does produce a PCH.

-Xclang -emit-pch does not change what the top-level driver does. You do need to tell it not to do too much. -S prevents additional bundling/linking steps. For regular C++ compilation -c would work, too.

Caveat -- while the command does produce the PCH, I have no idea whether that's the correct way to do it.

Sep 22 2020, 10:48 AM

Sep 17 2020

ashi1 added a comment to D87325: [HIP] Add -emit-pch option to clang driver.
In D87325#2277854, @tra wrote:

Having -emit-pch in the clang driver is useful because it doesn't require users to specify standard C++ include paths, clang include paths, and CUDA/HIP wrapper headers needed by CC1. That is error prone for the user.

I didn't meant o invoke -cc1 directly, but rather to pass -emit-pch via -Xclang -emit-pch. No need to provide *all* CC1 options manually.

Sep 17 2020, 2:13 PM
ashi1 updated the diff for D87325: [HIP] Add -emit-pch option to clang driver.

Adding Diag when mixing device and host paths with -emit-pch. Currently, we don't support this path, since the generated pch will be a clang_offload_bundle (supporting that will require that the ASTReader understand clang offload bundles and that is outside the scope of this patch). Added tests to check error Diag is reported when running both paths with -emit-pch.

Sep 17 2020, 11:43 AM
ashi1 updated the diff for D87325: [HIP] Add -emit-pch option to clang driver.

Added a C++ header to .pch file test.

Sep 17 2020, 11:21 AM

Sep 16 2020

ashi1 updated the diff for D87325: [HIP] Add -emit-pch option to clang driver.

Added a test checking for error when -o option is used for multi-device -emit-pch run.

Sep 16 2020, 2:24 PM
ashi1 added a comment to D87325: [HIP] Add -emit-pch option to clang driver.
In D87325#2277467, @tra wrote:
In D87325#2271676, @tra wrote:

Can you elaborate on the use case of PCH files for CUDA/HIP?

I believe one use-case for PCH is for common include headers such as hip_runtime.h which is being re-used in many application source files. To improve the performance, we can pre-compile the header and re-use it during online compilation.

That would be potentially useful if it could be used from a normal compilation, but it's not. Single-sub-compilarion is a very very small niche.

I'm OK with making -emit-pch work for GPUs, but considering very limited use case and the fact that the generated PCH will be wrong more often than not (I.e. it will be usable for only 1 out of N subcompilations for particular TU), I would rather keep the -emit-pch a CC1 only option. Those who need it should be able to use it via -Xclang -emit-pch and for most of the regular users it does not matter.

Having -emit-pch in the clang driver is useful because it doesn't require users to specify standard C++ include paths, clang include paths, and CUDA/HIP wrapper headers needed by CC1. That is error prone for the user.
Also, this device compilation is not niche, it is needed for nvrtc/hiprtc and hip applications can perform device-only compilations at either compile-time or run-time.

Sep 16 2020, 1:45 PM
ashi1 updated the diff for D87325: [HIP] Add -emit-pch option to clang driver.

Updated the tests to use --cuda-host-only or --cuda-device-only options when using -emit-pch. Added more tests for compilation when using -include-pch. Also, added a negative test when using different GPU variant PCH during compilation.

Sep 16 2020, 12:48 PM
ashi1 added a comment to D87325: [HIP] Add -emit-pch option to clang driver.
In D87325#2271676, @tra wrote:

Can you elaborate on the use case of PCH files for CUDA/HIP?

I believe one use-case for PCH is for common include headers such as hip_runtime.h which is being re-used in many application source files. To improve the performance, we can pre-compile the header and re-use it during online compilation.

Sep 16 2020, 11:09 AM

Sep 10 2020

ashi1 updated the diff for D87325: [HIP] Add -emit-pch option to clang driver.

Fixed to use TY_HIPHeader instead of changing the phases in TY_HIP.

Sep 10 2020, 2:23 PM
ashi1 added a comment to D87325: [HIP] Add -emit-pch option to clang driver.

Looking into the C/C++ tests.

Sep 10 2020, 2:20 PM