- User Since
- Feb 24 2016, 11:36 AM (203 w, 4 d)
Dec 3 2019
Oct 9 2019
Oct 3 2019
LGTM - Thanks for generalizing
Oct 2 2019
LGTM thank you
Oct 1 2019
Jul 10 2019
Apr 10 2019
Apr 3 2019
Thank you, I submitted a clang-formatted fix for the if statement.
Apr 2 2019
Hi Artem, I had just committed the change. IS this change OK or should I revert it?
Mar 15 2019
Mar 13 2019
Hi Matt, that solution will need refactoring and testing. Currently, HIP-Clang is following the same link flow as HCC
Feb 19 2019
This was submitted again with the fix. Thanks!
Feb 13 2019
Feb 12 2019
Yes, but it will need this PR: https://github.com/ROCm-Developer-Tools/HIP/pull/910
So that the default is set.
I've added a lit test to check for options such as -mxnack/-mno-xnack, -msram-ecc/-mno-sram-ecc, -mcode-object-v3/-mno-code-object-v3
Changed patch to us handleTargetFeatures, to consume all -m options passed into clang.
Feb 8 2019
Jan 4 2019
I've commit the changes, but forgot to tag the proper Diff link in the commit message. I just updated it.
Oct 9 2018
I've moved the hip.amdgcn.bc to the top of the libs. Updated test as well.
The device libraries has been updated, and the hip.amdgcn.bc library is now available there.
Oct 4 2018
I've added a hip.amdgcn.bc library for the fence functions that were originally in irif library.
Oct 1 2018
Added diff with full context. Also, I need to find replacements for few functions in HIP github before this can be submitted.
Sep 28 2018
Jun 27 2018
Updated diff with a lit test.
Merged checks for flush denorm on and off into single test hip-device-libs.hip
I've updated. Moved the bitcode files into hip_dev_lib and added test for both on and off flush denorms to zero option.
Fix diff file
I've changed the string to a more meaningful name, and also added a lit test to check that oclc_daz_opt_on.amdgcn.bc is used.
Jun 22 2018
Jun 21 2018
Mar 22 2018
Is first one encountered a poor design?
Nov 9 2017
I've added the lit tests for this change, and also showing full context.
Nov 7 2017
Aug 16 2016
Aug 2 2016
Jul 29 2016
Jul 27 2016
Removed indentation as per Anastasia's comments.
Jul 26 2016
Revised based on Anastasia's comments. Restructured the if statements in test cases.
Jul 25 2016
Jul 22 2016
Revised based on Sam's comments.
Revised based on Sam's comments. Added to tests Misc\amdgcn.languageOptsOpenCL.cl and SemaOpenCL\extension-version.cl
Jul 21 2016
Jul 20 2016
Removed excess semicolon by Anastasia's comments
Jul 19 2016
Revised based on Sam's comments. Also updated test file to changes with using triple spir-unknown-unknown.
Revised based on Anastasia's comments. Now using new function name appendOpenCLVersionMD(
Jul 15 2016
Jul 12 2016
Revised to Anastasia's comments. Removed opencl-blocks.cl, and created a generic opencl.cl inside test/Frontend folder.
Jul 11 2016
Moved cl-strict-aliasing testing to a new file cl-strict-aliasing.cl
Jul 8 2016
Jul 7 2016
Revised base on Sam's comments.
Jul 6 2016
Jun 22 2016
Revised to Anastasia's comments.
Jun 21 2016
Revised based on Anastasia's comments. Also clang-test run passes, the testcases should be working correctly.
Jun 20 2016
Revised with Anastasia's comments. Please take a look at the diagnostic to see if it is what we want.
Jun 6 2016
May 17 2016
Xiuli, are you OK with this patch?
May 9 2016
Modified the testcase. Tested this diff on clang-test and it passes.
Added changes for comments from majnemer.
Feb 26 2016
Revised with Xiuli Pan's comments.
Joey Gouly or Joey Korkames?