- User Since
- Feb 24 2016, 11:36 AM (326 w, 2 d)
Aug 10 2021
Jul 28 2021
Same question as @jdoerfert , and are we passing SOLVVEVV inside llvm-testsuite?
Jul 22 2021
Jul 21 2021
Jul 20 2021
Jul 15 2021
Jul 9 2021
Updated the checks in the hip test.
Thanks, added a test.
Jul 6 2021
This is a work-in-progress. RCCL requires using hipcc for the linking step, however the CMake file would not allow me to override the CMAKE_LINKER as hipcc. The reason to use hipcc is to handle static libraries created by -fgpu-rdc.
Jun 28 2021
A few small comments, otherwise LGTM on the HIP header side.
Jun 22 2021
Looks OK to me, please address other review comments. Thanks.
Jun 11 2021
Fixed to yaxunl's comments, using ~0U , and allowing major only component.
Jun 10 2021
Jun 2 2021
May 21 2021
May 14 2021
Looks good, let me verify on HIP builder.
May 13 2021
Apr 30 2021
Apr 29 2021
@tra have you seen this exception in your CUDA buildbots before?
Revised to @palves' comments.
Apr 26 2021
Revised to Artem's comments.
Apr 23 2021
Added documentation changes.
Apr 22 2021
Revised to @gkistanova 's comments.
Please review again, I have changed the patch description, and revised to the comments.
Moving this script to annotated/ directory. The AnnotatedBuilder.py now support running bash scripts.
Hi @gkistanova, I've changed the buildbot to use a local relative path (in annotated/hip-build.sh dir).
I will keep it as a local uncommitted script during bring-up. D100666 was submitted, and script_interpreter="python" is disabled for this bash script.
Apr 21 2021
I agree that the no_pop variant may not be what we want, so removing it.
Revised to Artem's comments, moved --jobs to extra_args when are unspecified.
Apr 20 2021
Fix unrelated pre-merge test failures. Something changed upstream, unrelated to this patch.
Fixed formatting issues.
I may be moving this patch and combining with D99894 , since we plan to add this to the public repo.
If no additional opinions, I think this current patch with no_pop serves the purpose and can be committed, while we discuss if we want to add global scope. @palves, does that work for you?
Apr 16 2021
Apr 15 2021
Ping arphaman and aaron.ballman. Also adding @erik.pilkington, who introduced namespaces to clang attribute, for opinions.
Apr 14 2021
@gkistanova , is it okay to submit this with a full system path temporarily? /buildbot/hip-build.sh? Or do we have to switch to a python script?
Apr 13 2021
Address Artem's comments.
Closing this revision, I have a patch to add no_pop variant of #pragma clang attribute push.
Alternatively, we could look into making no pop the default.
Apr 12 2021
No, what I'm saying is that we can allow #pragma clang attribute push to be unbalanced if the user requests it. Injecting it with -include is a reasonable use case, IMO and you've correctly pointed out that there's no easy way to add a matching pop.
#pragma clang attribute appears to be a better and more generic mechanism for tinkering with attributes and I would prefer to use it instead of adding more pragmas that do about the same thing.
Apr 9 2021
Revised to Artem's comments, and added empty.hip.
Apr 7 2021
This HIP builder is dependent on two other patches:
Please note, this patch is under-development, and I've added it here, as open uncommitted review to allow HIP builder to use external script.
Apr 6 2021
Apr 5 2021
Apr 1 2021
LGTM, thank you.
Mar 31 2021
Merged DiagnosticParseKinds as requested.
Mar 18 2021
Mar 16 2021
Thank you for the review, please see latest test updates adding tests for static/constexpr local var combinations.