This is an archive of the discontinued LLVM Phabricator instance.

[MIPS, test] Fix use of undef FileCheck var
ClosedPublic

Authored by thopre on Apr 1 2021, 4:44 PM.

Details

Summary

LLVM test CodeGen/Mips/sr1.ll tries to check for the absence of a
sequence of instructions with several CHECK-NOT with one of those
directives using a variable defined in another. However CHECK-NOT are
checked independently so that is using a variable defined in a pattern
that should not occur in the input.

This commit removes the definition and uses of variable to check each
line independently, making the check stronger than the current one.

Diff Detail

Event Timeline

thopre created this revision.Apr 1 2021, 4:44 PM
thopre requested review of this revision.Apr 1 2021, 4:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2021, 4:44 PM
dsanders accepted this revision.Apr 1 2021, 4:46 PM

LGTM

This revision is now accepted and ready to land.Apr 1 2021, 4:46 PM
This revision was landed with ongoing or failed builds.Apr 1 2021, 4:59 PM
This revision was automatically updated to reflect the committed changes.